Re: CVS commit: src/lib/csu

2011-02-01 Thread Matthias Drochner
jo...@britannica.bec.de said: The attached patch seems to sort this out. Yes, thanks, this works. best regards Matthias

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 07:32:50PM +0100, Matthias Drochner wrote: m.droch...@fz-juelich.de said: $ make -V .OBJDIR [...]/src/lib/csu/obj.zelz27 And as a data point, to show what's going wrong: $ make -V COMMON_DIR ./common That should be ../common, or better an absolute path. $

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu This shows that you are not using an .OBJDIR, in the sense that it is different from .CURDIR. See the make(1) manpage. There are various rules

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 08:42:59PM +0100, Matthias Drochner wrote: jo...@britannica.bec.de said: $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu This shows that you are not using an .OBJDIR, in the sense that it is

Re: CVS commit: src/lib/csu

2011-01-31 Thread Matthias Drochner
jo...@britannica.bec.de said: BSDOBJDIR doesn't seem to do anything. BUILDID breaks this. I have no idea why those variables even exist, the code in bsd.own.mk is messy at best I agree that the code is messy, but at least BUILDID serves a useful purpose: I can use the same source tree from

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 09:54:03PM +0100, Joerg Sonnenberger wrote: On Mon, Jan 31, 2011 at 08:42:59PM +0100, Matthias Drochner wrote: jo...@britannica.bec.de said: $ ~/work/NetBSD/obj/clang-base/tools/bin/nbmake-amd64 -V .OBJDIR /home/joerg/work/NetBSD/obj/clang-base/amd64/lib/csu

Re: CVS commit: src/lib/csu

2011-01-31 Thread David Holland
On Mon, Jan 31, 2011 at 11:05:23PM +0100, Joerg Sonnenberger wrote: -static char curdir[MAXPATHLEN + 1]; /* startup directory */ +char curdir[MAXPATHLEN + 1];/* startup directory */ [...] -Var_Set(.PARSEDIR, ., VAR_GLOBAL, 0); +extern char curdir[]; +

Re: CVS commit: src/lib/csu

2011-01-31 Thread David Holland
On Mon, Jan 31, 2011 at 10:34:25PM +, David Holland wrote: -static char curdir[MAXPATHLEN + 1];/* startup directory */ +char curdir[MAXPATHLEN + 1]; /* startup directory */ [...] - Var_Set(.PARSEDIR, ., VAR_GLOBAL, 0); + extern char curdir[]; +

Re: CVS commit: src/lib/csu

2011-01-31 Thread Simon J. Gerraty
I can comment out the MAKEOBJDIR assignment in nbmake-amd64 and it still works fine. BSDOBJDIR doesn't seem to do anything. BUILDID breaks this. I have no idea why those variables even exist, the code in bsd.own.mk is messy at best and I don't think it justifies the changes to the Makefiles.

Re: CVS commit: src/lib/csu

2011-01-31 Thread Joerg Sonnenberger
On Mon, Jan 31, 2011 at 04:07:43PM -0800, Simon J. Gerraty wrote: I didn't follow the conversation, how is this patch relevant to BUILDID? Some of the redefinition magic involved with BUILDID results in .PARSEDIR as ., not a full path. This only happens if none of the usual MAKEOBJDIR* variables

Re: CVS commit: src/lib/librumphijack

2011-01-27 Thread Antti Kantee
On Wed Jan 26 2011 at 13:48:32 -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed Jan 26 18:48:32 UTC 2011 Modified Files: src/lib/librumphijack: hijack.c Log Message: make SSP friendly Can you add a comment stating why readlink and getcwd

Re: CVS commit: src/lib/librumphijack

2011-01-27 Thread Christos Zoulas
In article 20110127140249.gd23...@cs.hut.fi, Antti Kantee po...@cs.hut.fi wrote: On Wed Jan 26 2011 at 13:48:32 -0500, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Wed Jan 26 18:48:32 UTC 2011 Modified Files: src/lib/librumphijack:

Re: CVS commit: src/lib/libp2k

2011-01-14 Thread David Holland
On Fri, Jan 07, 2011 at 11:15:31AM +, Antti Kantee wrote: Modified Files: src/lib/libp2k: p2k.c Log Message: Remove the componentname-saving code since it was addressing SAVENAME/HASBUF/SAVESTART and they don't exist anymore (and the removed code didn't compile on nb5).

Re: CVS commit: src/lib/libp2k

2011-01-14 Thread Antti Kantee
On Fri Jan 14 2011 at 08:42:45 +, David Holland wrote: On Fri, Jan 07, 2011 at 11:15:31AM +, Antti Kantee wrote: Modified Files: src/lib/libp2k: p2k.c Log Message: Remove the componentname-saving code since it was addressing SAVENAME/HASBUF/SAVESTART and they don't

Re: CVS commit: src/lib/libp2k

2011-01-14 Thread David Holland
On Fri, Jan 14, 2011 at 11:22:33AM +0200, Antti Kantee wrote: Remove the componentname-saving code since it was addressing SAVENAME/HASBUF/SAVESTART and they don't exist anymore (and the removed code didn't compile on nb5). Unfortunately, you still need that code for now,

Re: CVS commit: src/lib/libp2k

2011-01-14 Thread Antti Kantee
On Fri Jan 14 2011 at 14:49:36 +, David Holland wrote: Do you have some relevant scenarios where fses set flags in componentname? For example, ufs_lookup sets ISWHITEOUT, which is later checked by ufs_mkdir and ufs_create and others. ... which is used only with unions which are not

Re: CVS commit: src/lib/libm

2011-01-09 Thread Matthias Scheler
On Sun, Jan 09, 2011 at 02:32:14AM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Sun Jan 9 02:32:13 UTC 2011 Modified Files: src/lib/libm: Makefile Added Files: src/lib/libm/noieee_src: n_fmax.c n_fmaxf.c n_fmin.c n_fminf.c Log

Re: CVS commit: src/lib/libc/time

2010-12-18 Thread Antti Kantee
On Fri Dec 17 2010 at 18:11:57 -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Dec 17 23:11:57 UTC 2010 Modified Files: src/lib/libc/time: localtime.c Log Message: PR/44248: Antti Kantee: Fix multi-threaded localtime hang. Please remember

Re: CVS commit: src/lib/libc/time

2010-12-18 Thread Jukka Ruohonen
On Fri Dec 17 2010 at 18:11:57 -0500, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Fri Dec 17 23:11:57 UTC 2010 Modified Files: src/lib/libc/time: localtime.c Log Message: PR/44248: Antti Kantee: Fix multi-threaded

Re: CVS commit: src/lib/libc

2010-12-17 Thread Jukka Ruohonen
On Thu, Dec 16, 2010 at 01:38:07PM -0500, Christos Zoulas wrote: Log Message: Provide a re-entrant and thread-safe set of timezone API's that don't require locking and can operate on user-specified timezones as opposed to having to alter the environment to change a timezone. This work was

Re: CVS commit: src/lib/libc

2010-12-17 Thread Antti Kantee
On Fri Dec 17 2010 at 21:56:59 +0200, Jukka Ruohonen wrote: On Thu, Dec 16, 2010 at 01:38:07PM -0500, Christos Zoulas wrote: Log Message: Provide a re-entrant and thread-safe set of timezone API's that don't require locking and can operate on user-specified timezones as opposed to having

Re: CVS commit: src/lib/libc

2010-12-17 Thread Antti Kantee
On Fri Dec 17 2010 at 22:03:46 +0200, Antti Kantee wrote: On Fri Dec 17 2010 at 21:56:59 +0200, Jukka Ruohonen wrote: On Thu, Dec 16, 2010 at 01:38:07PM -0500, Christos Zoulas wrote: Log Message: Provide a re-entrant and thread-safe set of timezone API's that don't require locking and

Re: CVS commit: src/lib/libc/gen

2010-12-12 Thread David Holland
On Thu, Dec 09, 2010 at 09:27:32PM +, Joerg Sonnenberger wrote: Log Message: Wrap sys_errlist constants in a macro to make it easier to extract the strings reliably with sed/awk. Why two layers of parentheses? Also, if we're going to be extracting strings anyway, errlist.c and whatever

Re: CVS commit: src/lib/libc/gen

2010-12-12 Thread Joerg Sonnenberger
On Sun, Dec 12, 2010 at 08:34:25AM +, David Holland wrote: On Thu, Dec 09, 2010 at 09:27:32PM +, Joerg Sonnenberger wrote: Log Message: Wrap sys_errlist constants in a macro to make it easier to extract the strings reliably with sed/awk. Why two layers of parentheses? In case

Re: CVS commit: src/lib/libc/net

2010-12-07 Thread Christos Zoulas
In article 20101208020539.c6bd817...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: joerg Date: Wed Dec 8 02:05:39 UTC 2010 Modified Files: src/lib/libc/net: nslexer.l Log Message: input() is not used, so

Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-22 Thread Izumi Tsutsui
mrg@ wrote: there's *really* broken code that writes to a time_t via a long*. OpenBSD still uses long (not time_t) for tv_sec in struct timeval... --- Izumi Tsutsui

Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-22 Thread Christos Zoulas
On Nov 22, 11:10pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/lib/libpam/modules/pam_ssh | mrg@ wrote: | | there's *really* broken code that writes to a time_t via a long*. | | OpenBSD still uses long (not time_t) for tv_sec in struct timeval... Yes

Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-21 Thread Christos Zoulas
In article 20101121204136.cbed017...@cvs.netbsd.org, Adam Ciarcinski source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: adam Date: Sun Nov 21 20:41:36 UTC 2010 Modified Files: src/lib/libpam/modules/pam_ssh: pam_ssh.c Log Message: Use

Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-21 Thread Hisashi T Fujinaka
On Mon, 22 Nov 2010, Christos Zoulas wrote: In article 20101121204136.cbed017...@cvs.netbsd.org, Adam Ciarcinski source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: adam Date: Sun Nov 21 20:41:36 UTC 2010 Modified Files:

re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-21 Thread matthew green
On Mon, 22 Nov 2010, Christos Zoulas wrote: In article 20101121204136.cbed017...@cvs.netbsd.org, Adam Ciarcinski source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: adam Date: Sun Nov 21 20:41:36 UTC 2010 Modified Files:

Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-21 Thread Christos Zoulas
On Nov 21, 6:31pm, ht...@twofifty.com (Hisashi T Fujinaka) wrote: -- Subject: Re: CVS commit: src/lib/libpam/modules/pam_ssh | I'm having all sorts of troubles with casting for prints, etc. Adam is fixing them. Adam, if you need help, just let me know. christos

Re: CVS commit: src/lib/libc/stdlib

2010-11-01 Thread Alan Barrett
On Mon, 01 Nov 2010, enami tsugutomo wrote: Modified Files: src/lib/libc/stdlib: getenv.c Log Message: Double the array only when really necessary. Otherwise memory will be exhausted if user modifies the variable envrion itself repeatedly.. Now the code disagrees with the comment

Re: CVS commit: src/lib/libc/stdlib

2010-11-01 Thread enami tsugutomo
Now the code disagrees with the comment above it. Please fix the comment. I've changed the comment but feel free to improve it if you have better one. enami.

Re: CVS commit: src/lib/libc/stdio

2010-10-24 Thread Robert Elz
Date:Sun, 24 Oct 2010 16:00:46 +0100 From:Matthias Scheler t...@netbsd.org Message-ID: 20101024150046.ga...@colwyn.zhadum.org.uk | It doesn't have to be a macro anyway as it used only ones. Yes, I meant to ask about that, simply written inline would be no problem.

Re: CVS commit: src/lib/libc/stdio

2010-10-24 Thread Matthias Scheler
On Mon, Oct 25, 2010 at 12:24:14AM +0700, Robert Elz wrote: Date:Sun, 24 Oct 2010 16:00:46 +0100 From:Matthias Scheler t...@netbsd.org Message-ID: 20101024150046.ga...@colwyn.zhadum.org.uk | It doesn't have to be a macro anyway as it used only ones. Yes, I

Re: CVS commit: src/lib/libc/stdio

2010-10-23 Thread Jukka Ruohonen
On Fri, Oct 22, 2010 at 05:29:46PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Fri Oct 22 21:29:46 UTC 2010 Modified Files: src/lib/libc/stdio: ftell.c local.h Log Message: implement EOVERFLOW To generate a diff of this commit: cvs

Re: CVS commit: src/lib/libc/stdio

2010-10-23 Thread Matthias Scheler
On Sat, Oct 23, 2010 at 10:12:51AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Oct 23 14:12:51 UTC 2010 Modified Files: src/lib/libc/stdio: local.h Log Message: tell lint to shut up. I'm sorry but this whole code is horrible. What is

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Matthias Scheler
On Thu, Sep 30, 2010 at 03:05:26PM +0200, Nicolas Joly wrote: One possibility could be to not free memory at all in setenv, but only with unsetenv. I'm not convinced about that. IMHO, it's a programmer error to call setenv more than once on the same variable without a corresponding unsetenv

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Nicolas Joly
On Thu, Sep 30, 2010 at 02:11:19PM +0100, Matthias Scheler wrote: On Thu, Sep 30, 2010 at 03:05:26PM +0200, Nicolas Joly wrote: One possibility could be to not free memory at all in setenv, but only with unsetenv. I'm not convinced about that. IMHO, it's a programmer error to call

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Matthias Scheler
On Thu, Sep 30, 2010 at 03:35:41PM +0200, Nicolas Joly wrote: That may be part of the problem (at least for zsh 4.2). http://www.opengroup.org/onlinepubs/009695399/functions/putenv.html From the OpenGroup function description; this function does not copy the provided string, but use it

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Nicolas Joly
On Thu, Sep 30, 2010 at 12:41:34PM +, Matthias Scheler wrote: Module Name: src Committed By: tron Date: Thu Sep 30 12:41:33 UTC 2010 Modified Files: src/lib/libc/stdlib: setenv.c unsetenv.c Log Message: Be slightly more careful about freeing memory allocated for

Re: CVS commit: src/lib/libc/stdlib

2010-09-30 Thread Christos Zoulas
In article 20100930134213.ga18...@colwyn.zhadum.org.uk, Matthias Scheler t...@netbsd.org wrote: On Thu, Sep 30, 2010 at 03:35:41PM +0200, Nicolas Joly wrote: That may be part of the problem (at least for zsh 4.2). http://www.opengroup.org/onlinepubs/009695399/functions/putenv.html From the

Re: CVS commit: src/lib/libc/stdio

2010-09-28 Thread Alistair Crooks
On Tue, Sep 28, 2010 at 11:06:39AM +0900, Masao Uebayashi wrote: Index: src/lib/libc/stdio/fmemopen.c diff -u src/lib/libc/stdio/fmemopen.c:1.3 src/lib/libc/stdio/fmemopen.c:1.4 --- src/lib/libc/stdio/fmemopen.c:1.3 Sat Sep 25 14:00:30 2010 +++ src/lib/libc/stdio/fmemopen.c Mon Sep

Re: CVS commit: src/lib/libc/stdio

2010-09-28 Thread Masao Uebayashi
On Tue, Sep 28, 2010 at 08:28:04AM +0200, Alistair Crooks wrote: On Tue, Sep 28, 2010 at 11:06:39AM +0900, Masao Uebayashi wrote: Index: src/lib/libc/stdio/fmemopen.c diff -u src/lib/libc/stdio/fmemopen.c:1.3 src/lib/libc/stdio/fmemopen.c:1.4 --- src/lib/libc/stdio/fmemopen.c:1.3

Re: CVS commit: src/lib/libc/stdio

2010-09-27 Thread Masao Uebayashi
Index: src/lib/libc/stdio/fmemopen.c diff -u src/lib/libc/stdio/fmemopen.c:1.3 src/lib/libc/stdio/fmemopen.c:1.4 --- src/lib/libc/stdio/fmemopen.c:1.3 Sat Sep 25 14:00:30 2010 +++ src/lib/libc/stdio/fmemopen.c Mon Sep 27 16:50:13 2010 @@ -79,16 +79,18 @@ if (p-cur = p-tail)

Re: CVS commit: src/lib/libc/stdlib

2010-09-25 Thread David Laight
On Thu, Sep 23, 2010 at 12:02:42PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Sep 23 16:02:41 UTC 2010 Modified Files: src/lib/libc/stdlib: setenv.c Log Message: PR/43899: Nicolas Joly: setenv(3)/unsetenv(3) memory leak. Partial fix:

Re: CVS commit: src/lib/libc/stdlib

2010-09-24 Thread enami tsugutomo
In addition to previous, __allocenv() call in unsetenv() isn't necessary if we check if there exists the bitmap before touching it. If still want to call it, it must be protected by the lock. enami.

Re: CVS commit: src/lib/libc/stdlib

2010-09-23 Thread enami tsugutomo
Module Name: src Committed By: christos Date: Thu Sep 23 16:02:41 UTC 2010 Modified Files: src/lib/libc/stdlib: setenv.c Log Message: PR/43899: Nicolas Joly: setenv(3)/unsetenv(3) memory leak. Partial fix: Don't allocate a new string if the length is equal to the old

Re: CVS commit: src/lib/libperfuse

2010-08-26 Thread Antti Kantee
On Thu Aug 26 2010 at 13:07:14 +, Emmanuel Dreyfus wrote: On Thu, Aug 26, 2010 at 04:01:38PM +0300, Antti Kantee wrote: IIRC ntfs-3g has been shipped with its own hacked copy of libfuse for quite some time now. So technically ntfs-3g uses the kernel interface as well. (but I never

Re: CVS commit: src/lib/libperfuse

2010-08-25 Thread Emmanuel Dreyfus
Matthias Scheler t...@zhadum.org.uk wrote: Can you please explain what is the difference between libperfuse and librefuse is? There is per instead of re in the name :-) Here is the explanation: http://mail-index.netbsd.org/tech-userlevel/2010/08/22/msg003843.html -- Emmanuel Dreyfus

Re: CVS commit: src/lib/libperfuse

2010-08-25 Thread Lubomir Sedlacik
On Thu, Aug 26, 2010 at 03:39:04AM +0200, Emmanuel Dreyfus wrote: Matthias Scheler t...@zhadum.org.uk wrote: Can you please explain what is the difference between libperfuse and librefuse is? There is per instead of re in the name :-) Perhaps con would've been more appropriate, given the

Re: CVS commit: src/lib/libm

2010-08-11 Thread David Laight
On Tue, Aug 10, 2010 at 05:53:09PM +, Matthias Drochner wrote: Module Name: src Committed By: drochner Date: Tue Aug 10 17:53:08 UTC 2010 Modified Files: src/lib/libm: Makefile Log Message: two disgusting hacks: -mk/bsd.lib.mk picks up a .S asm file behind our back

Re: CVS commit: src/lib/libpthread

2010-08-06 Thread Christos Zoulas
On Aug 6, 12:26pm, m.droch...@fz-juelich.de (Matthias Drochner) wrote: -- Subject: Re: CVS commit: src/lib/libpthread | | Module Name:src | Committed By: christos | Date: Fri Aug 6 05:25:02 UTC 2010 | | Modified Files: | src/lib/libpthread: pthread.h pthread_attr.c

Re: CVS commit: src/lib/libpthread

2010-08-06 Thread Christos Zoulas
On Aug 6, 12:59pm, m.droch...@fz-juelich.de (Matthias Drochner) wrote: -- Subject: Re: CVS commit: src/lib/libpthread | chris...@zoulas.com said: | They are different and pthread_attr_get_np() is not weak... | | But pthread_attr_get_np() is now used internally. | The rule is that functions

Re: CVS commit: src/lib/libc

2010-06-19 Thread Paul Goyette
Yup, this is failing on port-amd64, too: In file included from /build/netbsd-local/src/tools/mklocale/../../usr.bin/mklocale/lex.l:55: /build/netbsd-local/src/lib/libc/locale/runetype_file.h:42:28: error: sys/ctype_bits.h: No such file or directory In file included from

Re: CVS commit: src/lib/libc

2010-06-19 Thread Paul Goyette
On Sun, 20 Jun 2010, Izumi Tsutsui wrote: What's your host? Probably it won't fail on -current hosts and it's too strict to test builds on multiple platforms/OSes/versions before any commits... Failing for me on a 5.99.30 amd64... When was userland updated? sys/ctype_bits.h has been added

Re: CVS commit: src/lib/libc

2010-06-19 Thread Izumi Tsutsui
But isn't the whole point of building host tools to make sure that we DON'T depend on the installed userland? My point is: Just report a problem (with detailed info), but please don't complain. --- Izumi Tsutsui

Re: CVS commit: src/lib/libc

2010-06-19 Thread Izumi Tsutsui
What's your host? Probably it won't fail on -current hosts and it's too strict to test builds on multiple platforms/OSes/versions before any commits... Failing for me on a 5.99.30 amd64... When was userland updated? sys/ctype_bits.h has been added on 2010/06/01. --- Izumi Tsutsui

Re: CVS commit: src/lib/libc

2010-06-19 Thread Jeff Rizzo
On 6/19/10 12:44 PM, Izumi Tsutsui wrote: But isn't the whole point of building host tools to make sure that we DON'T depend on the installed userland? My point is: Just report a problem (with detailed info), but please don't complain. --- Izumi Tsutsui Yes, my apologies. It's

Re: CVS commit: src/lib/libc/locale

2010-06-06 Thread Izumi Tsutsui
I was just wondering why this change was made? It seems to be a backwards step to me? If we need exact-width interger we should use uintNN_t but I don't think exact width is required in locale. As other guys say we can't assume uint8_t == unsigned char implicitly:

Re: CVS commit: src/lib/libc/locale

2010-06-06 Thread Alan Barrett
On Sun, 06 Jun 2010, Izumi Tsutsui wrote: If we need exact-width interger we should use uintNN_t but I don't think exact width is required in locale. The [u]int_leastN_t types may be useful in this sort of code. For example, [u]int_least32_t is required to exist, and on a 36-bit machine it

Re: CVS commit: src/lib/libc/locale

2010-06-06 Thread Takehiko NOZAKI
hi, all I was just wondering why this change was made? It seems to be a backwards step to me? my intension is quite paranoia. changing uint8_t - unsigned char / int16_t - short is because _ctype_ / _tolower_tab_ / _toupper_tab_ in ctype.h (now splitted sys/ctype_bits.h) declared as unsigned

Re: CVS commit: src/lib/libc/locale

2010-06-05 Thread Alistair Crooks
Hi Nozaki-san, On Wed, Jun 02, 2010 at 04:04:52PM +, Takehiko NOZAKI wrote: Module Name: src Committed By: tnozaki Date: Wed Jun 2 16:04:52 UTC 2010 Modified Files: src/lib/libc/locale: bsdctype.c Log Message: uint8_t - unsigned char, int16_t - short. As ever,

Re: CVS commit: src/lib/libc/locale

2010-06-05 Thread David Holland
On Sat, Jun 05, 2010 at 11:53:32PM +0200, Alistair Crooks wrote: Module Name: src Committed By: tnozaki Date: Wed Jun 2 16:04:52 UTC 2010 Modified Files: src/lib/libc/locale: bsdctype.c Log Message: uint8_t - unsigned char, int16_t - short.

Re: CVS commit: src/lib/libc/locale

2010-06-05 Thread M. Warner Losh
In message: 20100606041254.gb19...@netbsd.org David Holland dholland-sourcechan...@netbsd.org writes: : On Sat, Jun 05, 2010 at 11:53:32PM +0200, Alistair Crooks wrote: :Module Name: src :Committed By:tnozaki :Date:Wed Jun 2 16:04:52 UTC 2010 : :

Re: CVS commit: src/lib/libc/locale

2010-06-05 Thread David Holland
On Sat, Jun 05, 2010 at 11:28:31PM -0600, M. Warner Losh wrote: : I looked at it and it appears to me that it's a change to use : non-sized types (that are guaranteed to be large enough) in the : in-memory structures. If we ever do a port to a 36-bit machine or : whatever it's probably

Re: CVS commit: src/lib/libpthread

2010-05-19 Thread David Holland
On Tue, May 18, 2010 at 11:04:12AM +0300, Jukka Ruohonen wrote: In my opinion we could have more introductory sections that connect the pages in a more logical manner.[1] Just listing the manual pages in the intro-sections is not enough. For example [...] Another option could be a

Re: CVS commit: src/lib/libpthread

2010-05-18 Thread Jukka Ruohonen
On Mon, May 17, 2010 at 07:35:37PM +0200, Matthias Drochner wrote: Also, the xrefs are not sorted strictly alphabetically but in some logical order which is good imo. The Xrefs are generally a symptom of the manual page format. As D. Holland well said, the man -k is so 1980s. In my opinion we

Re: CVS commit: src/lib/libpthread

2010-05-17 Thread Marc Balmer
Am 16.05.10 14:23, schrieb Jukka Ruohonen: Module Name: src Committed By: jruoho Date: Sun May 16 12:23:32 UTC 2010 Modified Files: src/lib/libpthread: pthread.3 Log Message: Add the Butenhof's book to SEE ALSO. (It was decent enough when I read it years ago, but if

Re: CVS commit: src/lib/libpthread

2010-05-17 Thread Jukka Ruohonen
On Mon, May 17, 2010 at 09:21:18AM +0200, Marc Balmer wrote: Is the SEE ALSO section meant to refer to external sources? I always thought it was only to reference other manpages. I don't know if there has ever been a strict rule about this; even some of the really old manual pages refer to

Re: CVS commit: src/lib/libpthread

2010-05-17 Thread Matthias Drochner
Is the SEE ALSO section meant to refer to external sources? Just as a data point, OSF/1 does this. To cite eg inet(7): RELATED INFORMATION Functions: ioctl(2), socket(2). Network Information: netintro(7), tcp(7), udp(7), ip(7), icmp(7). Network Programmer's Guide Technical Overview

Re: CVS commit: src/lib/libc/time

2010-05-15 Thread David Holland
On Sat, May 15, 2010 at 01:54:52PM +, Paul Goyette wrote: XXX Someone else can decide whether we should refer to U.S.A. or to XXX the United States in the parenthetical. The way it is now matches the other use later on, so let's leave it. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/lib/libc/stdio

2010-05-15 Thread David Holland
On Fri, May 14, 2010 at 08:29:34AM +0300, Jukka Ruohonen wrote: Yes. The trouble is that because libraries and headers don't match up, you need to parse headers to extract the lists, and that seems likely to end up being delicate and a constant source of annoyance. How about the

Re: CVS commit: src/lib/libc/stdio

2010-05-13 Thread David Holland
On Thu, May 06, 2010 at 03:17:38PM +0300, Jukka Ruohonen wrote: Perhaps we need a bot to watch all commits and send reminders like You added a new file, but you haven't updated the sets, see URL for instructions, You added a new sysctl node but you haven't updated sysctl(7), etc.

Re: CVS commit: src/lib/libc/stdio

2010-05-13 Thread David Holland
On Fri, May 14, 2010 at 05:10:24AM +, David Holland wrote: Anyway, can you (at your convenience) send me a list of the things like this that need consistency checking? I will then have a shot at writing some scripts and we can see what things look like. er wait, there's a list upthread.

Re: CVS commit: src/lib/libc/stdio

2010-05-13 Thread David Holland
On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in such cases the NetBSD implementation does not set errno to

Re: CVS commit: src/lib/libc/stdio

2010-05-13 Thread Jukka Ruohonen
On Fri, May 14, 2010 at 05:10:24AM +, David Holland wrote: Yes. The trouble is that because libraries and headers don't match up, you need to parse headers to extract the lists, and that seems likely to end up being delicate and a constant source of annoyance. How about the section 4

Re: CVS commit: src/lib/libc/stdio

2010-05-07 Thread Alan Barrett
On Thu, 06 May 2010, Christos Zoulas wrote: The fileno() function may fail if: [EBADF] The stream argument is not a valid stream, or the stream is not associated with a file. Isn't the above EBADF exactly what you are after? Our stdio supports funopen() which has

Re: CVS commit: src/lib/libc/stdio

2010-05-07 Thread Christos Zoulas
In article 20100507063258.ga23...@apb-laptoy.apb.alt.za, Alan Barrett a...@cequrux.com wrote: On Thu, 06 May 2010, Christos Zoulas wrote: The fileno() function may fail if: [EBADF] The stream argument is not a valid stream, or the stream is not associated with a file.

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread David Holland
On Wed, May 05, 2010 at 08:05:20AM +0200, Alan Barrett wrote: On Wed, 05 May 2010, Jukka Ruohonen wrote: Few examples of pages that are badly and *systematically* behind: intro(3) intro(4) pci(4) usb(4) mk.conf(5) sysctl(7) Perhaps we need a bot to

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread David Holland
On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in such cases the NetBSD implementation does not set errno to EBADF, hence diverging from the standard in this small detail. How is that not

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Jukka Ruohonen
On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in such cases the NetBSD implementation does not set errno to EBADF,

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Jukka Ruohonen
On Thu, May 06, 2010 at 12:04:53PM +0300, Jukka Ruohonen wrote: On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Jukka Ruohonen
On Thu, May 06, 2010 at 07:48:59AM +, David Holland wrote: On Wed, May 05, 2010 at 08:05:20AM +0200, Alan Barrett wrote: Perhaps we need a bot to watch all commits and send reminders like You added a new file, but you haven't updated the sets, see URL for instructions, You added a

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Joerg Sonnenberger
On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in such cases the NetBSD implementation does not set errno to EBADF,

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Jukka Ruohonen
On Thu, May 06, 2010 at 02:48:32PM +0200, Joerg Sonnenberger wrote: On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about return values: fileno() may fail and return -1. Note that in

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Joerg Sonnenberger
On Thu, May 06, 2010 at 06:00:45PM +0300, Jukka Ruohonen wrote: On Thu, May 06, 2010 at 02:48:32PM +0200, Joerg Sonnenberger wrote: On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the discussion about

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Matthias Scheler
On 6 May 2010, at 9:14, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Thu May 6 08:14:08 UTC 2010 Modified Files: src/lib/libc/stdio: ferror.3 Log Message: Correct the discussion about return values: fileno() may fail and return -1. Note that in

Re: CVS commit: src/lib/libc/stdio

2010-05-06 Thread Christos Zoulas
In article 20100506150045.ga...@marx.bitnet, Jukka Ruohonen jruoho...@iki.fi wrote: On Thu, May 06, 2010 at 02:48:32PM +0200, Joerg Sonnenberger wrote: On Thu, May 06, 2010 at 08:51:29AM +, David Holland wrote: On Thu, May 06, 2010 at 08:14:08AM +, Jukka Ruohonen wrote: Correct the

Re: CVS commit: src/lib/libc/stdio

2010-05-05 Thread Alan Barrett
On Wed, 05 May 2010, Jukka Ruohonen wrote: Few examples of pages that are badly and *systematically* behind: intro(3) intro(4) pci(4) usb(4) mk.conf(5) sysctl(7) Perhaps we need a bot to watch all commits and send reminders like You added a new file,

Re: CVS commit: src/lib/libc/stdio

2010-05-05 Thread Mindaugas Rasiukevicius
Jukka Ruohonen jruoho...@iki.fi wrote: On Wed, May 05, 2010 at 12:58:13AM +0700, Robert Elz wrote: | As something like gets() has been standardized for ages, it makes | sense to explicitly note that this may no longer be true (with | respect to POSIX). That's where I disagree, it

Re: CVS commit: src/lib/libc/stdio

2010-05-05 Thread Jukka Ruohonen
On Wed, May 05, 2010 at 08:52:23AM +0100, Mindaugas Rasiukevicius wrote: History is indeed important, however it belongs to books, articles, etc. Other part of history belongs to version control logs, as Robert already mentioned. If I will want to figure out why and by whom some function was

Re: CVS commit: src/lib/libc/stdio

2010-05-05 Thread Joerg Sonnenberger
On Wed, May 05, 2010 at 06:53:06AM +0300, Jukka Ruohonen wrote: Please revert this change. I will rever it. Can you change it to use .Xr please? That makes proper cross-references in HTML output possible. Joerg

re: CVS commit: src/lib/libutil

2010-05-05 Thread matthew green
Modified Files: src/lib/libutil: util.3 Log Message: Upon lukem@'s request, put the list of functions back. thank you.

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Robert Elz
Date:Fri, 30 Apr 2010 06:00:14 + From:Jukka Ruohonen jru...@netbsd.org Message-ID: 20100430060014.7739117...@cvs.netbsd.org | Module Name:src | Committed By: jruoho | Date: Fri Apr 30 06:00:14 UTC 2010 | | Modified Files: |

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Jukka Ruohonen
On Tue, May 04, 2010 at 06:35:48PM +0700, Robert Elz wrote: I don't understand the change - that is, I don't understand the sentence that was added to the man page, it says ... The revision marked gets() as obsolete... What revision??? In my manual page: The functions fgets() and

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Joerg Sonnenberger
On Tue, May 04, 2010 at 04:39:16PM +0300, Jukka Ruohonen wrote: In my manual page: The functions fgets() and gets() conform to ANSI X3.159-1989 (``ANSI C89'') and IEEE Std 1003.1-2001 (``POSIX.1''). The IEEE Std 1003.1-2008 (``POSIX.1'') revision marked gets() as obsolescent,

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Robert Elz
Date:Tue, 4 May 2010 16:39:16 +0300 From:Jukka Ruohonen jruoho...@iki.fi Message-ID: 20100504133916.ga9...@marx.bitnet | In my manual page: [...] | What was the problem again? Something odd - sorry - it looks as if my (older) nroff -mandoc on current sources

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Jukka Ruohonen
On Wed, May 05, 2010 at 12:58:13AM +0700, Robert Elz wrote: | As something like gets() has been standardized for ages, it makes sense to | explicitly note that this may no longer be true (with respect to POSIX). That's where I disagree, it is just bloat - once it stops being a

Re: CVS commit: src/lib/libc/stdio

2010-05-04 Thread Luke Mewburn
On Tue, May 04, 2010 at 07:43:12AM +, Jukka Ruohonen wrote: | Module Name:src | Committed By: jruoho | Date: Tue May 4 07:43:12 UTC 2010 | | Modified Files: | src/lib/libc/stdio: stdio.3 | | Log Message: | Remove the list of functions. |

<    3   4   5   6   7   8   9   >