CVS commit: src/sys/arch/acorn32/acorn32
Module Name:src
Committed By: christos
Date: Fri Oct 4 12:08:33 UTC 2019
Modified Files:
src/sys/arch/acorn32/acorn32: rpc_machdep.c
Log Message:
undo previous, requested by uwe
To generate a diff of this commit:
cvs rdiff -u -r1.95 -r1.96 src/sys/arch/acorn32/acorn32/rpc_machdep.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/acorn32/acorn32/rpc_machdep.c
diff -u src/sys/arch/acorn32/acorn32/rpc_machdep.c:1.95 src/sys/arch/acorn32/acorn32/rpc_machdep.c:1.96
--- src/sys/arch/acorn32/acorn32/rpc_machdep.c:1.95 Thu Oct 3 21:53:58 2019
+++ src/sys/arch/acorn32/acorn32/rpc_machdep.c Fri Oct 4 08:08:33 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: rpc_machdep.c,v 1.95 2019/10/04 01:53:58 christos Exp $ */
+/* $NetBSD: rpc_machdep.c,v 1.96 2019/10/04 12:08:33 christos Exp $ */
/*
* Copyright (c) 2000-2002 Reinoud Zandijk.
@@ -55,7 +55,7 @@
#include
-__KERNEL_RCSID(0, "$NetBSD: rpc_machdep.c,v 1.95 2019/10/04 01:53:58 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rpc_machdep.c,v 1.96 2019/10/04 12:08:33 christos Exp $");
#include
#include
@@ -518,7 +518,7 @@ initarm(void *cookie)
#endif
for (loop = 0, physmem = 0; loop < bootconfig.dramblocks; ++loop) {
#ifdef VERBOSE_INIT_ARM
- printf("%#x + %#0x, type = %#08x\n", bootconfig.dram[loop].address,
+ printf("0x%x + 0x%0x, type = 0x%08x\n", bootconfig.dram[loop].address,
bootconfig.dram[loop].pages * PAGE_SIZE,
bootconfig.dram[loop].flags);
#endif
@@ -626,13 +626,13 @@ initarm(void *cookie)
#ifdef VERBOSE_INIT_ARM
printf("Setting up stacks :\n");
- printf("IRQ stack: p%#08lx v%#08lx\n",
+ printf("IRQ stack: p0x%08lx v0x%08lx\n",
irqstack.pv_pa, irqstack.pv_va);
- printf("ABT stack: p%#08lx v%#08lx\n",
+ printf("ABT stack: p0x%08lx v0x%08lx\n",
abtstack.pv_pa, abtstack.pv_va);
- printf("UND stack: p%#08lx v%#08lx\n",
+ printf("UND stack: p0x%08lx v0x%08lx\n",
undstack.pv_pa, undstack.pv_va);
- printf("SVC stack: p%#08lx v%#08lx\n",
+ printf("SVC stack: p0x%08lx v0x%08lx\n",
kernelstack.pv_pa, kernelstack.pv_va);
printf("\n");
#endif
@@ -656,7 +656,7 @@ initarm(void *cookie)
*/
#ifdef VERBOSE_INIT_ARM
- printf("Creating L1 page table p@%#08x\n", (uint32_t)kernel_l1pt.pv_pa);
+ printf("Creating L1 page table p@0x%08x\n", (uint32_t)kernel_l1pt.pv_pa);
#endif
/*
CVS commit: src/sys/arch/acorn32/acorn32
Module Name:src Committed By: christos Date: Fri Oct 4 12:08:33 UTC 2019 Modified Files: src/sys/arch/acorn32/acorn32: rpc_machdep.c Log Message: undo previous, requested by uwe To generate a diff of this commit: cvs rdiff -u -r1.95 -r1.96 src/sys/arch/acorn32/acorn32/rpc_machdep.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/arch/acorn32/acorn32
On Fri, Oct 04, 2019 at 04:57:51 +0200, Kamil Rytarowski wrote: > At least in certain domains of engineering 0 is a special case as it > does not need unit (km, lumen, kg, ...) neither base (hex, dec, ..). > > It is natural (correct, expected) to print %#x for 0 as 0, without 0x. I'm happy for them and that there's %#x that they can use. What does it have to do with with anything? > On 04.10.2019 04:09, Christos Zoulas wrote: > > Thanks, and zero is special for 0#. Should I revert it? > > > > christos > > > >> On Oct 3, 2019, at 10:06 PM, Valery Ushakov wrote: > >> > >> > >>> Modified Files: > >>> src/sys/arch/acorn32/acorn32: rpc_machdep.c > >>> > >>> Log Message: > >>> change 0x% -> %x > >> > >> This should read %#x. > >> And this is wrong. > >> > >> 1) With # the 0x is part of the width, so > >> > >> 0x%08x -> 0x0001 > >> %#08x -> 0x01 > >> > >> 0x 0x0001 > >> 0x01 > >> > >> 2) # doesn't add prefix for zero, so > >> > >> 0x%08x -> 0x > >> %#08x -> > >> > >> -uwe > > > > -uwe
Re: CVS commit: src/sys/arch/acorn32/acorn32
On Thu, Oct 03, 2019 at 22:09:28 -0400, Christos Zoulas wrote: > Thanks, and zero is special for 0#. Should I revert it? Yes, please. > > On Oct 3, 2019, at 10:06 PM, Valery Ushakov wrote: > > > > > >> Modified Files: > >>src/sys/arch/acorn32/acorn32: rpc_machdep.c > >> > >> Log Message: > >> change 0x% -> %x > > > > This should read %#x. > > And this is wrong. > > > > 1) With # the 0x is part of the width, so > > > > 0x%08x -> 0x0001 > > %#08x -> 0x01 > > > > 0x 0x0001 > > 0x01 > > > > 2) # doesn't add prefix for zero, so > > > > 0x%08x -> 0x > > %#08x -> -uwe
Re: CVS commit: src/sys/arch/acorn32/acorn32
At least in certain domains of engineering 0 is a special case as it does not need unit (km, lumen, kg, ...) neither base (hex, dec, ..). It is natural (correct, expected) to print %#x for 0 as 0, without 0x. On 04.10.2019 04:09, Christos Zoulas wrote: > Thanks, and zero is special for 0#. Should I revert it? > > christos > >> On Oct 3, 2019, at 10:06 PM, Valery Ushakov wrote: >> >> >>> Modified Files: >>> src/sys/arch/acorn32/acorn32: rpc_machdep.c >>> >>> Log Message: >>> change 0x% -> %x >> >> This should read %#x. >> And this is wrong. >> >> 1) With # the 0x is part of the width, so >> >> 0x%08x -> 0x0001 >> %#08x -> 0x01 >> >> 0x 0x0001 >> 0x01 >> >> 2) # doesn't add prefix for zero, so >> >> 0x%08x -> 0x >> %#08x -> >> >> -uwe > signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/sys/arch/acorn32/acorn32
Thanks, and zero is special for 0#. Should I revert it? christos > On Oct 3, 2019, at 10:06 PM, Valery Ushakov wrote: > > >> Modified Files: >> src/sys/arch/acorn32/acorn32: rpc_machdep.c >> >> Log Message: >> change 0x% -> %x > > This should read %#x. > And this is wrong. > > 1) With # the 0x is part of the width, so > > 0x%08x -> 0x0001 > %#08x -> 0x01 > > 0x 0x0001 > 0x01 > > 2) # doesn't add prefix for zero, so > > 0x%08x -> 0x > %#08x -> > > -uwe
Re: CVS commit: src/sys/arch/acorn32/acorn32
> Modified Files: > src/sys/arch/acorn32/acorn32: rpc_machdep.c > > Log Message: > change 0x% -> %x This should read %#x. And this is wrong. 1) With # the 0x is part of the width, so 0x%08x -> 0x0001 %#08x -> 0x01 0x 0x0001 0x01 2) # doesn't add prefix for zero, so 0x%08x -> 0x %#08x -> -uwe
CVS commit: src/sys/arch/acorn32/acorn32
Module Name:src
Committed By: christos
Date: Fri Oct 4 01:53:58 UTC 2019
Modified Files:
src/sys/arch/acorn32/acorn32: rpc_machdep.c
Log Message:
change 0x% -> %x
To generate a diff of this commit:
cvs rdiff -u -r1.94 -r1.95 src/sys/arch/acorn32/acorn32/rpc_machdep.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/acorn32/acorn32/rpc_machdep.c
diff -u src/sys/arch/acorn32/acorn32/rpc_machdep.c:1.94 src/sys/arch/acorn32/acorn32/rpc_machdep.c:1.95
--- src/sys/arch/acorn32/acorn32/rpc_machdep.c:1.94 Thu Oct 3 11:36:24 2019
+++ src/sys/arch/acorn32/acorn32/rpc_machdep.c Thu Oct 3 21:53:58 2019
@@ -1,4 +1,4 @@
-/* $NetBSD: rpc_machdep.c,v 1.94 2019/10/03 15:36:24 msaitoh Exp $ */
+/* $NetBSD: rpc_machdep.c,v 1.95 2019/10/04 01:53:58 christos Exp $ */
/*
* Copyright (c) 2000-2002 Reinoud Zandijk.
@@ -55,7 +55,7 @@
#include
-__KERNEL_RCSID(0, "$NetBSD: rpc_machdep.c,v 1.94 2019/10/03 15:36:24 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rpc_machdep.c,v 1.95 2019/10/04 01:53:58 christos Exp $");
#include
#include
@@ -518,7 +518,7 @@ initarm(void *cookie)
#endif
for (loop = 0, physmem = 0; loop < bootconfig.dramblocks; ++loop) {
#ifdef VERBOSE_INIT_ARM
- printf("0x%x + 0x%0x, type = 0x%08x\n", bootconfig.dram[loop].address,
+ printf("%#x + %#0x, type = %#08x\n", bootconfig.dram[loop].address,
bootconfig.dram[loop].pages * PAGE_SIZE,
bootconfig.dram[loop].flags);
#endif
@@ -626,13 +626,13 @@ initarm(void *cookie)
#ifdef VERBOSE_INIT_ARM
printf("Setting up stacks :\n");
- printf("IRQ stack: p0x%08lx v0x%08lx\n",
+ printf("IRQ stack: p%#08lx v%#08lx\n",
irqstack.pv_pa, irqstack.pv_va);
- printf("ABT stack: p0x%08lx v0x%08lx\n",
+ printf("ABT stack: p%#08lx v%#08lx\n",
abtstack.pv_pa, abtstack.pv_va);
- printf("UND stack: p0x%08lx v0x%08lx\n",
+ printf("UND stack: p%#08lx v%#08lx\n",
undstack.pv_pa, undstack.pv_va);
- printf("SVC stack: p0x%08lx v0x%08lx\n",
+ printf("SVC stack: p%#08lx v%#08lx\n",
kernelstack.pv_pa, kernelstack.pv_va);
printf("\n");
#endif
@@ -656,7 +656,7 @@ initarm(void *cookie)
*/
#ifdef VERBOSE_INIT_ARM
- printf("Creating L1 page table p@0x%08x\n", (uint32_t)kernel_l1pt.pv_pa);
+ printf("Creating L1 page table p@%#08x\n", (uint32_t)kernel_l1pt.pv_pa);
#endif
/*
CVS commit: src/sys/arch/acorn32/acorn32
Module Name:src Committed By: christos Date: Fri Oct 4 01:53:58 UTC 2019 Modified Files: src/sys/arch/acorn32/acorn32: rpc_machdep.c Log Message: change 0x% -> %x To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/sys/arch/acorn32/acorn32/rpc_machdep.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
