Re: CVS commit: src/distrib

2010-04-23 Thread Martin Husemann
On Thu, Apr 22, 2010 at 09:37:51PM +, Tom Spindler wrote: Log Message: Change use of ${CP} and ${CHMOD} to ${INSTALL_FILE}, so that if the target is made un-writeable, the build won't bomb out during an UPDATE build. OK'ed by mar...@. on i386, when I try building, I now get:

Re: CVS commit: src/distrib

2010-04-23 Thread Havard Eidnes
On Thu, Apr 22, 2010 at 09:37:51PM +, Tom Spindler wrote: Log Message: Change use of ${CP} and ${CHMOD} to ${INSTALL_FILE}, so that if the target is made un-writeable, the build won't bomb out during an UPDATE build. OK'ed by mar...@. on i386, when I try building, I now get:

Re: CVS commit: src/distrib

2010-04-23 Thread Alan Barrett
On Fri, 23 Apr 2010, Havard Eidnes wrote: Modified Files: src/distrib/i386/cdroms: Makefile.cdrom src/distrib/sparc64/cdroms/installcd: Makefile Log Message: Um, as has been noted, INSTALL_FILE records what's installed if it's done unprived, and that doesn't go down well on a

Re: CVS commit: src/lib/libc/compat/gen

2010-04-23 Thread Christos Zoulas
In article 20100423190454.62ec017...@cvs.netbsd.org, Matthias Drochner source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: drochner Date: Fri Apr 23 19:04:54 UTC 2010 Modified Files: src/lib/libc/compat/gen: Makefile.inc compat_frexp_ieee754.c

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Christos Zoulas
In article 20100423113953.7c16417...@cvs.netbsd.org, Adam Hoka source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: ahoka Date: Fri Apr 23 11:39:53 UTC 2010 Modified Files: src/external/cddl/osnet/dev/dtrace: dtrace_sysctl.c dtrace_unload.c

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
chris...@astron.com (Christos Zoulas) wrote: Modified Files: src/external/cddl/osnet/dev/dtrace: dtrace_sysctl.c dtrace_unload.c src/external/cddl/osnet/dev/dtrace/amd64: dtrace_subr.c src/external/cddl/osnet/dev/dtrace/i386: dtrace_subr.c

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Christos Zoulas
On Apr 24, 1:43am, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: -- Subject: Re: CVS commit: src/external/cddl/osnet | chris...@astron.com (Christos Zoulas) wrote: | Modified Files: | src/external/cddl/osnet/dev/dtrace: dtrace_sysctl.c dtrace_unload.c |

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: | | It is consistent with the code in OpenSolaris, so it should not diverge. This is changed code that would produce a diff in either case. It is more correct, and I don't see propagating a poor choice. OpenSolaris uses NULL for 0 in many

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread David Holland
On Sat, Apr 24, 2010 at 02:09:57AM +0100, Mindaugas Rasiukevicius wrote: | Also, while I see the benefits with *var (technically, it is against KNF, | by the way), my preference is to use type. That was not an explicit preference, it was just a random choice, so I have corrected it.

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Christos Zoulas
On Apr 24, 2:09am, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: -- Subject: Re: CVS commit: src/external/cddl/osnet | Are you planning to maintain this? That should be something for the | maintainer to decide, since it is not a small and simple code base. What I am saying is that all

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Christos Zoulas
On Apr 24, 1:43am, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/external/cddl/osnet | We should make lint examine the sizes of malloc calls... We have coverity for that but unfortunately the free runs have been busted for a long time. christos

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
David Holland dholland-sourcechan...@netbsd.org wrote: That was not an explicit preference, it was just a random choice, so I have corrected it. That is arbitrary. Can we please just stay relatively liberal (up to sane point) about small style differences each developer has?

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Mindaugas Rasiukevicius
chris...@zoulas.com (Christos Zoulas) wrote: | Are you planning to maintain this? That should be something for the | maintainer to decide, since it is not a small and simple code base. What I am saying is that all lines you change, they become diffs. Diffs in our preferred style or theirs

Re: CVS commit: src/external/cddl/osnet

2010-04-23 Thread Christos Zoulas
On Apr 24, 3:23am, rm...@netbsd.org (Mindaugas Rasiukevicius) wrote: -- Subject: Re: CVS commit: src/external/cddl/osnet | chris...@zoulas.com (Christos Zoulas) wrote: | | | Are you planning to maintain this? That should be something for the | | maintainer to decide, since it is not a small