Re: CVS commit: src/sys/arch/atari/dev

2022-06-26 Thread Izumi Tsutsui
> Modified Files: > src/sys/arch/atari/dev: kbd.c > > Log Message: > gcc is not smart enough to track the equivalence of conditions used > here and warns about an unused value - initialize "code" always. Umm, complains only with -Os ... Anyway thanks for fixing. --- Izumi Tsutsui

Re: CVS commit: src/sys/arch/x68k/dev

2022-06-24 Thread Izumi Tsutsui
I wrote: > Module Name: src > Committed By: tsutsui > Date: Sat Jun 25 03:18:38 UTC 2022 > > Modified Files: > src/sys/arch/x68k/dev: ite.c ite_tv.c itevar.h > > Log Message: > Add a minimum box drawing character support for x68k ite(4). Ah, I committed a wrong branch so these

Re: CVS commit: src/sys/uvm

2022-06-19 Thread Rin Okuyama
On 2022/06/09 1:55, Michael Lorenz wrote: Module Name:src Committed By: macallan Date: Wed Jun 8 16:55:00 UTC 2022 Modified Files: src/sys/uvm: uvm_map.c Log Message: initialize a variable to appease clang My bug! Thanks for fixing it. rin

Re: CVS commit: src/sys/dev/usb

2022-06-16 Thread sc . dying
Hi, On 2022/05/14 19:44, Taylor R Campbell wrote: > Module Name: src > Committed By: riastradh > Date: Sat May 14 19:44:37 UTC 2022 > > Modified Files: > src/sys/dev/usb: xhci.c > > Log Message: > xhci(4): Handle race between software abort and hardware stall. xhci_abortx is

Re: CVS commit: src/sys

2022-06-04 Thread Paul Goyette
Should be fixed now. On Sat, 4 Jun 2022, J. Hannken-Illjes wrote: On 4. Jun 2022, at 05:31, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Jun 4 03:31:10 UTC 2022 Modified Files: src/sys/dev: files.audio files.dev midi.c sequencer.c

Re: CVS commit: src/sys

2022-06-04 Thread Paul Goyette
yeah, working on it. On Sat, 4 Jun 2022, J. Hannken-Illjes wrote: On 4. Jun 2022, at 05:31, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Jun 4 03:31:10 UTC 2022 Modified Files: src/sys/dev: files.audio files.dev midi.c sequencer.c

Re: CVS commit: src/sys

2022-06-04 Thread J. Hannken-Illjes
> On 4. Jun 2022, at 05:31, Paul Goyette wrote: > > Module Name: src > Committed By: pgoyette > Date: Sat Jun 4 03:31:10 UTC 2022 > > Modified Files: > src/sys/dev: files.audio files.dev midi.c sequencer.c > src/sys/modules: Makefile > src/sys/modules/midi: Makefile

Re: CVS commit: src/sys/dev/marvell

2022-05-22 Thread Rin Okuyama
On 2022/05/21 19:27, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sat May 21 10:27:30 UTC 2022 Modified Files: src/sys/dev/marvell: if_mvgbe.c Log Message: m_freem() *after* bus_dmamap_sync() and bus_dmamap_load() for that mbuf. This is mandatory for some

Re: CVS commit: src/sys/arch

2022-05-07 Thread Rin Okuyama
Oops, I missed it. I will fix soon. Thanks again, rin On 2022/05/07 17:24, Valery Ushakov wrote: On Sat, May 07, 2022 at 04:12:55 +, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sat May 7 04:12:55 UTC 2022 Modified Files: src/sys/arch/evbppc/dht:

Re: CVS commit: src/sys/arch

2022-05-07 Thread Valery Ushakov
On Sat, May 07, 2022 at 04:12:55 +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Sat May 7 04:12:55 UTC 2022 > > Modified Files: > src/sys/arch/evbppc/dht: locore.S > src/sys/arch/powerpc/include: spr.h > > Log Message: > Instead of hard-coding

Re: CVS commit: src/sys/lib/libsa

2022-04-29 Thread Rin Okuyama
On 2022/04/28 3:29, Christos Zoulas wrote: In article <20220427144850.61383f...@cvs.netbsd.org>, Rin Okuyama wrote: -=-=-=-=-=- Module Name:src Committed By: rin Date: Wed Apr 27 14:48:50 UTC 2022 Modified Files: src/sys/lib/libsa: ext2fs.c minixfs3.c stand.h ufs.c

Re: CVS commit: src/sys/lib/libsa

2022-04-27 Thread Christos Zoulas
In article <20220427144850.61383f...@cvs.netbsd.org>, Rin Okuyama wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: rin >Date: Wed Apr 27 14:48:50 UTC 2022 > >Modified Files: > src/sys/lib/libsa: ext2fs.c minixfs3.c stand.h ufs.c > >Log Message: >Revert previous at the

Re: CVS commit: src/sys/arch/x68k/stand

2022-04-25 Thread Izumi Tsutsui
> Module Name: src > Committed By: mlelstv > Date: Mon Apr 25 15:12:07 UTC 2022 > > Modified Files: > src/sys/arch/x68k/stand/boot: conf.c > src/sys/arch/x68k/stand/xxboot: Makefile.xxboot xx.c > > Log Message: > libsa now needs ioctl to support media with large sectors.

Re: CVS commit: src/sys/arch/amiga/stand/bootblock/elf2bb

2022-04-25 Thread Rin Okuyama
On 2022/04/25 23:03, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon Apr 25 14:03:15 UTC 2022 Modified Files: src/sys/arch/amiga/stand/bootblock/elf2bb: chksum.c elf2bb.c Log Message: Use htobe{16,32}(9) instead of be{16,32}toh(9) where appropriate. No

Re: CVS commit: src/sys/dev/raidframe

2022-04-16 Thread J. Hannken-Illjes
> On 16. Apr 2022, at 18:40, Andrius Varanavicius wrote: > > Module Name: src > Committed By: andvar > Date: Sat Apr 16 16:40:54 UTC 2022 > > Modified Files: > src/sys/dev/raidframe: rf_netbsdkintf.c > > Log Message: > Fix mistake in error branch locking caused by previous

Re: CVS commit: src/sys/fs/udf

2022-03-18 Thread Joerg Sonnenberger
Am Fri, Mar 18, 2022 at 04:06:18PM + schrieb Reinoud Zandijk: > Module Name: src > Committed By: reinoud > Date: Fri Mar 18 16:06:18 UTC 2022 > > Modified Files: > src/sys/fs/udf: ecma167-udf.h > > Log Message: > Replace the variable field data[0] to data[1] to avoid undefined

re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2022-03-18 Thread matthew green
> Log Message: > old drm: Use getticks(), not hardclock_ticks. > > Should delete this code, no idea if it even still compiles. it did last i tried, and it still worked on the r100/r200 systems that new drm is still problematic with. not objecting... .mrg.

Re: CVS commit: src/sys/dev/pci

2022-02-27 Thread Martin Husemann
On Sun, Feb 27, 2022 at 11:50:15AM +0100, Martin Husemann wrote: > On Sun, Feb 27, 2022 at 12:04:58AM +0100, Joerg Sonnenberger wrote: > > Personally, I prefer the use of the C extension in cases like this. The > > "portable" version is less readable... > > I would prefer the type correct C++

Re: CVS commit: src/sys/dev/pci

2022-02-27 Thread Martin Husemann
On Sun, Feb 27, 2022 at 12:04:58AM +0100, Joerg Sonnenberger wrote: > Personally, I prefer the use of the C extension in cases like this. The > "portable" version is less readable... I would prefer the type correct C++ style variant (and making lint deal with it, if it doesn't yet). At least gcc

Re: CVS commit: src/sys/dev/pci

2022-02-26 Thread Joerg Sonnenberger
Am Sat, Feb 26, 2022 at 03:04:40PM + schrieb Roland Illig: > Module Name: src > Committed By: rillig > Date: Sat Feb 26 15:04:40 UTC 2022 > > Modified Files: > src/sys/dev/pci: if_wm.c > > Log Message: > if_wm.c: fix value return from void function > > lint complained: >

Re: CVS commit: src/sys/kern

2022-02-11 Thread Taylor R Campbell
> Date: Fri, 11 Feb 2022 16:50:16 -0800 > From: Jason Thorpe > > > On Feb 11, 2022, at 9:53 AM, Taylor R Campbell wrote: > > > > That is, this was presumably meant to ensure (A) happens-before (B). > > This relation is already guaranteed by ipi(9), so there is no need > > for any explicit

Re: CVS commit: src/sys/kern

2022-02-11 Thread Jason Thorpe
> On Feb 11, 2022, at 9:53 AM, Taylor R Campbell wrote: > > That is, this was presumably meant to ensure (A) happens-before (B). > This relation is already guaranteed by ipi(9), so there is no need > for any explicit memory barrier. Is this documented in ipi(9)? -- thorpej

Re: CVS commit: src/sys/kern

2022-02-05 Thread Taylor R Campbell
> Date: Sat, 5 Feb 2022 22:47:30 +0100 > From: Tobias Nygren > > On Sat, 5 Feb 2022 15:17:40 + > Martin Husemann wrote: > > > Modified Files: > > src/sys/kern: subr_autoconf.c > > > > Log Message: > > cfdriver_iattr_count() is only used in a KASSERT, so #ifdef DIAGNOSTIC it. > > This

Re: CVS commit: src/sys/kern

2022-02-05 Thread Tobias Nygren
On Sat, 5 Feb 2022 15:17:40 + Martin Husemann wrote: > Modified Files: > src/sys/kern: subr_autoconf.c > > Log Message: > cfdriver_iattr_count() is only used in a KASSERT, so #ifdef DIAGNOSTIC it. This doesn't seem to work as intended. In a kernel with "no options DIAGNOSTIC" I now

Re: CVS commit: src/sys/dev/fdt

2022-01-21 Thread Michael
Should fix PR 56650 > Module Name: src > Committed By: macallan > Date: Fri Jan 21 21:00:26 UTC 2022 > > Modified Files: > src/sys/dev/fdt: fdt_port.c > > Log Message: > when enumerating ports and endpoints treat missing 'reg' properties as zero > ok jmcneill: > Looking at Linux.

Re: CVS commit: src/sys/conf

2022-01-01 Thread Izumi Tsutsui
> Modified Files: > src/sys/conf: copyright > > Log Message: > Welcome to 2022! Please don't forget pullup requests for release branches. (looks 2021 was missed in 9.2) --- Izumi Tsutsui

re: CVS commit: src/sys/conf

2021-12-30 Thread matthew green
> - We only make a debuginstall rule to install netbsd-${KERNEL_CONFIG}.debug > if MKDEBUG=yes this part pollutes my $DESTDIR with non-distrib kernel info still, which also means it requires a $DESTDIR to build a kernel now. i think that we should not do this in the kernel build but inside the

Re: CVS commit: src/sys/arch/i386/stand/efiboot

2021-12-27 Thread Simon Burge
Emmanuel Dreyfus wrote: > In src/sys/arch/i386/stand/lib/biosdisk.c > int > biosdisk_findpartition(int biosdev, daddr_t sector, >int *partition, const char **part_name) > { > (...) > /* default ot first partition */ > *partition = 0; > *part_name =

Re: CVS commit: src/sys/arch/i386/stand/efiboot

2021-12-27 Thread Simon Burge
Emmanuel Dreyfus wrote: > On Mon, Dec 27, 2021 at 01:08:15PM +1100, Simon Burge wrote: > > What crash did this fix? All the use of part_name by the > > called functions should check if it is NULL before trying > > to assign anything to *part_name. > > I do not recall the details now, but I had a

Re: CVS commit: src/sys/arch/i386/stand/efiboot

2021-12-26 Thread Emmanuel Dreyfus
On Mon, Dec 27, 2021 at 01:08:15PM +1100, Simon Burge wrote: > What crash did this fix? All the use of part_name by the > called functions should check if it is NULL before trying > to assign anything to *part_name. I do not recall the details now, but I had a crash because of this. Please

Re: CVS commit: src/sys/arch/i386/stand/efiboot

2021-12-26 Thread Simon Burge
Hi Emmanuel, "Emmanuel Dreyfus" wrote: > Module Name: src > Committed By: manu > Date: Thu Nov 18 16:18:13 UTC 2021 > > Modified Files: > > src/sys/arch/i386/stand/efiboot: devopen.c > > Log Message: > > Fix crash because of NULL pointer reference What crash did this fix? All

Re: CVS commit: src/sys/dev/pci

2021-12-23 Thread Nick Hudson
On 23/12/2021 17:05, Juergen Hannken-Illjes wrote: Module Name:src Committed By: hannken Date: Thu Dec 23 17:05:49 UTC 2021 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Keep constants 32 bit, why does __BIT() return uintmax_t? PRIxBIT is available Nick

Re: CVS commit: src/sys/net

2021-12-03 Thread Tobias Nygren
On Mon, 15 Nov 2021 07:07:06 + Shoichi YAMAGUCHI wrote: > Date: Mon Nov 15 07:07:06 UTC 2021 > > Modified Files: > src/sys/net: if_ether.h if_ethersubr.c if_vlan.c > src/sys/net/lagg: if_lagg.c > > Log Message: > introduced APIs to configure VLAN TAG to ethernet devices

Re: CVS commit: src/sys/dev/tprof

2021-11-26 Thread Nick Hudson
On 26/11/2021 13:24, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Fri Nov 26 13:24:28 UTC 2021 Modified Files: src/sys/dev/tprof: tprof_armv7.c tprof_armv8.c Log Message: declare xc Thanks! Nick

Re: CVS commit: src/sys

2021-11-19 Thread Rin Okuyama
On 2021/11/20 8:46, Rin Okuyama wrote: Enable this quirk for "C600/X79 AHCI". Also add commented out quirk entries for "Bay Trail SATA (AHCI)" and "Mobile AHCI SATA Controller", for which non-reproducible failures worked around by extra delays have been reported. Oops, I meant: "Mobile AHCI

Re: CVS commit: src/sys/arch/arm/sa11x0

2021-11-08 Thread Rin Okuyama
On 2021/11/09 8:57, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon Nov 8 23:57:23 UTC 2021 Modified Files: src/sys/arch/arm/sa11x0: sa11x0_irq.S Log Message: irq_entry(): Do not clobber fp (= r11), in order not to confuse DDB. (snip) XXX Rewrite

Re: CVS commit: src/sys/arch

2021-10-31 Thread Tobias Nygren
On Sun, 31 Oct 2021 16:23:48 + Nick Hudson wrote: > Modified Files: > src/sys/arch/aarch64/include: cpu.h cpufunc.h db_machdep.h ... > Log Message: > Rework Arm (32bit and 64bit) AP startup so that cpu_hatch doesn't sleep. Hi, I'm afraid this broke the userland build. I think

Re: CVS commit: src/sys/dev/sbus

2021-10-30 Thread Ryo Shimizu
>Module Name: src >Committed By: macallan >Date: Sat Oct 30 05:37:39 UTC 2021 > >Modified Files: > src/sys/dev/sbus: mgx.c mgxreg.h > >Log Message: >actually mmap() the blitter registers when asked to, while there do some >magic number reduction > > >To generate a diff of this

Re: CVS commit: src/sys/dev/pci

2021-10-21 Thread Jonathan A. Kollasch
On Thu, Oct 21, 2021 at 05:32:28AM +, Shoichi YAMAGUCHI wrote: > Module Name: src > Committed By: yamaguchi > Date: Thu Oct 21 05:32:27 UTC 2021 > > Modified Files: > src/sys/dev/pci: virtio.c virtio_pci.c virtiovar.h > > Log Message: > divide setup routine of virtio

Re: CVS commit: src/sys/dev/pci

2021-10-18 Thread Kengo NAKAHARA
Hi, Thank you for your quick commit! Thanks, On 2021/10/18 17:15, Juergen Hannken-Illjes wrote: Module Name:src Committed By: hannken Date: Mon Oct 18 08:15:00 UTC 2021 Modified Files: src/sys/dev/pci: xmm7360.c Log Message: Use a local static variable to hold

Re: CVS commit: src/sys/arch/x86/x86

2021-10-15 Thread Paul Goyette
hehehe - porn iterators - love it! On Fri, 15 Oct 2021, Jason Thorpe wrote: I demand this change be reverted. (/s) On Oct 15, 2021, at 11:12 AM, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Fri Oct 15 18:12:48 UTC 2021 Modified Files:

Re: CVS commit: src/sys/arch/x86/x86

2021-10-15 Thread Jason Thorpe
I demand this change be reverted. (/s) > On Oct 15, 2021, at 11:12 AM, Jared D. McNeill wrote: > > Module Name: src > Committed By: jmcneill > Date: Fri Oct 15 18:12:48 UTC 2021 > > Modified Files: > src/sys/arch/x86/x86: tsc.c > > Log Message: > Fix typo in comment:

Re: CVS commit: src/sys/dev/wscons

2021-10-11 Thread nia
On Sun, Oct 10, 2021 at 10:44:03PM +0900, Izumi Tsutsui wrote: > > Module Name:src > > Committed By: nia > > Date: Tue Sep 28 06:14:28 UTC 2021 > > > > Modified Files: > > src/sys/dev/wscons: wsconsio.h wsmouse.c wsmousevar.h > > > > Log Message: > > wsmouse: add

Re: CVS commit: src/sys/arch

2021-10-11 Thread Nick Hudson
On 11/10/2021 08:14, Rin Okuyama wrote: Hi, On 2021/09/23 15:34, Nick Hudson wrote: Module Name:    src Committed By:    skrll Date:    Thu Sep 23 06:34:00 UTC 2021 Modified Files: src/sys/arch/aarch64/aarch64: cpufunc.c src/sys/arch/arm/arm32: cpu.c Log Message: Print the

Re: CVS commit: src/sys/arch

2021-10-11 Thread Rin Okuyama
Thanks for quick response. Committed :) rin On 2021/10/11 16:27, Nick Hudson wrote: On 11/10/2021 08:14, Rin Okuyama wrote: Hi, On 2021/09/23 15:34, Nick Hudson wrote: Module Name:    src Committed By:    skrll Date:    Thu Sep 23 06:34:00 UTC 2021 Modified Files:

Re: CVS commit: src/sys/arch

2021-10-11 Thread Rin Okuyama
Hi, On 2021/09/23 15:34, Nick Hudson wrote: Module Name:src Committed By: skrll Date: Thu Sep 23 06:34:00 UTC 2021 Modified Files: src/sys/arch/aarch64/aarch64: cpufunc.c src/sys/arch/arm/arm32: cpu.c Log Message: Print the cache information in similar formats

Re: CVS commit: src/sys/dev/wscons

2021-10-10 Thread Izumi Tsutsui
> Module Name: src > Committed By: nia > Date: Tue Sep 28 06:14:28 UTC 2021 > > Modified Files: > src/sys/dev/wscons: wsconsio.h wsmouse.c wsmousevar.h > > Log Message: > wsmouse: add support for "precision scrolling" events and (GET|SET)PARAMS Could you please also update

Re: CVS commit: src/sys/arch/arm/arm

2021-10-07 Thread Rin Okuyama
Oops, forgot to mention: No binary changes. On 2021/10/07 18:58, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Thu Oct 7 09:58:27 UTC 2021 Modified Files: src/sys/arch/arm/arm: cpufunc_asm_armv5_ec.S Log Message: Reduce diff with cpufunc_asm_armv5.S, from

Re: CVS commit: src/sys

2021-10-06 Thread Taylor R Campbell
> Date: Wed, 6 Oct 2021 17:44:22 +0200 > From: Reinoud Zandijk > > Sorry for my ignorance but I thought that the ksyms list was static? ie > read-only? Or is this change to support kernel modules symbols too and thus > need rw access control? The main kernel's symbols don't change, but the

Re: CVS commit: src/sys

2021-10-06 Thread Reinoud Zandijk
On Wed, Sep 15, 2021 at 07:58:20PM +0900, Rin Okuyama wrote: > On 2021/09/11 19:09, Taylor R Campbell wrote: > > Module Name:src > > Committed By: riastradh > > Date: Sat Sep 11 10:09:55 UTC 2021 > > > > Modified Files: > > src/sys/arch/sparc64/sparc64: machdep.c >

Re: CVS commit: src/sys

2021-09-29 Thread Robert Elz
Date:Wed, 29 Sep 2021 08:42:12 -0700 From:Jason Thorpe Message-ID: | Anything that depends on the new return value would have simply been | doing what the socket / fifo code was doing (groveling around in | selinfo internals), so it's not like they're broken

Re: CVS commit: src/sys

2021-09-29 Thread Jason Thorpe
> On Sep 29, 2021, at 8:15 AM, Robert Elz wrote: > >Date:Wed, 29 Sep 2021 05:37:44 -0700 >From:Jason Thorpe >Message-ID: <39db6c46-94bf-4126-811b-466e5293b...@me.com> > > | Not needed in this case. > | No callers that need the return value are in a module. > >

Re: CVS commit: src/sys

2021-09-29 Thread Robert Elz
Date:Wed, 29 Sep 2021 05:37:44 -0700 From:Jason Thorpe Message-ID: <39db6c46-94bf-4126-811b-466e5293b...@me.com> | Not needed in this case. | No callers that need the return value are in a module. The problem with this argument is that it assumes that you know

Re: CVS commit: src/sys

2021-09-29 Thread Jason Thorpe
> On Sep 28, 2021, at 10:58 PM, matthew green wrote: > > "Jason R Thorpe" writes: >> Module Name: src >> Committed By:thorpej >> Date:Wed Sep 29 02:47:22 UTC 2021 >> >> Modified Files: >> src/sys/kern: sys_select.c uipc_socket.c >> src/sys/miscfs/fifofs:

re: CVS commit: src/sys

2021-09-28 Thread matthew green
"Jason R Thorpe" writes: > Module Name: src > Committed By: thorpej > Date: Wed Sep 29 02:47:22 UTC 2021 > > Modified Files: > src/sys/kern: sys_select.c uipc_socket.c > src/sys/miscfs/fifofs: fifo_vnops.c > src/sys/sys: select.h > > Log Message: > - Change

Re: CVS commit: src/sys/arch

2021-09-23 Thread Izumi Tsutsui
> Module Name: src > Committed By: skrll > Date: Thu Sep 23 06:34:00 UTC 2021 > > Modified Files: > src/sys/arch/aarch64/aarch64: cpufunc.c > src/sys/arch/arm/arm32: cpu.c > > Log Message: > Print the cache information in similar formats and arm and aarch64, e.g. : >

Re: CVS commit: src/sys/kern

2021-09-22 Thread Rin Okuyama
On 2021/09/22 14:42, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Wed Sep 22 05:42:19 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksymsmmap: Add missing uao_reference(9) call for ks->ks_uobj. Fix failure for savecore(8) and subsequent

Re: CVS commit: src/sys

2021-09-16 Thread Rin Okuyama
Hi, For alpha, I've observed similar failure with rev 1.104; savecore fails and panic occurs in pagedaemon after that. Thanks, rin # /etc/rc.d/savecore onestart Checking for core dump... savecore: (null): kvm_nlist: bad namelist savecore: (null): _dumpdev not in namelist # dd if=/dev/zero

Re: CVS commit: src/sys

2021-09-15 Thread Rin Okuyama
On 2021/09/15 21:55, Taylor R Campbell wrote: Date: Wed, 15 Sep 2021 19:58:20 +0900 From: Rin Okuyama login: [ 95.5000696] panic: kernel diagnostic assertion "slock != NULL" failed: file "../../../../uvm/uvm_pdaemon.c", line 398 pg 0x8c66bd88 uobj 0x8fa7e400, NULL lock [...] It seems that I

Re: CVS commit: src/sys

2021-09-15 Thread Taylor R Campbell
> Date: Wed, 15 Sep 2021 19:58:20 +0900 > From: Rin Okuyama > > login: [ 95.5000696] panic: kernel diagnostic assertion "slock != NULL" > failed: file "../../../../uvm/uvm_pdaemon.c", line 398 pg 0x8c66bd88 uobj > 0x8fa7e400, NULL lock > [...] > > It seems that I can avoid this panic if > >

Re: CVS commit: src/sys

2021-09-15 Thread Rin Okuyama
Hi, On 2021/09/11 19:09, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Sat Sep 11 10:09:55 UTC 2021 Modified Files: src/sys/arch/sparc64/sparc64: machdep.c src/sys/kern: kern_ksyms.c subr_csan.c subr_msan.c src/sys/sys: ksyms.h

Re: CVS commit: src/sys/arch/sh3/sh3

2021-09-08 Thread Rin Okuyama
On 2021/09/08 20:47, Izumi Tsutsui wrote: Module Name:src Committed By: rin Date: Wed Sep 8 07:22:56 UTC 2021 Modified Files: src/sys/arch/sh3/sh3: pmap.c Log Message: Redo a part of rev 1.89: - Remove redundant parentheses/braces/comments. - Fix indents. No binary

Re: CVS commit: src/sys/arch/sh3/sh3

2021-09-08 Thread Izumi Tsutsui
> Module Name: src > Committed By: rin > Date: Wed Sep 8 07:22:56 UTC 2021 > > Modified Files: > src/sys/arch/sh3/sh3: pmap.c > > Log Message: > Redo a part of rev 1.89: > > - Remove redundant parentheses/braces/comments. > - Fix indents. > > No binary changes confirmed this

Re: CVS commit: src/sys/arch/evbarm/conf

2021-08-31 Thread Rin Okuyama
Hi, On 2021/08/30 18:20, matthew green wrote: hi. nice work on BE marvell :) Thanks! "Rin Okuyama" writes: Module Name:src Committed By: rin Date: Mon Aug 30 00:12:15 UTC 2021 Modified Files: src/sys/arch/evbarm/conf: MARVELL_NAS Log Message: Enable FFS_EI and

re: CVS commit: src/sys/arch/evbarm/conf

2021-08-30 Thread matthew green
hi. nice work on BE marvell :) "Rin Okuyama" writes: > Module Name: src > Committed By: rin > Date: Mon Aug 30 00:12:15 UTC 2021 > > Modified Files: > src/sys/arch/evbarm/conf: MARVELL_NAS > > Log Message: > Enable FFS_EI and DISKLABEL_EI as this SoC supports both endians now.

Re: CVS commit: src/sys

2021-08-25 Thread Jason Thorpe
> On Aug 24, 2021, at 10:21 PM, matthew green wrote: > >> - For alpha and sparc64, don't define MUTEX_CAS() in terms of their own >> _lock_cas(), which has its own memory barriers; the call sites in >> kern_mutex.c already have the appropriate memory barrier calls. Thus, >> alpha and

re: CVS commit: src/sys

2021-08-24 Thread matthew green
> - For alpha and sparc64, don't define MUTEX_CAS() in terms of their own > _lock_cas(), which has its own memory barriers; the call sites in > kern_mutex.c already have the appropriate memory barrier calls. Thus, > alpha and sparc64 can use default definition. this seems to leave

Re: CVS commit: src/sys/kern

2021-08-18 Thread Michael van Elst
On Tue, Aug 17, 2021 at 11:39:26PM +, Taylor R Campbell wrote: > > > > Log Message: > > skip symbol tables that were unloaded again to avoid EFAULT when reading > > ksyms. > > > > also restore TAILQ_FOREACH idiom. > > This change isn't quite right: Reading past st = ksyms_last_snapshot > in

Re: CVS commit: src/sys/kern

2021-08-17 Thread Taylor R Campbell
> Module Name:src > Committed By: mlelstv > Date: Sun Jul 18 06:57:28 UTC 2021 > > Modified Files: > src/sys/kern: kern_ksyms.c > > Log Message: > skip symbol tables that were unloaded again to avoid EFAULT when reading > ksyms. > > also restore TAILQ_FOREACH idiom.

Re: CVS commit: src/sys/modules/lua

2021-08-08 Thread Rin Okuyama
On 2021/08/09 7:26, Rin Okuyama wrote: - Initialize LIST_HEAD. Hmm, since HEADs are static, this is not necessary. But, it should be a good practice to initialize HEADs always, IMO... Thanks, rin

Re: CVS commit: src/sys/arch/arm/xscale

2021-08-06 Thread Kengo NAKAHARA
Hi, On 2021/08/06 17:58, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Fri Aug 6 08:58:42 UTC 2021 Modified Files: src/sys/arch/arm/xscale: i80321_intr.h Log Message: Do *NOT* lower IPL in i80321_splraise(). Fix various strange crashes for DIAGNOSTIC

Re: CVS commit: src/sys

2021-08-01 Thread Jared McNeill
The H6 BSP provides some clues: #if defined(CONFIG_ARCH_SUN8IW12) \ || defined(CONFIG_ARCH_SUN8IW15) \ || defined(CONFIG_ARCH_SUN50IW3) \ || defined(CONFIG_ARCH_SUN50IW6) #define SUNXI_UART_FIFO_SIZE256 #elif defined(CONFIG_ARCH_SUN3IW1) #define

Re: CVS commit: src/sys

2021-07-31 Thread Jason Thorpe
> On Jul 31, 2021, at 3:17 AM, Tobias Nygren wrote: > > It's not possible to deduce from the manual what DesignWare revision > is used but I guess I can go over the data sheets of currently > released SoCs and build a matrix of the proper values regardless > of DesignWare revision. Have the

Re: CVS commit: src/sys

2021-07-31 Thread Tobias Nygren
On Fri, 30 Jul 2021 22:36:45 +0200 Tobias Nygren wrote: > On Fri, 30 Jul 2021 17:25:46 -0300 (ADT) > Jared McNeill wrote: > > > Why only A20? > > It is the hardware I have on hand. If you know specifically which > SoCs need this, the compat_data array can be extended. > I guess maybe these

Re: CVS commit: src/sys

2021-07-30 Thread Tobias Nygren
On Fri, 30 Jul 2021 17:25:46 -0300 (ADT) Jared McNeill wrote: > Why only A20? It is the hardware I have on hand. If you know specifically which SoCs need this, the compat_data array can be extended. I guess maybe these also? allwinner,sun4i-a10 allwinner,sun6i-a31

Re: CVS commit: src/sys

2021-07-30 Thread Jared McNeill
Why only A20? On Fri, 30 Jul 2021, Tobias Nygren wrote: Module Name:src Committed By: tnn Date: Fri Jul 30 12:46:46 UTC 2021 Modified Files: src/sys/arch/arm/sunxi: sunxi_platform.c src/sys/dev/ic: com.c Log Message: com(4): fix FIFO for DW_APB on Allwinner

Re: CVS commit: src/sys/miscfs/kernfs

2021-07-18 Thread David Holland
On Mon, Jul 19, 2021 at 01:33:53AM +, David A. Holland wrote: > Part 3; cvs randomly didn't commit all the files the first time, still > hunting down the files it skipped. ok, I'm pretty sure that's the lot. -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/dev/usb

2021-07-15 Thread Nick Hudson
On 15/07/2021 04:25, Tohru Nishimura wrote: Module Name:src Committed By: nisimura Date: Thu Jul 15 03:25:50 UTC 2021 Modified Files: src/sys/dev/usb: if_mue.c uchcom.c Log Message: explanation typo To generate a diff of this commit: cvs rdiff -u -r1.60 -r1.61

Re: CVS commit: src/sys/kern

2021-06-30 Thread David Holland
On Thu, Jul 01, 2021 at 12:25:51AM -0400, Christos Zoulas wrote: > Modified Files: > src/sys/kern: vfs_vnops.c > > Log Message: > don't clear the error before we use it to determine if we are moving or > duping. oh ffs... *goes to soak head* -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm

2021-06-30 Thread Nick Hudson
On 30/06/2021 15:13, Joerg Sonnenberger wrote: On Tue, Jun 29, 2021 at 11:26:00PM +, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Tue Jun 29 23:26:00 UTC 2021 Modified Files: src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm: aeabi_cfcmp.S

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm

2021-06-30 Thread Joerg Sonnenberger
On Tue, Jun 29, 2021 at 11:26:00PM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Tue Jun 29 23:26:00 UTC 2021 > > Modified Files: > src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm: aeabi_cfcmp.S > divmodsi4.S divsi3.S modsi3.S > > Log

Re: CVS commit: src/sys

2021-06-29 Thread Paul Goyette
On Tue, 29 Jun 2021, David A. Holland wrote: Module Name:src Committed By: dholland Date: Tue Jun 29 22:39:21 UTC 2021 Modified Files: src/sys/fs/puffs: puffs_vnops.c src/sys/fs/union: union_vnops.c src/sys/fs/unionfs: unionfs_subr.c

Re: CVS commit: src/sys/dev/pad

2021-06-16 Thread Rin Okuyama
On 2021/06/16 19:23, Rin Okuyama wrote: On 2021/06/16 18:15, Taylor R Campbell wrote: Date: Wed, 16 Jun 2021 17:38:26 +0900 From: Rin Okuyama KASSERT added to pad_attach() by this commit fires on macppc with mixerctl(1): [...] panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed:

Re: CVS commit: src/sys/dev/pad

2021-06-16 Thread Rin Okuyama
On 2021/06/16 18:15, Taylor R Campbell wrote: Date: Wed, 16 Jun 2021 17:38:26 +0900 From: Rin Okuyama KASSERT added to pad_attach() by this commit fires on macppc with mixerctl(1): [...] panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file "/usr/src/sys/dev/pad/pad.c", line 214

Re: CVS commit: src/sys/dev/pad

2021-06-16 Thread Taylor R Campbell
> Date: Wed, 16 Jun 2021 17:38:26 +0900 > From: Rin Okuyama > > KASSERT added to pad_attach() by this commit fires on macppc with mixerctl(1): > [...] panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file > "/usr/src/sys/dev/pad/pad.c", line 214 Can you share `ident netbsd | grep

Re: CVS commit: src/sys/dev/pad

2021-06-16 Thread Rin Okuyama
Hi, KASSERT added to pad_attach() by this commit fires on macppc with mixerctl(1): # cd /usr/tests/usr.bin/mixerctl && atf-run ... tc-start: ..., nflag [...] panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file "/usr/src/sys/dev/pad/pad.c", line 214 [...] cpu0: Begin

Re: CVS commit: src/sys/dev

2021-06-09 Thread Paul Goyette
On Wed, 9 Jun 2021, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Wed Jun 9 23:22:51 UTC 2021 Modified Files: src/sys/dev: dev_verbose.h Log Message: Use the localcount(9)-based module_hook mechanism to prevent the verbose modules' code and data

Re: CVS commit: src/sys/dev/audio

2021-06-08 Thread Rin Okuyama
On 2021/06/08 16:09, nia wrote: On Tue, Jun 01, 2021 at 09:12:24PM +, Taylor R Campbell wrote: audio(4): Set AUMODE_PLAY/RECORD only if asked _and_ supported. If one is requested and _not_ supported, fail; otherwise we might enter audio_write with a null play track and crash on KASSERT.

Re: CVS commit: src/sys/dev/audio

2021-06-08 Thread nia
On Tue, Jun 01, 2021 at 09:12:24PM +, Taylor R Campbell wrote: > audio(4): Set AUMODE_PLAY/RECORD only if asked _and_ supported. > > If one is requested and _not_ supported, fail; otherwise we might > enter audio_write with a null play track and crash on KASSERT. It looks like this is an

Re: CVS commit: src/sys/kern

2021-06-02 Thread Rin Okuyama
Hmm, misleading commit log (code itself is correct). More precisely: s/the last element of ksyms_symtabs/ksyms_last_snapshot/ Anyway, does this help you to reintroduce "ksyms(4): Don't skip symbol tables that are soon to be freed."? That KASSERT does not fire anymore for aarch64, as far as I

Re: CVS commit: src/sys/kern

2021-06-02 Thread Taylor R Campbell
> Date: Wed, 2 Jun 2021 17:33:39 +0900 > From: Rin Okuyama > > On 2021/06/02 6:11, Taylor R Campbell wrote: > > - KASSERT(filepos <= sizeof(struct ksyms_hdr) + > > + KASSERT(filepos == sizeof(struct ksyms_hdr) + > > ksyms_hdr.kh_shdr[SYMTAB].sh_size); > ... > > This KASSERT fires at

Re: CVS commit: src/sys/kern

2021-06-02 Thread Rin Okuyama
Hi, On 2021/06/02 6:11, Taylor R Campbell wrote: Module Name:src Committed By: riastradh Date: Tue Jun 1 21:11:52 UTC 2021 Modified Files: src/sys/kern: kern_ksyms.c Log Message: ksyms(4): Don't skip symbol tables that are soon to be freed. They will not actually be

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Rin Okuyama
Correction: On 2021/06/01 7:10, Rin Okuyama wrote: On 2021/05/31 23:35, Joerg Sonnenberger wrote: On Mon, May 31, 2021 at 12:12:24PM +, Rin Okuyama wrote: Bump LAST_REGISTER and LAST_RESTORE_REG to REGNO_ARM32_S31 for arm. This is not desirable as it significantly increases the memory

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Rin Okuyama
On 2021/05/31 23:35, Joerg Sonnenberger wrote: On Mon, May 31, 2021 at 12:12:24PM +, Rin Okuyama wrote: Bump LAST_REGISTER and LAST_RESTORE_REG to REGNO_ARM32_S31 for arm. This is not desirable as it significantly increases the memory use. The goal here is to actually alias the single and

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Rin Okuyama
On 2021/05/31 23:32, Joerg Sonnenberger wrote: On Mon, May 31, 2021 at 12:12:24PM +, Rin Okuyama wrote: There are two numbering schemes for VFPv2 registers: s0-s31 and d0-d15. The former is used by GCC, and the latter is by LLVM. Since libunwind was derived from LLVM, it has never supported

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Rin Okuyama
On 2021/05/31 23:30, Joerg Sonnenberger wrote: On Mon, May 31, 2021 at 11:41:22AM +, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Mon May 31 11:41:22 UTC 2021 Modified Files: src/sys/lib/libunwind: Registers.hpp unwind_registers.S Log Message: ... -

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Joerg Sonnenberger
On Mon, May 31, 2021 at 12:12:24PM +, Rin Okuyama wrote: > Bump LAST_REGISTER and LAST_RESTORE_REG to REGNO_ARM32_S31 for arm. This is not desirable as it significantly increases the memory use. The goal here is to actually alias the single and double register in the space. That's what the

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Joerg Sonnenberger
On Mon, May 31, 2021 at 12:12:24PM +, Rin Okuyama wrote: > There are two numbering schemes for VFPv2 registers: s0-s31 and d0-d15. > The former is used by GCC, and the latter is by LLVM. Since libunwind was > derived from LLVM, it has never supported the former. This results in > crashes for

Re: CVS commit: src/sys/lib/libunwind

2021-05-31 Thread Joerg Sonnenberger
On Mon, May 31, 2021 at 11:41:22AM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Mon May 31 11:41:22 UTC 2021 > > Modified Files: > src/sys/lib/libunwind: Registers.hpp unwind_registers.S > > Log Message: > ... > > - Introduce enum for flags. Please

Re: CVS commit: src/sys/arch/arm/include/arm32

2021-05-30 Thread Simon Burge
"Rin Okuyama" wrote: > Module Name: src > Committed By: rin > Date: Sun May 30 07:20:00 UTC 2021 > > Modified Files: > > src/sys/arch/arm/include/arm32: param.h > > Log Message: > > Include opt_param.h for MSGBUFSIZE ifdef _KERNEL_OPT. Thanks Rin! I thought I had checked all the

  1   2   3   4   5   6   7   8   9   10   >