Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-04 Thread Valery Ushakov
On Fri, Oct 04, 2019 at 04:57:51 +0200, Kamil Rytarowski wrote:

> At least in certain domains of engineering 0 is a special case as it
> does not need unit (km, lumen, kg, ...) neither base (hex, dec, ..).
> 
> It is natural (correct, expected) to print %#x for 0 as 0, without 0x.

I'm happy for them and that there's %#x that they can use.  What does
it have to do with with anything?


> On 04.10.2019 04:09, Christos Zoulas wrote:
> > Thanks, and zero is special for 0#. Should I revert it?
> > 
> > christos
> > 
> >> On Oct 3, 2019, at 10:06 PM, Valery Ushakov  wrote:
> >>
> >>
> >>> Modified Files:
> >>>   src/sys/arch/acorn32/acorn32: rpc_machdep.c
> >>>
> >>> Log Message:
> >>> change 0x% -> %x
> >>
> >> This should read %#x.
> >> And this is wrong.
> >>
> >> 1) With # the 0x is part of the width, so 
> >>
> >> 0x%08x -> 0x0001
> >> %#08x  -> 0x01
> >>
> >> 0x 0x0001
> >>  0x01
> >>
> >> 2) # doesn't add prefix for zero, so 
> >>
> >> 0x%08x -> 0x
> >> %#08x  ->  
> >>
> >> -uwe
> > 
> 
> 




-uwe


Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Valery Ushakov
On Thu, Oct 03, 2019 at 22:09:28 -0400, Christos Zoulas wrote:

> Thanks, and zero is special for 0#. Should I revert it?

Yes, please.


> > On Oct 3, 2019, at 10:06 PM, Valery Ushakov  wrote:
> > 
> > 
> >> Modified Files:
> >>src/sys/arch/acorn32/acorn32: rpc_machdep.c
> >> 
> >> Log Message:
> >> change 0x% -> %x
> > 
> > This should read %#x.
> > And this is wrong.
> > 
> > 1) With # the 0x is part of the width, so 
> > 
> > 0x%08x -> 0x0001
> > %#08x  -> 0x01
> > 
> > 0x 0x0001
> >  0x01
> > 
> > 2) # doesn't add prefix for zero, so 
> > 
> > 0x%08x -> 0x
> > %#08x  ->  

-uwe


Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Kamil Rytarowski
At least in certain domains of engineering 0 is a special case as it
does not need unit (km, lumen, kg, ...) neither base (hex, dec, ..).

It is natural (correct, expected) to print %#x for 0 as 0, without 0x.

On 04.10.2019 04:09, Christos Zoulas wrote:
> Thanks, and zero is special for 0#. Should I revert it?
> 
> christos
> 
>> On Oct 3, 2019, at 10:06 PM, Valery Ushakov  wrote:
>>
>>
>>> Modified Files:
>>> src/sys/arch/acorn32/acorn32: rpc_machdep.c
>>>
>>> Log Message:
>>> change 0x% -> %x
>>
>> This should read %#x.
>> And this is wrong.
>>
>> 1) With # the 0x is part of the width, so 
>>
>> 0x%08x -> 0x0001
>> %#08x  -> 0x01
>>
>> 0x 0x0001
>>  0x01
>>
>> 2) # doesn't add prefix for zero, so 
>>
>> 0x%08x -> 0x
>> %#08x  ->  
>>
>> -uwe
> 




signature.asc
Description: OpenPGP digital signature


Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Christos Zoulas
Thanks, and zero is special for 0#. Should I revert it?

christos

> On Oct 3, 2019, at 10:06 PM, Valery Ushakov  wrote:
> 
> 
>> Modified Files:
>>  src/sys/arch/acorn32/acorn32: rpc_machdep.c
>> 
>> Log Message:
>> change 0x% -> %x
> 
> This should read %#x.
> And this is wrong.
> 
> 1) With # the 0x is part of the width, so 
> 
> 0x%08x -> 0x0001
> %#08x  -> 0x01
> 
> 0x 0x0001
>  0x01
> 
> 2) # doesn't add prefix for zero, so 
> 
> 0x%08x -> 0x
> %#08x  ->  
> 
> -uwe



Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Valery Ushakov


> Modified Files:
>   src/sys/arch/acorn32/acorn32: rpc_machdep.c
> 
> Log Message:
> change 0x% -> %x

This should read %#x.
And this is wrong.

1) With # the 0x is part of the width, so 

0x%08x -> 0x0001
%#08x  -> 0x01

0x 0x0001
 0x01

2) # doesn't add prefix for zero, so 

0x%08x -> 0x
%#08x  ->  

-uwe