Re: GCC TSan (Re: CVS commit: src/tests/usr.bin)
On Tue, Sep 15, 2020 at 03:32:25PM +0200, Kamil Rytarowski wrote: > I've tried to mark the TSan parts that need porting as explicit failure, > soo we can reduce the risk of shipping unported runtime. That risc is quite low as currently the runtime is apparently not buildable on anything but amd64 ;-) Indeed once we are able to build runtime components we should also adjust the tested architectures. Would be great if we could easily query such things, but it is not even easy to conditionalize the tests on gcc 9 or newer. Martin
GCC TSan (Re: CVS commit: src/tests/usr.bin)
On 15.09.2020 07:03, Martin Husemann wrote: > On Mon, Sep 14, 2020 at 03:17:53PM +, Kamil Rytarowski wrote: >> Enable TSan tests for GCC and >32bit address space environments > > Since tsan does not work on all architectures, this is not a good idea. > It would be better to code it with an explicit list of architectures > supported. > > Martin > I've tried to mark the TSan parts that need porting as explicit failure, soo we can reduce the risk of shipping unported runtime. There are generally three such parts: - address space memory mappings - setjmp mapping of stack pointer - setjmp/longjmp assembly code I noted that not all ATF TSan tests pass for GCC amd64. I suspect that the runtime is still too old (even older than Clang-7 2 years ago, when we added the ATF tests). Another difference is that LLVM by default links the runtime statically and GCC dynamically. There is a crash with dl_iterate_phdr(3). This is possibly related to the crash with -pg. GCC requires to deliver .spec files for static linking of sanitizers. We need to generate libsanitizer.spec and install it to /usr/lib/. I will have a look into it. GCC9 also wants to install libasan_preinit.o, liblsan_preinit.o, libtsan_preinit.o. I'm going to prepare appropriate build rules for them. signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/tests/usr.bin
On Mon, Sep 14, 2020 at 03:17:53PM +, Kamil Rytarowski wrote: > Enable TSan tests for GCC and >32bit address space environments Since tsan does not work on all architectures, this is not a good idea. It would be better to code it with an explicit list of architectures supported. Martin
Re: CVS commit: src/tests/usr.bin
On 14.10.2019 05:47, Jason High wrote: Module Name:src Committed By: jhigh Date: Mon Oct 14 03:47:20 UTC 2019 Modified Files: src/tests/usr.bin: Makefile Added Files: src/tests/usr.bin/argon2: Atffile Makefile t_argon2.sh Log Message: adding argon2 tests diff -u /dev/null src/tests/usr.bin/argon2/Atffile:1.1 --- /dev/null Mon Oct 14 03:47:20 2019 +++ src/tests/usr.bin/argon2/AtffileMon Oct 14 03:47:20 2019 @@ -0,0 +1,7 @@ +Content-Type: application/X-atf-atffile; version="1" + +# Automatically generated by bsd.test.mk. + +prop: test-suite = "NetBSD" + +tp: t_argon2 This file shall not be added, please delete it. On the other hand we need to add entries in distrib sets.
Re: CVS commit: src/tests/usr.bin/netpgpverify
On Tue, Nov 27, 2012 at 11:23:48AM +0100, Herbert J. Skuhra wrote: On 20.11.2012 08:55, Alistair G. Crooks wrote: Module Name: src Committed By:agc Date:Tue Nov 20 07:55:55 UTC 2012 Added Files: src/tests/usr.bin/netpgpverify: Atffile Makefile t_netpgpverify.sh Log Message: Add tests for netpgpverify. After this commit the following command fails: % ./build.sh -O ../obj -T ../tools -U distribution [...] rm: Atffile: Permission denied Failed to remove the following files from /usr/src/tests/usr.bin/netpgpverify: Atffile [...] *** Error code 1 Stop. nbmake: stopped in /usr/src ERROR: Failed to make distribution *** BUILD ABORTED *** Should be fixed now. Best, Alistair
Re: CVS commit: src/tests/usr.bin/netpgpverify
On 20.11.2012 08:55, Alistair G. Crooks wrote: Module Name:src Committed By: agc Date: Tue Nov 20 07:55:55 UTC 2012 Added Files: src/tests/usr.bin/netpgpverify: Atffile Makefile t_netpgpverify.sh Log Message: Add tests for netpgpverify. After this commit the following command fails: % ./build.sh -O ../obj -T ../tools -U distribution [...] rm: Atffile: Permission denied Failed to remove the following files from /usr/src/tests/usr.bin/netpgpverify: Atffile [...] *** Error code 1 Stop. nbmake: stopped in /usr/src ERROR: Failed to make distribution *** BUILD ABORTED *** -- Herbert
Re: CVS commit: src/tests/usr.bin/pr
On Tue, May 03, 2011 at 02:26:11PM +, Jukka Ruohonen wrote: Modified Files: src/tests/usr.bin/pr: t_basic.sh Log Message: Fix same copy-paste error here. (Why atf(7) does not warn about these?) How could it? All it's got there is a shell function. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/tests/usr.bin/pr
On Tue, May 03, 2011 at 06:22:46PM +0300, Jukka Ruohonen wrote: I think it actually does, but only at run-time. It will end up counting as a bogus test program. Another question: was a conclusion ever reached about the preferred directory structure for the tests? I've been now following the same structure used in the actual src, but many things are in ../tests/util. The stuff in util/ predates the decision to use a matching directory structure. It hasn't been renamed because of inertia, I guess, combined with cvs issues and perhaps the faint hope we might get version control with rename before the end of the next millennium. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/tests/usr.bin/pr
On Fri, May 06, 2011 at 01:31:11AM +, David Holland wrote: The stuff in util/ predates the decision to use a matching directory structure. It hasn't been renamed because of inertia, I guess, Ok. That was kind of my supposition too. combined with cvs issues and perhaps the faint hope we might get version control with rename before the end of the next millennium. Add the set-lists and their obsolete keywords, and the next millennium sounds quite right indeed... - Jukka.
Re: CVS commit: src/tests/usr.bin/pr
On Tue, May 03, 2011 at 07:44:57AM -0700, Paul Goyette wrote: I think it actually does, but only at run-time. It will end up counting as a bogus test program. Another question: was a conclusion ever reached about the preferred directory structure for the tests? I've been now following the same structure used in the actual src, but many things are in ../tests/util. - Jukka.
Re: CVS commit: src/tests/usr.bin/pr
I'm not sure where the src/tests/util stuff came from, but I would prefer that we continue to mirror src/... as you have been doing. On Tue, 3 May 2011, Jukka Ruohonen wrote: On Tue, May 03, 2011 at 07:44:57AM -0700, Paul Goyette wrote: I think it actually does, but only at run-time. It will end up counting as a bogus test program. Another question: was a conclusion ever reached about the preferred directory structure for the tests? I've been now following the same structure used in the actual src, but many things are in ../tests/util. - Jukka. !DSPAM:4dc01dcf2434615079005! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
