CVS commit: src/distrib/notes/common

2014-02-08 Thread Maxime Villard
, and would like to .It Ta Shuichiro URATA Ta Mt u...@netbsd.org .It Ta Valeriy E. Ushakov Ta Mt u...@netbsd.org .It Ta Todd Vierling Ta Mt t...@netbsd.org +.It Ta Maxime Villard Ta Mt m...@netbsd.org .It Ta Aymeric Vincent Ta Mt ayme...@netbsd.org .It Ta Paul Vixie Ta Mt vi...@netbsd.org .It Ta

CVS commit: src/sbin/veriexecctl

2014-02-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 9 13:41:00 UTC 2014 Modified Files: src/sbin/veriexecctl: veriexecctl.c Log Message: Fix error message; argv[1] could be NULL To generate a diff of this commit: cvs rdiff -u -r1.35 -r1.36

CVS commit: src/sys/kern

2014-02-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 9 14:51:13 UTC 2014 Modified Files: src/sys/kern: kern_sysctl.c Log Message: Reorder code to avoid using an uninitialized variable: if sysctl_copyin fails, 'tmp' is not initialized. This bug is harmless since only the

CVS commit: src/sys/compat/linux/common

2014-02-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Feb 11 16:00:13 UTC 2014 Modified Files: src/sys/compat/linux/common: linux_futex.c Log Message: Fix uninitialized variable. Harmless: it does not change the behavior at all. ok rmind@ christos@ To generate a diff of this

CVS commit: src/sys/kern

2014-02-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 14 07:30:07 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Fix memory leak. ok christos@ agc@ To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55 src/sys/kern/exec_elf.c Please note that diffs

CVS commit: src/sys

2014-02-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 15 16:17:01 UTC 2014 Modified Files: src/sys/kern: exec_elf.c src/sys/sys: exec_elf.h Log Message: Remove the last argument of elf_check_header(). It is easier - and faster - to check the e_type field in the calling

CVS commit: src/sys/fs/tmpfs

2014-02-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 16 12:54:07 UTC 2014 Modified Files: src/sys/fs/tmpfs: tmpfs_vnops.c Log Message: Fix tmpfs_read()'s return value; it should return EINVAL. Now consistent with tmpfs_write(). ok christos@ To generate a diff of this

CVS commit: src/sys/kern

2014-02-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 16 17:46:36 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Small cleanup: - make elf_load_file() and elf_load_psection() static - make loops consistent - 'nload' is not used - see rev1.24 - 'ap' is not

CVS commit: src/sys/kern

2014-02-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 17 19:29:46 UTC 2014 Modified Files: src/sys/kern: exec_script.c kern_exec.c Log Message: Cosmetic; just replace whitespaces by tabs To generate a diff of this commit: cvs rdiff -u -r1.67 -r1.68 src/sys/kern/exec_script.c

CVS commit: src/sys/fs/tmpfs

2014-02-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Feb 17 20:16:52 UTC 2014 Modified Files: src/sys/fs/tmpfs: tmpfs_vnops.c Log Message: Adapt my previous patch differently. read(2) wants EISDIR when the object is a directory. Which also means that tmpfs_read() was returning a

CVS commit: src/sys/kern

2014-02-19 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 19 15:23:20 UTC 2014 Modified Files: src/sys/kern: exec_elf.c kern_exec.c Log Message: We need VMCMDs for a binary and its interpreter, so make sure we have at least one VMCMD. This also prevents the kernel from using an

CVS commit: src/sys/kern

2014-02-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 21 07:47:02 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Properly check the section size to avoid out-of-bound reads. The computed size must be the exact same size that is indicated in sh_size. ok agc@

CVS commit: src/sys/compat

2014-02-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 21 07:53:53 UTC 2014 Modified Files: src/sys/compat/linux/arch/amd64: linux_exec_machdep.c src/sys/compat/linux/common: linux_exec.h linux_exec_elf32.c src/sys/compat/linux32/arch/amd64: linux32_exec.h

CVS commit: src/sys/kern

2014-02-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 21 08:11:59 UTC 2014 Modified Files: src/sys/kern: exec_script.c Log Message: Revert rev1.38. The header already begins with EXEC_SCRIPT_MAGIC=#!. So it can't be ELFMAG=\177ELF at the same time. ok christos@ To generate

CVS commit: src/sys/kern

2014-02-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 07:53:16 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Simplify error path. ok christos@ To generate a diff of this commit: cvs rdiff -u -r1.60 -r1.61 src/sys/kern/exec_elf.c Please note that diffs

CVS commit: src/sys/kern

2014-02-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Feb 27 09:58:05 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: We have to ensure the string is NUL-terminated and of the expected length to avoid copying uninitialized data. ok christos@ To generate a diff of

CVS commit: src/sys/netinet

2014-03-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 1 16:46:14 UTC 2014 Modified Files: src/sys/netinet: tcp_input.c Log Message: ';;' - ';' no functional change spotted by my code scanner ok christos@ To generate a diff of this commit: cvs rdiff -u -r1.330 -r1.331

CVS commit: src/sys/dev/acpi

2014-03-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 1 16:59:42 UTC 2014 Modified Files: src/sys/dev/acpi: tpm_acpi.c Log Message: Some {} are missing. The behavior is thus wrong: the code always jumps to out1. Spotted by my code scanner. ok christos@ To generate a diff

CVS commit: src/sys/arch/arm/ep93xx

2014-03-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Mar 6 19:46:28 UTC 2014 Modified Files: src/sys/arch/arm/ep93xx: epclk.c Log Message: Fix uninitialized variable. Found by my code scanner. ok christos@ To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21

CVS commit: src/sys/kern

2014-03-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Mar 16 07:57:25 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Remove the 'prot' argument from elf_load_psection(). It is not used outside, and can be declared locally. Clearer. ok christos@ To generate a

CVS commit: src/sys/kern

2014-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 22 07:27:22 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Small changes: - rename elf_load_file() to elf_load_interp() - use the correct type for 'nused' - remove useless cases - reorder a kmem_alloc

CVS commit: src/sys/net

2014-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 22 07:46:35 UTC 2014 Modified Files: src/sys/net: route.c Log Message: 'newrt' is not supposed to be NULL. Therefore, the NULL-check in the if() is pointless; and even if 'newrt' were NULL, 'rt' would be dereferenced later.

CVS commit: src/sys

2014-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 22 08:15:25 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_netbsd.c src/sys/kern: vfs_syscalls.c Log Message: Fix a potential - but very unlikely - NULL pointer dereference. (it does not introduce a new

CVS commit: src/sys/kern

2014-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 29 09:31:12 UTC 2014 Modified Files: src/sys/kern: exec_subr.c Log Message: Style To generate a diff of this commit: cvs rdiff -u -r1.70 -r1.71 src/sys/kern/exec_subr.c Please note that diffs are not public domain; they

CVS commit: src/sys/kern

2014-04-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Apr 4 06:47:02 UTC 2014 Modified Files: src/sys/kern: vfs_syscalls.c Log Message: Limit check for 'data_len'. Otherwise a (un)privileged user can easily panic the system by passing a huge size. ok christos@ To generate a

CVS commit: src/sys/compat/svr4_32

2014-04-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Apr 9 11:40:03 UTC 2014 Modified Files: src/sys/compat/svr4_32: svr4_32_exec_elf32.c Log Message: 'error' is not set on failure. Which means that if copyout() fails, 0 will be returned while the stack is not ready. This is a

CVS commit: src/sys/compat

2014-06-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jun 21 10:23:07 UTC 2014 Modified Files: src/sys/compat/linux/common: linux_socketcall.c src/sys/compat/linux32/common: linux32_socketcall.c Log Message: If SCARG(uap, what) = 0, copyin() will copy (size_t)-1 bytes, and

CVS commit: src/sys/kern

2014-06-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 22 17:23:34 UTC 2014 Modified Files: src/sys/kern: kern_exec.c Log Message: A KASSERT() is better. To generate a diff of this commit: cvs rdiff -u -r1.407 -r1.408 src/sys/kern/kern_exec.c Please note that diffs are not

CVS commit: src/sys/kern

2014-06-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 22 17:36:42 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: Put the KMEM_GUARD code under #if defined(KMEM_GUARD). No functional change. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52

CVS commit: src/sys/kern

2014-06-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 22 18:32:27 UTC 2014 Modified Files: src/sys/kern: vfs_vnops.c Log Message: Fix a NULL pointer dereference after a lng discussion with dholland@, hannken@, blymn@ and martin@. This bug would panic the system when

CVS commit: src/sys

2014-06-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jun 22 19:09:39 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_netbsd.c src/sys/uvm: uvm_swap.c Log Message: Sync swapctl() with netbsd32. Return EINVAL when misc0, and 0 when misc=0 or uvmexp.nswapdev=0.

CVS commit: src/sys/kern

2014-06-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jun 23 17:43:42 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: Enable KMEM_SIZE on DIAGNOSTIC. It will catch memory corruption bugs due to a different size given to kmem_alloc() and kmem_free(), with no

CVS commit: src/sys/kern

2014-06-23 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jun 23 18:06:32 UTC 2014 Modified Files: src/sys/kern: exec_script.c Log Message: Use KASSERT() instead of #ifdef(DIAGNOSTIC). Clearer. To generate a diff of this commit: cvs rdiff -u -r1.70 -r1.71 src/sys/kern/exec_script.c

CVS commit: src/sys/kern

2014-06-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jun 24 07:28:23 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: KMEM_REDZONE+KMEM_POISON is supposed to detect buffer overflows. But it only poisons memory after kmem_roundup_size(), which means that if an

CVS commit: src/sys/kern

2014-06-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jun 24 10:08:45 UTC 2014 Modified Files: src/sys/kern: sched_4bsd.c sched_m2.c Log Message: 'miliseconds' - 'milliseconds'. To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/kern/sched_4bsd.c cvs rdiff -u

CVS commit: src/sys

2014-06-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jun 24 11:59:11 UTC 2014 Modified Files: src/sys/arch/amd64/conf: ALL src/sys/arch/i386/conf: ALL src/sys/compat/freebsd: freebsd_exec_elf32.c Log Message: Remove dead code. The kernel already checks for

CVS commit: src/sys/compat/freebsd

2014-06-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jun 24 12:17:40 UTC 2014 Modified Files: src/sys/compat/freebsd: freebsd_exec_elf32.c Log Message: Remove unused headers. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19

CVS commit: src/sys/compat/netbsd32

2014-06-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jun 24 14:33:57 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_50.c netbsd32_event.c Log Message: Allocate directly KQ_NEVENTS bytes. Otherwise a user can panic the system. ok christos@ To generate a diff

CVS commit: src/sys/kern

2014-06-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jun 24 14:42:43 UTC 2014 Modified Files: src/sys/kern: kern_event.c Log Message: Do not hardcode the value. Use KQ_NEVENTS. To generate a diff of this commit: cvs rdiff -u -r1.79 -r1.80 src/sys/kern/kern_event.c Please note

CVS commit: src/sys/kern

2014-06-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jun 25 16:05:22 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: Rephrase some comments and remove whitespaces. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55

CVS commit: src/sys/kern

2014-06-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jun 25 16:35:13 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: 1) Make clear that we want the space allocated for the KMEM_SIZE header to be aligned, by using kmem_roundup_size(). There's no functional

CVS commit: src/sys/compat/freebsd

2014-06-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jun 28 11:06:31 UTC 2014 Modified Files: src/sys/compat/freebsd: freebsd_sched.c Log Message: Empy comment To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/sys/compat/freebsd/freebsd_sched.c Please note that

CVS commit: src/sys/compat/netbsd32

2014-06-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jun 28 11:39:15 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_netbsd.c Log Message: Sync getfh() with the native implementation. It also fixes: a) a return value b) a vnode lock c) a user-controlled memory

CVS commit: src/sys/uvm

2014-06-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jun 28 15:52:45 UTC 2014 Modified Files: src/sys/uvm: uvm_swap.c Log Message: This KASSERT can trigger a panic too easily, if SCARG(uap, cmd)=SWAP_OFF and SCARG(uap, arg)=NULL. The same KASSERT is already in the SWAP_ON switch

CVS commit: src/sys/kern

2014-06-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jun 30 17:22:32 UTC 2014 Modified Files: src/sys/kern: exec_script.c Log Message: If the interpreter is , do not keep loading the script (which will later fail), but return ENOEXEC directly. ok christos@ To generate a diff

CVS commit: src/sys/kern

2014-06-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jun 30 17:31:15 UTC 2014 Modified Files: src/sys/kern: exec_script.c Log Message: Reorder two variables and fix some comments. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/kern/exec_script.c Please

CVS commit: src/sys/kern

2014-06-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jun 30 17:51:32 UTC 2014 Modified Files: src/sys/kern: vfs_syscalls.c Log Message: This is weird; 'abort' already does all this, so simply use goto abort. To generate a diff of this commit: cvs rdiff -u -r1.486 -r1.487

CVS commit: src/sys/kern

2014-07-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jul 1 12:08:33 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: 1) Define a malloc(9)-like kmem_header structure for KMEM_SIZE. It is in fact more consistent, and more flexible (eg if we want to add new

CVS commit: src/sys/kern

2014-07-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 2 15:00:29 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: Fix the KMEM_POISON check: it should check the whole buffer, otherwise some write-after-free's wouldn't be detected (those occurring in the 8 last

CVS commit: src/sys/kern

2014-07-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jul 3 08:43:49 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: Change the pattern of KMEM_REDZONE so that the first byte is never '\0'. From me and lars@. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2014-07-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jul 6 07:41:41 UTC 2014 Modified Files: src/sys/kern: exec_elf.c Log Message: Check .evs_used==0 instead of .evs_cmds==NULL. evs_cmds would not be NULL if another _makecmds() had allocated and deallocated VMCMDs (not the case

CVS commit: src/sys/kern

2014-07-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jul 6 15:22:31 UTC 2014 Modified Files: src/sys/kern: subr_kobj.c Log Message: Use a macro instead of always putting __func__ and __LINE__. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47

CVS commit: src/sys/kern

2014-07-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jul 6 15:35:32 UTC 2014 Modified Files: src/sys/kern: subr_kobj.c Log Message: Remove this (symtabindex == -1) check; it is already handled by (nsym != 1). Put a KASSERT instead. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys

2014-07-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jul 8 17:16:25 UTC 2014 Modified Files: src/sys/kern: exec_elf.c src/sys/sys: exec_elf.h Log Message: Define ELF_MAXNOTESIZE, ELF_MAXSHNUM and ELF_MAXPHNUM in sys/exec_elf.h, so that it can be used externally. To

CVS commit: src/sys/fs/msdosfs

2014-07-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jul 8 19:34:47 UTC 2014 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: - Perform sanity checks not just for GEMDOSFS, but for all FAT devices. This also fixes a division-by-zero bug that could crash the

CVS commit: src/sys/kern

2014-07-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 9 05:50:51 UTC 2014 Modified Files: src/sys/kern: subr_kobj.c Log Message: - limit the number of sections with ELF_MAXSHNUM - fix the (symstrindex hdr-e_shnum) check: it should be =, otherwise there's an off-by-one

CVS commit: src/usr.sbin/makefs/msdos

2014-07-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 9 06:04:16 UTC 2014 Modified Files: src/usr.sbin/makefs/msdos: msdosfs_vfsops.c Log Message: What a terrible use-after-free To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8

CVS commit: src/sys

2014-07-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 9 08:43:54 UTC 2014 Modified Files: src/sys/fs/cd9660: cd9660_vfsops.c src/sys/fs/msdosfs: msdosfs_vfsops.c src/sys/ufs/ext2fs: ext2fs_vfsops.c Log Message: Remove ROOTNAME (unused). To generate a diff of

CVS commit: src/sys/fs/msdosfs

2014-07-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 9 09:00:18 UTC 2014 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Minor changes: - malloc()+memset() - malloc(|M_ZERO) - rename 'vers' to 'FSVers' - declare 'ExtFlags' instead of calling getushort()

CVS commit: src/sys/kern

2014-07-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jul 10 19:12:07 UTC 2014 Modified Files: src/sys/kern: sys_module.c Log Message: Fix a user-controlled memory allocation. kmem_alloc(0) will panic the system. ok christos@ To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2014-07-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jul 10 19:21:46 UTC 2014 Modified Files: src/sys/kern: sys_module.c Log Message: Simplify a bit To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/kern/sys_module.c Please note that diffs are not public

CVS commit: src/sys/compat/netbsd32

2014-07-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jul 11 16:22:49 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_mod.c Log Message: netbsd32 should depend on exec_elf32, since it will use exec_elf32's functions. This fixes # modload compat_netbsd32 when

CVS commit: src/sys/kern

2014-07-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jul 14 16:06:48 UTC 2014 Modified Files: src/sys/kern: kern_module.c Log Message: Tell which dependency has failed To generate a diff of this commit: cvs rdiff -u -r1.95 -r1.96 src/sys/kern/kern_module.c Please note that

CVS commit: src/sys/fs/smbfs

2014-07-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Jul 14 16:29:50 UTC 2014 Modified Files: src/sys/fs/smbfs: smbfs_vfsops.c Log Message: smbfs depends on nsmb, so add the dependency as appropriate. Fixes # modload smbfs on modular kernels, PR kern/40011, and probably

CVS commit: src/sys/kern

2014-07-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 16 13:26:33 UTC 2014 Modified Files: src/sys/kern: subr_kobj.c Log Message: Keep setting 'error' as appropriate (even if this place is broken enough to crash in many other ways...) To generate a diff of this commit: cvs

CVS commit: src/sys/fs/msdosfs

2014-07-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jul 16 20:09:00 UTC 2014 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Limit the minimum size of a disk sector to 512 bytes, to prevent memory overflow on extremely low secsize. This normally conforms to the

CVS commit: src/sys/rump/dev/lib/libnetsmb

2014-07-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jul 18 16:25:17 UTC 2014 Modified Files: src/sys/rump/dev/lib/libnetsmb: netsmb_component.c Log Message: Fix the ATF failures caused by my recent smbfs change (smbfs_vfsops.c -r1.103). ok pooka@ To generate a diff of this

CVS commit: src/sys/fs/msdosfs

2014-07-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jul 18 17:24:34 UTC 2014 Modified Files: src/sys/fs/msdosfs: msdosfs_vfsops.c Log Message: Make DPRINTF more understandable, and replace my previous #ifdef DIAGNOSTIC... To generate a diff of this commit: cvs rdiff -u -r1.114

CVS commit: src/sys/kern

2014-07-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jul 22 07:38:41 UTC 2014 Modified Files: src/sys/kern: subr_kmem.c Log Message: Enable KMEM_REDZONE on DIAGNOSTIC. It will try to catch overflows. No comment on tech-kern@ To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys

2014-07-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jul 22 08:18:33 UTC 2014 Modified Files: src/sys/compat/linux32/common: linux32_mod.c src/sys/compat/netbsd32: netbsd32_mod.c src/sys/kern: exec_elf32.c exec_elf64.c Log Message: 1) On 64bit systems, don't add

CVS commit: src/sys/compat/netbsd32

2014-07-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jul 25 16:23:13 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_exec_elf32.c Log Message: Remove ELF_ROUND and ELF_TRUNC (unused). Found by my code scanner. To generate a diff of this commit: cvs rdiff -u -r1.36

CVS commit: src/sys/kern

2014-07-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jul 25 16:28:12 UTC 2014 Modified Files: src/sys/kern: vfs_syscalls.c Log Message: 'result' - 'error' To generate a diff of this commit: cvs rdiff -u -r1.489 -r1.490 src/sys/kern/vfs_syscalls.c Please note that diffs are not

CVS commit: src/sys/compat/netbsd32

2014-07-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jul 31 12:35:33 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_netbsd.c Log Message: Just return sys_open(). COMPAT_10 will be handled internally. ok christos@ To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/miscfs/umapfs

2014-08-11 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Aug 11 14:02:14 UTC 2014 Modified Files: src/sys/miscfs/umapfs: umap_vfsops.c Log Message: 1) 'error' is returned while it does not even hold an error code. Which means that zero is returned, and the kernel keeps mounting

CVS commit: src/sys/ufs/ext2fs

2014-08-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Aug 12 06:49:11 UTC 2014 Modified Files: src/sys/ufs/ext2fs: ext2fs_readwrite.c Log Message: http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html#Report-2 #04-0x02: Remove 'doclusterread' and 'doclusterwrite'

CVS commit: src/sys/fs/smbfs

2014-08-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Aug 12 06:57:20 UTC 2014 Modified Files: src/sys/fs/smbfs: smbfs_smb.c Log Message: http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html#Report-2 #04-0x01: Uninitialized var 'rqp' (does not compile anyway) To

CVS commit: src/sys/fs/ptyfs

2014-08-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Aug 14 14:06:53 UTC 2014 Modified Files: src/sys/fs/ptyfs: ptyfs_vfsops.c Log Message: Overflow if *data_len == OSIZE and args-version = PTYFS_ARGSVERSION. Sent on tech-kern@, ok christos@ To generate a diff of this commit:

CVS commit: src/sys/compat/svr4

2014-08-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Aug 14 17:29:30 UTC 2014 Modified Files: src/sys/compat/svr4: svr4_stat.c Log Message: http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html#Report-2 #06-0x01: Empty compiler block ok christos@ To generate a diff

CVS commit: src/sys/netinet6

2014-08-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Aug 16 17:27:09 UTC 2014 Modified Files: src/sys/netinet6: ip6_output.c Log Message: http://m00nbsd.net/ae123a9bae03f7dde5c6d654412daf5a.html#Report-2 #03-0x02: Memory leak ok ozaki-r@ To generate a diff of this

CVS commit: src/sys

2014-08-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Aug 21 06:40:35 UTC 2014 Modified Files: src/sys/arch/arm/s3c2xx0: s3c24x0_lcd.c src/sys/compat/netbsd32: netbsd32_compat_50.c netbsd32_compat_60.c src/sys/compat/osf1: osf1_mount.c src/sys/fs/ptyfs:

CVS commit: src/sys/compat/osf1

2014-08-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Aug 24 12:48:58 UTC 2014 Modified Files: src/sys/compat/osf1: osf1_file.c Log Message: Ensure nbytes 0. Otherwise bad things may happen. Compile-tested only. ok christos@ To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/compat/freebsd

2014-10-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Oct 10 16:29:56 UTC 2014 Modified Files: src/sys/compat/freebsd: freebsd_sysctl.c Log Message: I'm not sure reading from an unsanitized userland pointer is a good idea. Some users might be tempted to give 0x01, in which case

CVS commit: src/sys/compat/linux/common

2014-10-19 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Oct 19 17:33:59 UTC 2014 Modified Files: src/sys/compat/linux/common: linux_uselib.c Log Message: Resource leak. Found by my code scanner. Tested by njoly@; ok njoly@ rmind@ on tech-kern@. To generate a diff of this commit:

CVS commit: src/sys/ufs/chfs

2014-10-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Oct 20 06:41:52 UTC 2014 Modified Files: src/sys/ufs/chfs: chfs_vfsops.c Log Message: Memory leak. Found by my code scanner. ok christos@ To generate a diff of this commit: cvs rdiff -u -r1.11 -r1.12

CVS commit: src/sys/compat/common

2014-10-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Oct 20 06:56:38 UTC 2014 Modified Files: src/sys/compat/common: vfs_syscalls_30.c Log Message: Memory leak, triggerable from root only. Found by my code scanner. ok christos@ To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2014-10-20 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Oct 20 08:20:08 UTC 2014 Modified Files: src/sys/kern: kern_prot.c Log Message: The userland namelen is size_t, but the kernel holds it in an int. The sizeof(login) test implicitly interprets 'namelen' as unsigned, which means

CVS commit: src/sys/compat/linux/common

2014-10-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 30 16:45:28 UTC 2014 Modified Files: src/sys/compat/linux/common: linux_uselib.c Log Message: Reject non-regular files. Patch from njoly@. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32

CVS commit: src/sys/ufs/ffs

2014-10-30 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Oct 30 17:13:41 UTC 2014 Modified Files: src/sys/ufs/ffs: ffs_vfsops.c Log Message: Limit the superblock size to SBLOCKSIZE, not MAXBSIZE. Otherwise memcpy will read beyond the allocated buffer. Discussed a bit on tech-kern@.

CVS commit: src/sys/secmodel

2014-11-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Nov 4 16:01:58 UTC 2014 Modified Files: src/sys/secmodel: secmodel.c Log Message: Do not release secmodels_lock when it is not held. Sent on tech-kern@, ok lars@ To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2

CVS commit: src/sys/compat

2014-11-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 9 17:48:08 UTC 2014 Modified Files: src/sys/compat/common: compat_util.c if_43.c kern_time_50.c uipc_syscalls_43.c src/sys/compat/linux/arch/alpha: linux_machdep.c linux_pipe.c

CVS commit: src/sys/kern

2014-11-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 9 17:50:02 UTC 2014 Modified Files: src/sys/kern: kern_exec.c Log Message: Do not uselessly include sys/malloc.h. To generate a diff of this commit: cvs rdiff -u -r1.409 -r1.410 src/sys/kern/kern_exec.c Please note that

CVS commit: src/sys/miscfs

2014-11-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 9 18:08:07 UTC 2014 Modified Files: src/sys/miscfs/fdesc: fdesc_vfsops.c src/sys/miscfs/genfs: layer_subr.c layer_vfsops.c src/sys/miscfs/nullfs: null_vfsops.c src/sys/miscfs/umapfs: umap_subr.c

CVS commit: src/sys/compat/svr4

2014-11-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 9 18:16:55 UTC 2014 Modified Files: src/sys/compat/svr4: svr4_exec_elf32.c svr4_exec_elf64.c svr4_fcntl.c svr4_filio.c svr4_ioctl.c svr4_ipc.c svr4_schedctl.c svr4_signal.c svr4_sockio.c

CVS commit: src/sys/ufs

2014-11-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 9 18:23:28 UTC 2014 Modified Files: src/sys/ufs/chfs: chfs_vfsops.c chfs_vnode.c src/sys/ufs/ext2fs: ext2fs_readwrite.c ext2fs_vfsops.c ext2fs_vnops.c Log Message: Do not uselessly include sys/malloc.h. To

CVS commit: src/sys/compat/freebsd

2014-11-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Nov 9 18:30:39 UTC 2014 Modified Files: src/sys/compat/freebsd: freebsd_exec_elf32.c freebsd_file.c freebsd_ipc.c freebsd_misc.c Log Message: Do not uselessly include sys/malloc.h. To generate a diff of this

CVS commit: src/sys

2014-11-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Nov 10 18:46:34 UTC 2014 Modified Files: src/sys/fs/cd9660: cd9660_node.c cd9660_util.c src/sys/fs/puffs: puffs_compat.c puffs_msgif.c puffs_node.c puffs_subr.c puffs_vfsops.c src/sys/fs/udf:

CVS commit: src/sys/netinet

2014-11-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Nov 10 18:52:51 UTC 2014 Modified Files: src/sys/netinet: if_atm.c in_pcb.c raw_ip.c tcp_output.c tcp_sack.c tcp_subr.c tcp_timer.c tcp_usrreq.c tcp_vtw.c Log Message: Do not uselessly include sys/malloc.h. To

CVS commit: src/sys/netinet6

2014-11-14 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Nov 14 17:34:23 UTC 2014 Modified Files: src/sys/netinet6: dest6.c in6_ifattach.c in6_pcb.c ip6_forward.c udp6_output.c Log Message: Do not uselessly include sys/malloc.h. To generate a diff of this commit: cvs

CVS commit: src/sys/compat/netbsd32

2014-12-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 5 17:26:21 UTC 2014 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_30.c Log Message: User-triggerable kmem_alloc(0). Ok martin@ christos@ User To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31

CVS commit: src

2014-12-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Dec 27 19:32:57 UTC 2014 Modified Files: src/share/man/man9: Makefile malloc.9 src/sys/sys: malloc.h mallocvar.h Log Message: Cleanup: - remove struct kmembuckets (dead) - correctly deadify MALLOC_XX - remove

  1   2   3   4   5   6   7   8   9   10   >