Re: [Spacewalk-devel] RFE: spacecmd: patches for printing

2012-05-15 Thread Aron Parsons
Jörg, I'm good with these patches. The diff functionality is definitely useful. I've committed them to Spacewalk master tonight. For future commit messages, can you prefix with "spacecmd:" or something similar? Take a look at the commit history to see how Steve and I have done it. Please feel

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-15 Thread Miroslav Suchy
On 15.5.2012 14:28, Johannes Renner wrote: On 05/15/2012 01:25 PM, Miroslav Suchy wrote: +Requires: susestudio-java-client This will require susestudio-java-client rpm? It is not present in neither in Fedora nor in jpackage. Can I take: https://build.opensuse.org/package/view_file?file=susest

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-15 Thread Johannes Renner
On 05/15/2012 01:25 PM, Miroslav Suchy wrote: > +Requires: susestudio-java-client > > This will require susestudio-java-client rpm? It is not present in neither in > Fedora nor in jpackage. > Can I take: > > https://build.opensuse.org/package/view_file?file=susestudio-java-client.spec&package=su

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-15 Thread Uwe Gansert
On 15.05.2012 13:25, Miroslav Suchy wrote: The Python code was revised by Uwe, see patch 0002 and 0003. print filePath ^^ This probably omitted from some debugging. you are right of course. That line slipped in accidently from a debugging session and can be removed. -- ciao, Uwe Gansert

Re: [Spacewalk-devel] Deployment of images built with SUSE Studio

2012-05-15 Thread Miroslav Suchy
On 15.5.2012 11:39, Johannes Renner wrote: Hi Miroslav, attached please find a new version of our patches. We considered most of your advices, see my comments below and the patches itself, of course. Hi, I spent just 10 minutes on preliminary review. Please give me few days for complete revi