Re: [Spacewalk-devel] pgsql review

Devan Goodwin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 22 May 2009 13:09:44 -0400 Jeff Ortel jor...@redhat.com wrote: I fear our other test suites will require us to merge back so we can actually tag packages and have a sane way to deploy the postgresql modified code.

[Spacewalk-devel] Re: Missing tag for spacewalk-utils

Miroslav Suchý wrote: Ops, Package spacewalk-utils is in releng/packages/spacewalk-utils in version 0.6.1-1, but there is no such tag there. I blame: 4853fe71 (Brad Buckingham 2009-04-07 16:29:15 -0400 1) 0.6.1-1 utils/ Sincerely the watchdog Package should now be tagged in master. ref

[Spacewalk-devel] Re: [Fwd: 487566 - api/script - initial commit of snapshot script and mods to snapshot apis]

Miroslav Suchý wrote: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=c55ad4bf0952843b458b33579544338069cb442e May I ask that with new API addition/change we bump minor number of web.apiversion in file web/conf/rhn_web.conf And in Javadoc we write comment similar to:

Re: [Spacewalk-devel] Re: [Fwd: 487566 - api/script - initial commit of snapshot script and mods to snapshot apis]

Brad Buckingham wrote: Miroslav Suchý wrote: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=c55ad4bf0952843b458b33579544338069cb442e May I ask that with new API addition/change we bump minor number of web.apiversion in file web/conf/rhn_web.conf And in Javadoc we write

Re: [Spacewalk-devel] Re: [Fwd: 487566 - api/script - initial commit of snapshot script and mods to snapshot apis]

Jason Dobies wrote: Brad Buckingham wrote: Brad Buckingham wrote: Miroslav Suchý wrote: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=c55ad4bf0952843b458b33579544338069cb442e May I ask that with new API addition/change we bump minor number of web.apiversion in file web

Re: [Spacewalk-devel] Exceptions need work

Jason Dobies wrote: Jesus Rodriguez wrote: This is more of a note to self, but I'd figured I'd share with everyone. We need to revisit our exception classes, the api has a very rich set of exceptions that can be useful by other parts of the code. Most folks don't want to use them because they

Re: [Spacewalk-devel] [Fwd: 489616 - update NewChannelHelper.clone to create channel family, if none exists]

Jason Dobies wrote: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=f811e59d177e6922c54eea65123d9782b324bac7 Can we move the second lookup to inside of the if? That way, since most times the family will not be null we remove the duplicate load from the normal case.

Re: [Spacewalk-devel] Custom values

Miroslav Suchý wrote: Can somebody explain me what is s.system.get_custom_values and set_custom_values API call? Custom values of what? For what it is useful? Mirek, The system.getCustomValue system.setCustomValue APIs are related to the Custom Info capability that is provided via the UI

Re: [Spacewalk-devel] 481180 - update KickstartFormatter to not include --interpetter in profile f...

://git.fedoraproject.org/git/?p=spacewalk.git;a=summary by Brad Buckingham bbucking...@redhat.com on 3/11/09 481180 - update KickstartFormatter to not include --interpetter in profile for scripts where the Scripting Language is omitted/blank. * [D http://git.fedoraproject.org/git/?p=spacewalk.git

Re: [Spacewalk-devel] 487563 - switching take_snapshots to enable_snapshots

This is a good question. I'll be working on modifications in the future to make the documentation links configurable. This would be to address the fact that the various help links in Spacewalk are currently dead-links. When I do that, it'll likely be controlled based on properties defined

Re: [Spacewalk-devel] first_names Fix: 233c64b8e502fe85ed1a77730559078d32adcdb8

Devan Goodwin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey Jason, not sure if this is an issue but am I correct that you changed the incoming key the API expects from first_names to first_name? If so that might need a follow up, in general we try not to change the API signatures so

[Spacewalk-devel] git - please run checkstyle before submitting to master

Developers, Just a friendly reminder... :) Please make it a habit to always run 'ant checkstyle' before submitting code to master in git. This evening we had 17 errors that spanned multiple commits. I have submitted changes to address the current errors. thanks, Brad

Re: [Spacewalk-devel] Spacewalk 0.4 update

Partha Aji wrote: Mike McCune wrote: Jesus M. Rodriguez wrote: Hey Spacewalk hackers, I'd like to wrap up feature and bug fixing by 12/5 so that we can start the package building process on Monday 12/8 for a release on 12/15. Let me know if this will be a problem. Feature freeze: 12/5

Re: [Spacewalk-devel] PATCH: JUNIT tests for get/setCustomOptions

Coe, Colin C. (Unix Engineer) wrote: Hi all Attached are the JUNIT tests for the get/setCustomOptions API calls. This is a correction of the patch sent Oct 5. Apologies for the delay. CC NOTICE: This email and any attachments are confidential. They may contain legally privileged

Re: [Spacewalk-devel] Patch: new API call 'channelExists'

Colin, The patch has been applied to Spacewalk 0.3. Prior to committing, I did add a junit test to ConfigChannelHandlerTest. Thanks for the contribution ! Brad Jesus M. Rodriguez wrote: Colin, Thanks for the submission. I'll review this and apply it. It won't make it until Spacewalk 0.3