Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-08-04 Thread Jan Pazdziora
On Thu, Jul 21, 2011 at 05:35:14PM -0300, Marcelo Moreira de Mello wrote: On Thu, 2011-07-21 at 13:21 +0200, Jan Pazdziora wrote: On Tue, Jul 19, 2011 at 02:38:24PM -0300, Marcelo Moreira de Mello wrote: Not sure what would be verifying the Satellite/Spacewalk version. If rhncfg*, then,

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-21 Thread Jan Pazdziora
On Tue, Jul 19, 2011 at 02:38:24PM -0300, Marcelo Moreira de Mello wrote: Yes. Makes sense! What do you think if we verify the Satellite/Spacewalk version and then apply /script/run or /script/all. What do you think? Not sure what would be verifying the Satellite/Spacewalk version. If

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-21 Thread Marcelo Moreira de Mello
On Thu, 2011-07-21 at 13:21 +0200, Jan Pazdziora wrote: On Tue, Jul 19, 2011 at 02:38:24PM -0300, Marcelo Moreira de Mello wrote: Not sure what would be verifying the Satellite/Spacewalk version. If rhncfg*, then, well, it should just gracefuly rename all to run, in runtime (as opposed to the

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-19 Thread Jan Pazdziora
On Fri, Jul 15, 2011 at 03:43:34PM -0300, Marcelo Moreira de Mello wrote: But for those systems already installed and when updating the rhncfg* packages, the %post scriptlet will works and make it compatible with script/run. That's why we test if the script/all exits and then move the file.

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-19 Thread Marcelo Moreira de Mello
On Tue, 2011-07-19 at 18:28 +0200, Jan Pazdziora wrote: On Fri, Jul 15, 2011 at 03:43:34PM -0300, Marcelo Moreira de Mello wrote: But for those systems already installed and when updating the rhncfg* packages, the %post scriptlet will works and make it compatible with script/run. That's

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-15 Thread Marcelo Moreira de Mello
On 07/15/2011 07:23 AM, Michael Mraka wrote: Marcelo Moreira de Mello wrote: % Hello, % % Follow attached a new patch which include the 3 modifications: % % 1) Change KickstartFormatter.java to create the run file instead % of all; % % 2) Adds a %post script to move any

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-15 Thread Jan Pazdziora
On Fri, Jul 15, 2011 at 11:16:11AM -0300, Marcelo Moreira de Mello wrote: * Will the new code work with kickstarts from current spacewalk which contain 'touch .../script/all'? I mean if new rhncfg-* is installed so it looks for .../script/run but no %postinst which renames .../script/all

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-15 Thread Marcelo Moreira de Mello
On 07/15/2011 11:39 AM, Jan Pazdziora wrote: It's the combination of Spacewalk 1.4 (or Satellite 5.3, 5.4) and new rhncfg* being kickstarted. The file is touched in the kickstart file only after the rhncfg* packages were installed. So the %post scriptlet trick does not apply (there is no

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-14 Thread Jan Pazdziora
On Wed, Jul 06, 2011 at 02:05:12PM -0300, Marcelo Moreira de Mello wrote: Howdy, Any news regarding this patch? Marcelo, could you explain in deeper detail what in the current (Spacewalk) code makes both 'all' and 'run' to be taken as True for the script.run action? -- Jan Pazdziora

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-14 Thread Jan Pazdziora
On Thu, Jul 14, 2011 at 02:54:41PM +0200, Jan Pazdziora wrote: On Wed, Jul 06, 2011 at 02:05:12PM -0300, Marcelo Moreira de Mello wrote: Howdy, Any news regarding this patch? Marcelo, could you explain in deeper detail what in the current (Spacewalk) code makes both 'all' and

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-14 Thread Marcelo Moreira de Mello
On 07/14/2011 09:58 AM, Jan Pazdziora wrote: On Thu, Jul 14, 2011 at 02:54:41PM +0200, Jan Pazdziora wrote: On Wed, Jul 06, 2011 at 02:05:12PM -0300, Marcelo Moreira de Mello wrote: Howdy, Any news regarding this patch? Marcelo, could you explain in deeper detail what in the current

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-07-14 Thread Marcelo Moreira de Mello
Hello, Follow attached a new patch which include the 3 modifications: 1) Change KickstartFormatter.java to create the run file instead of all; 2) Adds a %post script to move any existing all to run, making it consistent with the documentation and with the new kickstart 3)

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-06-29 Thread Cliff Perry
On 06/25/2011 01:24 AM, Marcelo Moreira de Mello wrote: Hello, Follow a new patch which follow the guidelines raise by Jan. This patch makes rhn-actions-control --disable-all to remove both files and --report check if all or run file exists. # rhn-actions-control --disable-all ; tree

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-06-24 Thread Marcelo Moreira de Mello
Hello, Follow a new patch which follow the guidelines raise by Jan. This patch makes rhn-actions-control --disable-all to remove both files and --report check if all or run file exists. # rhn-actions-control --disable-all ; tree /etc/sysconfig/rhn/allowed-actions

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-06-17 Thread Marcelo Moreira de Mello
Hello Jan, On Thu, 2011-06-16 at 16:38 +0200, Jan Pazdziora wrote: On Thu, Jun 02, 2011 at 07:30:23PM -0300, Marcelo Moreira de Mello wrote: Follow attached the patch which fixes the BZ#508936. At RHN Satellite/Spacewalk documentation, to be able to execute remote commands, it must

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-06-16 Thread Jan Pazdziora
On Thu, Jun 02, 2011 at 07:30:23PM -0300, Marcelo Moreira de Mello wrote: Follow attached the patch which fixes the BZ#508936. At RHN Satellite/Spacewalk documentation, to be able to execute remote commands, it must exists a file named run into /etc/sysconfig/rhn/allowed-actions/scripts

Re: [Spacewalk-devel] [PATCH] - RHBZ#508936 - Run remote command works even when run is disabled on the client

2011-06-03 Thread Marcelo Moreira de Mello
Hello, Here follow a better patch which check if the action_type if configfiles or script. Please, ignore the patch sent previously. Thank you! Cheers, Marcelo On 06/02/2011 07:30 PM, Marcelo Moreira de Mello wrote: Hello, Follow attached the patch which fixes the BZ#508936. At RHN