Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 12:56:32PM +0100, Alessandro Rubini wrote: > > I have Acks on some of the driver patches and no comments on the > > rest. I've been circulating these for some time, so if you're > > happy to pull those driver patches via your tree, please go ahead. > > Sure I have no probl

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-11-22 Thread Alessandro Rubini
>> lkml.org/lkml/2011/11/4/125 (0/2: description of the work) >> lkml.org/lkml/2011/11/4/126 (1/2: turn the if plethora to table lookup) >> lkml.org/lkml/2011/11/4/127 (2/2: partial split to type-specific files). > > Splitting this up doesn't look like a silly idea -- I thought it was > unfo

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-11-22 Thread Alessandro Rubini
> I have Acks on some of the driver patches and no comments on the > rest. I've been circulating these for some time, so if you're > happy to pull those driver patches via your tree, please go ahead. Sure I have no problem with the nomadik-rng.c, (so please have my Acked-by: -- sorry for not noti

Re: [GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-11-22 Thread Dave Martin
On Tue, Nov 22, 2011 at 12:56:32PM +0100, Alessandro Rubini wrote: > > I have Acks on some of the driver patches and no comments on the > > rest. I've been circulating these for some time, so if you're > > happy to pull those driver patches via your tree, please go ahead. > > Sure I have no probl

[GIT PULL] ARM: amba: Enable module alias autogeneration for AMBA drivers

2011-11-22 Thread Dave Martin
Hi Russell, This series enables the general infrastructure for modalias generation to work for AMBA devices, and enables it in the affected drivers. Since there are several patches here, I though it better to send a pull request. The first two patches (subject lines "ARM: amba: ...") are the cor

Re: config SPI_STMP3XXX

2011-11-22 Thread Paul Bolle
On Tue, 2011-11-22 at 10:56 +0100, Wolfram Sang wrote: > > 1) Are there any plans to port this driver to the mxs sub-architecture? [...] > There are definately plans, it just takes longer than expected :( I will > take care of it. Thanks. I'll stop worrying about this invalid Kconfig dependency fo

config SPI_STMP3XXX

2011-11-22 Thread Paul Bolle
0) config SPI_STMP3XXX ("Freescale STMP37xx/378x SPI/SSP controller") depends on depends on ARCH_STMP3XXX. ARCH_STMP3XXX got dropped in commit 041f10d46f ("ARM: plat-stmp: remove plat"). This means that this driver is unbuildable since v3.0. 1) Are there any plans to port this driver to the mxs su

Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Linus Walleij
On Tue, Nov 22, 2011 at 9:28 AM, Viresh Kumar wrote: > On 11/22/2011 1:55 PM, Linus WALLEIJ wrote: >>       if (list_empty(&pl022->queue) || !pl022->running) { >> +             if (pl022->busy) { >> +                     pm_runtime_put(&pl022->adev->dev); >> +             } > > We used to get warn

Re: [PATCH 7/7] spi/pl022: make the chip deselect handling thread safe

2011-11-22 Thread Viresh Kumar
On 11/22/2011 1:55 PM, Linus WALLEIJ wrote: > From: Virupax Sadashivpetimath > > There is a possibility that the pump_message and giveback > run in parallel on a SMP system. Both the pump_message and > giveback threads work on the same SPI message queue. > Results will be in correct if the pump_m

Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Viresh Kumar
On 11/22/2011 1:55 PM, Linus WALLEIJ wrote: > if (list_empty(&pl022->queue) || !pl022->running) { > + if (pl022->busy) { > + pm_runtime_put(&pl022->adev->dev); > + } We used to get warnings from checkpatch, for single line code inside {}. Don't we

Re: [PATCH 3/7] spi/pl022: skip default configuration before suspending

2011-11-22 Thread Viresh Kumar
On 11/22/2011 1:54 PM, Linus WALLEIJ wrote: > From: Virupax Sadashivpetimath > > The loading of the default configuration before suspending has > been in the driver since its inception, but it is not really > needed. Especially so since we take to all the trouble of > enabling and disabling power

Re: [PATCH spi-next] spi: add Broadcom BCM63xx SPI controller driver

2011-11-22 Thread Shubhrajyoti Datta
Hi Florian, On Tue, Nov 22, 2011 at 1:46 AM, Florian Fainelli wrote: > This patch adds support for the SPI controller found on the Broadcom BCM63xx > SoCs. > > Signed-off-by: Tanguy Bouzeloc > Signed-off-by: Florian Fainelli > --- > The platform related changes have been submitted on the linux-

[PATCH 6/7] spi/pl022: add support for pm_runtime autosuspend

2011-11-22 Thread Linus Walleij
From: Chris Blair Adds support for configuring the spi bus to use autosuspend for runtime power management. This can reduce the latency in starting an spi transfer by not suspending the device immediately following completion of a transfer. If another transfer then takes place before the autosusp

[PATCH 7/7] spi/pl022: make the chip deselect handling thread safe

2011-11-22 Thread Linus Walleij
From: Virupax Sadashivpetimath There is a possibility that the pump_message and giveback run in parallel on a SMP system. Both the pump_message and giveback threads work on the same SPI message queue. Results will be in correct if the pump_message gets to work on the queue first. when the pump_m

[PATCH 5/7] spi/pl022: disable the PL022 block when unused

2011-11-22 Thread Linus Walleij
From: Virupax Sadashivpetimath Make sure we clear the enable bit when the block is not used. This will save some energy in certain hardware versions. Reviewed-by: Viresh Kumar Signed-off-by: Virupax Sadashivpetimath Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Move this patch after t

[PATCH 3/7] spi/pl022: skip default configuration before suspending

2011-11-22 Thread Linus Walleij
From: Virupax Sadashivpetimath The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now. Signe

[PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Linus Walleij
From: Chris Blair Moves the disabling of the device and clocks to the same thread in which the device and clocks are enabled. This avoids SMP issues where the device can be enabled for a transfer by one thread and then disabled by the completion of the previous transfer in another thread. Signed

[PATCH 1/7] spi/pl022: only enable RX interrupts when TX is complete

2011-11-22 Thread Linus Walleij
From: Chris Blair For interrupt mode transfers, start with only TX interrupts enabled to reduce the overall number of interrupts received. Once TX is complete, enable RX interrupts to complete the transfer. Reviewed-by: Viresh Kumar Signed-off-by: Chris Blair Signed-off-by: Linus Walleij ---

[PATCH 2/7] spi/pl022: fix build warnings

2011-11-22 Thread Linus Walleij
From: Jonas Aaberg The driver build complains with newer compilers unless you initialize this struct properly. Reviewed-by: Viresh Kumar Signed-off-by: Jonas Aaberg Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add Viresh's Reviewed-by --- drivers/spi/spi-pl022.c |2 +- 1 files ch