[PATCH 4/4] spi: s3c64xx: add support for exynos5440 spi

2013-02-05 Thread Girish K S
This patch adds support for the exynos5440 spi controller. The integration of the spi IP in exynos5440 is different from other SoC's. The I/O pins are no more configured via gpio, they have dedicated pins. Signed-off-by: Girish K S --- drivers/spi/spi-s3c64xx.c | 12 1 file change

[PATCH 2/4] spi: s3c64xx: added support for polling mode

2013-02-05 Thread Girish K S
The 64xx spi driver supports partial polling mode. Only the last chunk of the transfer length is transferred or recieved in polling mode. Some SoC's that adopt this controller might not have have dma interface. This patch adds support for complete polling mode and gives flexibity for the user to s

[PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-05 Thread Girish K S
The status of the interrupt is available in the status register, so reading the clear pending register and writing back the same value will not actually clear the pending interrupts. This patch modifies the interrupt handler to read the status register and clear the corresponding pending bit in the

[PATCH 0/4] Add polling support for 64xx spi controller

2013-02-05 Thread Girish K S
[PATCH 1/4]: fixes the error handling in the interrupt handler [PATCH 2/4]: The existing driver support partial polling mode. This patch modifies the current driver to support only polling mode. [PATCH 3/4]: Adds quirk to support SoC's with dedicated i/o pins [PATCH 4/4]:

[PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-05 Thread Girish K S
This patch adds support for spi controllers with dedicated clk/miso/mosi/cs pins. It skips the gpio parsing and initialization for controllers that have dedicated pins. Signed-off-by: Girish K S --- drivers/spi/spi-s3c64xx.c | 39 +++ 1 file changed, 31 inse

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Arnd Bergmann
On Tuesday 05 February 2013, Tony Lindgren wrote: > * Felipe Balbi [130204 07:46]: > > > > Current DMA abstraction is quite poor, for example there's no way to > > compile support for multiple DMA engines. Code also makes certain, IMO > > unnecessary, assumptions about the underlying DMA engine (

[PATCH 2/2] arm: mvebu: Add SPI flash on Armada 370 DB board

2013-02-05 Thread Gregory CLEMENT
This patch add support for the SPI flash MX25l25635E which is present on the Armada 370 DB board. This flash stores the bootloader and its environment. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-370-db.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/a

[PATCH 1/2] arm: mvebu: Add SPI flash on Armada XP-DB board

2013-02-05 Thread Gregory CLEMENT
This patch add support for the SPI flash M25P64 which is present on the Armada XP DB board. This flash stores the bootloader and its environment. Signed-off-by: Gregory CLEMENT --- arch/arm/boot/dts/armada-xp-db.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boo

[PATCH 0/2] Add SPI flash for Aramda 370 and XP dev board

2013-02-05 Thread Gregory CLEMENT
Hi, Following the Ezequiel's patches this patch set add support for SPI data Flash for two other development board from Marvell. This pacthes depend on the SPI serie of Ezequiel [1], and also on the selection of CONFIG_MTD_M25P80=y in the config file. [1] http://thread.gmane.org/gmane.linux.kern

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Gregory CLEMENT
On 02/05/2013 05:28 PM, Gregory CLEMENT wrote: > Hi Ezequiel, > > On 02/05/2013 12:24 PM, Ezequiel Garcia wrote: >> This patch adds an SPI master device node for Armada XP-GP board. >> This master node is an SPI flash controller 'n25q128a13'. >> >> Since there is no 'partitions' node declared, one

[PATCH v2] spi/ath79: add shutdown handler

2013-02-05 Thread Gabor Juhos
The SPI controller of the AR7xxx/AR9xxx SoCs have a special mode which allows the SoC to directly read data from SPI flash chips. In this mode, the content of the SPI flash chip can be accessed via a memory mapped region. During early init time, the kernel expects that the flash chip is accessible

Re: [PATCH 6/6] spi/ath79: add shutdown handler

2013-02-05 Thread Gabor Juhos
2013.02.05. 14:02 keltezéssel, Grant Likely írta: >> -static int ath79_spi_remove(struct platform_device *pdev) >> +static void __ath79_spi_remove(struct platform_device *pdev) >> { >> struct ath79_spi *sp = platform_get_drvdata(pdev); >> >> @@ -304,13 +304,23 @@ static int ath79_spi_remov

Re: [PATCH 1/6] spi/ath79: add delay between SCK changes

2013-02-05 Thread Gabor Juhos
Hi Grant, > On Thu, 27 Dec 2012 10:42:24 +0100, Gabor Juhos wrote: >> The driver uses the "as fast as it can" approach >> to drive the SCK signal. However this does not >> work with certain low speed SPI chips (e.g. the >> PCF2123 RTC chip). >> >> The patch adds per-bit slowdowns in order to be >

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Ezequiel Garcia
On Tue, Feb 05, 2013 at 06:07:05PM +0100, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > On Tue, 05 Feb 2013 17:20:02 +0100, Gregory CLEMENT wrote: > > > So that means we should enable the drivers for all the devices present > > on all the boards? > > Yes. For example my mvsdio patch set en

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Cyril Chemparathy
On 02/05/2013 01:29 PM, Linus Walleij wrote: > On Tue, Feb 5, 2013 at 5:47 PM, Mark Brown > wrote: >> On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote: >> >>> For IRQ mode, use the completion callback to push each cookie >>> to NAPI, and thus let the IRQ drive the traffic. >> >> The w

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Tue, Feb 5, 2013 at 6:14 PM, Russell King - ARM Linux wrote: > On Tue, Feb 05, 2013 at 04:30:45PM +0100, Linus Walleij wrote: >> So put them on a wait list? Surely you will have a list of pending >> cookies and pick from the front of the queue if there isn't a hole on >> queue position 0. > >

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Tue, Feb 5, 2013 at 5:47 PM, Mark Brown wrote: > On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote: > >> For IRQ mode, use the completion callback to push each cookie >> to NAPI, and thus let the IRQ drive the traffic. > > The whole purpose of NAPI is to avoid taking interrupts for

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Tony Lindgren
* Felipe Balbi [130204 07:46]: > > Current DMA abstraction is quite poor, for example there's no way to > compile support for multiple DMA engines. Code also makes certain, IMO > unnecessary, assumptions about the underlying DMA engine (abstraction is > poor, as said above but it we could follow

Re: [PATCH V2 2/2] spi/bcm63xx: work around inability to keep CS up

2013-02-05 Thread Grant Likely
On Tue, 5 Feb 2013 16:00:04 +0100, Jonas Gorski wrote: > On Tue, 05 Feb 2013 14:35:30 + > Grant Likely wrote: > > > On Sun, 3 Feb 2013 15:15:13 +0100, Jonas Gorski wrote: > > > This SPI controller does not support keeping CS asserted after sending > > > a transfer. > > > Since messages exp

Re: [PATCH v2 2/2] spi: bitbang: convert to using core message queue

2013-02-05 Thread Grant Likely
On Thu, 10 Jan 2013 13:04:37 +0100 (CET), Guennadi Liakhovetski wrote: > On Thu, 10 Jan 2013, Linus Walleij wrote: > > > On Wed, Jan 9, 2013 at 3:44 PM, Guennadi Liakhovetski > > wrote: > > > > > [ 79.968000] mmc0: new SD card on SPI > > > [ 79.976000] mmcblk0: mmc0: SU02G 1.84 GiB > >

Re: Trying to use spidev to send an spi message, result from spidev_test.c "Illegal argument" . (i.mx23, kernel 3.7)

2013-02-05 Thread Grant Likely
On Sun, 30 Dec 2012 18:14:55 +0900, Juha Lumme wrote: > Hi, > > I am having issues communicating with a micro controller connected to > SPI bus, using spidev. > I would like to send messages to my MSP430 from user land, but so far no > luck. > > At least I know that my SPI bus should be ok, si

Re: [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message

2013-02-05 Thread Grant Likely
On Wed, 30 Jan 2013 21:33:30 +0100, John Crispin wrote: > Rather than calling m->complete() directly we choose the sane way and call > spi_finalize_current_message instead. > > Signed-off-by: Thomas Langer > Signed-off-by: John Crispin Applied, thanks. g. ---

Re: [PATCH RESEND] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc

2013-02-05 Thread Grant Likely
On Wed, 30 Jan 2013 13:15:24 +0100, Andreas Larsson wrote: > This makes the cpu mode of the driver available outside of an FSL SOC > and even powerpc environment. This is accomplished by putting things > regarding fsl specific code and to cpm specific code within ifdefs. > > Furthermore, this add

Re: [PATCH V2 0/2] spi/bcm63xx: fix multi transfer messages

2013-02-05 Thread Grant Likely
On Tue, 5 Feb 2013 15:04:41 +, Mark Brown wrote: > On Tue, Feb 05, 2013 at 02:30:40PM +, Grant Likely wrote: > > > Another option is to allow longer transfers if a GPIO is used for the CS > > line. A lot of SPI controllers need to do that. > > > That isn't a critique of this patch becau

Re: [PATCH] spi: davinci: use request_threaded_irq() to fix deadlock

2013-02-05 Thread Grant Likely
On Wed, 2 Jan 2013 10:19:08 -0500, Murali Karicheri wrote: > On 12/22/2012 05:08 AM, Grant Likely wrote: > > On Fri, 21 Dec 2012 15:13:26 -0500, Murali Karicheri > > wrote: > >> With RT pre-empt patch applied to Linux kernel, the irq handler will be > >> force converted to an irq thread. spi dri

Re: Fixing eSPI controller driver: some queries

2013-02-05 Thread Grant Likely
On Fri, 18 Jan 2013 10:03:28 +0100, Thomas De Schampheleire wrote: > Hi, > > The Freescale eSPI controller driver is broken in several ways. I already > attempted to fix this with a patch many months back. The patch works for > me, but never got feedback from the original author. > (see https://

Re: [PATCH 2/2] SPI: MIPS: lantiq: set SPI_MASTER_HALF_DUPLEX flag

2013-02-05 Thread Grant Likely
On Wed, 30 Jan 2013 21:33:31 +0100, John Crispin wrote: > Due to hardware limitations of the spi/flash frontend of the EBU we need to > set > the SPI_MASTER_HALF_DUPLEX flag. > > Signed-off-by: Thomas Langer > Signed-off-by: John Crispin Applied, thanks. g.

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 06:07:05PM +0100, Thomas Petazzoni wrote: > Of course, it doesn't make sense to have drivers for pluggable devices > like PCIe devices that are not soldered, USB devices and things like > that. But for all the rest, I would say it should be in the defconfig. hmmm, so for th

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 04:30:45PM +0100, Linus Walleij wrote: > On Mon, Feb 4, 2013 at 10:54 PM, Cyril Chemparathy wrote: > > On 02/04/2013 04:11 PM, Linus Walleij wrote: > > >> Cyril, just stack up the cookies and take a sweep over them to see > >> which ones are baked when the NAPI poll comes

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 04:47:05PM +, Mark Brown wrote: > On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote: > > > For IRQ mode, use the completion callback to push each cookie > > to NAPI, and thus let the IRQ drive the traffic. > > The whole purpose of NAPI is to avoid taking in

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Tue, 05 Feb 2013 17:20:02 +0100, Gregory CLEMENT wrote: > So that means we should enable the drivers for all the devices present > on all the boards? Yes. For example my mvsdio patch set enables some Wifi driver that corresponds to a particular SDIO Wifi device that is p

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Gregory CLEMENT
Hi Ezequiel, On 02/05/2013 12:24 PM, Ezequiel Garcia wrote: > This patch adds an SPI master device node for Armada XP-GP board. > This master node is an SPI flash controller 'n25q128a13'. > > Since there is no 'partitions' node declared, one full sized > partition named as the device will be crea

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 05:17:01PM +0100, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Tue, 5 Feb 2013 10:31:35 -0500, Jason Cooper wrote: > > > One thing we've been doing a lot of with mvebu is using it for > > build-testing. For that use case, since the bootloader is there, I'd > > reco

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Mon, Feb 4, 2013 at 11:30 PM, Cyril Chemparathy wrote: > NAPI needs to switch between polled and interrupt driven modes of operation. > Further, in a given poll, it needs to be able to limit the amount of traffic > processed to a specified budget. I don't think any of this is a problem. Poll

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Gregory CLEMENT
On 02/05/2013 05:17 PM, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Tue, 5 Feb 2013 10:31:35 -0500, Jason Cooper wrote: > >> One thing we've been doing a lot of with mvebu is using it for >> build-testing. For that use case, since the bootloader is there, I'd >> recommend setting it. Th

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Thomas Petazzoni
Dear Jason Cooper, On Tue, 5 Feb 2013 10:31:35 -0500, Jason Cooper wrote: > One thing we've been doing a lot of with mvebu is using it for > build-testing. For that use case, since the bootloader is there, I'd > recommend setting it. This will reduce the likelyhood of nasty build > breakages fu

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Cyril Chemparathy
On 02/05/2013 07:41 AM, Russell King - ARM Linux wrote: > On Mon, Feb 04, 2013 at 04:54:45PM -0500, Cyril Chemparathy wrote: >> You're assuming that cookies complete in order. That is not necessarily >> true. > > Under what circumstances is that not true? > Notably when hardware can prioritize ce

Re: [PATCH 2/2] ARM: mvebu: Update defconfig to select SPI support

2013-02-05 Thread Gregory CLEMENT
Hi Ezequiel, On 02/04/2013 05:38 PM, Ezequiel Garcia wrote: > Cc: Gregory Clement > Cc: Thomas Petazzoni > Cc: Lior Amsalem > Signed-off-by: Ezequiel Garcia > --- > arch/arm/configs/mvebu_defconfig |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/configs

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Cyril Chemparathy
On 02/05/2013 07:38 AM, Russell King - ARM Linux wrote: > On Mon, Feb 04, 2013 at 09:47:38PM +, Arnd Bergmann wrote: >> On Monday 04 February 2013, Linus Walleij wrote: >>> So I think the above concerns are moot. The callback we can >>> set on cookies is entirely optional, and it's even impleme

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 11:27:21AM -0300, Ezequiel Garcia wrote: > On Tue, Feb 05, 2013 at 07:48:33AM -0500, Jason Cooper wrote: > > Morning-ish Andrew, > > > > On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Mon, Feb 4, 2013 at 10:54 PM, Cyril Chemparathy wrote: > On 02/04/2013 04:11 PM, Linus Walleij wrote: >> Cyril, just stack up the cookies and take a sweep over them to see >> which ones are baked when the NAPI poll comes in -> problem >> solved. > > You're assuming that cookies complete in ord

Re: [PATCH V2 2/2] spi/bcm63xx: work around inability to keep CS up

2013-02-05 Thread Jonas Gorski
On Tue, 05 Feb 2013 14:35:30 + Grant Likely wrote: > On Sun, 3 Feb 2013 15:15:13 +0100, Jonas Gorski wrote: > > This SPI controller does not support keeping CS asserted after sending > > a transfer. > > Since messages expected on this SPI controller are rather short, we can > > work around

[PATCH V2] spi: Remove erroneous __init, __exit and __exit_p() references in drivers

2013-02-05 Thread Grant Likely
Some of the spi driver module remove hooks were annotated with __exit and referenced with __exit_p(). Presumably these were supposed to be __devinit, __devexit and __devexit_p() since __init/__exit for a probe/remove hook has never been correct. They also got missed during the big __devinit/__devex

Re: [PATCH] spi: orion: Use module_platform_driver()

2013-02-05 Thread Grant Likely
On Mon, 4 Feb 2013 09:26:26 -0300, Ezequiel Garcia wrote: > This patch reduces and simplifies initalization code by > using module_platform_driver(). > With this change it's necessary to remove the __init annotation > to avoid section mismatch warnings. > > Signed-off-by: Ezequiel Garcia Appl

Re: [PATCH V2 2/2] spi/bcm63xx: work around inability to keep CS up

2013-02-05 Thread Grant Likely
On Sun, 3 Feb 2013 15:15:13 +0100, Jonas Gorski wrote: > This SPI controller does not support keeping CS asserted after sending > a transfer. > Since messages expected on this SPI controller are rather short, we can > work around it for normal use cases by sending all transfers at once in > a big

Re: [PATCH V2 1/2] spi/bcm63xx: reject transfers unable to transfer

2013-02-05 Thread Grant Likely
On Sun, 3 Feb 2013 15:15:12 +0100, Jonas Gorski wrote: > The hardware does not support keeping CS asserted after sending one > FIFO buffer worth of data, so reject transfers requiring CS being kept > asserted, either between transers or for a certain time after it, > or exceeding the FIFO size. >

Re: [PATCH V2 0/2] spi/bcm63xx: fix multi transfer messages

2013-02-05 Thread Grant Likely
On Sun, 3 Feb 2013 15:15:11 +0100, Jonas Gorski wrote: > The bcm63xx SPI controller does not support keeping CS up after doing a > transfer. Since this is problematic for most typical use cases, this > patchset introduces a workaround by combining small enough messages > to one transfer, rejectin

Re: [PATCH RFC 1/1] gpio: mcp23s08: convert driver to DT

2013-02-05 Thread Grant Likely
On Thu, 31 Jan 2013 21:51:36 +0100, Linus Walleij wrote: > On Thu, Jan 31, 2013 at 4:58 PM, Lars Poeschel > wrote: > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt > > @@ -0,0 +1,27 @@ > > +Microchip MCP2308/MCP23S08/MCP23017/MCP23S17 driver for > > +8-/16

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Ezequiel Garcia
On Tue, Feb 05, 2013 at 07:48:33AM -0500, Jason Cooper wrote: > Morning-ish Andrew, > > On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y > > > > Maybe it makes sense to provide a patch to mvebu_defconfig to ad

Re: [PATCH 3/5] serial: pl011: use generic DMA slave configuration if possible

2013-02-05 Thread Grant Likely
On Mon, 28 Jan 2013 17:57:35 +, Arnd Bergmann wrote: > With the new OF DMA binding, it is possible to completely avoid the > need for platform_data for configuring a DMA channel. In cases where the > platform has already been converted, calling dma_request_slave_channel > should get all the ne

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-05 Thread Grant Likely
On Mon, 28 Jan 2013 17:57:34 +, Arnd Bergmann wrote: > With the new OF DMA binding, it is possible to completely avoid the > need for platform_data for configuring a DMA channel. In cases where the > platform has already been converted, calling dma_request_slave_channel > should get all the ne

Re: [PATCH] spi: Ensure memory used for spi_write_then_read() is DMA safe

2013-02-05 Thread Grant Likely
On Sun, 27 Jan 2013 14:35:04 +0800, Mark Brown wrote: > Use GFP_DMA in order to ensure that the memory we allocate for transfers > in spi_write_then_read() can be DMAed. On most platforms this will have > no effect. > > Signed-off-by: Mark Brown Applied, thanks. g. > --- > drivers/spi/spi.c

Re: [PATCH 25/33] spi: Convert to devm_ioremap_resource()

2013-02-05 Thread Grant Likely
On Mon, 21 Jan 2013 11:09:18 +0100, Thierry Reding wrote: > Convert all uses of devm_request_and_ioremap() to the newly introduced > devm_ioremap_resource() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages so all explicit > error messages

Re: [PATCH 2/2] spi: spi-mpc512x-psc: add support for gpio chip selects

2013-02-05 Thread Grant Likely
On Mon, 14 Jan 2013 21:27:01 +0100, Anatolij Gustschin wrote: > Currently the driver only uses one internal chip select. Add support > for gpio chip selects configured by gpio specifiers in the device tree. > > Signed-off-by: Anatolij Gustschin GPIO chip selects are now in the core spi library.

Re: [PATCH 1/2] spi: spi-mpc512x-psc: init mode bits supported by the driver

2013-02-05 Thread Grant Likely
On Mon, 14 Jan 2013 21:27:00 +0100, Anatolij Gustschin wrote: > The driver should setup mode bits it supports, otherwise > adding an SPI device might fail even if the driver supports > the requested SPI mode. > > Signed-off-by: Anatolij Gustschin Applied, thanks. g. > --- > drivers/spi/spi-m

Re: [PATCH v2] spi: spi-mpc512x-psc: don't use obsolet cell-index property

2013-02-05 Thread Grant Likely
On Fri, 11 Jan 2013 01:05:48 +0100, Anatolij Gustschin wrote: > Remove deprecated cell-index property and use spi alias to > obtain the SPI PSC number used for SPI bus id. > > Signed-off-by: Anatolij Gustschin > --- > v2: > - use of_alias_get_id() to get spi bus number > Applied, thanks. g.

Re: [PATCH 1/3] spi: Add helper functions for setting up transfers

2013-02-05 Thread Grant Likely
On Sun, 27 Jan 2013 03:33:59 +, Mark Brown wrote: > On Wed, Jan 09, 2013 at 06:31:09PM +0100, Lars-Peter Clausen wrote: > > > The second function spi_sync_transfer() takes a SPI device and an array of > > spi_transfers. It will allocate a new spi_message (on the stack) and add all > > transf

[PATCH] spi: Remove erroneous __exit and __exit_p() references in drivers

2013-02-05 Thread Grant Likely
Some of the spi driver module remove hooks were annotated with __exit and referenced with __exit_p(). Presumably these were supposed to be __devexit and __devexit_p() since __exit for a remove hook has never been correct. They also got missed during the big __devexit purge since they didn't match t

Re: [PATCH 1/2] ARM: mvebu: Add support for SPI controller in Armada 370/XP

2013-02-05 Thread Gregory CLEMENT
Hi Ezequiel, On 02/04/2013 05:38 PM, Ezequiel Garcia wrote: > The Armada 370 and Armada XP SoC has an SPI controller. > This patch adds support for this controller in Armada 370 > and Armada XP SoC common device tree files. > > Cc: Gregory Clement > Cc: Thomas Petazzoni > Cc: Lior Amsalem > Si

Re: [PATCH] driver-core: constify data for class_find_device()

2013-02-05 Thread Grant Likely
On Fri, 1 Feb 2013 20:40:17 +0100 (CET), Michał Mirosław wrote: > All in-kernel users of class_find_device() don't really need mutable > data for match callback. > > In two places (kernel/power/suspend_test.c, drivers/scsi/osd/osd_uld.c) > this patch changes match callbacks to use const searc

Re: [PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-02-05 Thread Grant Likely
On Fri, 25 Jan 2013 14:14:31 +, Arnd Bergmann wrote: > Since we no longer allow building without hotplug, the > atmel_spi_remove function is always present and we should > not use __exit_p() to refer to it. > > Without this patch, building at91_dt_defconfig results in: > > drivers/spi/spi-at

Re: [PATCH] spi: s3c64xx: fix checkpatch warnings and error

2013-02-05 Thread Grant Likely
On Thu, 31 Jan 2013 15:25:01 +0900, Jingoo Han wrote: > Fix checkpatch warnings and error as below: > ERROR: "foo * bar" should be "foo *bar" > WARNING: please, no space before tabs > WARNING: quoted string split across lines > WARNING: msleep < 20ms can sleep for up to 20ms; see > Docume

Re: [PATCH v2] spi: s3c64xx: Use devm_clk_get() and devm_request_irq()

2013-02-05 Thread Grant Likely
On Thu, 10 Jan 2013 11:04:21 +0900, Jingoo Han wrote: > Use devm_clk_get() and devm_request_irq() rather than clk_get() and > request_irq() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han Applied, thanks. g. ---

Re: [PATCH] spi: spi-imx: Add MODULE_ALIAS()

2013-02-05 Thread Grant Likely
On Mon, 7 Jan 2013 20:42:55 -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Add an entry for MODULE_ALIAS(). > > Signed-off-by: Fabio Estevam Applied, thanks. g. > --- > drivers/spi/spi-imx.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-imx.c b/driver

Re: [PATCH 2/2] spi: tegra: remove checks for valid speed

2013-02-05 Thread Grant Likely
On Sat, 5 Jan 2013 00:17:15 +0530, Laxman Dewangan wrote: > SPI core make sure that all transfer has proper speed set > before calling low level spi transfer. Hence, it is not > require to have check in spi driver. > > Remove the check for speed validity from transfer and use it directly. > > Si

Re: [PATCH 1/2] spi: make sure all transfer has proper speed set

2013-02-05 Thread Grant Likely
On Sat, 5 Jan 2013 00:17:14 +0530, Laxman Dewangan wrote: > When spi client does the spi transfer and if it does not set > the speed for each transfer then set it as default > of spi device in spi core before calling low level transfer. > > This will remove the extra check in low level driver for

Re: [PATCH 1/2] spi: spi-gpio: Add checks for the dt properties

2013-02-05 Thread Grant Likely
On Tue, 22 Jan 2013 16:50:30 +0100, Maxime Ripard wrote: > On 09/01/2013 09:37, Maxime Ripard wrote: > > On 27/12/2012 22:54, Maxime Ripard wrote: > >> The bindings assumed that the gpios properties were always there, which > >> made the NO_TX and NO_RX mode not usable from device tree. Add extra

Re: [PATCH 6/6] spi/ath79: add shutdown handler

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:29 +0100, Gabor Juhos wrote: > The SPI controller of the AR7xxx/AR9xxx SoCs > have a special mode which allows the SoC to > directly read data from SPI flash chips. In > this mode, the content of the SPI flash chip > can be accessed via a memory mapped region. > > During

Re: [PATCH 5/6] spi/ath79: avoid multiple initialization of the SPI controller

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:28 +0100, Gabor Juhos wrote: > Currently we are initializing the SPI controller in > the chip select line function, and that function is > called once for each SPI device on the bus. If a > board has multiple SPI devices, the controller will > be initialized multiple time

Re: [PATCH 4/6] spi/ath79: use gpio_request_one

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:27 +0100, Gabor Juhos wrote: > Use gpio_request_one() instead of multiple gpiolib calls. > > Signed-off-by: Gabor Juhos Applied, thanks. g. > --- > drivers/spi/spi-ath79.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff -

Re: [PATCH 3/6] spi/ath79: remove superfluous chip select code

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:26 +0100, Gabor Juhos wrote: > The spi_bitbang driver calls the chipselect function > of the driver from spi_bitbang_setup in order to > deselect the given SPI chip, so we don't have to > initialize the CS line here. > > Signed-off-by: Gabor Juhos Applied, thanks. g.

Re: [PATCH 2/6] spi/ath79: add missing HIGH->LOW SCK transition

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:25 +0100, Gabor Juhos wrote: > The 'ath79_spi_txrx_mode0' function does not > set the SCK signal to LOW at the end of a word > transfer. This causes communications errors with > certain devices (e.g. the PCF2123 RTC chip). > > The patch ensures that the SCK signal will b

Re: [PATCH 1/6] spi/ath79: add delay between SCK changes

2013-02-05 Thread Grant Likely
On Thu, 27 Dec 2012 10:42:24 +0100, Gabor Juhos wrote: > The driver uses the "as fast as it can" approach > to drive the SCK signal. However this does not > work with certain low speed SPI chips (e.g. the > PCF2123 RTC chip). > > The patch adds per-bit slowdowns in order to be > able to use the d

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
Morning-ish Andrew, On Tue, Feb 05, 2013 at 01:38:27PM +0100, Andrew Lunn wrote: > > And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y > > Maybe it makes sense to provide a patch to mvebu_defconfig to add > CONFIG_MTD_M25P80=y ? I thought this as well, then reconsidered when

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 04:54:45PM -0500, Cyril Chemparathy wrote: > You're assuming that cookies complete in order. That is not necessarily > true. Under what circumstances is that not true? -- Free Next-Gen Firewall

Re: [PATCH V2] mxs: spi: clear XFER_COUNT in ctrl0 field in DMA descriptor

2013-02-05 Thread Grant Likely
On Wed, 26 Dec 2012 14:48:51 +0900, Juha Lumme wrote: > On MX23 the XFER_COUNT part in ctrl0 field in DMA descriptor was improperly > OR'd during the construction of DMA descriptor chain, instead of being > freshly set. > Because of that too many bytes were being expected from SPI during the last

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 09:47:38PM +, Arnd Bergmann wrote: > On Monday 04 February 2013, Linus Walleij wrote: > > So I think the above concerns are moot. The callback we can > > set on cookies is entirely optional, and it's even implemented by > > each DMA engine, and some may not even support

Re: [PATCH 1/2] spi: sirf: use clk_prepare_enable and clk_disable_unprepare

2013-02-05 Thread Grant Likely
On Wed, 26 Dec 2012 10:48:33 +0800, Barry Song wrote: > From: Barry Song > > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. > > Signed-off-by: Barry Song Applied, thanks. g. > --- > drivers/spi/spi-sirf.c |6 +++

Re: [PATCH 2/2] spi: sirf: add support for new SiRFmarco SMP SoC

2013-02-05 Thread Grant Likely
On Wed, 26 Dec 2012 10:48:34 +0800, Barry Song wrote: > From: Barry Song > > the driver is also compatible with SiRFmarco except SiRFprimaII, > so simply add "sirf,marco-spi" to OF match table. > > Signed-off-by: Barry Song Applied, thanks. g. > --- > drivers/spi/spi-sirf.c |1 + > 1 f

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Andrew Lunn
> And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y Hi Ezequiel Maybe it makes sense to provide a patch to mvebu_defconfig to add CONFIG_MTD_M25P80=y ? Andrew -- Free Next-Gen Firewall Hardw

Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Jason Cooper
On Tue, Feb 05, 2013 at 08:24:33AM -0300, Ezequiel Garcia wrote: > This patch adds an SPI master device node for Armada XP-GP board. > This master node is an SPI flash controller 'n25q128a13'. > > Since there is no 'partitions' node declared, one full sized > partition named as the device will be

[PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Ezequiel Garcia
This patch adds an SPI master device node for Armada XP-GP board. This master node is an SPI flash controller 'n25q128a13'. Since there is no 'partitions' node declared, one full sized partition named as the device will be created. Cc: Gregory Clement Cc: Thomas Petazzoni Cc: Lior Amsalem Sign