[PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Mark Brown
The following changes since commit 805a6af8dba5dfdd35ec35dc52ec0122400b2610: Linux 3.2 (2012-01-04 15:55:44 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git spi/s3c64xx They've all been posted several times before but seem to have

[PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
Although the hardware supports interrupts we're not currently using them at all since for small transfers the overhead is greater than that for busy waiting and for large transfers we have interrupts from the DMA. This means that if the hardware reports an error (especially one which might not stal

[PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Mark Brown
Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when the device is idle. Signed-off-by: Mark Brown Acked-by: Linus Walleij Acked-by: Heiko Stuebner --- drivers/spi/spi-s3c64xx.c

[PATCH 2/3] spi/s3c64xx: Convert to dev_pm_ops

2012-01-21 Thread Mark Brown
In preparation for the addition of runtime PM ops. Signed-off-by: Mark Brown --- drivers/spi/spi-s3c64xx.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index d56066b..56dbdf1 100644 --- a/drivers

Re: [PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Bill Gatliff
Guys: On Sat, Jan 21, 2012 at 2:24 PM, Mark Brown wrote: > Enable and disable the clocks to the SPI controller using runtime PM. This > serves the dual purpose of reducing power consumption a little and letting > the core know when the device is idle. What about using autosuspend instead? If a

Re: [PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 02:41:59PM +0100, Bill Gatliff wrote: > What about using autosuspend instead? If a client is doing a lot of > closely-spaced SPI transactions on a relatively flat device tree, > might the resulting runtime suspend/resume overhead between each > transaction become noticeabl

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Grant Likely
On Sat, Jan 21, 2012 at 6:23 AM, Mark Brown wrote: > The following changes since commit 805a6af8dba5dfdd35ec35dc52ec0122400b2610: > >  Linux 3.2 (2012-01-04 15:55:44 -0800) > > are available in the git repository at: >  git://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git spi/s3c64xx Pu

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 07:27:23AM -0700, Grant Likely wrote: > Pushed out to git://git.secretlab.ca/git/linux-2.6.git spi/merge. > I'll ask Linus to pull in a couple of days after it has hit > linux-next. Thanks. Obviously it'd be nice to get it into 3.3 but I don't see a huge rush and it did m

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:24 PM, Mark Brown wrote: > Although the hardware supports interrupts we're not currently using them > at all since for small transfers the overhead is greater than that for > busy waiting and for large transfers we have interrupts from the DMA. > This means that if the hardware rep

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: > On 01/21/2012 02:24 PM, Mark Brown wrote: > > - int ret; > > + int ret, irq; > > + char clk_name[16]; > clk_name seems to be unused, otherwise looks good. That's git cherry-pick being too clever for me when I pulled this

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 04:29 PM, Mark Brown wrote: > On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: >> On 01/21/2012 02:24 PM, Mark Brown wrote: > >>> - int ret; >>> + int ret, irq; >>> + char clk_name[16]; > >> clk_name seems to be unused, otherwise looks good. > > That's git