M DDI 0194G).
Signed-off-by: Linus Walleij
---
arch/arm/boot/dts/ste-u300.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ste-u300.dts b/arch/arm/boot/dts/ste-u300.dts
index a9da4800daf0..6fe688e9e4da 100644
--- a/arch/arm/boot/dts/ste-u300.dts
+++ b/arch/arm
M DDI 0194G).
Signed-off-by: Linus Walleij
---
arch/arm/boot/dts/ste-dbx5x0.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi
b/arch/arm/boot/dts/ste-dbx5x0.dtsi
index e0853ea02df2..e41eedca3ce3 100644
--- a/arch/arm/boot/dt
;
> int spi_unprepare_message(struct_spi_dev*, struct spi_message *);
Maybe? I cannot tell from the above how this would look so
I think it is better if you send a patch showing how this improves
efficiency.
Yours,
Linus Walleij
From: Linus Walleij
This registers the PL022 PrimeCell from the U300 device
tree. We make a new copy of the platform data for the
device tree boot path, as the old platform data is in an
older file which will be going away.
Signed-off-by: Linus Walleij
---
arch/arm/boot/dts/ste-u300.dts | 7
From: Linus Walleij
This probes the U300 dummy-spichip from the device tree
and adds the apropriate node to the tree.
Signed-off-by: Linus Walleij
---
arch/arm/boot/dts/ste-u300.dts| 5 +
arch/arm/mach-u300/dummyspichip.c | 6 ++
2 files changed, 11 insertions(+)
diff --git a
x27;ll be picked up.
Yours,
Linus Walleij
--
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal tools
same chipselect.
>
> Signed-off-by: Lars Poeschel
> ---
> v4:
> - removed the ability to specify the pullup from device tree
> - updated binding doc
Patch applied!
Thanks,
Linus Walleij
--
Precog is a
= "mcp23s08",
> .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(mcp23s08_spi_of_match),
Will this compile if CONFIG_OF is not enabled?
Yours,
Linus Walleij
--
Mi
On Wed, Mar 27, 2013 at 12:35 PM, Lars Poeschel wrote:
> On Friday 22 March 2013 at 09:33:10, Linus Walleij wrote:
>> I would currently feel a lot better if you did not include this
>> flag. How would you control this the day drivers need to
>> enable/disable pull-up at r
s08_set_pullup(struct mcp23s08 *mcp, unsigned offset)
> +{
> + int status;
> + u16 value;
> +
> + mutex_lock(&mcp->lock);
> + value = mcp->cache[MCP_GPPU] | (1 << offset);
> + status = mcp->ops->write(mcp, MCP_GPPU, value);
On Wed, Mar 6, 2013 at 12:42 PM, Thomas Abraham
wrote:
> With device core now able to setup the default pin configuration,
> the pin configuration code based on the deprecated Samsung specific
> gpio bindings is removed.
>
> Signed-off-by: Thomas Abraham
Acked-by: Linus Walleij
On Thu, Feb 14, 2013 at 1:22 PM, Lars Poeschel wrote:
> On Wednesday 13 February 2013 at 13:51:12, Linus Walleij wrote:
>> Have you considered this [pinctrl] approach?
>
> No, I haven't. And although this doesn't solve all my problems, I like the
> idea very much! Th
s.
If you look in drivers/pinctrl/pinctrl-abx500.c which is my
latest submitted pinctrl driver you can see that this is basically
a quite simple GPIO chip, we just model it as a pin controller
with a GPIO front-end too exactly because it can do things
like multiplexing, pull-up and pull-down.
Have y
to get
something out you need to put something in. So when reading,
this is a way to feed in some junk.
So this goes on my TODO...
Yours,
Linus Walleij
--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen
On Thu, Feb 7, 2013 at 8:42 PM, Arnd Bergmann wrote:
> On Thursday 07 February 2013, Linus Walleij wrote:
>> Actually I once read about a feature where the kernel provides
>> a static page full of zeroes or something like this, that would be
>> ideal to use in cases like t
then all of this dummy page
allocation and freeing can be deleted.
Yours,
Linus Walleij
--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and
get all the necessary information from the device tree.
>
> Like the patch that converts the dw_dma controller, this is completely
> untested and is looking for someone to try it out.
>
> Signed-off-by: Arnd Bergmann
This looks correct to me atleast:
Acked-by: Linus Wal
each instance.
And luckily the base is zero. Not elegant maybe, but the
global GPIO numberspace is not elegant by nature.
Yours,
Linus Walleij
--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before
On Tue, Feb 5, 2013 at 6:14 PM, Russell King - ARM Linux
wrote:
> On Tue, Feb 05, 2013 at 04:30:45PM +0100, Linus Walleij wrote:
>> So put them on a wait list? Surely you will have a list of pending
>> cookies and pick from the front of the queue if there isn't a hole on
On Tue, Feb 5, 2013 at 5:47 PM, Mark Brown
wrote:
> On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote:
>
>> For IRQ mode, use the completion callback to push each cookie
>> to NAPI, and thus let the IRQ drive the traffic.
>
> The whole purpose of NAPI is to avo
1_dma_rx_trigger_dma(),
then either pl011_dma_rx_callback() gets called if the DMA
transfer completes, or we get an IRQ (like a timeout) and
endup in pl011_dma_rx_irq(), where the transfer is stopped,
buffer emtied and then we can decide what to do next.
This could just as well
On Mon, Feb 4, 2013 at 10:54 PM, Cyril Chemparathy wrote:
> On 02/04/2013 04:11 PM, Linus Walleij wrote:
>> Cyril, just stack up the cookies and take a sweep over them to see
>> which ones are baked when the NAPI poll comes in -> problem
>> solved.
>
> You'r
On Mon, Feb 4, 2013 at 9:33 PM, Mark Brown
wrote:
> On Mon, Feb 04, 2013 at 09:29:46PM +0100, Linus Walleij wrote:
>> On Mon, Feb 4, 2013 at 8:22 PM, Cyril Chemparathy wrote:
>
>> > Based on our experience with fitting multiple subsystems on top of this
>> > DMA-
ng is similar.
Surely the way to look up resources cannot be paramount in this
discussion, I think the real problem must be your specific networking
usecase, so we need to drill into that.
Yours,
Linus Walleij
--
Every
nce v1:
> - Handle error return values from calls to of_gpio_count
Looks correct to me, but I'm no DT-ninja.
For the GPIO portions:
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
Everyone hates slow websites. S
tie the global GPIO numbers into the device tree.
In the DT GPIOs are referenced by ampersand <&gpio0 1 2>
notation referring to the instance, so as you realize DT itself
has no need for that number.
Further it is not OS-neutral.
You have to find another way to h
oesn't appear before the patch?
Yours,
Linus Walleij
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevN
On Wed, Jan 9, 2013 at 3:08 PM, Guennadi Liakhovetski
wrote:
> Add a pointer variable to make spi_bitbang_start() look simpler.
>
> Signed-off-by: Guennadi Liakhovetski
Acked-by: Linus Walleij
I think Mark Brown is still backing up Grant sometimes, so include
him on CC.
Yours,
Linu
common core for dw IP and SSP IP (i think pxa uses same stuff). That way lot
> of
> code will get reduced from driver
+1 on this comment, I didn't even notice :-(
Linus Walleij
--
Master Visual Studio, Shar
hat I have no real way of testing this. But if I break something
I guess people will notice :-D
Yours,
Linus Walleij
--
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills
ET_A_WORD 3
>> > +#define DFLT_TIMEOUT_VAL 500
>>
>> milliseconds?
>
> It depends on peripheral clock frequency.
So then write in a comment that it's the number of clock cycles
or something?
>> > +#define SRAM_BASE_ADDR 0xfffdc000
>>
>> Should b
t;
> + u32 direction;
> +};
> +
Convert the inline documentation below to use kerneldoc.
> +struct ssp_driver_context {
> + /* Driver model hookup */
> + struct pci_dev *pdev;
> +
> + /* SPI framework hookup */
> + struct spi_master *maste
considered trying to also generalize parts of the transfer
handling but ran out of energy.
Yours,
Linus Walleij
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provid
Yes it seems like it will do the job.
Ulf can you comment on this...
Yours,
Linus Walleij
--
WINDOWS 8 is here.
Millions of people. Your app in 30 days.
Visit The Windows 8 Center at So
thanks.
So it probably wasn't and it's just some mishap so
that 2,3,4 /4 were applied while 1/4 was actually needed
to.
Yours,
Linus Walleij
--
Everyone hates slow websites. So do we.
Make your web app
From: Ulf Hansson
In probe pm_runtime_put_autosuspend has the same effect as doing
pm_runtime_put.
Signed-off-by: Ulf Hansson
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers
rom being runtime suspended by a pm_runtime_get*". This was
> the case earlier.
OK I'll update the commit message and respin this one *only*
as [PATCH 2/4 v2] hold on...
Yours,
Linus Walleij
--
Everyone hates
from PM_RUNTIME callbacks or not.
Signed-off-by: Patrice Chotard
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 44 +++-
1 file changed, 31 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 51
: Ulf Hansson
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 51b7a95..51329b2 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2346,6 +2346,8 @@ static int
From: Ulf Hansson
In probe pm_runtime_put_autosuspend has the same effect as doing
pm_runtime_put. This due to upper layer in driver core is preventing
the device from being runtime suspended by a pm_runtime_get*.
Signed-off-by: Ulf Hansson
Signed-off-by: Linus Walleij
---
drivers/spi/spi
From: Ulf Hansson
This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99.
This patch is reverted due to wrong runtime PM code.
Conflicts:
drivers/spi/spi-pl022.c
Signed-off-by: Ulf Hansson
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 4
1 file changed, 4
Hi Mark, it turns out the reason that the IDLE state patch did
not apply was due to this dependency chain, all tested by me.
So I signed them all off and rebased on top of spi-next, hope
this works out.
Patrice Chotard (1):
spi/pl022: add IDLE state pin management
Ulf Hansson (3):
Revert "spi
On Wed, Oct 17, 2012 at 9:24 AM, Mark Brown
wrote:
> On Thu, Oct 11, 2012 at 02:03:51PM +0200, Linus Walleij wrote:
>> From: Patrice Chotard
>>
>> This commit allow to put pins in IDLE state in
>> runtime_suspend and in SLEEP state in suspend, corresponding
>>
from PM_RUNTIME callbacks or not.
Signed-off-by: Patrice Chotard
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 44 +++-
1 file changed, 31 insertions(+), 13 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 51
tches and updated commit messages.
>
> Ulf Hansson (3):
> Revert "spi/pl022: fix spi-pl022 pm enable at probe"
> Revert "spi/pl022: enable runtime PM"
> spi: spi-pl022: Minor simplification for runtime pm
I think patch 1/3 and 2/3 needs to go into the -rc fix
by a pm_runtime_get*.
>>
>> Signed-off-by: Ulf Hansson
>> Reviewed-by: Linus Walleij
>> ---
>> drivers/spi/spi-pl022.c |5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl02
t;
> Signed-off-by: Ulf Hansson
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://a
On Fri, Sep 28, 2012 at 1:21 PM, Ulf Hansson wrote:
> From: Ulf Hansson
>
> This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99.
>
> Signed-off-by: Ulf Hansson
Reviewed-by: Linus Walleij
Thanks for fixing my stupid mistakes ..
On Sun, Sep 30, 2012 at 12:14 PM, Russell King - ARM Linux
wrote:
> The real answer is to revert both commits to get the driver back to a
> sane state, before then progressing with the driver in a sane manner.
> This is what Ulf is doing.
Aha, mea culpa.
Acked-by: Linus Walleij
F
Signed-off-by: Linus Walleij
Signed-off-by: Mark Brown
Yours,
Linus Walleij
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.
urn 0;
}
Yours,
Linus Walleij
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://ad.doubleclick.net/clk;258768047;13503038;j?
http://info.
reference
counter to 0, runtime resume having previously increased it
to 1.
Cc: Vipul Kumar Samar
Cc: Viresh Kumar
Acked-by: Ulf Hansson
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Add more #ifdef for the case where we have neither normal
PM nor runtime PM.
---
drivers/spi/spi-pl02
On Wed, Sep 26, 2012 at 5:23 PM, Ulf Hansson wrote:
> You will have compile warnings when not having CONFIG_SUSPEND and
> CONFIG_RUNTIME_PM, due to unused code/functions.
Argh the evil #fidefs... I'll put in even more of them then.
> Otherwise you have my ack.
Thanks!
Yours,
reference
counter to 0, runtime resume having previously increased it
to 1.
Cc: Ulf Hansson
Cc: Vipul Kumar Samar
Cc: Viresh Kumar
Signed-off-by: Linus Walleij
---
Vipin: can you confirm that this approach works for your
case with only suspend/resume but no runtime PM?
Question: can I be sure that
This switches the PL022 SPI driver to use devm_* managed resources
for IRQ, clocks, ioremap and GPIO. Prior to this, the GPIOs would
even leak.
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff
On Wed, Sep 26, 2012 at 4:08 PM, viresh kumar wrote:
> On Wed, Sep 26, 2012 at 5:49 PM, Mark Brown
> wrote:
>> On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote:
>>> On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar
>>
>>> > SPI functional cl
On Wed, Sep 26, 2012 at 2:19 PM, Mark Brown
wrote:
> On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote:
>> On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar
>
>> > SPI functional clock must be disalble/enable in non RTPM suspend/resume
>> > hooks. Curr
den by e.g. voltage domains. In this case we (ux500)
have choosen to call out to the AMBA level to make sure
semantics are preserved.
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cove
that there is not a race between runtime
suspend/resume and ordinary suspend/resume.
I don't like it since it actually turns things upside-down
completely, during ordinary suspend the device is
"runtime resumed" for example.
Rafael, Magnus: help.
Yours,
Linus Walleij
-
On Wed, Sep 19, 2012 at 5:31 AM, viresh kumar wrote:
> On Tue, Sep 18, 2012 at 5:20 PM, Linus Walleij
> wrote:
>> On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar
>> wrote:
>
>>> The amba layer is taking care of interface clock only and not
>>> functional
PC32xx: does not appear to be using pinctrl.
- ARM Integrator IMPD1, RealView & Versatile: does not use pinctrl.
Cc: Pawel Moll
Cc: Roland Stigge
Cc: Shiraz Hashim
Cc: Mark Brown
Cc: Vinit Kamalaksha Shenoy
Cc: Viresh Kumar
Signed-off-by: Patrice Chotard
Signed-off-by: Linus Walle
ady have pinmuxes configured
> before the drivers probe.
>
> Signed-off-by: Matt Porter
Looks like a good idea, so FWIW:
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclu
On Mon, Sep 17, 2012 at 7:03 PM, Roland Stigge wrote:
> On 09/10/2012 01:11 PM, Linus Walleij wrote:
>>
>> It appears Roland has written his bindings such that DT
>> data augments platform data (yes, I am also getting crazy
>> about this prioritization, mea culpa for AC
. :)
This clock is the one for the external bus. In some designs these two
clocks are one and the same, and these won't currently get into any clock
disabled states, sadly. (We need to fix that some day.)
Yours,
Linus Walleij
emoved, so I guess what you're trying to say is that
on your platform the clk_unprepare() process context call
is needed to save power?
Please elaborate...
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exc
On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack wrote:
> On 05.08.2012 21:12, Linus Walleij wrote:
>> On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack wrote:
>>
>>>> Acked-by: Linus Walleij
>>>
>>> Ok, thanks. Mark, did the patches reach you this time?
d) but to a multiple of bytes after it because of the (int *) type.
>
> Replacing the kludgy pointer arithmetic with managed memory allocation for the
> chip selects.
>
> Signed-off-by: Roland Stigge
Reviewed-by: Linus Walleij
Thanks for fixing this! And thanks to Shiraz for spot
gt; but infact 4 times the size of pl022 (because type of pl022 is now int *).
>
> Do you get my point ? This would go way beyond memory allocated
> for chipselects.
Yes of course ... how could I not see this. Sorry!
Yours,
Linus Walleij
---
tform_info->num_chipselect);
separately.
(But I'm happy with the patch as it is. And the other way
too, since I'm not very picky.)
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live even
On Wed, Aug 22, 2012 at 3:49 PM, Roland Stigge wrote:
> This patch adds device tree support to the spi-pl022 driver.
>
> Based on the initial patch by Alexandre Pereira da Silva
>
>
> Signed-off-by: Roland Stigge
> Acked-by: Alexandre Pereira da Silva
Reviewed-by:
On Wed, Aug 22, 2012 at 3:49 PM, Roland Stigge wrote:
> Several SPI controller drivers have defined differently named properties for
> the number of chip selects. Now adding "num-cs" as a reference name for new
> bindings.
>
> Signed-off-by: Roland Stigge
Reviewed-
> Based on the initial patch by Alexandre Pereira da Silva
>
>
> Signed-off-by: Roland Stigge
> Acked-by: Alexandre Pereira da Silva
Thanks Roland, excellent work!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
this is a generic property on all GPIO drivers.
The rest looks good.
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has
gt;chipselect = (int *)&master[1];
That last thing looks pretty awkward, atleast a comment
explaining what is going on is necessary. I would have done
it like this:
/* Point chipselects to allocated memory beyond the main struct */
pl022->chipselects = (int *) pl022 + sizeof(struct pl022);
May
On Wed, Aug 22, 2012 at 11:16 AM, Viresh Kumar wrote:
> On 19 August 2012 03:56, Linus Walleij wrote:
>> On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar
>> Isn't this one of those things that *have* to be #ifdef CONFIG_OF?
>>
>> Next iteration, remember to ad
e they should be removed if the spi
> framework doesn't have support in a standard way.
Uncertain about this, others would need to comment.
At some point there has been a chip needing these to be set
to some magic values.
Yours,
Linus Walleij
-
] = cs_gpio;
> +
> + if (gpio_is_valid(cs_gpio)) {
> + if (gpio_request(cs_gpio, "ssp-pl022"))
> + dev_err(&adev->dev,
> + "
ecause je's taking
care of SPI patches for the moment.
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed an
From: Michel JAOUEN
amba drivers does not need to enable pm runtime at probe.
amba_probe already enables pm runtime.
This rids this warning in the ux500 boot log:
ssp-pl022 ssp0: Unbalanced pm_runtime_enable!
Signed-off-by: Michel JAOUEN
Signed-off-by: Linus Walleij
---
drivers/spi/spi
On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack wrote:
>> Acked-by: Linus Walleij
>
> Ok, thanks. Mark, did the patches reach you this time? I think they
> should go thru the SPI tree.
Yeah no problem, Mark is always faster than me ...
Yours
On Wed, Aug 1, 2012 at 10:57 PM, Daniel Mack wrote:
> This patch adds DT bindings to the spi-gpio driver and some
> documentation about how to use it.
>
> Signed-off-by: Daniel Mack
> Cc: Mark Brown
> Cc: Grant Likely
> Cc: Linus Walleij
>From a GPIO point of vi
Hi Mark,
Can you please pull in these PL022 patches to your spi-next tree?
Yours,
Linus Walleij
-- Forwarded message --
From: Linus Walleij
Date: Thu, Jul 5, 2012 at 4:27 PM
Subject: [GIT PULL] PL022 patches for v3.6
To: Wolfram Sang
Cc: spi mailing list ,
Alexandre Pereira
x27;s also possible that I just miss why the
>> > active chip select is important. For the devices I have it doesn't seem
>> > to make a difference.
>> ping
>
> You probably want to resend this with Linus W in the CCs.
It all makes sense to me so:
+0200)
Alexandre Pereira da Silva (1):
spi/pl022: cleanup pl022 header documentation
Linus Walleij (2):
spi/pl022: delete DB5500 support
spi/pl022: enable runtime PM
Virupax Sadashivpetimath (1):
spi/pl022: disable port when unused
drivers/spi/spi-pl022.c|
.
>
> Signed-off-by: Mark Brown
Much clearer.
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape h
On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown
wrote:
> Saves some error handling and a small amount of code.
>
> Signed-off-by: Mark Brown
Elegant, monsieur.
Acked-by: Linus Walleij
I'm starting to wonder if it would not be possible to mass-convert these
using coccinelle.
Yours,
lock before making the call.
> Rework the logic a bit to hold queue_lock to protect the 'busy' flag,
> then release it to call unprepare_transfer_hardware().
>
> Signed-off-by: Bryan Freed
Yes, this looks correct to me! Good catch.
Ac
ile) or just to add
> a comment. I will let others comment on that. :)
The message pump initially used a workqueue, but was converted
to a kthread because we needed to push the queue to run as
realtime for some important low-latency workloads across
SPI. The code is basically a tweaked workqueue
ned-off-by: Roland Stigge
Acked-by: Linus Walleij
> Should this patch be joined with gpiolib-of's patch to of_get_named_gpio()? Or
> should they just be issued as a series?
If it's not bisectable unless you change this in the same patch then join
them. Else I'd put them i
igge
Reviewed-by: Linus Walleij
Thanks for fixing this!
Grant, will you please pick this to the SPI tree.
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today'
cross transfers found in jornada720_ssp is probably
not going to play well with the SPI subsystem so this has
been replaced by a mutex.
Cc: Kristoffer Ericson
Cc: Nicolas Pitre
Cc: Russell King
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Rebase to v3.5-rc1
- Move SA1100 SSP platfor
From: Linus Walleij
If we're gonna use runtime PM it's a pretty good idea to actually
enable it in probe() and disable it in remove() too, so it
gets used for real. Up until now we only fooled around with the
reference count.
Cc: Vinit Shenoy
Signed-off-by: Linus Walleij
---
drive
ned-off-by: Virupax Sadashivpetimath
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 400ae21..469eb28 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
From: Linus Walleij
This ASIC variant has been deleted from the ARM tree, no need
to keep support around.
Cc: Vinit Shenoy
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi
On Sun, Jun 10, 2012 at 12:31 PM, Andrew Lunn wrote:
> Replace the deprecated master->transfer with transfer_one_message()
> and allow the SPI subsystem handle all the queuing of messages.
>
> Signed-off-by: Andrew Lunn
> Acked-by: Linus Walleij
Looks good to me:
Acked
private DMA API for the transmit and receive sides.
>
> Tested-by: Shubhrajyoti
> Acked-by: Grant Likely
> Signed-off-by: Russell King
This looks very good,
Acked-by: Linus Walleij
Thanks,
Linus Walleij
Acked-by: Linus Walleij
Thanks,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discu
Grant have you picked this patch? It arrived pretty early so should be
quite ripe by now...
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
'
> drivers/spi/spi-sirf.c:603: error: implicit declaration of function
> 'pinmux_put'
> make[3]: *** [drivers/spi/spi-sirf.o] Error 1
>
> Signed-off-by: Barry Song
> Cc: Guennadi Liakhovetski
&g
patch?
Acked-by: Linus Walleij
Yours,
Linus Walleij
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respon
1 - 100 of 310 matches
Mail list logo
