[PATCH 2/2] ARM: u300: switch SSP/SPI clock name to SSPCLK

2014-02-24 Thread Linus Walleij
0194G). Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/boot/dts/ste-u300.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ste-u300.dts b/arch/arm/boot/dts/ste-u300.dts index a9da4800daf0..6fe688e9e4da 100644 --- a/arch/arm/boot/dts/ste-u300

[PATCH 1/2] ARM: ux500: switch SSP/SPI clock name to SSPCLK

2014-02-24 Thread Linus Walleij
0194G). Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/boot/dts/ste-dbx5x0.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi index e0853ea02df2..e41eedca3ce3 100644

Re: Depreciated spi_master.transfer and prepared spi messages for an optimized pipelined-SPI-DMA-driver

2013-10-29 Thread Linus Walleij
*); Maybe? I cannot tell from the above how this would look so I think it is better if you send a patch showing how this improves efficiency. Yours, Linus Walleij -- Android is increasing in popularity, but the open

[PATCH 21/23] ARM: u300: probe the U300 dummy-spichip from device tree

2013-04-22 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This probes the U300 dummy-spichip from the device tree and adds the apropriate node to the tree. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/boot/dts/ste-u300.dts| 5 + arch/arm/mach-u300/dummyspichip.c | 6 ++ 2

[PATCH 20/23] ARM: u300: add SPI PL022 to the device tree

2013-04-22 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This registers the PL022 PrimeCell from the U300 device tree. We make a new copy of the platform data for the device tree boot path, as the old platform data is in an older file which will be going away. Signed-off-by: Linus Walleij linus.wall

Re: [PATCH v4] gpio: mcp23s08: convert driver to DT

2013-04-10 Thread Linus Walleij
on the same chipselect. Signed-off-by: Lars Poeschel poesc...@lemonage.de --- v4: - removed the ability to specify the pullup from device tree - updated binding doc Patch applied! Thanks, Linus Walleij -- Precog

Re: [PATCH v4] gpio: mcp23s08: convert driver to DT

2013-04-04 Thread Linus Walleij
, .owner = THIS_MODULE, + .of_match_table = of_match_ptr(mcp23s08_spi_of_match), Will this compile if CONFIG_OF is not enabled? Yours, Linus Walleij -- Minimize network downtime and maximize

Re: [PATCH v3] gpio: mcp23s08: convert driver to DT

2013-03-27 Thread Linus Walleij
On Wed, Mar 27, 2013 at 12:35 PM, Lars Poeschel poesc...@lemonage.de wrote: On Friday 22 March 2013 at 09:33:10, Linus Walleij wrote: I would currently feel a lot better if you did not include this flag. How would you control this the day drivers need to enable/disable pull-up at runtime

Re: [PATCH v3] gpio: mcp23s08: convert driver to DT

2013-03-22 Thread Linus Walleij
); + if (!status) + mcp-cache[MCP_GPPU] = value; + mutex_unlock(mcp-lock); + + return status; +} The pull-up business actually looks like new functionality that has nothing to do with adding device tree support and should be a separate patch. Yours, Linus Walleij

Re: [PATCH v2] gpio: mcp23s08: convert driver to DT

2013-02-15 Thread Linus Walleij
On Thu, Feb 14, 2013 at 1:22 PM, Lars Poeschel poesc...@lemonage.de wrote: On Wednesday 13 February 2013 at 13:51:12, Linus Walleij wrote: Have you considered this [pinctrl] approach? No, I haven't. And although this doesn't solve all my problems, I like the idea very much! Thank you

Re: [PATCH v2] gpio: mcp23s08: convert driver to DT

2013-02-13 Thread Linus Walleij
, Linus Walleij -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb

Re: [PATCH 2/5] spi: pl022: use generic DMA slave configuration if possible

2013-02-08 Thread Linus Walleij
, this is a way to feed in some junk. So this goes on my TODO... Yours, Linus Walleij -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn

Re: [PATCH RFC 1/1] gpio: mcp23s08: convert driver to DT

2013-02-06 Thread Linus Walleij
instance. And luckily the base is zero. Not elegant maybe, but the global GPIO numberspace is not elegant by nature. Yours, Linus Walleij -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Mon, Feb 4, 2013 at 10:54 PM, Cyril Chemparathy cy...@ti.com wrote: On 02/04/2013 04:11 PM, Linus Walleij wrote: Cyril, just stack up the cookies and take a sweep over them to see which ones are baked when the NAPI poll comes in - problem solved. You're assuming that cookies complete

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
decide what to do next. This could just as well have been some API calling in and saying give me your buffer NOW. I think we need to look at an NAPI driver that does this trick so we understand what you want from the API. Yours, Linus Walleij

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Tue, Feb 5, 2013 at 5:47 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote: For IRQ mode, use the completion callback to push each cookie to NAPI, and thus let the IRQ drive the traffic. The whole purpose of NAPI

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Linus Walleij
On Tue, Feb 5, 2013 at 6:14 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Feb 05, 2013 at 04:30:45PM +0100, Linus Walleij wrote: So put them on a wait list? Surely you will have a list of pending cookies and pick from the front of the queue if there isn't a hole on queue

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Linus Walleij
networking usecase, so we need to drill into that. Yours, Linus Walleij -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Linus Walleij
On Mon, Feb 4, 2013 at 9:33 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Feb 04, 2013 at 09:29:46PM +0100, Linus Walleij wrote: On Mon, Feb 4, 2013 at 8:22 PM, Cyril Chemparathy cy...@ti.com wrote: Based on our experience with fitting multiple subsystems on top

Re: [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count

2013-02-01 Thread Linus Walleij
from calls to of_gpio_count Looks correct to me, but I'm no DT-ninja. For the GPIO portions: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Everyone hates slow websites. So do we. Make your web

Re: [PATCH RFC 1/1] gpio: mcp23s08: convert driver to DT

2013-01-31 Thread Linus Walleij
are referenced by ampersand gpio0 1 2 notation referring to the instance, so as you realize DT itself has no need for that number. Further it is not OS-neutral. You have to find another way to handle this in the driver code. In worst case: use AUXDATA. Yours, Linus Walleij

Re: [PATCH] SPI: SSP SPI Controller driver

2013-01-10 Thread Linus Walleij
need a common core for dw IP and SSP IP (i think pxa uses same stuff). That way lot of code will get reduced from driver +1 on this comment, I didn't even notice :-( Linus Walleij -- Master Visual Studio, SharePoint, SQL

Re: [PATCH v2 1/2] spi: bitbang: simplify pointer arithmetics

2013-01-10 Thread Linus Walleij
On Wed, Jan 9, 2013 at 3:08 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Add a pointer variable to make spi_bitbang_start() look simpler. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Linus Walleij linus.wall...@linaro.org I think Mark Brown is still backing

Re: [PATCH v2 2/2] spi: bitbang: convert to using core message queue

2013-01-10 Thread Linus Walleij
appear before the patch? Yours, Linus Walleij -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step

Re: [PATCH 3/3] spi: bitbang: convert to using core message queue

2013-01-08 Thread Linus Walleij
way of testing this. But if I break something I guess people will notice :-D Yours, Linus Walleij -- Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-20 Thread Linus Walleij
all kind of crap for encoding things into the ARM plaforms like this, so let's not repeat that mistake. Yours, Linus Walleij -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-17 Thread Linus Walleij
to also generalize parts of the transfer handling but ran out of energy. Yours, Linus Walleij -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant

Re: [PATCH] SPI: SSP SPI Controller driver

2012-12-17 Thread Linus Walleij
signature; + u32 length; + u8 rev; + u8 checksum; + u8 dib[0]; +} __packed; Why is this packed? Yours, Linus Walleij -- LogMeIn Rescue: Anywhere, Anytime Remote support

Re: [PATCH] spi/pl022: Activate resourses before deactivate them in suspend

2012-10-28 Thread Linus Walleij
it will do the job. Ulf can you comment on this... Yours, Linus Walleij -- WINDOWS 8 is here. Millions of people. Your app in 30 days. Visit The Windows 8 Center at Sourceforge for all your go to resources. http

Re: [PATCH] spi/pl022: add IDLE state pin management

2012-10-17 Thread Linus Walleij
On Wed, Oct 17, 2012 at 9:24 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Oct 11, 2012 at 02:03:51PM +0200, Linus Walleij wrote: From: Patrice Chotard patrice.chot...@stericsson.com This commit allow to put pins in IDLE state in runtime_suspend and in SLEEP state

[PATCH 0/4] PL022 patch queue

2012-10-17 Thread Linus Walleij
Hi Mark, it turns out the reason that the IDLE state patch did not apply was due to this dependency chain, all tested by me. So I signed them all off and rebased on top of spi-next, hope this works out. Patrice Chotard (1): spi/pl022: add IDLE state pin management Ulf Hansson (3): Revert

[PATCH 1/4] Revert spi/pl022: enable runtime PM

2012-10-17 Thread Linus Walleij
From: Ulf Hansson ulf.hans...@linaro.org This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99. This patch is reverted due to wrong runtime PM code. Conflicts: drivers/spi/spi-pl022.c Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Signed-off-by: Linus Walleij linus.wall

[PATCH 2/4] spi: spi-pl022: Minor simplification for runtime pm

2012-10-17 Thread Linus Walleij
-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index a1db91a..51b7a95 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2246,10

[PATCH 3/4] spi/pl022: Activate resourses before deactivate them in suspend

2012-10-17 Thread Linus Walleij
with a pm_runtime_put. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 51b7a95..51329b2 100644 --- a/drivers/spi/spi

[PATCH 4/4] spi/pl022: add IDLE state pin management

2012-10-17 Thread Linus Walleij
/pl022_suspend_resources which indicates if it's called from PM_RUNTIME callbacks or not. Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 44 +++- 1 file changed, 31

Re: [PATCH 2/4] spi: spi-pl022: Minor simplification for runtime pm

2012-10-17 Thread Linus Walleij
from being runtime suspended by a pm_runtime_get*. This was the case earlier. OK I'll update the commit message and respin this one *only* as [PATCH 2/4 v2] hold on... Yours, Linus Walleij -- Everyone hates slow websites

[PATCH 2/4 v2] spi: spi-pl022: Minor simplification for runtime pm

2012-10-17 Thread Linus Walleij
From: Ulf Hansson ulf.hans...@linaro.org In probe pm_runtime_put_autosuspend has the same effect as doing pm_runtime_put. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 5 ++--- 1 file changed, 2 insertions

[PATCH] spi/pl022: add IDLE state pin management

2012-10-11 Thread Linus Walleij
/pl022_suspend_resources which indicates if it's called from PM_RUNTIME callbacks or not. Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 44 +++- 1 file changed, 31

Re: [PATCH V2 3/3] spi: spi-pl022: Minor simplification for runtime pm

2012-10-05 Thread Linus Walleij
by a pm_runtime_get*. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index a1db91a..51b7a95

Re: [PATCH V2 0/3] spi: spi-pl022: Fixup use of runtime pm

2012-10-05 Thread Linus Walleij
? Grant or Mark? Yours, Linus Walleij -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-09-30 Thread Linus Walleij
-pl022 ssp0: Unbalanced pm_runtime_enable! Signed-off-by: Michel JAOUEN michel.jao...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Yours, Linus Walleij

Re: [PATCH 2/3] Revert spi/pl022: enable runtime PM

2012-09-30 Thread Linus Walleij
On Fri, Sep 28, 2012 at 1:21 PM, Ulf Hansson ulf.hans...@stericsson.com wrote: From: Ulf Hansson ulf.hans...@linaro.org This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org Thanks

Re: [PATCH 3/3] spi: spi-pl022: Minor simplification for runtime pm

2012-09-30 Thread Linus Walleij
suspended by a pm_runtime_get*. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Everyone hates slow websites. So do we. Make your web apps faster

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Linus Walleij
, during ordinary suspend the device is runtime resumed for example. Rafael, Magnus: help. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [PATCH 2/2] ARM: ABMA: Disable/Enable interface clock from suspend/resume

2012-09-26 Thread Linus Walleij
) have choosen to call out to the AMBA level to make sure semantics are preserved. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Linus Walleij
On Wed, Sep 26, 2012 at 2:19 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar SPI functional clock must be disalble/enable in non RTPM suspend/resume hooks. Currently

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Linus Walleij
On Wed, Sep 26, 2012 at 4:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Sep 26, 2012 at 5:49 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar SPI

[PATCH] spi/pl022: use more managed resources

2012-09-26 Thread Linus Walleij
This switches the PL022 SPI driver to use devm_* managed resources for IRQ, clocks, ioremap and GPIO. Prior to this, the GPIOs would even leak. Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/spi/spi-pl022.c | 31 ++- 1 file changed, 10

[PATCH] spi/pl022: get/put resources on suspend/resume

2012-09-26 Thread Linus Walleij
reference counter to 0, runtime resume having previously increased it to 1. Cc: Ulf Hansson ulf.hans...@linaro.org Cc: Vipul Kumar Samar vipulkumar.sa...@st.com Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- Vipin: can you confirm

Re: [PATCH] spi/pl022: get/put resources on suspend/resume

2012-09-26 Thread Linus Walleij
! Yours, Linus Walleij -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http

[PATCH v2] spi/pl022: get/put resources on suspend/resume

2012-09-26 Thread Linus Walleij
reference counter to 0, runtime resume having previously increased it to 1. Cc: Vipul Kumar Samar vipulkumar.sa...@st.com Cc: Viresh Kumar viresh.ku...@linaro.org Acked-by: Ulf Hansson ulf.hans...@linaro.org Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- ChangeLog v1-v2: - Add more

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-20 Thread Linus Walleij
On Wed, Sep 19, 2012 at 5:31 AM, viresh kumar viresh.ku...@linaro.org wrote: On Tue, Sep 18, 2012 at 5:20 PM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar viresh.ku...@linaro.org wrote: The amba layer is taking care of interface clock only

[PATCH] spi/pl022: adopt pinctrl support

2012-09-19 Thread Linus Walleij
vinit.she...@st.com Cc: Viresh Kumar viresh.ku...@arm.com Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/mach-u300/core.c | 3 --- drivers/spi/spi-pl022.c | 46 ++ 2 files

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-18 Thread Linus Walleij
bus. In some designs these two clocks are one and the same, and these won't currently get into any clock disabled states, sadly. (We need to fix that some day.) Yours, Linus Walleij -- Live Security Virtual Conference

Re: [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree

2012-09-18 Thread Linus Walleij
On Mon, Sep 17, 2012 at 7:03 PM, Roland Stigge sti...@antcom.de wrote: On 09/10/2012 01:11 PM, Linus Walleij wrote: It appears Roland has written his bindings such that DT data augments platform data (yes, I am also getting crazy about this prioritization, mea culpa for ACKing this without

Re: [PATCH v2 2/2] ARM: OMAP2+: Enable pinctrl dummy states

2012-09-18 Thread Linus Walleij
have pinmuxes configured before the drivers probe. Signed-off-by: Matt Porter mpor...@ti.com Looks like a good idea, so FWIW: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread Linus Walleij
clk_prepare/unprepare at probe and removed, so I guess what you're trying to say is that on your platform the clk_unprepare() process context call is needed to save power? Please elaborate... Yours, Linus Walleij -- Live

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-03 Thread Linus Walleij
of pl022 is now int *). Do you get my point ? This would go way beyond memory allocated for chipselects. Yes of course ... how could I not see this. Sorry! Yours, Linus Walleij -- Live Security Virtual Conference Exclusive

Re: [PATCH] spi/pl022: Fix chipselects pointer computation

2012-09-03 Thread Linus Walleij
) but to a multiple of bytes after it because of the (int *) type. Replacing the kludgy pointer arithmetic with managed memory allocation for the chip selects. Signed-off-by: Roland Stigge sti...@antcom.de Reviewed-by: Linus Walleij linus.wall...@linaro.org Thanks for fixing this! And thanks to Shiraz

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-03 Thread Linus Walleij
On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack zon...@gmail.com wrote: On 05.08.2012 21:12, Linus Walleij wrote: On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack zon...@gmail.com wrote: Acked-by: Linus Walleij linus.wall...@linaro.org Ok, thanks. Mark, did the patches reach you this time? I think

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Linus Walleij
as it is. And the other way too, since I'm not very picky.) Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how

Re: [PATCH] spi/pl022: Fill master-dev.of_node to get spi devices registered via DT

2012-08-22 Thread Linus Walleij
On Wed, Aug 22, 2012 at 11:16 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On 19 August 2012 03:56, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar viresh.ku...@linaro.org Isn't this one of those things that *have* to be #ifdef CONFIG_OF? Next

Re: [PATCH v5 2/2] spi/pl022: Add devicetree support

2012-08-22 Thread Linus Walleij
property on all GPIO drivers. The rest looks good. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-08-22 Thread Linus Walleij
on the initial patch by Alexandre Pereira da Silva aletes@gmail.com Signed-off-by: Roland Stigge sti...@antcom.de Acked-by: Alexandre Pereira da Silva aletes@gmail.com Thanks Roland, excellent work! Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij

Re: [PATCH v6 3/3] DT bindings documentation: num-cs property for SPI controllers

2012-08-22 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can

Re: [PATCH v6 2/3] spi/pl022: Add devicetree support

2012-08-22 Thread Linus Walleij
Silva aletes@gmail.com Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has

Re: [PATCH RESEND v4] spi/pl022: add devicetree support

2012-08-20 Thread Linus Walleij
++) + pl022-chipselect[i] = -EINVAL; Why? Instead, add a int *chipselects; field to the struct pl022_ssp_controller platform data in include/linux/amba/pl022.h and copy it from there if num_chipselects in the same data != 0. (First patch.) Yours, Linus Walleij

Re: [PATCH RESEND v4] spi/pl022: add devicetree support

2012-08-20 Thread Linus Walleij
. At some point there has been a chip needing these to be set to some magic values. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [PATCH] spi/pl022: Fill master-dev.of_node to get spi devices registered via DT

2012-08-18 Thread Linus Walleij
patches for the moment. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions

[PATCH] spi/pl022: fix spi-pl022 pm enable at probe

2012-08-17 Thread Linus Walleij
Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index aab518e..6abbe23 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2053,7 +2053,6

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-08-04 Thread Linus Walleij
...@secretlab.ca Cc: Linus Walleij linus.wall...@stericsson.com From a GPIO point of view this looks good to me. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual Conference

Fwd: [GIT PULL] PL022 patches for v3.6

2012-07-10 Thread Linus Walleij
Hi Mark, Can you please pull in these PL022 patches to your spi-next tree? Yours, Linus Walleij -- Forwarded message -- From: Linus Walleij linus.wall...@linaro.org Date: Thu, Jul 5, 2012 at 4:27 PM Subject: [GIT PULL] PL022 patches for v3.6 To: Wolfram Sang w.s

Re: [PATCH RFC] spi/gpio: start with CS non-active

2012-07-09 Thread Linus Walleij
a difference. ping You probably want to resend this with Linus W in the CCs. It all makes sense to me so: Acked-by: Linus Walleij linus.wall...@linaro.org Now the SPI maintainer needs to pick it up though, if your proposal to pick it up goes through this patch is all yours now. Yours, Linus

[GIT PULL] PL022 patches for v3.6

2012-07-05 Thread Linus Walleij
) Alexandre Pereira da Silva (1): spi/pl022: cleanup pl022 header documentation Linus Walleij (2): spi/pl022: delete DB5500 support spi/pl022: enable runtime PM Virupax Sadashivpetimath (1): spi/pl022: disable port when unused drivers/spi/spi-pl022.c| 23

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-06-28 Thread Linus Walleij
On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Elegant, monsieur. Acked-by: Linus Walleij linus.wall...@linaro.org I'm starting

Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

2012-06-25 Thread Linus Walleij
. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint

Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

2012-06-25 Thread Linus Walleij
before making the call. Rework the logic a bit to hold queue_lock to protect the 'busy' flag, then release it to call unprepare_transfer_hardware(). Signed-off-by: Bryan Freed bfr...@chromium.org Yes, this looks correct to me! Good catch. Acked-by: Linus Walleij linus.wall...@linaro.org Yours

Re: [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER

2012-06-18 Thread Linus Walleij
-by: Roland Stigge sti...@antcom.de Acked-by: Linus Walleij linus.wall...@linaro.org Should this patch be joined with gpiolib-of's patch to of_get_named_gpio()? Or should they just be issued as a series? If it's not bisectable unless you change this in the same patch then join them. Else I'd put

Re: [PATCH] spi/pl022: cleanup pl022 header documentation

2012-06-17 Thread Linus Walleij
-by: Roland Stigge sti...@antcom.de Reviewed-by: Linus Walleij linus.wall...@linaro.org Thanks for fixing this! Grant, will you please pick this to the SPI tree. Yours, Linus Walleij -- Live Security Virtual Conference

[PATCH v2] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-06-13 Thread Linus Walleij
found in jornada720_ssp is probably not going to play well with the SPI subsystem so this has been replaced by a mutex. Cc: Kristoffer Ericson kristoffer.eric...@gmail.com Cc: Nicolas Pitre nicolas.pi...@linaro.org Cc: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Linus Walleij linus.wall

[PATCH 2/3] spi/pl022: delete DB5500 support

2012-06-12 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This ASIC variant has been deleted from the ARM tree, no need to keep support around. Cc: Vinit Shenoy vinit.she...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 14 -- 1 file changed, 14

[PATCH 3/3] spi/pl022: enable runtime PM

2012-06-12 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org If we're gonna use runtime PM it's a pretty good idea to actually enable it in probe() and disable it in remove() too, so it gets used for real. Up until now we only fooled around with the reference count. Cc: Vinit Shenoy vinit.she...@st.com Signed

Re: [PATCH 2/9] SPI: Refactor spi-orion to use SPI framework queue.

2012-06-11 Thread Linus Walleij
On Sun, Jun 10, 2012 at 12:31 PM, Andrew Lunn and...@lunn.ch wrote: Replace the deprecated master-transfer with transfer_one_message() and allow the SPI subsystem handle all the queuing of messages. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Linus Walleij linus.wall...@linaro.org

Re: [PATCH 3/3] spi: bitbang: convert to using core message queue

2012-05-21 Thread Linus Walleij
g.liakhovet...@gmx.de Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed

Re: [PATCH] SPI: PRIMA2: use the newest APIs of PINCTRL to fix compiling errors

2012-05-15 Thread Linus Walleij
declaration of function 'pinmux_put' make[3]: *** [drivers/spi/spi-sirf.o] Error 1 Signed-off-by: Barry Song baohua.s...@csr.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Linus Walleij linus.wall...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Counting on Grant to pick

Re: [PATCH 1/2] MIPS: OCTEON: Add register definitions for SPI host hardware.

2012-05-14 Thread Linus Walleij
; +               uint64_t clkdiv:13; +               uint64_t reserved_29_63:35; +#endif This boggles my mind, but I see there are many drivers doing this, but using uint64_t looks overly scary. Can't you break it apart using a set of u32's like in drivers/net/ethernet/micrel/ksz884x.c? Yours, Linus Walleij

Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated

2012-05-10 Thread Linus Walleij
drivers to populate empty functions to prevent crashing. This patch prevents the call to prepare/unprepare if not populated. Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Great! Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij

Re: [PATCH] spi: pl022: Allow request for higher frequency than maximum possible

2012-04-19 Thread Linus Walleij
max possible. But should program it to max possible. Reported-by: Vinit Kamalaksha Shenoy vinit.she...@st.com Signed-off-by: Viresh Kumar viresh.ku...@st.com Looks reasonable and mostly harmless :-) Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij

Re: [PATCH] spi: bitbang: convert to using core message queue

2012-04-18 Thread Linus Walleij
On Wed, Apr 11, 2012 at 10:56 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Grant On Tue, 20 Mar 2012, Grant Likely wrote: On Mon, 19 Mar 2012 00:33:14 +0100, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Mar 17, 2012 at 12:39 AM, Guennadi Liakhovetski g.liakhovet

Re: [PATCH V2] spi/pl022: Fix range checking for bits per word

2012-04-17 Thread Linus Walleij
message is incorrect, that prints range is from 1 to 16. Fix both these issues. Signed-off-by: Vinit Shenoy vinit.she...@st.com --- V1-V2: - Fixed the check:        if (pl022-vendor-max_bpw = 32) - Re-written complete range check logic. Looks correct to me: Acked-by: Linus Walleij

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-02 Thread Linus Walleij
On Mon, Apr 2, 2012 at 12:43 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Apr 02, 2012 at 11:14:28AM +0100, Mark Brown wrote: On Mon, Apr 02, 2012 at 12:39:11AM +0200, Linus Walleij wrote: Mark: as Rabin says the v1 patch is probably fine, are you pushing this to ARM

Re: [PATCH/RFC] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
and fixes up taking the above regulators. That said I'm all for replacing it - but I'd need to figure out the details on how to do that. We do have code for ux500 power domains. If it will will be enough to handle this I can try to hack it up and submit it. Yours, Linus Walleij

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
is really lost... And I do like the change, if for nothing else so for the fact that it eventually pushes to power domains what belongs there, so: Acked-by: Linus Walleij linus.wall...@linaro.org But to the defence: power domain code was not in the kernel when the AMBA vcore regulator

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
On Sun, Apr 1, 2012 at 9:39 PM, Rabin Vincent ra...@rab.in wrote: On Mon, Apr 2, 2012 at 00:52, Linus Walleij linus.wall...@linaro.org wrote: Combined with the PL022 patch this causes a power regression since the PL022 is hereafter always on. How can there be a power regression here

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
On Sun, Apr 1, 2012 at 11:27 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sun, Apr 01, 2012 at 09:22:50PM +0200, Linus Walleij wrote: Combined with the PL022 patch this causes a power regression since the PL022 is hereafter always on. I guess this code isn't in mainline

Re: [PATCH] SPI/Pl022: Include types.h to remove compilation warnings

2012-03-23 Thread Linus Walleij
-by: Viresh Kumar viresh.ku...@st.com Looks reasonable! Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http

Re: [PATCH] spi: bitbang: convert to using core message queue

2012-03-18 Thread Linus Walleij
g.liakhovet...@gmx.de This is great stuff! Acked-by: Linus Walleij linus.wall...@linaro.org (Since I've never really used the bitbang driver I wouldn't trust me to do any deeper review.) Quick thought: +static int spi_bitbang_dummy_prepare(struct spi_master *master) +{ +       return 0

Re: [PATCH v3] spi: create a message queueing infrastructure

2012-03-06 Thread Linus Walleij
On Wed, Feb 22, 2012 at 10:05 AM, Linus Walleij linus.wall...@stericsson.com wrote: From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread

[PATCH v3] spi: create a message queueing infrastructure

2012-02-22 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread will need to define the new per-messags transfer methods and leave the deprecated transfer

Re: [PATCH] spi/s3c64xx: Convert to using core message queue

2012-02-22 Thread Linus Walleij
On Wed, Feb 15, 2012 at 11:48 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Convert the s3c64xx driver to using the new message queue factored out of the pl022 driver by Linus Walleij, saving us a nice block of code and getting the benefits of improvements implemented in the core

  1   2   3   >