RE: [PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE,}ACT macros at call sites

Linus Walleij wrote: > > On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown > wrote: > > > They have very few users and they're both just doing a single register > > write so the advantage of having the macro is a bit limited. An inline > > function might make sense but it's as easy to just do the writ

[PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE, }ACT macros at call sites

They have very few users and they're both just doing a single register write so the advantage of having the macro is a bit limited. An inline function might make sense but it's as easy to just do the writes directly. Signed-off-by: Mark Brown Acked-by: Linus Walleij --- drivers/spi/spi-s3c64xx.

Re: [PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE,}ACT macros at call sites

On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown wrote: > They have very few users and they're both just doing a single register > write so the advantage of having the macro is a bit limited. An inline > function might make sense but it's as easy to just do the writes directly. > > Signed-off-by: Mark

[PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE, }ACT macros at call sites

They have very few users and they're both just doing a single register write so the advantage of having the macro is a bit limited. An inline function might make sense but it's as easy to just do the writes directly. Signed-off-by: Mark Brown --- drivers/spi/spi-s3c64xx.c | 12 1