Hi,
On 01/25/2011 03:06 PM, Alon Levy wrote:
---
client/application.cpp |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/client/application.cpp b/client/application.cpp
index d865e84..d0da277 100644
--- a/client/application.cpp
+++ b/client/application.cpp
@@
The name to channel id mapping for the smartcard channel is missing,
add it in client and server.
---
client/application.cpp |6 ++
server/reds.c |3 +++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/client/application.cpp b/client/application.cpp
index
disable some code that only makes sense when USE_TUNNEL is defined
in client and server channel security level setting.
---
client/application.cpp |4
server/reds.c |2 ++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/client/application.cpp
On Tue, Jan 25, 2011 at 03:40:06PM +0100, Hans de Goede wrote:
Hi,
On 01/25/2011 03:06 PM, Alon Levy wrote:
---
client/application.cpp |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/client/application.cpp b/client/application.cpp
index d865e84..d0da277
This is the downfall of me running rawhide and having been upgraded
to gcc 4.6.0 recently.
But it's all good, since it's really things we want to fix. Some of the
comments are a little more verbose then required, (talking about the third
patch, remove unused error val).
The only tricky bit is in
gcc 4.6.0 added [-Werror=unused-but-set-variable], this and the next
few fixes tend to that. Mostly harmless.
---
client/x11/platform.cpp |7 +--
server/jpeg_encoder.c |3 +--
server/red_parse_qxl.c |3 +--
server/red_worker.c | 14 +-
server/reds.c
---
common/canvas_base.c | 12
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index 3b0f801..796bda3 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -647,14 +647,12 @@ static pixman_image_t
This is the only unused var change I'll want to revisit eventually,
I'm submitting anyway since it doesn't change current behavior. I'm
talking about ignoring the return value from canvas creation. Adding
a print is possible but I didn't test (may be too verbose, also
preferable to be a debug
---
python_modules/demarshal.py |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/python_modules/demarshal.py b/python_modules/demarshal.py
index cbe3599..48551c0 100644
--- a/python_modules/demarshal.py
+++ b/python_modules/demarshal.py
@@ -1047,9 +1047,11 @@ def
Hi!
Some of those patches have been pending for a while
sleeping in my branches.
About gdi_handlers, I have no idea why the code was using an
extern in the first place. Perhaps because of some weird
Windows library reason?
The most important changes is the move of ssl verification
code in a
This patch make it easier to spot warnings in compilation. It should
work with older versions of automake that don't support silent rules.
If you want verbose build, make V=1.
Signed-off-by: Uri Lublin u...@redhat.com
---
configure.ac |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
---
common/mem.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/common/mem.c b/common/mem.c
index b0a7eb1..4db8a2c 100644
--- a/common/mem.c
+++ b/common/mem.c
@@ -71,6 +71,10 @@ void *spice_memdup(const void *mem, size_t n_bytes)
{
void *copy;
+if (mem ==
---
common/ring.h | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/common/ring.h b/common/ring.h
index cdfe7e1..0194959 100644
--- a/common/ring.h
+++ b/common/ring.h
@@ -136,5 +136,18 @@ static inline RingItem *ring_prev(Ring *ring, RingItem
*pos)
Code adapter from RedPeer::ssl_verify_callback() and used by
spice-gtk.
Note: the various VERIFY_OP check in openssl_verify() are exclusive.
Is that intended?
---
common/Makefile.am |2 +
common/ssl_verify.c | 458 +++
common/ssl_verify.h |
---
client/application.cpp | 20 ++-
client/red_client.cpp |2 +-
client/red_peer.cpp| 374 +++-
client/red_peer.h | 23 +---
4 files changed, 36 insertions(+), 383 deletions(-)
diff --git a/client/application.cpp
Hi all,
Ack to series.
Regards,
Hans
On 01/25/2011 04:33 PM, Alon Levy wrote:
This is the downfall of me running rawhide and having been upgraded
to gcc 4.6.0 recently.
But it's all good, since it's really things we want to fix. Some of the
comments are a little more verbose then required,
Hi,
Good to review your own patch once it is sent ;)
- Original Message -
+++ b/common/Makefile.am
@@ -47,6 +47,8 @@ COMMON_SRCS = \
quic_family_tmpl.c \
quic_rgb_tmpl.c \
quic_tmpl.c \
+ ssl_verfiy.h \
+ ssl_verfiy.c \
$(NULL)
+ ssl_verify.h \
+ ssl_verify.c \
That would
On Tue, Jan 25, 2011 at 07:17:26PM +0100, Marc-André Lureau wrote:
---
common/ring.h | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/common/ring.h b/common/ring.h
index cdfe7e1..0194959 100644
--- a/common/ring.h
+++ b/common/ring.h
@@ -136,5 +136,18
Hi
+static inline unsigned int ring_get_length(Ring *ring)
This won't compile if no one uses it - so you probably want to make
it non static (or do a hack by doing (void)ring_get_length somewhere).
Correct, if you intend to do (gdb) call ring_get_length(ring). But I was using
it in some
separate initialization into before command line parsing and after,
call later only if command line parsing succeeds (in particular, it
fails if --help is given).
Not tested on windows.
---
client/application.cpp | 75 ---
client/application.h |
On Fri, Jan 21, 2011 at 05:14:11PM +0100, Gerd Hoffmann wrote:
Hi,
The spice-specific issue here is that spice supports multihead, i.e.
you have two displays in the guest and two windows on the host, and
mouse positions are reported as (x,y,window). Question is how to
handle this best
21 matches
Mail list logo
