Re: [Spice-devel] [spice-server v2 3/6] net: Introduce red_socket_set_keepalive() helper

> > On Fri, Mar 10, 2017 at 08:46:09AM -0500, Frediano Ziglio wrote: > > > > > > This allows to move some low-level code out of reds.c > > > > > > Signed-off-by: Christophe Fergeau > > > --- > > > server/net-utils.c | 25 + > > > server/net-utils.h

[Spice-devel] [PATCH spice-server] tests: Enable address sanitizer on GitLab CI

Add required library and options so tests will use the sanitizer. Signed-off-by: Frediano Ziglio --- You can find a build execution log at https://gitlab.com/freddy77/spice/builds/11999610 --- .gitlab-ci.yml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [Spice-devel] Video streaming problem

Hi, On Fri, Mar 10, 2017 at 08:24:24PM +0800, Jayce Wong wrote: > Hi guys, > > I have built and installed the newest version of spice-server, spice-gtk, > and spice-protocol (*Fri Mar 10 07:00:00 UTC 2017*). When I set > "SPICE_DEBUG_LEVEL=5", and add "--spice-debug" when start spicy, and then I

Re: [Spice-devel] gtk client side timeouts

On Fri, Mar 10, 2017 at 10:49:54AM -0600, Jeremy White wrote: > Hey all, > > We've got an issue with a remote viewer kiosk. That is, in our normal > mode of operation, if something goes wrong with a client connection > (e.g. the sessions is killed, server restarted normally), the kiosk will >

[Spice-devel] gtk client side timeouts

Hey all, We've got an issue with a remote viewer kiosk. That is, in our normal mode of operation, if something goes wrong with a client connection (e.g. the sessions is killed, server restarted normally), the kiosk will exit on disconnect, and we get a chance to retry the connection, or present

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST - OT Makefiles...

On Fri, Mar 10, 2017 at 11:32:55AM -0500, Frediano Ziglio wrote: > > Yes, but take a look at server/Makefile.am :-) > At some point seems like a weird textual game! Yeah I know, every time I look there I refrain myself from alphabetically ordering the file list, and aligning the \ Christophe >

Re: [Spice-devel] [spice-server v2 3/6] net: Introduce red_socket_set_keepalive() helper

On Fri, Mar 10, 2017 at 08:46:09AM -0500, Frediano Ziglio wrote: > > > > This allows to move some low-level code out of reds.c > > > > Signed-off-by: Christophe Fergeau > > --- > > server/net-utils.c | 25 + > > server/net-utils.h | 1 + > >

Re: [Spice-devel] [spice-server] build-sys: Add make check-valgrind target

On Fri, Mar 10, 2017 at 09:18:31AM -0500, Frediano Ziglio wrote: > > > > This allows to run automatically our test-suite with valgrind to test > > for memory leaks. > > If this is a reply to test-leaks question from Christphe D > I usually use address sanitizer now :) > > I didn't check/test

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST - OT Makefiles...

> > On Fri, Mar 10, 2017 at 09:22:13AM -0500, Frediano Ziglio wrote: > > > > > > This fixes make distcheck > > > --- > > > This applies on top of the make check-valgrind patch I sent earlier, I > > > can > > > rebase on top of git master if needed > > > > > > Christophe > > > > > >

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST - OT Makefiles...

On Fri, Mar 10, 2017 at 09:22:13AM -0500, Frediano Ziglio wrote: > > > > This fixes make distcheck > > --- > > This applies on top of the make check-valgrind patch I sent earlier, I can > > rebase on top of git master if needed > > > > Christophe > > > > server/tests/Makefile.am | 7 ++- >

Re: [Spice-devel] [spice-gtk PATCH v3 0/2] Handle failed spice authentication

Series looks good to me, sorry, forgot to look at it sooner :-/ Christophe On Sun, Feb 26, 2017 at 12:09:16PM +0200, Snir Sheriber wrote: > Differences from v2: > -more informative commit messages > -removing authentication type from error messages > -rebase > > Snir Sheriber (2): >

Re: [Spice-devel] [PATCH spice-gtk] dist: Keep generated keymaps

On Fri, 2017-03-10 at 15:07 +0100, Christophe Fergeau wrote: > On Fri, Mar 10, 2017 at 12:58:40PM +0100, Pavel Grunt wrote: > > spice-gtk does not have to require python > > > > Regression since 271222e2217bf82644d87649b43b920240430f8 > > > Acked-by: Christophe Fergeau >

[Spice-devel] [PATCH spice-server] test-leaks: Document test program

This test needs some additional setup to do its job. Signed-off-by: Frediano Ziglio --- server/tests/test-leaks.c | 13 + 1 file changed, 13 insertions(+) diff --git a/server/tests/test-leaks.c b/server/tests/test-leaks.c index 8ab8e15..4985a1e 100644 ---

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST - OT Makefiles...

> > This fixes make distcheck > --- > This applies on top of the make check-valgrind patch I sent earlier, I can > rebase on top of git master if needed > > Christophe > > server/tests/Makefile.am | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [spice-server] build-sys: Add make check-valgrind target

> > This allows to run automatically our test-suite with valgrind to test > for memory leaks. If this is a reply to test-leaks question from Christphe D I usually use address sanitizer now :) I didn't check/test the patch but I'm seeing it has GNU make specific stuff. From another patch this

Re: [Spice-devel] [spice-server v2] RedChannelClient: Mark some private data as bool

I would propagate the types, something like this: https://cgit.freedesktop.org/~fziglio/spice-server/commit/?h=teuf2=6930f008fd0dcbffc9e0c7a47e49dcdd1013b1e1 Beside that, Acked-by: Frediano Ziglio Frediano > > Some RedChannelClient data members were marked as int when

Re: [Spice-devel] [PATCH spice-gtk] dist: Keep generated keymaps

On Fri, Mar 10, 2017 at 12:58:40PM +0100, Pavel Grunt wrote: > spice-gtk does not have to require python > > Regression since 271222e2217bf82644d87649b43b920240430f8 Acked-by: Christophe Fergeau though I wonder whether we should always regenerate the keymaps .c files

Re: [Spice-devel] [RFC spice-protocol] Update NEWS for 0.12.13 release

> > On Fri, 2017-03-10 at 08:25 -0500, Frediano Ziglio wrote: > > > > > > --- > > > Hi, > > > I would like to do the spice-gtk release, for that the protocol > > > release > > > is required. > > > --- > > >  NEWS | 7 +++ > > >  1 file changed, 7 insertions(+) > > > > > > diff --git a/NEWS

[Spice-devel] Video streaming problem

Hi guys, I have built and installed the newest version of spice-server, spice-gtk, and spice-protocol (*Fri Mar 10 07:00:00 UTC 2017*). When I set "SPICE_DEBUG_LEVEL=5", and add "--spice-debug" when start spicy, and then I found that the SPICE is using glz-decoder even when I change

Re: [Spice-devel] [spice-server v2 6/6] build-sys: Add configure check for TCP_KEEPIDLE

> > On Fri, Mar 10, 2017 at 09:59:42AM +0100, Christophe Fergeau wrote: > > This is only available in newer FreeBSD releases (9.1 and later), and > > will cause build errors or older versions > > > > This fixes https://bugs.freedesktop.org/show_bug.cgi?id=99213 Do we support *BSD ? > > --- >

Re: [Spice-devel] error on USB redirect: LIBUSB_ERROR_NOT_FOUND

On Fri, Mar 10, 2017 at 11:36:59AM +0100, Victor Toso wrote: > Hi, > Hi Victor, thank you very much for answering. > > phones. When I set the device to redirect it won't work and sometimes > > it shows this message: > > > > Could not redirect: Samsung Electronics Co., > > Ltd Galaxy

Re: [Spice-devel] [spice-server v2 5/6] reds-stream: Cache TCP socket 'no-delay' value

> > Rather than calling getsockopt when we need its value, we can cache it > as it can only be set through a call to reds_stream_set_no_delay() > > Signed-off-by: Christophe Fergeau I would avoid that - not in an hot path, it's just a system call; - with my patches this

Re: [Spice-devel] [spice-server v2 4/6] reds-stream: Introduce reds_stream_get_no_delay() helper

> > This new function removes one place outside of RedsStream which needs to > access RedsStream::socket > > Signed-off-by: Christophe Fergeau > --- > server/net-utils.c | 14 ++ > server/net-utils.h | 1 + > server/red-channel-client.c | 7

Re: [Spice-devel] [spice-server v2 3/6] net: Introduce red_socket_set_keepalive() helper

> > This allows to move some low-level code out of reds.c > > Signed-off-by: Christophe Fergeau > --- > server/net-utils.c | 25 + > server/net-utils.h | 1 + > server/reds.c | 27 ++- > 3 files changed, 28

Re: [Spice-devel] [RFC spice-protocol] Update NEWS for 0.12.13 release

On Fri, 2017-03-10 at 08:25 -0500, Frediano Ziglio wrote: > > > > --- > > Hi, > > I would like to do the spice-gtk release, for that the protocol > > release > > is required. > > --- > >  NEWS | 7 +++ > >  1 file changed, 7 insertions(+) > > > > diff --git a/NEWS b/NEWS > > index

Re: [Spice-devel] [spice-server v2 2/6] net: Introduce red_socket_set_non_blocking() helper

> > On Fri, Mar 10, 2017 at 09:59:38AM +0100, Christophe Fergeau wrote: > > This allows to move some low-level code out of reds.c > > Forgot that this patch (or one of the patches in this series) needs a > minor spice-common patch too to avoid build failures. > > diff --git a/common/log.h

Re: [Spice-devel] [spice-server v2 2/6] net: Introduce red_socket_set_non_blocking() helper

> > This allows to move some low-level code out of reds.c > Wonderful! Too many stuff in this file. > Signed-off-by: Christophe Fergeau > --- > server/net-utils.c | 17 + > server/net-utils.h | 1 + > server/reds.c | 18 +- > 3 files

Re: [Spice-devel] [spice-server v2 1/6] reds-stream: Introduce reds_stream_set_no_delay() helper

> > The code to enable/disable on a TCP socket is duplicated in multiple > places in the code base, this commit replaces this duplicated code with > a helper in RedsStream. > > Signed-off-by: Christophe Fergeau > --- > server/Makefile.am | 2 ++ >

Re: [Spice-devel] [spice-gtk] doc: Remove perl(Text::CSV) references

On Fri, Mar 10, 2017 at 12:06:43PM +, Daniel P. Berrange wrote: > On Fri, Mar 10, 2017 at 12:29:55PM +0100, Christophe Fergeau wrote: > > It's no longer used since commit e271222e "Switch over to using > > keycodemapdb submodule" > > --- > > README | 2 +- > > src/Makefile.am | 1 - >

Re: [Spice-devel] [RFC spice-protocol] Update NEWS for 0.12.13 release

> > --- > Hi, > I would like to do the spice-gtk release, for that the protocol release > is required. > --- > NEWS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/NEWS b/NEWS > index 4c71728..9c5697f 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,10 @@ > +Major changes in

Re: [Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST

On Fri, Mar 10, 2017 at 01:16:37PM +0100, Christophe Fergeau wrote: > This fixes make distcheck > --- > This applies on top of the make check-valgrind patch I sent earlier, I can > rebase on top of git master if needed > > Christophe > > server/tests/Makefile.am | 7 ++- > 1 file changed, 6

[Spice-devel] [spice-server] build-sys: Add tests/pki to EXTRA_DIST

This fixes make distcheck --- This applies on top of the make check-valgrind patch I sent earlier, I can rebase on top of git master if needed Christophe server/tests/Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server/tests/Makefile.am

Re: [Spice-devel] [spice-gtk] doc: Remove perl(Text::CSV) references

On Fri, Mar 10, 2017 at 12:29:55PM +0100, Christophe Fergeau wrote: > It's no longer used since commit e271222e "Switch over to using > keycodemapdb submodule" > --- > README | 2 +- > src/Makefile.am | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) ACK > diff --git a/README

[Spice-devel] [PATCH spice-gtk] Update submodules

Allow to compile without warnings with the new OpenSSL Add missing import in the keymap generator spice-common: Frediano Ziglio (1): region: Avoid possible memory corruption Jonathon Jongsma (1): Document REGION_TEST_* bitmasks Sebastian Andrzej Siewior (1): ssl: Use

[Spice-devel] [PATCH spice-gtk] dist: Keep generated keymaps

spice-gtk does not have to require python Regression since 271222e2217bf82644d87649b43b920240430f8 --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 594c0de..40cffa6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -31,6 +31,7 @@

Re: [Spice-devel] [spice-gtk] doc: Remove perl(Text::CSV) references

On Fri, 2017-03-10 at 12:29 +0100, Christophe Fergeau wrote: > It's no longer used since commit e271222e "Switch over to using > keycodemapdb submodule" Acked-by: Pavel Grunt > --- >  README  | 2 +- >  src/Makefile.am | 1 - >  2 files changed, 1 insertion(+), 2

[Spice-devel] [spice-server] build-sys: Add make check-valgrind target

This allows to run automatically our test-suite with valgrind to test for memory leaks. --- This adds the target suggested in https://lists.freedesktop.org/archives/spice-devel/2017-March/036499.html Half of the tests are currently failing when using make check-valgrind, I haven't tried to fix

[Spice-devel] [spice-gtk] doc: Remove perl(Text::CSV) references

It's no longer used since commit e271222e "Switch over to using keycodemapdb submodule" --- README | 2 +- src/Makefile.am | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/README b/README index 43ee08a..12513c5 100644 --- a/README +++ b/README @@ -53,4 +53,4 @@

Re: [Spice-devel] [PATCH spice-gtk] build-sys: Use AM_PATH_PYTHON to find PYTHON interpreter

(for those wondering about the syntax, that's actually documented in https://www.gnu.org/software/automake/manual/html_node/Python.html) ack - Original Message - > It is more suitable for the task than AC_PATH_PROGS > Also it prevents us from forcing a version of Python > --- >

Re: [Spice-devel] [PATCH spice-gtk] build-sys: Use AM_PATH_PYTHON to find PYTHON interpreter

On Fri, Mar 10, 2017 at 10:21:36AM +0100, Pavel Grunt wrote: > It is more suitable for the task than AC_PATH_PROGS > Also it prevents us from forcing a version of Python Acked-by: Christophe Fergeau > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Spice-devel] [PATCH spice-gtk] m4: Drop unused AM_CHECK_PYTHON_HEADERS

Acked-by: Christophe Fergeau On Fri, Mar 10, 2017 at 10:27:37AM +0100, Pavel Grunt wrote: > Unused since we dropped python bindings > 0917002c48a0a5deb615d120a0e5997eefc89fd4 > --- > m4/check_python.m4 | 46 -- > 1 file changed,

Re: [Spice-devel] [spice-server v2 6/6] build-sys: Add configure check for TCP_KEEPIDLE

On Fri, Mar 10, 2017 at 09:59:42AM +0100, Christophe Fergeau wrote: > This is only available in newer FreeBSD releases (9.1 and later), and > will cause build errors or older versions > > This fixes https://bugs.freedesktop.org/show_bug.cgi?id=99213 > --- > configure.ac | 10 ++ >

Re: [Spice-devel] error on USB redirect: LIBUSB_ERROR_NOT_FOUND

Hi, On Fri, Mar 10, 2017 at 11:36:59AM +0100, Victor Toso wrote: > On Fri, Mar 10, 2017 at 10:47:52AM +0100, Francesc Guasch wrote: > > The USB redirection works for pen drives but it won't recognize the > > phones. When I set the device to redirect it won't work and sometimes > > it shows this

Re: [Spice-devel] error on USB redirect: LIBUSB_ERROR_NOT_FOUND

Hi, On Fri, Mar 10, 2017 at 10:47:52AM +0100, Francesc Guasch wrote: > Hi. I have issues with the USB redirection. I hope this > is the right place to ask. Sure it is :) > We are trying to switch a PC classroom in the University to use > virtual PCs with Spice. There is a course that requires

[Spice-devel] error on USB redirect: LIBUSB_ERROR_NOT_FOUND

Hi. I have issues with the USB redirection. I hope this is the right place to ask. We are trying to switch a PC classroom in the University to use virtual PCs with Spice. There is a course that requires the students work with cell phones. The USB redirection works for pen drives but it won't

[Spice-devel] [RFC spice-protocol] Update NEWS for 0.12.13 release

--- Hi, I would like to do the spice-gtk release, for that the protocol release is required. --- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index 4c71728..9c5697f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,10 @@ +Major changes in 0.12.13 + +*

Re: [Spice-devel] [spice-server v2 2/6] net: Introduce red_socket_set_non_blocking() helper

On Fri, Mar 10, 2017 at 09:59:38AM +0100, Christophe Fergeau wrote: > This allows to move some low-level code out of reds.c Forgot that this patch (or one of the patches in this series) needs a minor spice-common patch too to avoid build failures. diff --git a/common/log.h b/common/log.h index

[Spice-devel] [PATCH spice-gtk] m4: Drop unused AM_CHECK_PYTHON_HEADERS

Unused since we dropped python bindings 0917002c48a0a5deb615d120a0e5997eefc89fd4 --- m4/check_python.m4 | 46 -- 1 file changed, 46 deletions(-) delete mode 100644 m4/check_python.m4 diff --git a/m4/check_python.m4 b/m4/check_python.m4 deleted file

[Spice-devel] [PATCH spice-gtk] build-sys: Use AM_PATH_PYTHON to find PYTHON interpreter

It is more suitable for the task than AC_PATH_PROGS Also it prevents us from forcing a version of Python --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 763d14b..ad5e6e9 100644 --- a/configure.ac +++ b/configure.ac @@ -43,7

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for reporting availability of agent features

Hi, On Fri, Mar 10, 2017 at 09:07:14AM +0100, Pavel Grunt wrote: > On Tue, 2017-02-28 at 15:07 +0100, Victor Toso wrote: > > Hi, > > > > On Tue, Feb 28, 2017 at 02:58:58PM +0100, Pavel Grunt wrote: > > > Some agent features can be disabled on the server: > > >  * Copy & Paste > > >  * File

[Spice-devel] [spice-server v2 6/6] build-sys: Add configure check for TCP_KEEPIDLE

This is only available in newer FreeBSD releases (9.1 and later), and will cause build errors or older versions This fixes https://bugs.freedesktop.org/show_bug.cgi?id=99213 --- configure.ac | 10 ++ server/net-utils.c | 2 ++ 2 files changed, 12 insertions(+) diff --git

[Spice-devel] [spice-server v2 4/6] reds-stream: Introduce reds_stream_get_no_delay() helper

This new function removes one place outside of RedsStream which needs to access RedsStream::socket Signed-off-by: Christophe Fergeau --- server/net-utils.c | 14 ++ server/net-utils.h | 1 + server/red-channel-client.c | 7 ++-

[Spice-devel] [spice-server v2 3/6] net: Introduce red_socket_set_keepalive() helper

This allows to move some low-level code out of reds.c Signed-off-by: Christophe Fergeau --- server/net-utils.c | 25 + server/net-utils.h | 1 + server/reds.c | 27 ++- 3 files changed, 28 insertions(+), 25 deletions(-)

[Spice-devel] [spice-server v2 5/6] reds-stream: Cache TCP socket 'no-delay' value

Rather than calling getsockopt when we need its value, we can cache it as it can only be set through a call to reds_stream_set_no_delay() Signed-off-by: Christophe Fergeau --- server/reds-stream.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff

[Spice-devel] [spice-server v2 1/6] reds-stream: Introduce reds_stream_set_no_delay() helper

The code to enable/disable on a TCP socket is duplicated in multiple places in the code base, this commit replaces this duplicated code with a helper in RedsStream. Signed-off-by: Christophe Fergeau --- server/Makefile.am | 2 ++

Re: [Spice-devel] [PATCH spice-server] test-leaks: Checks some leaks using TLS

On Thu, Mar 09, 2017 at 07:01:14PM +0100, Christophe de Dinechin wrote: > [Resend, apparently stayed in my outbox for a few days] > > On 7 Mar 2017, at 17:56, Frediano Ziglio wrote: > > > > Verify stuff are freed correctly (like TLS context). > > The different PKI file

Re: [Spice-devel] [PATCH spice-gtk] Use macro for more precise widget debugs

On Fri, 2017-03-10 at 08:34 +0100, Pavel Grunt wrote: > On Thu, 2017-03-09 at 22:00 +0100, Victor Toso wrote: > > On Thu, Mar 09, 2017 at 04:51:24PM +0100, Pavel Grunt wrote: > > > SPICE_DISPLAY_DEBUG provides information about channel and > > > monitor > > > ids. > > > > Yes, makes sense to me.

Re: [Spice-devel] [spice-gtk v2] gstaudio: Remove fixed TODOs about setting record volume

On Fri, 2017-03-10 at 09:13 +0100, Victor Toso wrote: > Hi, > > On Fri, Mar 10, 2017 at 09:09:03AM +0100, Pavel Grunt wrote: > > On Thu, 2017-03-09 at 10:13 +0100, Victor Toso wrote: > > > From: Victor Toso > > > > > > * directsoundsrc doesn't support

Re: [Spice-devel] [spice-gtk v2] gstaudio: Remove fixed TODOs about setting record volume

Hi, On Fri, Mar 10, 2017 at 09:09:03AM +0100, Pavel Grunt wrote: > On Thu, 2017-03-09 at 10:13 +0100, Victor Toso wrote: > > From: Victor Toso > > > > * directsoundsrc doesn't support IDirectSoundBuffer_SetVolume > > > > This was fixed by 1b564bfb8b0db in gst-plugins-bad,

Re: [Spice-devel] [spice-gtk v2] gstaudio: Remove fixed TODOs about setting record volume

On Thu, 2017-03-09 at 10:13 +0100, Victor Toso wrote: > From: Victor Toso > > * directsoundsrc doesn't support IDirectSoundBuffer_SetVolume > > This was fixed by 1b564bfb8b0db in gst-plugins-bad, see: > https://bugzilla.gnome.org/show_bug.cgi?id=744383 > > * pulsesrc

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for reporting availability of agent features

On Tue, 2017-02-28 at 15:07 +0100, Victor Toso wrote: > Hi, > > On Tue, Feb 28, 2017 at 02:58:58PM +0100, Pavel Grunt wrote: > > Some agent features can be disabled on the server: > >  * Copy & Paste > >  * File transfer > > > > Add the agent capability to inform about disabled file transfer. >