Signed-off-by: Jeremy White
---
.gitignore | 1 +
Makefile| 30 +-
package.json => package.json.in | 2 +-
3 files changed, 23 insertions(+), 10 deletions(-)
rename package.json => package.json.in (95%)
diff --git
Signed-off-by: Jeremy White
---
spice.html | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/spice.html b/spice.html
index f9e1af4..d744ef9 100644
--- a/spice.html
+++ b/spice.html
@@ -146,8 +146,10 @@
m.style.display = 'none';
}
Signed-off-by: Jeremy White
---
spice.css | 2 ++
spice.html | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/spice.css b/spice.css
index 4c61cb3..968ba16 100644
--- a/spice.css
+++ b/spice.css
@@ -103,6 +103,8 @@ body
-webkit-box-shadow: 5px 5px 5px rgba(0, 0, 0,
Hi Cédric,
On 2/14/19 3:44 AM, Cédric Bosdonnat wrote:
Hi Jeremy,
I fixed the missing SpiceHtml5: that was a mistake in the code rework.
Thanks for spotting it.
As for the whitespaces, I had more troubles with them. A big lot of them
was coming from dos line endings. I added a commit to
From: Olivier Fourdan
The Spice Gtk widget relies on pointer grabs to receive all pointer
events even after the pointer has left the window.
While that works on X11, on Wayland there is no active pointer grab,
so once the pointer has left the SPICE widget on Wayland, the events
are routed to
From: Olivier Fourdan
Using different GDK APIs to grab and ungrab devices leads to
undetermined behavior and can cause the cursor to remain hidden on
ungrab on Wayland because GDK Wayland backend keeps a reference of
the GdkSeat cursor.
On Wayland, use the GdkSeat API only even for ungrab, by
Hey Cédric,
I'm afraid you haven't got your line endings issue worked out yet:
git am /tmp/cedric/\[spice-html5\]\[PATCH\ v2\ 02_13\]\ dos2unix\
sha1.js\ -\ Cédric\ Bosdonnat\ \\ -\ 2019-02-14\
0344.eml
Applying: dos2unix sha1.js
error: patch failed: thirdparty/sha1.js:1
error:
Allows to catch some errors which the compiler is not able to
detect in debug mode (the default).
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/19157
(only Meson
On Mon, Feb 11, 2019 at 06:44:47AM -0500, Frediano Ziglio wrote:
> > > Hi
> > > On Fri, Feb 8, 2019 at 12:35 PM Victor Toso wrote:
> > > >
> > > > On Fri, Feb 08, 2019 at 06:11:29AM -0500, Frediano Ziglio wrote:
> > > > > >
> > > > > > New functions and macros have been added in glib 2.38 to
Acked-by: Christophe Fergeau
On Wed, Feb 13, 2019 at 02:53:15PM +, Frediano Ziglio wrote:
> The field is only assigned in do_spice_init, surely won't change
> in the meanwhile.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 22 +++---
> 1 file changed, 11
Acked-by: Christophe Fergeau
On Wed, Feb 13, 2019 at 02:53:14PM +, Frediano Ziglio wrote:
> Allows the compiler to catch some additional errors.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
On Wed, Feb 13, 2019 at 02:53:16PM +, Frediano Ziglio wrote:
> Avoid to register multiple interface with the same ID.
> This would results in issue as 2 channels would have same
"This would result in issues as 2 channels would have the same"
> (channel_type, channel_id) which should be
On Mon, Feb 11, 2019 at 06:39:09AM -0500, Frediano Ziglio wrote:
> Yes, agreed, at the moment the "ninja dist" does not work much,
> just try a git clone + meson + ninja build, it fails, you have
> to apply some workaround due to Meson bug with it.
> Also not sure how many additional dependencies
Hi
On Tue, Feb 12, 2019 at 12:35 PM Frediano Ziglio wrote:
>
>
> > From: Marc-André Lureau
> >
> > Use glib preset (from meson v0.37) to catch all our translatable
> > strings and use good default settings.
> >
> > While at it, remove the needless directory argument.
> >
> > Signed-off-by:
Hi
On Mon, Feb 11, 2019 at 6:16 PM Frediano Ziglio wrote:
>
> > >
> > > From: Marc-André Lureau
> > >
> > > - Fix the following warnings:
> > > ./spice-gtk-sections.txt:467: warning: No declaration found for
> > > SPICE_GTK_CHECK_VERSION.
> > > ./spice-gtk-sections.txt:468: warning: No
Hi,
On Thu, Feb 14, 2019 at 05:17:11AM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > One can check the following pipeline for this v2,
> >
> > https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/19133
> >
> > Cheers,
> >
>
> For the series,
> Acked-by: Frediano Ziglio
>
> Hi,
>
> One can check the following pipeline for this v2,
>
> https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/19133
>
> Cheers,
>
For the series,
Acked-by: Frediano Ziglio v2:" in the commit messages.
Frediano
> On Thu, Feb 14, 2019 at 10:10:12AM +, Victor Toso
Hi,
One can check the following pipeline for this v2,
https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/19133
Cheers,
On Thu, Feb 14, 2019 at 10:10:12AM +, Victor Toso wrote:
> From: Victor Toso
>
> Group by target build instead of command. The focus of each job is to
>
From: Victor Toso
* On a windows job-build, we don't need to install Fedora dependencies.
This change makes only one dnf install be ran per job.
* On a meson build, we should build spice-protocol with meson too.
Moving this before_script rule to each job makes all of this clear.
So, this
From: Victor Toso
Much better than playing around with shell. Logs should live for week
since the build and CI will try to always upload them.
This patch also adds the logs for tests from builds with autotools
Signed-off-by: Victor Toso
---
.gitlab-ci.yml | 20
1 file
From: Victor Toso
Group by target build instead of command. The focus of each job is to
check any regression for given platform, using 'fedora'/'windows' and
'autotools'/'meson' seems more intuitive.
By doing that we are grouping similar jobs together, this is
intentional as we are reducing the
From: Victor Toso
To keep all dependencies together. Some (small) effort was made to
distinguish what is necessary for Fedora and what is necessary for
Windows builds in order to install only required packages when job is
executing.
Note that we are adding gettext, gettext-devel and glib2-devel
From: Victor Toso
To keep track of meson builds for windows too.
Note that mingw64-meson requires to be ran inside the folder,
different from common meson. So, some extra steps were done due that.
v1 -> v2:
- Remove initial '_' from build folder filenames (Frediano);
- Always use '-' instead of
The resize_handler need to check for the existence of the message box
before computing it's size.
---
src/resize.js | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/resize.js b/src/resize.js
index 32282fd..c8d87d9 100644
--- a/src/resize.js
+++
Depending on the structure of the page, the computed mouse position was
not correct. Typically the case happend when there is no offset between
the canvas and the view area, but an offset on the view area.
The MouseEvent.offsetX and offsetY functions are now widely enough spread
to use them and
We don't want the users to rely on anything else than main.js. All the
helper functions from the other files are thus imported in main and
exported there too.
This way all the user needs to import is:
import * as SpiceHtml5 from './main.js';
---
main.js | 9 -
spice.html
---
thirdparty/sha1.js | 692 ++---
1 file changed, 346 insertions(+), 346 deletions(-)
diff --git a/thirdparty/sha1.js b/thirdparty/sha1.js
index 8118cb4..363c83d 100644
--- a/thirdparty/sha1.js
+++ b/thirdparty/sha1.js
@@ -1,346 +1,346 @@
-/*
- * A
If we round up, we may end up with a display slightly bigger than what
the window can have, thus adding scroll bars. When rounding down we
avoid this problems.
---
src/resize.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/resize.js b/src/resize.js
index
When forcing the background of the input fields, this makes them
unreadable for dark themed browsers.
---
spice.css | 1 -
1 file changed, 1 deletion(-)
diff --git a/spice.css b/spice.css
index ee1b2f3..4c61cb3 100644
--- a/spice.css
+++ b/spice.css
@@ -36,7 +36,6 @@ body
#login input
{
Add package.json needed to publish on npmjs.
---
package.json | 21 +
1 file changed, 21 insertions(+)
create mode 100644 package.json
diff --git a/package.json b/package.json
new file mode 100644
index 000..21a8b63
--- /dev/null
+++ b/package.json
@@ -0,0 +1,21 @@
+{
+
To add some more order to the folder, move the JS files into their own
src folder.
---
package.json| 2 +-
spice.html | 2 +-
spice_auto.html |
In case the user didn't provide any password, we want to prompt him for
it. Try once and if we get an permission denied error, then ask the
password and retry to connect.
---
spice_auto.html | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/spice_auto.html
---
src/main.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/main.js b/src/main.js
index be73828..4a37b55 100644
--- a/src/main.js
+++ b/src/main.js
@@ -56,6 +56,8 @@ import { resize_helper, handle_resize } from './resize.js';
** onagent (optional) If given, a function
---
enums.js | 7 ---
1 file changed, 7 deletions(-)
diff --git a/enums.js b/enums.js
index 9d31148..db13584 100644
--- a/enums.js
+++ b/enums.js
@@ -320,13 +320,6 @@ export var Constants = {
LZ_IMAGE_TYPE_XXXA: 10,
- QUIC_IMAGE_TYPE_INVALID : 0,
- QUIC_IMAGE_TYPE_GRAY: 1,
-
The disconnect() function were not checking the existence of the file
transfer area element, leading to stop the disconnect() before its end.
---
spice.html | 4 +++-
spice_auto.html | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/spice.html b/spice.html
index
Hi Jeremy,
I fixed the missing SpiceHtml5: that was a mistake in the code rework.
Thanks for spotting it.
As for the whitespaces, I had more troubles with them. A big lot of them
was coming from dos line endings. I added a commit to convert sha1.js to
unix line endings, but for some reason, git
On 2/14/19 4:40 AM, 陈炤 wrote:
Hi,
My spice server is 0.14.1 and gtk is master in the repository.
I was testing video stream. I set video-streaming to "filter" and played
a .mp4 file. The CPU usage of the gtk is about 180%. When I pause the
video, theoretically the stream should be destroyed
> Hi,
> My spice server is 0.14.1 and gtk is master in the repository.
> I was testing video stream. I set video-streaming to "filter" and played a
> .mp4 file. The CPU usage of the gtk is about 180%. When I pause the video,
> theoretically the stream should be destroyed and no data sould be
Patchew URL: https://patchew.org/QEMU/20190211141509.26964-1-lhra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH] spice: set device address and device display ID
in QXL interface
Type: series
39 matches
Mail list logo
