[Spice-devel] [spice] mjpeg: Pull more code in get_min_required_playback_delay()

2019-05-15 Thread Francois Gouget
This reduces code duplication and passing the MJpegEncoder object makes it possible to modify the playback calculation without adding more arguments. Signed-off-by: Francois Gouget --- server/mjpeg-encoder.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-)

[Spice-devel] [spice] reds: Enable mm_time adjustments on startup

2019-05-15 Thread Francois Gouget
This reinstates the reds_enable_mm_time() call in do_spice_init() that was removed by commit c541d7e29dc0. We send mm_time adjustments to the client whenever there is no audio playback. There is no audio playback on startup. Therefore mm_time_enabled must be true on startup. QED. This fixes

[Spice-devel] [spice] gstreamer-encoder: Return the average frame size as a 32 bit int

2019-05-15 Thread Francois Gouget
It makes no sense to expect average frame sizes anywhere close to 2GB. Signed-off-by: Francois Gouget --- server/gstreamer-encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c index e319eea22..6130781da 100644

[Spice-devel] [spice] gstreamer-encoder: Include encoding time in get_min_playback_delay()

2019-05-15 Thread Francois Gouget
This way all the minimum delay calculation is in one place and this makes gstreamer's implementation closer to the mjpeg one. Signed-off-by: Francois Gouget --- server/gstreamer-encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/gstreamer-encoder.c

[Spice-devel] [spice] gstreamer-encoder: Show the source fps when the system is too slow

2019-05-15 Thread Francois Gouget
The source framerate is as important as the resolution when trying to understand if the system should be fast enough to encode the video stream in real time. Signed-off-by: Francois Gouget --- server/gstreamer-encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Spice-devel] [spice] mjpeg: Remove the unused MJPEG_LOW_FPS_RATE_TH constant

2019-05-15 Thread Francois Gouget
Signed-off-by: Francois Gouget --- server/mjpeg-encoder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c index b373e8b71..1400519bb 100644 --- a/server/mjpeg-encoder.c +++ b/server/mjpeg-encoder.c @@ -38,7 +38,6 @@ static const int

Re: [Spice-devel] [PATCH spice-gtk] ci: Clean everything at the beginning

2019-05-15 Thread Victor Toso
Hi, On Wed, May 15, 2019 at 02:46:33PM +0100, Frediano Ziglio wrote: > It seems sometimes the working directory is not properly cleaned > causing some issue. > Make sure it's clean before doing a out-of-tree build (which have > problems with not cleaned directory). > > Signed-off-by: Frediano

[Spice-devel] [PATCH spice-gtk] ci: Clean everything at the beginning

2019-05-15 Thread Frediano Ziglio
It seems sometimes the working directory is not properly cleaned causing some issue. Make sure it's clean before doing a out-of-tree build (which have problems with not cleaned directory). Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Spice-devel] [PATCH spice-gtk] build-aux: remove unused file

2019-05-15 Thread Frediano Ziglio
> > From: Marc-André Lureau > > Left from previous commit. > > Signed-off-by: Marc-André Lureau Acked-by: Frediano Ziglio > --- > build-aux/gitlog-to-changelog | 191 -- > 1 file changed, 191 deletions(-) > delete mode 100755 build-aux/gitlog-to-changelog

[Spice-devel] [PATCH spice-gtk] build-aux: remove unused file

2019-05-15 Thread marcandre . lureau
From: Marc-André Lureau Left from previous commit. Signed-off-by: Marc-André Lureau --- build-aux/gitlog-to-changelog | 191 -- 1 file changed, 191 deletions(-) delete mode 100755 build-aux/gitlog-to-changelog diff --git a/build-aux/gitlog-to-changelog

Re: [Spice-devel] [spice-gtk v1 0/5] Prepare for v0.37 release

2019-05-15 Thread Frediano Ziglio
> > From: Victor Toso > > Hi, > > Due to spice-protocol 0.14.0 release, we need to roll a spice-gtk > release to make a spice-common compatible with 0.14.0 one. That is, 0.36 > and prior has the build breaking with spice-protocol 0.14.0. > > I've made README and CHANGELOG .md files like other

Re: [Spice-devel] [PATCH spice-gtk] build: Do not generate ChangeLog file

2019-05-15 Thread Victor Toso
Hi, On Wed, May 15, 2019 at 09:17:12AM +0100, Frediano Ziglio wrote: > There's already a hand written change log and people can look > at repository history. > > Signed-off-by: Frediano Ziglio Looks fine, Acked-by: Victor Toso > --- > Makefile.am | 15 --- > 1 file changed, 4

[Spice-devel] [PATCH spice-gtk] build: Do not generate ChangeLog file

2019-05-15 Thread Frediano Ziglio
There's already a hand written change log and people can look at repository history. Signed-off-by: Frediano Ziglio --- Makefile.am | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9fcb2d3b..3c607c9a 100644 --- a/Makefile.am

Re: [Spice-devel] [spice-gtk v1 3/5] Rename NEWS to CHANGELOG.md

2019-05-15 Thread Victor Toso
Hi, On Wed, May 15, 2019 at 02:24:20AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > In order to have gitlab interface to handle this file as Markdown > > and properly feed the changelog section. > > Add to EXTRA_DIST to include the renamed file to release's tarball. > > > >

Re: [Spice-devel] [spice-gtk v1 3/5] Rename NEWS to CHANGELOG.md

2019-05-15 Thread Frediano Ziglio
> > From: Victor Toso > > In order to have gitlab interface to handle this file as Markdown > and properly feed the changelog section. > Add to EXTRA_DIST to include the renamed file to release's tarball. > > Signed-off-by: Victor Toso Why not NEWS.md ? Now there are ChangeLog and