Hi,

On Wed, May 15, 2019 at 02:24:20AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <[email protected]>
> > 
> > In order to have gitlab interface to handle this file as Markdown
> > and properly feed the changelog section.
> > Add to EXTRA_DIST to include the renamed file to release's tarball.
> > 
> > Signed-off-by: Victor Toso <[email protected]>
> 
> Why not NEWS.md ?

If that is recognized by gitlab ui 'changelog' section, it could
have been. At this moment, I'd rather stick with the same name
for all components. I've renamed in spice-protocol and
linux/vdagent already

> Now there are ChangeLog and CHANGELOG.md which seems confusing
> to me

Not in spice-gtk repo but indeed there is auto generated one in
tarball, I missed. I honestly think that I'd rather stick with
manual labour of editing CHANGELOG.md every release than a file
that seems compiled from git instead.

> > ---
> >  NEWS => CHANGELOG.md | 0
> >  Makefile.am          | 1 +
> >  2 files changed, 1 insertion(+)
> >  rename NEWS => CHANGELOG.md (100%)
> > 
> > diff --git a/NEWS b/CHANGELOG.md
> > similarity index 100%
> > rename from NEWS
> > rename to CHANGELOG.md
> > diff --git a/Makefile.am b/Makefile.am
> > index df65c46..9fcb2d3 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -22,6 +22,7 @@ DISTCLEANFILES = $(pkgconfig_DATA)
> >  
> >  EXTRA_DIST =                                       \
> >     README.md                               \
> > +   CHANGELOG.md                            \
> >     meson.build                             \
> >     meson_options.txt                       \
> >     po/meson.build                          \
> 
> Frediano

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to