Re: [Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

Hi, El mié, 08-05-2019 a las 06:47 +, Victor Toso escribió: > Hi, > On Mon, May 06, 2019 at 04:06:45PM +0200, Javier Celaya wrote: > > HiEl lun, 06-05-2019 a las 10:37 +, Victor Toso escribió: > > > Hi,On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote: &g

Re: [Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

Hi El lun, 06-05-2019 a las 10:37 +, Victor Toso escribió: > Hi, > On Fri, May 03, 2019 at 06:52:00PM +0200, Javier Celaya wrote: > > A phodav server created with a NULL shared dir is valid andresults > > in an error answer to all requests of the webdav channel,instead of >

[Spice-devel] [Spice-Gtk] SpiceSession: Create webdav even with NULL shared_dir

A phodav server created with a NULL shared dir is valid and results in an error answer to all requests of the webdav channel, instead of silently ignoring them. This is better than just returning NULL from spice_session_get_webdav_server because: a) it crashes channel_webdav.c:start_client. b)

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

flexVDI/vd-agent-linuxhttps://github.com/flexVDI/vd-agent-win32They are somewhat outdated, though. Best regards > Thanks > Michal -- Javier Celaya Alastrué Chief Technology Officer

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

de with you if you are interested. Best regards > Cheers,Victor > ___Spice-devel mailing > listspice-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel --

Re: [Spice-devel] [PATCH spice-gtk v3] glib: add SpiceQmpPort helper

l is created with QEMU and/or libvirt? Thanks -- Javier Celaya Alastrué Chief Technology Officer javier.cel...@flexvdi.com +34696969959 j_cela

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

Hi again El lun, 24-09-2018 a las 08:25 +0200, Javier Celaya escribió: > Hi > > El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió: > > Hi, > > On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote: > > Hi, sorry for the late response, I was on holi

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

Hi El mié, 19-09-2018 a las 15:30 +0200, Victor Toso escribió: > Hi, > On Mon, Aug 13, 2018 at 01:44:37PM +0200, Javier Celaya wrote: > Hi, sorry for the late response, I was on holidaysEl mar, 24-07-2018 > a las 17:58 +0200, Marc-André Lureau escribió: > On Mon, Jul 16, 2018 at

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

Ping El lun, 13-08-2018 a las 13:44 +0200, Javier Celaya escribió: > Hi, sorry for the late response, I was on holidays > > El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió: > > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya > i.com> wrote:The main chan

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

Hi, El mar, 21-08-2018 a las 09:47 -0400, Frediano Ziglio escribió: > > Hi, > On Tue, Aug 21, 2018 at 02:53:59PM +0200, Javier Celaya wrote: > Yes, not against merging the fix. But if we can get it fixedinGlib, > it is matter to help other projects that port codetowindows to be

Re: [Spice-devel] [PATCH] Avoid passing libusb functions as callbacks

(), priv- > spice_device); priv->spice_device = NULL; priv- > >state = STATE_DISCONNECTED; > Frediano___Spice-devel > mailing listSpice-devel@lists.freedesktop.orghttps://lists.freedeskto > p.org/mailman/lis

Re: [Spice-devel] VDAgent and XDMCP

Hi guys, sorry I missed your answers El jue, 19-07-2018 a las 18:48 +0300, Uri Lublin escribió: > On 07/17/2018 04:05 PM, Javier Celaya wrote: > Hello list > I have a special scenario where I cannot get the VDAgent to run > correctly. We are migrating a physical setup to virtual,

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

Hi, sorry for the late response, I was on holidays El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió: > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya com> wrote:The main channel reference d->main of SpiceWidget is > initialized onconstruction. However, it is used a cou

[Spice-devel] VDAgent and XDMCP

it be executed in the Ubuntu guest too? If so, how? Thanks for your help -- Javier Celaya Alastrué Chief Technology Officer javier.cel...@flexvdi.com

[Spice-devel] [spice-gtk] Fix using NULL main channel reference

The main channel reference d->main of SpiceWidget is initialized on construction. However, it is used a couple of times before that moment while setting the default values of some properties, like resize-guest. This results in some annoying critical log messages. This commit makes sure that

[Spice-devel] [PATCH spice-gtk v2] Fix setting appsrc properties in i686 arch

The "max-bytes" property of the appsrc GStreamer element expects a 64-bit value. Calling: g_object_set(source, "max-bytes", 0, NULL); in a 32-bit architecture ends up with a wrong value, it must be cast to a gint64: g_object_set(source, "max-bytes", G_GINT64_CONSTANT(0), NULL); ---

Re: [Spice-devel] [PATCH spice-gtk] Fix setting appsrc properties in i686 arch

> - "max-bytes", 0, > > > + "max-bytes", 0LL, > > > "block", TRUE, > > > NULL); > > > gst_caps_unref(caps); > > > > I would use a gint64 ca

Re: [Spice-devel] RFC [spice-gtk] session: Allow to delay sending clipboard to the guest

haring for focused client" + > > "command-line/runtime option, with clipboard sharing enabled by > > default". > > I'd rather stick with a simple command-line & runtime option. > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/sp

Re: [Spice-devel] Fedora 25 guest no changing resolution correctly

Hi Christophe El lun, 23-10-2017 a las 14:29 +0200, Christophe Fergeau escribió: > Hey, > > On Mon, Oct 23, 2017 at 09:51:51AM +0200, Javier Celaya wrote: > > Hello list, > > > > Recently, we updated the Qemu version being used by flexVDI. We > > were > >

Re: [Spice-devel] Fedora 25 guest no changing resolution correctly

t; the guest agent, I would say it is the qxl driver, either in the > kernel or in Xorg. I'll try to see if there is something in there. > > > Thanks in advance.Frediano > --                           Javier Celaya          Chief Technology Of

Re: [Spice-devel] Fedora 25 guest no changing resolution correctly

blem with the guest, > either the agent or the kernel qxl driver. That's what I think, too. And since the message is not received by the guest agent, I would say it is the qxl driver, either in the kernel or in Xorg. I'll try to see if there is something in there. > Thanks in advance.Fr

[Spice-devel] Fedora 25 guest no changing resolution correctly

. However, we are not sure where the problem is. Spice server? Xorg? Qemu? Do you have any comments on this? Thanks in advance. --                           Javier Celaya          Chief Technology Officer

Re: [Spice-devel] Processing of rendering operations in separate thread

ormance improvement over using just one thread. > > Thanks, > Yuri > > On Fri, Nov 25, 2016 at 11:11 AM, Javier Celaya > > <javier.cel...@flexvdi.com>> wrote: > > Hello Yuri > > > > El vie, 25-11-2016 a las 01:08 +0200, Yuri Benditovich escribió

Re: [Spice-devel] Processing of rendering operations in separate thread

Hello Yuri El vie, 25-11-2016 a las 01:08 +0200, Yuri Benditovich escribió: > I'm porting to [qxl-wddm-dod] set of flexvdi changes > related to execution of 'present display only' events > in separate thread. There are 2 questions below I'd like to ask and > know your opinion. > > I see there 2

Re: [Spice-devel] [PATCH qxl-wddm-dod] Send HIDE command when pointer is not visible

El lun, 21-11-2016 a las 16:00 +0100, Javier Celaya escribió: > El vie, 18-11-2016 a las 17:07 +, Frediano Ziglio escribió: > > From: Javier Celaya <javier.cel...@flexvdi.com> > > > > This avoid having possibly 2 pointers (client and server) if > > Windo

Re: [Spice-devel] [PATCH qxl-wddm-dod] Send HIDE command when pointer is not visible

El vie, 18-11-2016 a las 17:07 +, Frediano Ziglio escribió: > From: Javier Celaya <javier.cel...@flexvdi.com> > > This avoid having possibly 2 pointers (client and server) if Windows > decide to render the mouse by itself. > This happens for instance moving windows. The

Re: [Spice-devel] [PATCH qxl-wddm-dod] Send HIDE command when pointer is not visible

own HIDE command on each > SetPointerPosition? > I'd like to check it - may be we can filter it better on > SetPointerShape? > > > On Fri, Nov 18, 2016 at 7:07 PM, Frediano Ziglio <fzig...@redhat.com> > wrote: > > From: Javier Celaya <javier.cel...@flexvdi.com

Re: [Spice-devel] QXL-WDDM-DOD v0.4-1 released

Hi, El dom, 30-10-2016 a las 10:50 +0200, Sameeh Jubran escribió: > Hi Fabio, > > I still suspect that the performance issue is caused by the mouse. As > you can see in flexVDI's repository ( > https://github.com/flexVDI/qxl-dod/blob/master/qxldod/QxlDod.h) the > function "EnablePointer" always

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 03/10] Use MmMapIoSpaceEx instead of MmMapIoSpace

El mar, 20-09-2016 a las 15:56 +0300, Dmitry Fleytman escribió: > > On 20 Sep 2016, at 15:46 PM, Frediano Ziglio > > wrote: > > > > > > > On Tue, Sep 20, 2016 at 01:14:10PM +0300, Sameeh Jubran wrote: > > > > On Mon, Sep 12, 2016 at 11:32 AM, Frediano Ziglio < > > > >

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 03/10] Use MmMapIoSpaceEx instead of MmMapIoSpace

Hi, El mar, 20-09-2016 a las 12:27 +0200, Christophe Fergeau escribió: > On Tue, Sep 20, 2016 at 01:14:10PM +0300, Sameeh Jubran wrote: > > On Mon, Sep 12, 2016 at 11:32 AM, Frediano Ziglio < > > fzig...@redhat.com> > > wrote: > > > It looks like MmMapIoSpaceEx was introduced with Windows 10 while

Re: [Spice-devel] [PATCH win-vdagent] Provide support for Windows CCD API

Hi, El mié, 03-08-2016 a las 16:36 +0300, Dmitry Fleytman escribió: > > From: Javier Celaya <javier.cel...@flexvdi.com> > > Date: Wed, Aug 3, 2016 at 12:17 PM > > Subject: Re: [Spice-devel] [PATCH win-vdagent] Provide support for > > Windows CCD API > > T

Re: [Spice-devel] [PATCH win-vdagent] Provide support for Windows CCD API

Hi, El mié, 03-08-2016 a las 04:57 -0400, Frediano Ziglio escribió: > > > > On Wed, Aug 03, 2016 at 11:35:56AM +0300, Sameeh Jubran wrote: > > > Hi, > > > > > > We've already looked into those patches (Javier's patches) and > > > tested them. > > > > Ah ok, I must have missed your answer to

[Spice-devel] [spice-gtk v2] Spice-widget: Allow smaller widget with scaling enabled

When resize-guest-to-match-window-size is disabled, the size request (minimum size) of the spice widget is set to the current guest resolution. The client window cannot be made smaller, even with scale-display enabled. This patch sets a size request of 640x480 when either

Re: [Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

Can someone review this patch, please? Thank you El 13/04/16 a las 13:42, Javier Celaya escribió: With scaling enabled, the size request of the widget must be 640x480 (the same as with resize_guest_enable) so that the widget can be actually scalled down. --- src/spice-widget.c | 25

[Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

With scaling enabled, the size request of the widget must be 640x480 (the same as with resize_guest_enable) so that the widget can be actually scalled down. --- src/spice-widget.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/spice-widget.c

Re: [Spice-devel] SPICE WDDM driver Windows 10

performance, ...) You are welcome ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel -- <http://flexvdi.com><http://flexvdi.com> Javier Celaya Softw

Re: [Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

Hi El 16/02/16 a las 15:23, Victor Toso escribió: Hi Javier, On Tue, Feb 16, 2016 at 10:50:22AM +0100, Javier Celaya wrote: El 15/02/16 a las 17:01, Javier Celaya escribió: El 15/02/16 a las 16:38, Victor Toso escribió: Hi, On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote

Re: [Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

El 15/02/16 a las 16:38, Victor Toso escribió: Hi, On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote: This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improveme

[Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

m.h, since they are actually not common to both the vdagent and the vdservice. The code for those classes is in vdagent/wddm.cpp. - Some improvements as suggested by Frediano Ziglio. Javier Celaya (2): Detect and use the new WDDM driver Use CCD API to update the WDDM display modes. Makefile

[Spice-devel] [vd-agent-win32 v2 1/2] Detect and use the new WDDM driver

When setting a new desktop resolution, detect whether the XDDM or the WDDM driver is loaded, and use the correct API. This patch is based on the one by Vadim Rozenfeld, with some improvements: - Valid for both the XDDM and the WDDM drivers. - Avoids flickering when the target resolution is the

[Spice-devel] [vd-agent-win32 v2 2/2] Use CCD API to update the WDDM display modes.

When a new custom display mode is added, the current WDDM driver notifies a disconnection and reconnection of the virtual monitor to force Windows to update the display modes. This produces an ugly effect, keeping the screen black for up to some seconds and usually not repainting it afterwards.

Re: [Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

Hi El 12/02/16 a las 12:56, Fabio Fantoni escribió: Il 10/02/2016 15:34, Fabio Fantoni ha scritto: Il 04/02/2016 17:01, Javier Celaya ha scritto: El 04/02/16 a las 16:59, Javier Celaya escribió: Hi El 04/02/16 a las 15:12, Fabio Fantoni escribió: Il 04/02/2016 13:31, Javier Celaya ha

Re: [Spice-devel] [vd-agent-win32 2/2] Use CCD API to update the WDDM display modes.

} else { vd_printf("escape failed with error 0x%08X", status); } } -- <http://flexvdi.com><http://flexvdi.com> Javier Celaya Software Engineer j <mailto:javier.cel...@flexvdi.com>avier.cel...@flexvdi.com +34

[Spice-devel] [vd-agent-win32 1/2] Detect and use the new WDDM driver

When setting a new desktop resolution, detect whether the XDDM or the WDDM driver is loaded, and use the correct API. This patch is based on the one by Vadim Rozenfeld, with some improvements: - Valid for both the XDDM and the WDDM drivers. - Avoids flickering when the target resolution is the

[Spice-devel] [vd-agent-win32 2/2] Use CCD API to update the WDDM display modes.

When a new custom display mode is added, the current WDDM driver notifies a disconnection and reconnection of the virtual monitor to force Windows to update the display modes. This produces an ugly effect, keeping the screen black for up to some seconds and usually not repainting it afterwards.

[Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

ove support of hardware pointers. The source can be found in https://github.com/flexvdi/qxl-dod, and precompiled and signed binaries can be downloaded from http://depot.flexvdi.com/guest-tools/. Javier Celaya (2): Detect and use the new WDDM driver Use CCD API to update the WDDM display mo

Re: [Spice-devel] [vd-agent-win32 0/2] Add support for WDDM driver

Hi El 04/02/16 a las 15:12, Fabio Fantoni escribió: Il 04/02/2016 13:31, Javier Celaya ha scritto: This patch set adds support for dynamic resolution changes with the WDDM driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld with some improvements: - It detects both the X

Re: [Spice-devel] [PATCH spice-gtk RFC] Call spice_marshaller_flush on message write

Hello El 15/09/15 a las 17:57, Christophe Fergeau escribió: Hey, On Fri, Jul 31, 2015 at 03:25:32PM +0200, Christophe Fergeau wrote: On Mon, Jul 27, 2015 at 03:06:12PM +0200, Javier Celaya wrote: spice_marshaller_flush must be called before writing a message to calculate pointer offsets

[Spice-devel] [PATCH spice-gtk RFC] Call spice_marshaller_flush on message write

spice_marshaller_flush must be called before writing a message to calculate pointer offsets. --- src/spice-channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/spice-channel.c b/src/spice-channel.c index c67e0aa..19db676 100644 --- a/src/spice-channel.c +++ b/src/spice-channel.c @@

Re: [Spice-devel] [PATCH spice-protocol v2 1/2] Update enums.h for preferred compression message

, but I think it's fine as I consider spice-protocol 0.12.8 as being a broken release which should not be used. Christophe Sorry, I have been out a couple of weeks. I should have thought about this problem, my apologies. Renaming looks good to me.-- [1] [2] *Javier Celaya * /Software

Re: [Spice-devel] [PATCH xf86-video-qxl] Fix drawable mm_time with KMS

El Lunes, 22 de junio de 2015 19:19:06 Christophe Fergeau escribió: I've pushed your patch with a minor formatting change. Christophe Thanks! [1] [2] *Javier Celaya * /Software Engineer / [3] j[4]_avier.celaya@flexvdi.com_ [5] +34 976 512 433 [6] @j_celaya [1] http

Re: [Spice-devel] [PATCH xf86-video-qxl] Fix drawable mm_time with KMS

El Lunes, 22 de junio de 2015 13:39:17 Christophe Fergeau escribió: Hey, On Fri, Jun 19, 2015 at 02:05:10PM +0200, Javier Celaya wrote: When KMS is enabled, the mm_time value of a QXLDrawable is undefined. This results in severe synchronization problems. This patch sets it to zero

[Spice-devel] [PATCH xf86-video-qxl] Fix drawable mm_time with KMS

When KMS is enabled, the mm_time value of a QXLDrawable is undefined. This results in severe synchronization problems. This patch sets it to zero to force the spice-server to use the local clock. --- src/qxl_surface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qxl_surface.c

[Spice-devel] [PATCH xf86-video-qxl] Fix drawable mm_time with KMS

When KMS is enabled, the mm_time value of a QXLDrawable is undefined. This results in severe synchronization problems. This patch sets it to zero to force the spice-server to use the local clock. --- src/qxl_surface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qxl_surface.c

Re: [Spice-devel] [PATCH spice-server v2 1/2] Use image compress constants from spice-protocol

El Jueves, 11 de junio de 2015 16:44:51 Christophe Fergeau escribió: On Mon, Jun 01, 2015 at 04:48:15PM +0200, Javier Celaya wrote: diff --git a/server/spice-server.h b/server/spice-server.h index bca0da6..5880ff0 100644 --- a/server/spice-server.h +++ b/server/spice-server.h @@ -67,20

Re: [Spice-devel] When will next version of SPICE Server be released?

. Maybe, with a numbered version that supports the SPICE_IMAGE_COMPRESS_LZ4 constant, they will accept it.-- [1] [2] *Javier Celaya * /Software Engineer / [3] j[4]_avier.celaya@flexvdi.com_ [5] +34 976 512 433 [6] @j_celaya [1] http://www.flexvdi.com/img/general/logo.flexvdi.png [2

Re: [Spice-devel] When will next version of SPICE Server be released?

El Lunes, 8 de junio de 2015 17:12:21 Christophe Fergeau escribió: On Mon, Jun 08, 2015 at 05:02:29PM +0200, Javier Celaya wrote: Good feature indeed In fact, my patch to the qemu list to include lz4 in the -spice command line option has not prospered yet. Maybe, with a numbered version

Re: [Spice-devel] [PATCH spice-server v2 2/2] Handle preferred image compression messages

El Miércoles, 3 de junio de 2015 15:29:34 Christophe Fergeau escribió: On Tue, Jun 02, 2015 at 06:26:09PM +0200, Javier Celaya wrote: El Martes, 2 de junio de 2015 14:33:35 Christophe Fergeau escribió: My last remaining comment about this patch is that now the client can force the server

[Spice-devel] [PATCH spice-gtk v4 2/3] Add a preferred-compression program option

--- gtk/spice-option.c | 37 + 1 file changed, 37 insertions(+) diff --git a/gtk/spice-option.c b/gtk/spice-option.c index 958e03c..463a3e3 100644 --- a/gtk/spice-option.c +++ b/gtk/spice-option.c @@ -41,6 +41,7 @@ static gint cache_size = 0; static gint

[Spice-devel] [PATCH spice-gtk v4 3/3] Display: Send a preferred compression message on init.

If the user prefers a specific compression algorithm, report it when setting up the display channel. --- gtk/channel-display.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index efe2259..5dd3f71 100644 --- a/gtk/channel-display.c

Re: [Spice-devel] [PATCH spice-gtk v3 2/3] Cmdline: Get the preferred-compression property

.-- [1] [2] *Javier Celaya * /Software Engineer / [3] j[4]_avier.celaya@flexvdi.com_ [5] +34 976 512 433 [6] @j_celaya [1] http://www.flexvdi.com/img/general/logo.flexvdi.png [2] http://flexvdi.com [3] http://flexvdi.com/signature/mail.png [4] mailto:javier.cel...@flexvdi.com [5] http

Re: [Spice-devel] [PATCH spice-gtk v3 3/3] Display: Send a preferred compression message on init.

shouldn't check it at all... After all, there is no check for the other two properties in that function (cache-size and glz-window-size). I would rather remove the preferred_compression SPICE_IMAGE_COMPRESS_ENUM_END condition.-- [1] [2] *Javier Celaya * /Software Engineer / [3] j[4

Re: [Spice-devel] [PATCH spice-server v2 2/2] Handle preferred image compression messages

to the one it gets from command-line or _AUTO_GLZ by default. There is no way to know from within spice-server whether the admin specified an image compression method or not, without patching QEMU too. You may want to delay this patch until we come up with a better solution. [1] [2] *Javier

Re: [Spice-devel] [PATCH v2 2/3] Cmdline: Get the preferred-compression property

that gtk/spice-cmdline.c was only used by spicy.-- [1] [2] *Javier Celaya * /Software Engineer / [3] j[4]_avier.celaya@flexvdi.com_ [5] +34 976 512 433 [6] @j_celaya [1] http://www.flexvdi.com/img/general/logo.flexvdi.png [2] http://flexvdi.com [3] http://flexvdi.com/signature/mail.png [4

Re: [Spice-devel] [PATCH v2 3/3] Display: Send a preferred compression message on init.

El Viernes, 29 de mayo de 2015 18:18:15 Christophe Fergeau escribió: On Mon, Apr 27, 2015 at 10:05:17AM +0200, Javier Celaya wrote: If the user prefers a specific compression algorithm, report it when setting up the display channel. ACK. Christophe I just realized that a server

[Spice-devel] [PATCH spice-server v2 0/2] Handle client's preferred image compression

Handle the message with the preferred image compression method reported by the client. The spice-common commit has been removed from the first patch to avoid conflicts, fix it as needed. Javier Celaya (2): Use image compress constants from spice-protocol Handle preferred image compression

[Spice-devel] [PATCH spice-server v2 1/2] Use image compress constants from spice-protocol

--- server/red_dispatcher.c | 2 +- server/red_dispatcher.h | 2 +- server/red_worker.c | 8 server/red_worker.h | 2 +- server/reds.c | 8 server/spice-server.h | 15 ++- spice-common| 2 +- 7 files changed, 14 insertions(+), 25

[Spice-devel] [PATCH spice-server v2 2/2] Handle preferred image compression messages

--- server/red_dispatcher.c | 1 + server/red_worker.c | 25 + 2 files changed, 26 insertions(+) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 4965a97..312b4f7 100644 --- a/server/red_dispatcher.c +++ b/server/red_dispatcher.c @@ -1154,6

[Spice-devel] [PATCH spice-gtk v3 1/3] Spice-session: Add preferred-compression property.

Also, depend on the spice-common commit that introduces the SpiceImageCompress enum. --- gtk/spice-session.c | 58 + spice-common| 2 +- 2 files changed, 59 insertions(+), 1 deletion(-) diff --git a/gtk/spice-session.c

[Spice-devel] [PATCH spice-gtk v3 0/3] Report the preferred compression method to server

This patch set allows the client to report its preferred image compression method to the server. It is read from command line and sent when the display channel is set up, if the server supports it. Javier Celaya (3): Spice-session: Add preferred-compression property. Cmdline: Get

[Spice-devel] [PATCH spice-protocol v2 0/2] Add preferred compression enums and capability.

Javier Celaya (2): Update enums.h for preferred compression message Add a preferred compression capability spice/enums.h| 14 ++ spice/protocol.h | 1 + 2 files changed, 15 insertions(+) -- 1.9.3 ___ Spice-devel mailing list

[Spice-devel] [PATCH spice-gtk v3 2/3] Cmdline: Get the preferred-compression property

--- gtk/spice-option.c | 37 + 1 file changed, 37 insertions(+) diff --git a/gtk/spice-option.c b/gtk/spice-option.c index 958e03c..463a3e3 100644 --- a/gtk/spice-option.c +++ b/gtk/spice-option.c @@ -41,6 +41,7 @@ static gint cache_size = 0; static gint

[Spice-devel] [PATCH spice-gtk v3 3/3] Display: Send a preferred compression message on init.

If the user prefers a specific compression algorithm, report it when setting up the display channel. --- gtk/channel-display.c | 12 1 file changed, 12 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index efe2259..b440f9b 100644 --- a/gtk/channel-display.c

[Spice-devel] [PATCH spice-protocol v2 1/2] Update enums.h for preferred compression message

--- spice/enums.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index 18e2f74..6a0ab0b 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -181,6 +181,19 @@ typedef enum SpiceImageType { SPICE_IMAGE_TYPE_ENUM_END } SpiceImageType; +typedef

[Spice-devel] [PATCH spice-protocol v2 2/2] Add a preferred compression capability

--- spice/protocol.h | 1 + 1 file changed, 1 insertion(+) diff --git a/spice/protocol.h b/spice/protocol.h index bea376c..d3c5962 100644 --- a/spice/protocol.h +++ b/spice/protocol.h @@ -134,6 +134,7 @@ enum { SPICE_DISPLAY_CAP_A8_SURFACE, SPICE_DISPLAY_CAP_STREAM_REPORT,

Re: [Spice-devel] [PATCH v2] Proto: Add preferred compression message and constants.

http://lists.freedesktop.org/archives/spice-devel/2015-April/019541.html You are right, I forgot to remove the submodule update, sorry. Thank you. Best, Victor Toso [1] [2] *Javier Celaya * /Software Engineer / [3] j[4]_avier.celaya@flexvdi.com_ [5] +34 976 512 433 [6] @j_celaya

Re: [Spice-devel] [PATCH v2] Proto: Add preferred compression message and constants.

algorithm. This patch also promotes the SPICE_IMAGE_COMPRESS_* constants so that they are available from both the server and the client. Any other comment on this patch (and the rest of the set)? Do you find it useful/less? Can anyone commit them? Thanks-- [1] [2] *Javier Celaya * /Software

[Spice-devel] [PATCH v2 3/3] Display: Send a preferred compression message on init.

If the user prefers a specific compression algorithm, report it when setting up the display channel. --- gtk/channel-display.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index efe2259..b32e8fc 100644 --- a/gtk/channel-display.c

[Spice-devel] [PATCH v2 2/3] Cmdline: Get the preferred-compression property

--- gtk/spice-cmdline.c | 48 1 file changed, 48 insertions(+) diff --git a/gtk/spice-cmdline.c b/gtk/spice-cmdline.c index 8619b57..c52b1a2 100644 --- a/gtk/spice-cmdline.c +++ b/gtk/spice-cmdline.c @@ -27,6 +27,39 @@ static char *port; static

[Spice-devel] [PATCH v2] Proto: Add preferred compression message and constants.

When accessing a virtual desktop from different devices, some may have different image compression requirements, e.g. slow devices may prefer the faster LZ4 over GLZ. This message instructs the server to switch the image compression algorithm. This patch also promotes the SPICE_IMAGE_COMPRESS_*

[Spice-devel] [PATCH 0/2] Set the image compression reported by client

This patch set uses the SpiceImageCompress enum from spice-common instead of spice_image_compression_t, and handles the preferred image compression message from the client. Javier Celaya (2): Use image compress constants from spice-protocol Handle preferred image compression messages server

[Spice-devel] [PATCH 0/3] Report the preferred compression method to server

This patch allows the client to report its preferred image compression method to the server. It is read from command line and sent when the display channel is set up. Javier Celaya (3): Spice-session: Add preferred-compression property. Cmdline: Get the preferred-compression property

[Spice-devel] [PATCH 3/3] Display: Send a preferred compression message on init.

If the user prefers a specific compression algorithm, report it when setting up the display channel. --- gtk/channel-display.c | 8 1 file changed, 8 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index efe2259..6f5fb5f 100644 --- a/gtk/channel-display.c +++

[Spice-devel] [PATCH 2/2] Handle preferred image compression messages

--- server/red_worker.c | 25 + 1 file changed, 25 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index 29d6d6d..af2f1d6 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -10276,6 +10276,27 @@ static int

[Spice-devel] [PATCH 2/3] Cmdline: Get the preferred-compression property

--- gtk/spice-cmdline.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/gtk/spice-cmdline.c b/gtk/spice-cmdline.c index 8619b57..dd64264 100644 --- a/gtk/spice-cmdline.c +++ b/gtk/spice-cmdline.c @@ -27,6 +27,34 @@ static char *port; static char

[Spice-devel] [PATCH 1/3] Spice-session: Add preferred-compression property.

Also, depend on the spice-common commit that introduces the SpiceImageCompress enum. --- gtk/spice-session.c | 26 ++ spice-common| 2 +- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index

[Spice-devel] [PATCH 1/2] Use image compress constants from spice-protocol

--- server/red_dispatcher.c | 2 +- server/red_dispatcher.h | 2 +- server/red_worker.c | 8 server/red_worker.h | 2 +- server/reds.c | 8 server/spice-server.h | 15 ++- spice-common| 2 +- 7 files changed, 14 insertions(+), 25

[Spice-devel] [PATCH] Proto: Add preferred compression message and constants.

When accessing a virtual desktop from different devices, some may have different image compression requirements, e.g. slow devices may prefer the faster LZ4 over GLZ. This message instructs the server to switch the image compression algorithm. This patch also promotes the SPICE_IMAGE_COMPRESS_*

[Spice-devel] [PATCH] Update enums.h for preferred compression message

--- spice/enums.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index 18e2f74..6a0ab0b 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -181,6 +181,19 @@ typedef enum SpiceImageType { SPICE_IMAGE_TYPE_ENUM_END } SpiceImageType; +typedef

Re: [Spice-devel] [PATCH spice-gtk] Fix: remove dependency cycle

El Lunes, 16 de febrero de 2015 11:23:54 Christophe Fergeau escribió: I'll adjust that before pushing unless you object. Christophe Perfect, go for it. -- Javier ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH spice-gtk] Fix: remove dependency cycle

El Lunes, 16 de febrero de 2015 10:34:17 Christophe Fergeau escribió: Hey, On Wed, Feb 11, 2015 at 03:34:13PM +0100, Javier Celaya wrote: channel-port.h includes spice-client.h, that includes channel-webdav.h, that includes channel-port.h again. It's enough if channel-port.h includes

[Spice-devel] [PATCH spice-gtk] Fix: remove dependency cycle

channel-port.h includes spice-client.h, that includes channel-webdav.h, that includes channel-port.h again. It's enough if channel-port.h includes spice-channel.h --- gtk/channel-port.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/channel-port.h b/gtk/channel-port.h

[Spice-devel] [PATCH] LZ4: Do not include arpa/inet.h in Windows builds

--- common/canvas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/canvas_base.c b/common/canvas_base.c index fb35c4a..1c96c9c 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -27,7 +27,9 @@ #include math.h #ifdef USE_LZ4 +#ifndef WIN32 #include arpa/inet.h

Re: [Spice-devel] [PATCH 6/6] LZ4: Include winsock.h when compiling for Windows

El Martes, 3 de febrero de 2015 11:54:27 Christophe Fergeau escribió: Hey, Are you sure this one is required? I did not get warnings when using ntohl without including winsock.h first. Christophe Ok, maybe it is included by some other header... But in any case the include of arpa/inet.h

Re: [Spice-devel] [PATCH 4/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

Hello El Viernes, 30 de enero de 2015 11:36:08 Christophe Fergeau escribió: On Wed, Jan 28, 2015 at 11:49:47AM +0100, Javier Celaya wrote: Fix the row alignment for 16/24 bpp images when it is not in a 32bit boundary. This is needed for 16bpp images when the width is an odd number

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

El Lunes, 26 de enero de 2015 17:00:04 Javier Celaya escribió: El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió: On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about

[Spice-devel] [PATCH 2/6] LZ4: Adjust reading the top_down flag

Adjust the way the top_down flag is read to the corresponding change in the wire protocol. --- common/canvas_base.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index cfbba5e..0dd438a 100644 --- a/common/canvas_base.c +++

[Spice-devel] [PATCH 3/6] LZ4: Decode the image format from the stream

--- common/canvas_base.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 0dd438a..d2162f2 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -557,6 +557,8 @@ static pixman_image_t

[Spice-devel] [PATCH 4/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

Fix the row alignment for 16/24 bpp images when it is not in a 32bit boundary. This is needed for 16bpp images when the width is an odd number, and for the future support of 24bpp images. --- common/canvas_base.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff

[Spice-devel] [PATCH 1/6] LZ4: Fix output buffer size

--- common/canvas_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index a1bfc27..cfbba5e 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -551,7 +551,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase

  1   2   >