Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-15 Thread Frediano Ziglio
> > > On 15 Feb 2018, at 11:59, Frediano Ziglio wrote: > > > >>> > >>> On 15 Feb 2018, at 10:07, Christophe Fergeau wrote: > >>> > >>> On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-15 Thread Christophe de Dinechin
> On 15 Feb 2018, at 11:59, Frediano Ziglio wrote: > >>> >>> On 15 Feb 2018, at 10:07, Christophe Fergeau wrote: >>> >>> On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote: > On 14 Feb 2018, at 17:34, Christophe

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-15 Thread Frediano Ziglio
> > > On 15 Feb 2018, at 10:07, Christophe Fergeau wrote: > > > > On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote: > >> > >> > >>> On 14 Feb 2018, at 17:34, Christophe Fergeau wrote: > >>> > >>> On Wed, Feb 14, 2018 at

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-15 Thread Christophe de Dinechin
> On 15 Feb 2018, at 10:07, Christophe Fergeau wrote: > > On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote: >> >> >>> On 14 Feb 2018, at 17:34, Christophe Fergeau wrote: >>> >>> On Wed, Feb 14, 2018 at 10:45:56AM -0500,

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-15 Thread Christophe Fergeau
On Wed, Feb 14, 2018 at 10:29:25PM +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at 17:34, Christophe Fergeau wrote: > > > > On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote: > >>> > >>> Shouldn't this go with a Makefile rule? A few lines in

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-14 Thread Christophe de Dinechin
> On 14 Feb 2018, at 17:34, Christophe Fergeau wrote: > > On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote: >>> >>> Shouldn't this go with a Makefile rule? A few lines in the log what this >>> is about, what is the goal for having this file, ... would not

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-14 Thread Christophe Fergeau
On Wed, Feb 14, 2018 at 10:45:56AM -0500, Frediano Ziglio wrote: > > > > Shouldn't this go with a Makefile rule? A few lines in the log what this > > is about, what is the goal for having this file, ... would not hurt. > > > > Christophe > > > > I think this file is supposed to just help

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-14 Thread Frediano Ziglio
> > Shouldn't this go with a Makefile rule? A few lines in the log what this > is about, what is the goal for having this file, ... would not hurt. > > Christophe > I think this file is supposed to just help developers so should not be in the Makefile. I think you mean that the intention

Re: [Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-14 Thread Christophe Fergeau
Shouldn't this go with a Makefile rule? A few lines in the log what this is about, what is the goal for having this file, ... would not hurt. Christophe On Thu, Feb 08, 2018 at 12:25:21PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > >

[Spice-devel] [PATCH v3 01/11] Add .clang-format with defaults matching what's specified in the style guide

2018-02-08 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- .clang-format | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 .clang-format diff --git a/.clang-format b/.clang-format new file mode 100644 index