Re: [Spice-devel] [PATCH v4 07/17] sound: Convert SndChannelClient to GObject

2016-12-01 Thread Jonathon Jongsma
On Thu, 2016-12-01 at 17:21 +0100, Christophe Fergeau wrote: > On Thu, Dec 01, 2016 at 11:24:29AM +, Frediano Ziglio wrote: > > > > This patch is quite huge but have some benefits: > > - reduce dependency (DummyChannel* and some RedChannelClient > > internals); > > - reuse RedChannelClient

Re: [Spice-devel] [PATCH v4 07/17] sound: Convert SndChannelClient to GObject

2016-12-01 Thread Christophe Fergeau
On Thu, Dec 01, 2016 at 11:24:29AM +, Frediano Ziglio wrote: > This patch is quite huge but have some benefits: > - reduce dependency (DummyChannel* and some RedChannelClient internals); > - reuse RedChannelClient instead of reading from the RedsStream > directly. > > You can see that

[Spice-devel] [PATCH v4 07/17] sound: Convert SndChannelClient to GObject

2016-12-01 Thread Frediano Ziglio
This patch is quite huge but have some benefits: - reduce dependency (DummyChannel* and some RedChannelClient internals); - reuse RedChannelClient instead of reading from the RedsStream directly. You can see that SndChannelClient has much less field as the code to read/write from/to client is

[Spice-devel] [PATCH v4 07/17] sound: Convert SndChannelClient to GObject

2016-12-01 Thread Frediano Ziglio
This patch is quite huge but have some benefits: - reduce dependency (DummyChannel* and some RedChannelClient internals); - reuse RedChannelClient instead of reading from the RedsStream directly. You can see that SndChannelClient has much less field as the code to read/write from/to client is