Re: [Spice-devel] aspeed: video frames pass-through

18.11.2015, 17:46, "Christophe Fergeau" : >> >>  May be better to use memcpy? It is align-safe. > > Oh yeah could definitely work better, not very familiar with this kind of > problems > :) memcpy works like a charm! Visually I don't see any performance regression on our

Re: [Spice-devel] aspeed: video frames pass-through

On Wed, Nov 18, 2015 at 06:29:23PM +0300, Anton D. Kachalov wrote: > > > 18.11.2015, 17:46, "Christophe Fergeau" : > >> > >>  May be better to use memcpy? It is align-safe. > > > > Oh yeah could definitely work better, not very familiar with this kind of > > problems > > :)

Re: [Spice-devel] aspeed: video frames pass-through

Hello. consume_* in parse_msgc_display_init() and a number of: spice_marshaller_add_int32 spice_marshaller_add_uint16 spice_marshaller_add_uint64 spice_marshaller_add_uint32 in marshallers' functions like spice_marshall_msg_display_draw_copy() So, for the packed structs, there are always

Re: [Spice-devel] aspeed: video frames pass-through

Hi. 18.11.2015, 17:06, "Christophe Fergeau" : > Hey, [...] > By 'alignment-safe', I mean: > static uint16_t read_uint16(unsigned uint16_t *ptr) Do you mean "uint8_t *ptr"? > { > return (ptr[1] << 8) || ptr[0]; > } > (or a macro version of it) Would compiler generate

Re: [Spice-devel] aspeed: video frames pass-through

Hey, On Wed, Nov 18, 2015 at 04:03:16PM +0300, Anton D. Kachalov wrote: > Hello. > > consume_* in parse_msgc_display_init() > > and a number of: > > spice_marshaller_add_int32 > spice_marshaller_add_uint16 > spice_marshaller_add_uint64 > spice_marshaller_add_uint32 > Ah right, these would

Re: [Spice-devel] aspeed: video frames pass-through

18.11.2015, 17:29, "Anton D. Kachalov" : > Hi. > > > struct { >   uint16_t foo; >   uint32_t bar; > } > > What alignment would be on "bar" access (ptr address input for read_uint32)? This might work: uint32_t read_uint32(uint8_t *ptr) { return ptr[3] << 24 | ... |

Re: [Spice-devel] aspeed: video frames pass-through

On Wed, Nov 18, 2015 at 05:29:32PM +0300, Anton D. Kachalov wrote: > Hi. > > 18.11.2015, 17:06, "Christophe Fergeau" : > > Hey, > [...] > > By 'alignment-safe', I mean: > > static uint16_t read_uint16(unsigned uint16_t *ptr) > > Do you mean "uint8_t *ptr"? > > > { > >

Re: [Spice-devel] aspeed: video frames pass-through

On Thu, Nov 12, 2015 at 08:29:07PM +0300, Anton D. Kachalov wrote: > Hello. > > 03.11.2015, 19:17, "Anton D. Kachalov" : > > 03.11.2015, 18:43, "Christophe Fergeau" : > >>  Hmm, not very familiar with ARM, and not sure this has seen a lot of > >>  

Re: [Spice-devel] aspeed: video frames pass-through

Hello. 03.11.2015, 19:17, "Anton D. Kachalov" : > 03.11.2015, 18:43, "Christophe Fergeau" : >>  Hmm, not very familiar with ARM, and not sure this has seen a lot of >>  testing. Maybe getting a backtrace would shed more light? > > I'll try rewritten

Re: [Spice-devel] aspeed: video frames pass-through

On Tue, Oct 27, 2015 at 08:42:03PM +0300, Anton D. Kachalov wrote: > Hello, > > sorry for the previous HTML-only message. > > I'm trying to add support for Aspeed SoC (AST2150/2300/2400) raw video > streaming to Spice (this SoC might be found in the most server's BMC). > It is a kind of a

Re: [Spice-devel] aspeed: video frames pass-through

03.11.2015, 18:43, "Christophe Fergeau" : > On Tue, Oct 27, 2015 at 08:42:03PM +0300, Anton D. Kachalov wrote: >>  Hello, >> > > If I understand correctly, the encoding/decoding is all done in > hardware? Encoding & compressing is done in hardware while decompressing have to

Re: [Spice-devel] aspeed: video frames pass-through

On Tue, 27 Oct 2015, Anton D. Kachalov wrote: [...] > I've started with Francois Gouget's https://github.com/fgouget/spice > repo with GStreamer support. It were my first steps with Spice. I've > added one more encoder: "aspeed" and one more image type: "AST" and > tries to pass fake image

[Spice-devel] aspeed: video frames pass-through

Hello, sorry for the previous HTML-only message. I'm trying to add support for Aspeed SoC (AST2150/2300/2400) raw video streaming to Spice (this SoC might be found in the most server's BMC). It is a kind of a compressed data with screen change detection algo. Right after Video streaming