Hi,
On Wed, Oct 19, 2016 at 03:40:18PM -0500, Jonathon Jongsma wrote:
> On Tue, 2016-10-18 at 14:59 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > This header is auto generated from spice_codegen.py tool in
> > spice-common repository and thus, it changes what was
Acked-by: Jonathon Jongsma
On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc.c | 1 +
> server/main-channel.c | 3 ++-
> server/red-qxl.c | 1 +
> server/reds.c | 1 +
>
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/red-channel.h
---
I need this additional change to get master to compile
server/red-qxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index e517b41..fa51195 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -36,6 +36,7 @@
#include "reds.h"
#include
Odd. Must have been a refactoring mixup.
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Avoid having duplication and desynchronisation.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel-client.c
On Tue, 2016-10-18 at 14:59 +0200, Victor Toso wrote:
> From: Victor Toso
>
> This header is auto generated from spice_codegen.py tool in
> spice-common repository and thus, it changes what was included
> manually.
I'm afraid I don't really understand this description.
>
Hi,
On Wed, Oct 19, 2016 at 06:26:18PM +0200, Francois Gouget wrote:
> On Wed, 19 Oct 2016, Victor Toso wrote:
> [...]
> > > But I don't think this necessarily impacts gstvideo_has_codec() if
> > > implemented using create_gstreamer_decoder() whereas with your code it
> > > will necessarily be
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Make move symmetric red_monitors_config_item_new and
> red_monitors_config_item_free.
This sentence is a little bit confusing. Perhaps:
"This makes red_monitors_config_item_new() and
red_monitors_config_item_free() symmetric"?
On Tue, 2016-10-18 at 12:17 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/inputs-channel.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/inputs-channel.h b/server/inputs-channel.h
> index 4bae61f..26569fa 100644
> ---
Personally I'd rather keep this sort of thing as a downstream patch. It
makes things less consistent. I'd like to be able to assume that if I
include main-channel-client.h, the MainChannelClient typedef will be
defined, for example.
On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote:
>
OK. Perhaps a bit more explicit description would be useful, since I
was also slightly confused. something like:
Allow both compiled and non-compiled tests to be used with "make
check". Compiled tests should be added to check_PROGRAMS, and scripts
that do not need to be built should be added to
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/red-worker.c
I think that a commit saying "Make X safe" really deserves a bit longer
description about what was unsafe, whether it's easily reproducible,
what the impact of the bug is, etc.
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
From: Victor Toso
Move declaration of variable to top and break big g_strdup_printf
line.
Signed-off-by: Victor Toso
---
src/channel-display-gst.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git
From: Victor Toso
v2:
- static assert in "channel-display-gst: use a static array for gst options" to
check if array is in the correct size (frediano)
- Don't need to use '&' to set the callback for GstAppSinkCallbacks in
"channel-display-gst: style changes in
From: Victor Toso
Signed-off-by: Victor Toso
---
src/channel-display-gst.c | 80 ++-
1 file changed, 44 insertions(+), 36 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> Acked-by: Christophe Fergeau
> ---
> Makefile.am | 2 +-
> configure.ac | 1 +
>
I assume this is fixing a warning?
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/image-encoders.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> spice_new return directly the correct type.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
Acked-by: Jonathon Jongsma
On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/image-encoders.h | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git
Acked-by: Jonathon Jongsma
On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote:
> These are already defined in red-channel.h which is included in
> red-channel-client.h header.
>
> Signed-off-by: Frediano Ziglio
> ---
>
>
> From: Victor Toso
>
> Move declaration of variable to top and break big g_strdup_printf
> line.
>
> Signed-off-by: Victor Toso
> ---
> src/channel-display-gst.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff
Hey,
On Tue, 2016-10-18 at 23:27 +0200, Victor Toso wrote:
> From: Victor Toso
>
> If gst_init() fails, gstvideo_init() will warn once about the issue
> and never attempt to try again, which is probably fine.
>
> All the other APIs that might be called such as
>
Hey,
On Wed, Oct 19, 2016 at 12:42:34PM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Oct 19, 2016 at 12:11:53PM +0200, Francois Gouget wrote:
> > On Tue, 18 Oct 2016, Victor Toso wrote:
> > [...]
> > > +elements = g_strsplit(gst_opts[codec_type].dec_name, "!", 0);
> >
> > This would not work
On Wed, 19 Oct 2016, Pavel Grunt wrote:
> Hi,
>
> this should be the last patch to avoid any compilation issues
Note that this does not create any compilation errors, only compilation
warnings. So putting it first will not break compilation and will show
the warnings being fixed as each other
On Tue, 18 Oct 2016, Victor Toso wrote:
[...]
> +elements = g_strsplit(gst_opts[codec_type].dec_name, "!", 0);
This would not work if one of the elements takes options.
(not the case right now but if we can keep the option open)
> +for (i = 0; elements[i] != NULL; i++) {
> +
>
> From: Victor Toso
>
> Signed-off-by: Victor Toso
> ---
> src/channel-display-gst.c | 78
> +--
> 1 file changed, 42 insertions(+), 36 deletions(-)
>
> diff --git a/src/channel-display-gst.c
Hi,
On Wed, Oct 19, 2016 at 12:11:53PM +0200, Francois Gouget wrote:
> On Tue, 18 Oct 2016, Victor Toso wrote:
> [...]
> > +elements = g_strsplit(gst_opts[codec_type].dec_name, "!", 0);
>
> This would not work if one of the elements takes options.
> (not the case right now but if we can keep
Hi,
On Wed, Oct 19, 2016 at 06:28:33AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > Signed-off-by: Victor Toso
> > ---
> > src/channel-display-gst.c | 78
> > +--
> > 1 file changed, 42
On Wed, 2016-10-19 at 13:31 +0200, Pavel Grunt wrote:
> Hey,
>
> On Tue, 2016-10-18 at 23:27 +0200, Victor Toso wrote:
> > From: Victor Toso
> >
> > If gst_init() fails, gstvideo_init() will warn once about the
> > issue
> > and never attempt to try again, which is probably
Hi,
On Tue, Oct 18, 2016 at 07:47:12PM +0200, Francois Gouget wrote:
> Third parties are not supposed to use spice_audio_new() anymore, but
> internally it is used to implement its replacement, spice_audio_get().
>
> Signed-off-by: Francois Gouget
This was deprecated in
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index 17a06e8..8580a9a 100644
--- a/server/tests/Makefile.am
+++
Hi,
On Wed, Oct 19, 2016 at 04:23:23PM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Oct 19, 2016 at 02:49:38PM +0100, Frediano Ziglio wrote:
> > Add an utility to make possible to check various features of
> > VideoEncoder.
> > 2 GStreamer plugins are used in a chain like this:
> > (1) input
Hi,
On Wed, Oct 19, 2016 at 06:26:17AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > Move declaration of variable to top and break big g_strdup_printf
> > line.
> >
> > Signed-off-by: Victor Toso
> > ---
> >
The test was not executed because G_N_ELEMENTS is 0 for the pointer
---
tests/session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/session.c b/tests/session.c
index 09856b3..7ed4a41 100644
--- a/tests/session.c
+++ b/tests/session.c
@@ -170,7 +170,7 @@ static void
Hi,
On Tue, Oct 18, 2016 at 07:46:34PM +0200, Francois Gouget wrote:
>
> This is another take on trying to clean up the deprecation warning
> situation in Spice-Gtk.
Many thanks :)
>
> Let me know if it goes in the right direction.
>
>
> With this patchset deprecation warnings are enabled again
Sorry, what do you mean ?
On Wed, 2016-10-19 at 14:49 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/Makefile.am | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/server/tests/Makefile.am
Add an utility to make possible to check various features of
VideoEncoder.
2 GStreamer plugins are used in a chain like this:
(1) input pipeline -> (2) video encoder -> (3) output pipeline
While converting output from (1) is compared with output of (3)
making sure the streaming is working
Hi,
On Wed, Oct 19, 2016 at 02:57:39PM +0200, Victor Toso wrote:
> I recall that Christophe commented about the spice macros but I failed
> to find it.
Just for reference:
https://lists.freedesktop.org/archives/spice-devel/2016-September/031601.html
signature.asc
Description: PGP signature
>
> Sorry, what do you mean ?
>
Currently all the executable that compose the test list
must be compiled.
This as check_PROGRAMS == TESTS.
If you have
TESTS = test1 test2
check_PROGRAMS = test1
"make check" will compile test1 and run test1 and test2 as
tests. But if you add test2 to
Hi,
On Wed, Oct 19, 2016 at 02:49:38PM +0100, Frediano Ziglio wrote:
> Add an utility to make possible to check various features of
> VideoEncoder.
> 2 GStreamer plugins are used in a chain like this:
> (1) input pipeline -> (2) video encoder -> (3) output pipeline
> While converting output
This patch solves this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1314600
After applying this patch the "UEFI GOP mode" test passed successfully but
only when setting the preferred boot resolution to 1024x768 in the OVMF
platform configuration screen.
Sameeh Jubran (1):
Indicate all Qxl
Currently the qxl device with id 0 is being set as an internal display
while all the rest are set as VGA connector. This commit solves this
issue that was discussed in detail here:
https://bugzilla.redhat.com/show_bug.cgi?id=1314600
Signed-off-by: Sameeh Jubran
---
Signed-off-by: Francois Gouget
---
src/spice-channel.h | 5 +++--
src/spice-util.h | 2 --
src/usb-device-manager.h | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/spice-channel.h b/src/spice-channel.h
index 3b0bffb..aa0d9cb 100644
For Spice-gtk most deprecation issues come from changes outside Spice
(GLib) and thus should not be treated as errors to not break
compilation for users who have newer third-party libraries.
However they must be visible otherwise Spice developers will not be
aware of them and thus will not fix
Signed-off-by: Francois Gouget
---
src/spice-widget.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 82adacf..f0681d6 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -812,6 +812,9 @@
Signed-off-by: Francois Gouget
---
src/spice-gtk-session.c | 5 +
src/spice-widget-egl.c | 3 +++
src/spice-widget.c | 6 ++
3 files changed, 14 insertions(+)
diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
index 3e0ec74..7ec2a57 100644
---
Signed-off-by: Francois Gouget
---
src/spicy-connect.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/spicy-connect.c b/src/spicy-connect.c
index 915eb06..39555a6 100644
--- a/src/spicy-connect.c
+++ b/src/spicy-connect.c
@@
Spice-Gtk requires GTK+ > 3.12 which has gtk_button_box_new().
Signed-off-by: Francois Gouget
---
src/spicy-connect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spicy-connect.c b/src/spicy-connect.c
index a1d895a..915eb06 100644
---
Spice-Gtk requires GTK+ > 3.12 which has gtk_box_new().
Signed-off-by: Francois Gouget
---
src/spicy-connect.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/spicy-connect.c b/src/spicy-connect.c
index c471df5..a1d895a 100644
---
GtkAction and lots of GtkUI APIs are deprecated.
Signed-off-by: Francois Gouget
---
src/spicy.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/spicy.c b/src/spicy.c
index c502428..c4a6c7d 100644
--- a/src/spicy.c
+++ b/src/spicy.c
@@ -38,6 +38,9 @@
Hi,
On Wed, Oct 19, 2016 at 04:43:12PM +0200, Francois Gouget wrote:
> On Wed, 19 Oct 2016, Victor Toso wrote:
> [...]
> > > In a different context I have found that I can fnid dfbvideosink and
> > > even instantiate it. But it will refuse to switch to the READY state and
> > > is thus unusable.
>
> It seems that
>
> On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> > These functions were implementing the same stuff as empty
> > messages functions provided by RedChannel so reuse them.
> >
> > The implementation seems a bit different but the result
> > is the same.
This is v2 of the following patchset:
https://lists.freedesktop.org/archives/spice-devel/2016-October/032797.html
Changes since v1:
* I have put the patch that enables the deprecation warnings last so
compiling does not generate warnings at any point. But really all the
patches are
Deprecation warnings no longer cause compilation errors.
Also they should either be fixed or ignored with
G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS.
Signed-off-by: Francois Gouget
---
src/Makefile.am | 1 -
src/spice-util.h | 12 +++-
2 files changed, 3
It has been deprecated for long enough.
Signed-off-by: Francois Gouget
---
src/spice-audio-priv.h | 2 ++
src/spice-audio.h | 5 -
src/spice-session.c| 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/spice-audio-priv.h
On Wed, 19 Oct 2016, Victor Toso wrote:
[...]
> > This one may be somewhat questionable since it spice-protocol's macros
> > don't use GLib's helpers and thus don't support Clang and Visual C++.
> > This means we may locally disable these warnings with
> > G_GNUC_BEGIN_IGNORE_DEPRECATIONS when
Hi,
On Wed, Oct 19, 2016 at 04:57:31PM +0200, Francois Gouget wrote:
> > > RFC: gtk: Temporarily ignore the keyboard/mouse grabbing deprecation
> > > warnings
> > > RFC: spicy: Temporarily ignore deprecation warnings
> > >
> > > These two really just silence warnings that should be fixed. So
On Wed, 19 Oct 2016, Victor Toso wrote:
[...]
> > In a different context I have found that I can fnid dfbvideosink and
> > even instantiate it. But it will refuse to switch to the READY state and
> > is thus unusable. That makes sense since I was not using it in a Direct
> > FB context.
>
>
On Wed, 19 Oct 2016, Victor Toso wrote:
[...]
> > But I don't think this necessarily impacts gstvideo_has_codec() if
> > implemented using create_gstreamer_decoder() whereas with your code it
> > will necessarily be impacted.
>
> Well, my point is simply why create the whole pipeline if we only
> Currently the qxl device with id 0 is being set as an internal display
> while all the rest are set as VGA connector. This commit solves this
> issue that was discussed in detail here:
> https://bugzilla.redhat.com/show_bug.cgi?id=1314600
>
> Signed-off-by: Sameeh Jubran
Hi,
On Wed, Oct 19, 2016 at 02:35:59PM +0200, Pavel Grunt wrote:
> The test was not executed because G_N_ELEMENTS is 0 for the pointer
Acked-by: Victor Toso
> ---
> tests/session.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/session.c
62 matches
Mail list logo