Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> > On Tue, Jul 25, 2017 at 07:20:23PM +0200, Christophe Fergeau wrote: > > On Tue, Jul 25, 2017 at 07:09:22AM -0400, Frediano Ziglio wrote: > > > > > > > > > >>> I see several benefits to doing this: > > > > > >>> > > > > > >>> 1. We always know exactly which component and branch is being > >

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

On Tue, Jul 25, 2017 at 07:20:23PM +0200, Christophe Fergeau wrote: > On Tue, Jul 25, 2017 at 07:09:22AM -0400, Frediano Ziglio wrote: > > > > > > > >>> I see several benefits to doing this: > > > > >>> > > > > >>> 1. We always know exactly which component and branch is being > > > > >>>

Re: [Spice-devel] [vdagent-win PATCH v12 3/6] Write code to decode PNG format

> > On Mon, Jul 24, 2017 at 01:39:35PM +0100, Frediano Ziglio wrote: > > +size_t PngCoder::convert_to_dib(uint8_t *out_buf, const uint8_t *data, > > size_t size) > > +{ > [...] > > +const unsigned int width = png_get_image_width(png, info); > > +const unsigned int height =

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> > On Tue, Jul 25, 2017 at 07:09:22AM -0400, Frediano Ziglio wrote: > > > > > > > >>> I see several benefits to doing this: > > > > >>> > > > > >>> 1. We always know exactly which component and branch is being > > > > >>> patched > > > > >>> > > > > > > > > > > As long as contributor keep

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

On Tue, Jul 25, 2017 at 02:26:36PM +0200, Christophe de Dinechin wrote: > >>> As long as contributor keep pinging or resending his series, this is > >>> already the case. > >> > >> As Frediano said at the beginning of the series, “I’m tired of hearing > >> this reply”. > > > > And this is not

[Spice-devel] [vdagent-win PATCH v13 2/6] Initial rewrite of image conversion code

Remove CxImage linking. Support Windows BMP format. Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- Makefile.am | 4 +- configure.ac| 4 +- mingw-spice-vdagent.spec.in | 10 +-- vdagent/image.cpp

[Spice-devel] [vdagent-win PATCH v13 4/6] Support encoding PNG images

Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- vdagent/imagepng.cpp | 118 +-- 1 file changed, 115 insertions(+), 3 deletions(-) diff --git a/vdagent/imagepng.cpp b/vdagent/imagepng.cpp

[Spice-devel] [vdagent-win PATCH v13 1/6] Move image handling to a separate file

This will make easier to change code that handle images. Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- Makefile.am | 2 ++ vdagent/image.cpp | 88 + vdagent/image.h |

[Spice-devel] [vdagent-win PATCH v13 6/6] spec: run tests during RPM build if possible

Currently to fully run checks we need Wine for both 32 and 64 bit. Some distros (like RHEL 7) don't seem to allow installing both 32 and 64 bit versions so turn on checks based on distro versions. Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau

[Spice-devel] [vdagent-win PATCH v13 5/6] Add test for PNG files

Test various image and formats. The idea is to decode and encode again an image and check for differences. ImageMagick is used to create some test image and compare results. Wine is used to execute a test helper. Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau

[Spice-devel] [vdagent-win PATCH v13 3/6] Write code to decode PNG format

Signed-off-by: Frediano Ziglio --- Makefile.am | 6 +- configure.ac | 3 + vdagent/image.cpp| 8 +- vdagent/imagepng.cpp | 245 +++ vdagent/imagepng.h | 25 ++ 5 files changed, 278

[Spice-devel] [vdagent-win PATCH v13 0/6] Rewrite image support

CxImage is used for image conversion for clipboard support. CxImage have currently some issue: - library is old and unsupported; - required an old libpng library. Currently the MingW binary we distribute due to some issue have PNG disabled (so no clipboard image support). Note that currently we

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

On Tue, Jul 25, 2017 at 07:09:22AM -0400, Frediano Ziglio wrote: > > > > > >>> I see several benefits to doing this: > > > >>> > > > >>> 1. We always know exactly which component and branch is being patched > > > >>> > > > > > > > > As long as contributor keep pinging or resending his series,

Re: [Spice-devel] [vdagent-win PATCH v12 3/6] Write code to decode PNG format

On Mon, Jul 24, 2017 at 01:39:35PM +0100, Frediano Ziglio wrote: > +size_t PngCoder::convert_to_dib(uint8_t *out_buf, const uint8_t *data, > size_t size) > +{ [...] > +const unsigned int width = png_get_image_width(png, info); > +const unsigned int height = png_get_image_height(png,

Re: [Spice-devel] [vdagent-win PATCH v11 4/6] Support encoding PNG images

Acked-by: Christophe Fergeau On Mon, Jul 24, 2017 at 01:10:24PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > Acked-by: Christophe Fergeau > --- > vdagent/imagepng.cpp | 118 >

Re: [Spice-devel] [spice-gtk v3] gstreamer: Take into account stride information

On 07/25/2017 06:30 PM, Pavel Grunt wrote: On Tue, 2017-07-25 at 16:20 +0100, Frediano Ziglio wrote: Using hardware encoders/decoders is possible that the output stride of the image cannot be computed with a fixed formula (width * 4). GStreamer in this case should set GstVideoMeta information

[Spice-devel] [spice-gtk v3] gstreamer: Take into account stride information

Using hardware encoders/decoders is possible that the output stride of the image cannot be computed with a fixed formula (width * 4). GStreamer in this case should set GstVideoMeta information with the correct stride value. Consider this value if present. This fix a problem using NvEnc encoder and

[Spice-devel] [spice-gtk v2] gstreamer: Take into account stride information

Using hardware encoders/decoders is possible that the output stride of the image cannot be computed with a fixed formula (width * 4). GStreamer in this case should set GstVideoMeta information with the correct stride value. Consider this value if present. This fix a problem using NvEnc encoder and

Re: [Spice-devel] [spice-gtk] gstreamer: Take into account stride information

On Tue, 2017-07-25 at 10:50 -0400, Frediano Ziglio wrote: > > > > Hi Frediano, > > > > On Tue, 2017-07-25 at 15:31 +0100, Frediano Ziglio wrote: > > > Using hardware encoders/decoders is possible that the output > > > stride of the image cannot be computed with a fixed formula > > > (width * 4).

Re: [Spice-devel] [spice-gtk] gstreamer: Take into account stride information

> > Hi Frediano, > > On Tue, 2017-07-25 at 15:31 +0100, Frediano Ziglio wrote: > > Using hardware encoders/decoders is possible that the output > > stride of the image cannot be computed with a fixed formula > > (width * 4). GStreamer in this case should set GstVideoMeta > > information with the

Re: [Spice-devel] [spice-gtk] gstreamer: Take into account stride information

Hi Frediano, On Tue, 2017-07-25 at 15:31 +0100, Frediano Ziglio wrote: > Using hardware encoders/decoders is possible that the output > stride of the image cannot be computed with a fixed formula > (width * 4). GStreamer in this case should set GstVideoMeta > information with the correct stride

[Spice-devel] [spice-gtk] gstreamer: Take into account stride information

Using hardware encoders/decoders is possible that the output stride of the image cannot be computed with a fixed formula (width * 4). GStreamer in this case should set GstVideoMeta information with the correct stride value. Consider this value if present. This fix a problem using NvDec encoder and

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 25 Jul 2017, at 12:36, Christophe Fergeau wrote: > > On Tue, Jul 25, 2017 at 12:23:34PM +0200, Christophe de Dinechin wrote: >>> and there are plenty of public places you can push your work. >> >> So plenty of places, but by no means a shared one? The point is that >>

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

On Tue, Jul 25, 2017 at 12:23:34PM +0200, Christophe de Dinechin wrote: > > and there are plenty of public places you can push your work. > > So plenty of places, but by no means a shared one? The point is that > we need a shared one, to be able to view pending reviews at a glance. Note that "we

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> On 24 Jul 2017, at 16:06, Marc-André Lureau > wrote: > > Hi > > - Original Message - >>> On 21 Jul 2017, at 12:41, Frediano Ziglio wrote: > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote:

Re: [Spice-devel] Proposal: review branches (was Re: [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code)

> > Hi > > - Original Message - > > ... > > > > > > > > > > 3. If you want to test, a git checkout is enough to test (assuming > > > > > you > > > > > did > > > > > the git fetch above). Simpler IMO than git am (even if I assume most > > > > > of > > > > > us > > > > > have scripts to

Re: [Spice-devel] [PATCH spice-gtk] Fix build without egl

- Original Message - > spice_display_widget_gl_scanout is defined only when building with egl > ./.libs/libspice-client-gtk-3.0.so: undefined reference to > `spice_display_widget_gl_scanout' > --- > src/spice-widget-priv.h | 2 ++ > src/spice-widget.c | 2 +- > 2 files changed, 3

[Spice-devel] [PATCH spice-gtk] Fix build without egl

spice_display_widget_gl_scanout is defined only when building with egl ./.libs/libspice-client-gtk-3.0.so: undefined reference to `spice_display_widget_gl_scanout' --- src/spice-widget-priv.h | 2 ++ src/spice-widget.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Spice-devel] [spice-gtk v1] display-gst: Improve h264 elements filtering

Hi, On Wed, Jul 19, 2017 at 11:34:14AM +0200, Victor Toso wrote: > Hi, > > On Thu, Jul 13, 2017 at 02:33:48PM +0200, Victor Toso wrote: > > From: Victor Toso > > > > This patch fixes the avdec_h264 element not being present on > > gstvideo_has_codec() which get all decoder