[Spice-devel] [PATCH 3/9] client/smartcard: s/reader_id_t/uint32_t/ (libcacard changed)

2011-02-09 Thread Alon Levy
--- client/smartcard_channel.cpp | 10 +- client/smartcard_channel.h | 12 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/client/smartcard_channel.cpp b/client/smartcard_channel.cpp index 994671f..e7f3870 100644 --- a/client/smartcard_channel.cpp +++

[Spice-devel] [PATCH 5/9] server/smartcard: print instead of assert on bad reader_id in smartcard_char_device_on_message_from_device

2011-02-09 Thread Alon Levy
--- server/smartcard.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index da67885..bd2cb25 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -114,7 +114,9 @@ void smartcard_char_device_on_message_from_device(

[Spice-devel] [PATCH 6/9] server/smartcard: ignore VSC_Init from client

2011-02-09 Thread Alon Levy
--- server/smartcard.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index bd2cb25..9fbeead 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -443,6 +443,9 @@ static int smartcard_channel_handle_message(RedChannel

[Spice-devel] [PATCH 7/9] client/smartcard: ignore VSC_Init

2011-02-09 Thread Alon Levy
--- client/smartcard_channel.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/smartcard_channel.cpp b/client/smartcard_channel.cpp index e7f3870..c57ecd5 100644 --- a/client/smartcard_channel.cpp +++ b/client/smartcard_channel.cpp @@ -410,6 +410,8 @@ void

[Spice-devel] [PATCH 8/9] server/smartcard: don't push our own error on reader add

2011-02-09 Thread Alon Levy
The device already sends one. There are actually two connections going on: server to client - this is the smartcard channel, it reuses the VSC protocol. server to device - this is an internal connection using VSC too. We generally just passthrough all messages from the client to the device, and

Re: [Spice-devel] Request For Comments: proposals for standarizing VDI protocols in IETF

2011-02-09 Thread Hans de Goede
Hi, On 02/09/2011 10:40 AM, liang.lian...@zte.com.cn wrote: Dear all, As you know VDI is believed to be one of most promising technologies in cloud-computing ages, different companies or communities have different VDI protocol definitions, such as SPICE, RDP and ICA. Some are open, while

Re: [Spice-devel] [PATCH v2 0/9] smartcard updates for libcacard 0.1.2

2011-02-09 Thread Hans de Goede
Hi, 1-8 look good, ack, 9 also looks good, but I've some small comments, see my separate reply. Regards, Hans On 02/09/2011 11:20 AM, Alon Levy wrote: The protocol has been updated through the review process on qemu-devel. These patches address the changes: * big endianess byte order *

[Spice-devel] [PATCH spice 1/1] client/windows: use SPICE_COMMON_DIR instead of ..\..\..\spice-protocol in project include dirs

2011-02-09 Thread Arnon Gilboa
relative path to another git tree is a bit ugly, since it requires spice-protocol to be in a specific location. SPICE_COMMON_DIR is also used in windows qxl and vdagent, so it's netural using it here as well. --- client/windows/redc.vcproj |8 1 files changed, 4 insertions(+), 4

Re: [Spice-devel] [PATCH spice 1/1] client/windows: use SPICE_COMMON_DIR instead of ..\..\..\spice-protocol in project include dirs

2011-02-09 Thread Uri Lublin
On 02/09/2011 05:15 PM, Arnon Gilboa wrote: relative path to another git tree is a bit ugly, since it requires spice-protocol to be in a specific location. SPICE_COMMON_DIR is also used in windows qxl and vdagent, so it's netural using it here as well. Ack. Can we in the near future rename

Re: [Spice-devel] Request For Comments: proposals for standarizing VDI protocols in IETF

2011-02-09 Thread wang . jun17
Alon, Does the following sentence mean that there are same number of spice server instances as vms, and these spice server processes are isolated each other? If so, each spice server in the same host should bind to different ip+port pair, and we can't access a spice server by an ip

Re: [Spice-devel] Request For Comments: proposals for standarizing VDI protocols in IETF

2011-02-09 Thread liang . liang12
Hi, Hans Thank you very much for pointing out our errors and your valuable comments :) we will make corresponding changes and submit updates to IETF later. For mentioned vmware svga graphics card, I just studied some references:

Re: [Spice-devel] Request For Comments: proposals for standarizing VDI protocols in IETF

2011-02-09 Thread Hans de Goede
Hi, On 02/10/2011 08:00 AM, liang.lian...@zte.com.cn wrote: Hi, Hans Thank you very much for pointing out our errors and your valuable comments :) we will make corresponding changes and submit updates to IETF later. You're welcome. For mentioned vmware svga graphics card, I just

[Spice-devel] [PATCH] update required minimal libcacard to 0.1.2

2011-02-09 Thread Alon Levy
--- Forgot this patch in the update smartcard support for libcacard series - essential of course to actually request the newer libcacard :) --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 9159b4a..00f19d2 100644 ---