Re: [Spice-devel] Problems compiling SPICE Windows client SDK 7.1

2011-07-04 Thread Arnon Gilboa
Hi John, See my comments below. Arnon John A. Sullivan III wrote: Hello, all. Being a Windows ignoramus, I am having a nightmare of a time compiling the Windows client on our Windows 7 build system. I'll recount them for other ignorami and to ask for help for the things I could not figure out.

Re: [Spice-devel] Possible Windows vdagent problems

2011-07-04 Thread Arnon Gilboa
Hi John, See my comments below. Arnon John A. Sullivan III wrote: Hello, all. I'm spinning this off of the "Unfair Comparisons with RDP" thread as that one is getting a bit long. However, in it, Yaniv identified that we were not using vdagent in our Windows guest based upon the packet traces w

Re: [Spice-devel] Possible Windows vdagent problems

2011-07-05 Thread Arnon Gilboa
John A. Sullivan III wrote: On Tue, 2011-07-05 at 09:44 +0300, Arnon Gilboa wrote: Hi John, See my comments below. Arnon John A. Sullivan III wrote: Hello, all. I'm spinning this off of the "Unfair Comparisons with RDP" thread as that one is getting a bit long. Howeve

Re: [Spice-devel] Problems compiling SPICE Windows client SDK 7.1

2011-07-06 Thread Arnon Gilboa
John A. Sullivan III wrote: We've made considerable progress. We do not have VS2008 as we are not a Windows shop and I assume in my Windows ignorance that that's a paid licensed product so we'd have track which of us could work on it and which couldn't so we've tried to make due with just the S

Re: [Spice-devel] merge spice-protocol master to 0.8

2011-07-18 Thread Arnon Gilboa
Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 12:06:35PM +0300, Alon Levy wrote: Ok, I've pushed everything through except the INLINE defining patch since that breaks windows build right now (because it treats warnings as errors and INLINE is defined twice in common/lz_config.h, easy to f

Re: [Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-24 Thread Arnon Gilboa
Naga Mohan Pothula wrote: Hi, Launched windows7 Guest image with Spice v0.8 in fullscreen mode with auto-config from windows client. Spice window hangs frequently while doing shutdown or restart. if it doesn't hang then shutdown process is slow. This issue doesn't happen if we don't launch in f

[Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
Arnon Gilboa (6): vdservice: add control events RHBZ #719140 #722980 vdservice: use overlap ConnectNamedPipe() in launch_agent() vdservice: clean agent proc handle in kill_agent() vdservice: extract init_vdi_port() vdagent: remove whitespaces vdagent: add casting vdagent

[Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
prevent race between service control manager (SCM) & the service main thread. use events for stop, logon, agent restart. --- vdservice/vdservice.cpp | 70 +- 1 files changed, 44 insertions(+), 26 deletions(-) diff --git a/vdservice/vdservice.cpp b/vds

[Spice-devel] [PATCH vdagent-win 2/6] vdservice: use overlap ConnectNamedPipe() in launch_agent()

2011-07-24 Thread Arnon Gilboa
passing NULL is buggy when pipe opened with FILE_FLAG_OVERLAPPED --- vdservice/vdservice.cpp | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 4d4937f..7ca9db8 100644 --- a/vdservice/vdservic

[Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
prevent usage of a dead proc handle in the WaitFor() --- vdservice/vdservice.cpp | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 7ca9db8..f61c318 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservic

[Spice-devel] [PATCH vdagent-win 4/6] vdservice: extract init_vdi_port()

2011-07-24 Thread Arnon Gilboa
--- vdservice/vdservice.cpp | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index f61c318..3abc146 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -77,6 +77,7 @@ private:

[Spice-devel] [PATCH vdagent-win 5/6] vdagent: remove whitespaces

2011-07-24 Thread Arnon Gilboa
--- vdagent/vdagent.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 1ebf1e4..646afed 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -565,11 +565,11 @@ bool VDAgent::handle_clipboard(VDAgentClipboard*

[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

2011-07-24 Thread Arnon Gilboa
--- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index 9bd1852..0eada52 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -67,7 +67,7 @@ void DesktopLayout::get

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
Alon Levy wrote: On Sun, Jul 24, 2011 at 01:48:13PM +0300, Arnon Gilboa wrote: prevent race between service control manager (SCM) & the service main thread. use events for stop, logon, agent restart. --- vdservice/vdservice.cpp | 70 +- 1 f

Re: [Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
Alon Levy wrote: On Sun, Jul 24, 2011 at 01:48:15PM +0300, Arnon Gilboa wrote: prevent usage of a dead proc handle in the WaitFor() Is this usage in fill_agent_event? can you make a note of that in the commit message? Otherwise ACK. Right, will add a note

[Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
use thread-safe control command queue Arnon Gilboa (6): vdservice: add control events RHBZ #719140 #722980 (v2) vdservice: use overlap ConnectNamedPipe() in launch_agent() vdservice: clean agent proc handle in kill_agent() vdservice: extract init_vdi_port() vdagent: remove whitespaces

[Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
-prevent race between service control manager (SCM) & the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue --- vdservice/vdservice.cpp | 85 +++--- 1 files changed, 57 insertions(+), 28 deletions(-) diff

[Spice-devel] [PATCH vdagent-win 2/6] vdservice: use overlap ConnectNamedPipe() in launch_agent()

2011-07-24 Thread Arnon Gilboa
passing NULL is buggy when pipe opened with FILE_FLAG_OVERLAPPED --- vdservice/vdservice.cpp | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 009f949..8c34f59 100644 --- a/vdservice/vdservic

[Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
fill_agent_events() will not add it to the events used by WaitFor(), preventing usage of a dead process handle. --- vdservice/vdservice.cpp | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 8c34f59..e09828a 10

[Spice-devel] [PATCH vdagent-win 4/6] vdservice: extract init_vdi_port()

2011-07-24 Thread Arnon Gilboa
--- vdservice/vdservice.cpp | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index e09828a..bc7ec41 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -80,6 +80,7 @@ private:

[Spice-devel] [PATCH vdagent-win 5/6] vdagent: remove whitespaces

2011-07-24 Thread Arnon Gilboa
--- vdagent/vdagent.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 1ebf1e4..646afed 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -565,11 +565,11 @@ bool VDAgent::handle_clipboard(VDAgentClipboard*

[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

2011-07-24 Thread Arnon Gilboa
--- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index 9bd1852..0eada52 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -67,7 +67,7 @@ void DesktopLayout::get

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
Arnon Gilboa wrote: NAK -prevent race between service control manager (SCM) & the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue ___ Spice-devel mailing list Spice-devel@lists.freedesktop

[Spice-devel] [PATCH vdagent-win v3 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
-prevent race between service control manager (SCM) & the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue --- vdservice/vdservice.cpp | 83 +++ 1 files changed, 55 insertions(+), 28 deletions(-) diff

Re: [Spice-devel] [PATCH] client: fix 30s timeout regression

2011-07-30 Thread Arnon Gilboa
ack Christophe Fergeau wrote: Changelog from Arnon Gilboa, patch from me: Commit eb6f55409412 caused the following regression: When client runs without the auto-conf or disable-effects options (either from CLI or controller), which is the case when using Spice from Admin Portal, the client

Re: [Spice-devel] [PATCH] common/backtrace.h: disable for WIN32

2011-07-31 Thread Arnon Gilboa
ack Alon Levy wrote: This also catches mingw32 which is probably fine, but at least it fixes the build on visual studio. --- common/backtrace.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/common/backtrace.h b/common/backtrace.h index 3b0c132..21b6b67 100644 --- a

Re: [Spice-devel] [PATCH v2] server/red_dispatcher: fix wrong resolution set for tablet

2011-07-31 Thread Arnon Gilboa
ack, although I did not really get why the ref got broken. Alon Levy wrote: when changing resolutions due to the new async code paths the surface creation command was kept by reference, and later, when the red_worker signaled completion by calling async_complete the mouse mode was updated using

[Spice-devel] [PATCH vdagent-win] virtio_vdi_port: if async read returns with ERROR_OPERATION_ABORTED, cancel pending (rhbz#725734)

2011-08-01 Thread Arnon Gilboa
Therefore in case of virtio-serial ReadFile timeout (new driver behavior), the next VirtioVDIPort::read() call by the service will be performed, since it is now (!_read.pending). --- vdservice/virtio_vdi_port.cpp | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git

Re: [Spice-devel] [PATCH vdagent-win] virtio_vdi_port: if async read returns with ERROR_OPERATION_ABORTED, cancel pending (rhbz#725734)

2011-08-01 Thread Arnon Gilboa
Uri Lublin wrote: On 08/01/2011 11:27 AM, Arnon Gilboa wrote: Therefore in case of virtio-serial ReadFile timeout (new driver behavior), the next VirtioVDIPort::read() call by the service will be performed, since it is now (!_read.pending). Ack. Do we need something similar for the

Re: [Spice-devel] Spice Windows 7 display driver?

2011-08-02 Thread Arnon Gilboa
Hi Nathan, Get the updated test-signed driver from the download page, or directly: http://www.spice-space.org/download/binaries/qxl-win_20110802.zip Arnon Nathan Lager wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've been running in circles attempting to install a Display driver in Wi

Re: [Spice-devel] Spice Windows 7 display driver?

2011-08-02 Thread Arnon Gilboa
Updated the zip with RedHat signed drivers. Enjoy, Arnon Arnon Gilboa wrote: Hi Nathan, Get the updated test-signed driver from the download page, or directly: http://www.spice-space.org/download/binaries/qxl-win_20110802.zip Arnon Nathan Lager wrote: -BEGIN PGP SIGNED MESSAGE- Hash

Re: [Spice-devel] Problems building 0.9.0

2011-08-04 Thread Arnon Gilboa
updated & installed spice-protocol accordingly? Damien Churchill wrote: Trying to package up 0.9.0 I'm encountering the following issues: 1. I'm having to replace all use of INLINE with inline 2. I'm having to force disabling -Werror by patching configure I imagine I'm doing something wrong so

Re: [Spice-devel] problem for vdagent

2011-08-09 Thread Arnon Gilboa
I guess you are forking vdagent ;) Do you call CreateProcess() from vdagent? or vdservice? upon receiving specific msg? what's the GetLastError()? if used from vdagent, why not just use MessageBox()? what OS are you using? Please provide all the details + relevant patch. 王耀峰 wrote: Hi Arnon:

Re: [Spice-devel] problem for vdagent

2011-08-09 Thread Arnon Gilboa
Yaniv Kaul wrote: On 08/09/2011 01:30 PM, Arnon Gilboa wrote: I guess you are forking vdagent ;) Do you call CreateProcess() from vdagent? or vdservice? upon receiving specific msg? what's the GetLastError()? if used from vdagent, why not just use MessageBox()? what OS are you using? P

Re: [Spice-devel] [PATCH] qxl: allowing the command rings to be not empty when spice worker is stopped RHBZ #728984

2011-08-09 Thread Arnon Gilboa
Acked-by: Arnon Gilboa Yonit Halperin wrote: same as 8927cfbba232e28304734f7afd463c1b84134031, but for qxl_check_state, that was triggered by qxl_pre_load (which calls qxl_hard_reset, which calls qxl_soft_reset), and caused the migration target to crash. --- hw/qxl.c |8 +++- 1

Re: [Spice-devel] vdagent\vdservice W 2008R2 guest under Fedora 15

2011-09-25 Thread Arnon Gilboa
Hi Sean, Remember to run cmd as Administrator. Is Z a network drive? put vdservice & vdagent on local drive. If it still fails, please send %windir\temp\vdservice.log & vdagent.log. Regarding the qxl driver, refer to the installing section in http://spice-space.org/page/WinQXL. Thanks, Arnon se

Re: [Spice-devel] problems with cut n paste - WinXP VM specificall

2011-10-02 Thread Arnon Gilboa
Hi Mike, Can you please: 1. net stop vdservice 2. delete vdservice.log & vdagent.log from %windir%\temp 3. net start vdservice 4. copy a text in the guest, paste in host & vice versa 5. send us the logs Thanks, Arnon Mike Hinz wrote: On Fri, 2011-09-30 at 22:32 +0300, Alon Levy wrote: Can y

Re: [Spice-devel] problems with cut n paste - WinXP VM specificall

2011-10-05 Thread Arnon Gilboa
Mike Hinz wrote: On Sun, 2011-10-02 at 14:03 -0500, Mike Hinz wrote: On Sun, 2011-10-02 at 11:01 +0200, Arnon Gilboa wrote: Hi Mike, Can you please: 1. net stop vdservice 2. delete vdservice.log & vdagent.log from %windir%\temp 3. net start vdservice 4. copy a text in the guest, p

Re: [Spice-devel] Spice agent oddities

2011-10-18 Thread Arnon Gilboa
Hi Damien, Seems like for some reason vdservice closed (handle of) the virtio serial device. Can you please send the relevant qemu output. You should see something like: spice_server_char_device_add_interface: CHAR_DEVICE vdagent handle_dev_input: mouse mode 2 reds_main_handle_message: agent s

Re: [Spice-devel] [PATCH] client: add xinerama support

2011-11-14 Thread Arnon Gilboa
Looks good to me, as I remember this old one;) Acked-by: Arnon Gilboa Alon Levy wrote: From: Arnon Gilboa RHEL-6 Bugzilla: 695323 cherry-picked from qspice commit 003667ac99beeec9b330a07bc3569c59a96d4588 which fixes RHEL-5 541566 with merge of the one line qspice fix to SPICE_REQUIRES

Re: [Spice-devel] [PATCH] client: add xinerama support

2011-11-14 Thread Arnon Gilboa
Looks good to me, as I remember this old one;) Acked-by: Arnon Gilboa Alon Levy wrote: From: Arnon Gilboa RHEL-6 Bugzilla: 695323 cherry-picked from qspice commit 003667ac99beeec9b330a07bc3569c59a96d4588 which fixes RHEL-5 541566 with merge of the one line qspice fix to SPICE_REQUIRES

[Spice-devel] [PATCH vdagent-win 0/3] fix 3 annoying vdagent issues

2011-11-16 Thread Arnon Gilboa
Arnon Gilboa (3): vdservice: fix vdagent connection & termination handling rhbz#750037 vdagent: release clipboard ownership on agent stop & desktop switch rhbz#731628 vdlog: change log times to human readable date & time rhbz#672828 common/vdlog.h | 23 ++

[Spice-devel] [PATCH vdagent-win 2/3] vdagent: release clipboard ownership on agent stop & desktop switch rhbz#731628

2011-11-16 Thread Arnon Gilboa
-use event queue for agent stop & desktop switch -exit gracefully on session end --- vdagent/vdagent.cpp | 86 ++ 1 files changed, 65 insertions(+), 21 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 646afed..f0f5243 1006

[Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection & termination handling rhbz#750037

2011-11-16 Thread Arnon Gilboa
-extend vdagent wait timeouts -timeout occured when connecting during windows startup, using wan emulator with 1Mbps bandwith, and only when qxl driver is installed. It might be due to spice commands window control which in this case indirectly affects windows startup timings (needs further investi

[Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Arnon Gilboa
ifndef USE_DATE_TIME, use system time instead of secs from system startup --- common/vdlog.h | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/common/vdlog.h b/common/vdlog.h index bb2eb28..995e9d3 100644 --- a/common/vdlog.h +++ b/common/vdlog.h @@ -2

Re: [Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection & termination handling rhbz#750037

2011-11-16 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:35PM +0200, Arnon Gilboa wrote: ACK A few comments / questions below. -#define VD_AGENT_TIMEOUT3000 +#define VD_AGENT_TIMEOUT1 Is this required? Do we want to make it configurable? It's way above

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: ifndef USE_DATE_TIME, use system time instead of secs from system startup Why do we want to keep the old behavior? For users & qa, human readable date & time (hh:mm:ss) is nicer. For debugging

[Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date & time rhbz#672828

2011-11-20 Thread Arnon Gilboa
-use RHEV log format -add log levels & macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 common/vdlog.h | 54 +++--- 2 files changed, 39 insertions(+), 19 deletions(-) diff --git a/common/vdlog.cpp b/common/vdlog.cpp index 1001

Re: [Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date & time rhbz#672828

2011-11-21 Thread Arnon Gilboa
10x, see below. Uri Lublin wrote: On 11/21/2011 09:50 AM, Arnon Gilboa wrote: -use RHEV log format -add log levels & macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 common/vdlog.h | 54 +++--- 2 files changed

[Spice-devel] [PATCH v3 vdagent-win] vdlog: change log times to human readable date & time rhbz#672828

2011-11-21 Thread Arnon Gilboa
-use RHEV log format -add log levels & macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 --- common/vdlog.h | 62 - 2 files changed, 47 insertions(+), 19 deletions(-) diff --git a/common/vdlog.cpp b/common/vdlog.cpp index 1001de

Re: [Spice-devel] vdagent supported only for XP?

2011-11-24 Thread Arnon Gilboa
Manual is not updated. It also supports W7, W2k8, W2k3. Todd And Margo Chester wrote: Hi All, Is this still the case? From the spice_uses_manual, page 15, 6.1.2: Note: ▪ The service currently supports only Windows XP. Is there a work around for W7? (Not a real big issue, I hardly ever use W7.

[Spice-devel] vdagent-win32 update

2011-11-24 Thread Arnon Gilboa
Hi there, No updates for some time. Have you tried using the debug vdagent I posted a while ago? A newer version with several fixes can be found at spice-space.org download page, or directly at: http://www.spice-space.org/download/binaries/vdagent-win32_2024.zip Please update with your resu

Re: [Spice-devel] vdagent-win32 update

2011-11-28 Thread Arnon Gilboa
an help us :( Try to catch me at irc.gimp.net #spice to debug the issue online. Waiting for your update, Arnon Mike Hinz wrote: On Thu, 2011-11-24 at 14:56 +0200, Arnon Gilboa wrote: Hi there, No updates for some time. Have you tried using the debug vdagent I posted a while ago? A newer version

[Spice-devel] [PATCH vdagent-win 1/1] vdservice: fix vdagent first launch (during startup) failure handling rhbz#750037

2011-12-26 Thread Arnon Gilboa
In case of agent launch failure: if connection state is not active(*), wait for agent launch on the next session connection. Otherwise, the service is stopped. (*) The failure was due to system startup timings and logon settings, causing the first agent instance lifetime (before session connect) to

Re: [Spice-devel] [PATCH vdagent-win 1/1] vdservice: fix vdagent first launch (during startup) failure handling rhbz#750037

2011-12-27 Thread Arnon Gilboa
Thanks Uri;) I couldn't explain it better. Uri Lublin wrote: On 12/26/2011 12:58 PM, Arnon Gilboa wrote: In case of agent launch failure: if connection state is not active(*), wait for agent launch on the next session connection. Otherwise, the service is stopped. (*) The failure was d

Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-29 Thread Arnon Gilboa
Hi Mohan, see below. Naga Mohan Pothula wrote: Hi Alon, Please refer my inline comments. Thanks/Mohan. From: Alon Levy To: Naga Mohan Pothula Cc: David Jaša ; "spice-devel@lists.freedesktop.org" ; Christophe Fergeau Sent: Wednesday, December 28, 2011 5:

Re: [Spice-devel] [spice-xpi PATCH 0/3] logging: add various log messages (#753155)

2012-01-02 Thread Arnon Gilboa
ACK series Acked-by: Arnon Gilboa Uri Lublin wrote: Mostly debug messages to log variable values coming in (from java-script) and going out (to spice-client). Uri Lublin (3): logging: add logging of variable setting (#753155) logging: add logging of messages sent to the client (#753155

[Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-01-04 Thread Arnon Gilboa
On any change of the display settings, driven by client message or guest user, normalize all display positions to non-negative coordinates, and update total width and height of the virtual desktop. The bug was due to wrong handling of (non-primary) displays positioned on negative coordinates. ---

Re: [Spice-devel] keyboard and Mouse Fails....

2012-01-09 Thread Arnon Gilboa
received VdAgent build. Thanks\Mohan. From: Naga Mohan Pothula To: Naga Mohan Pothula ; Arnon Gilboa Cc: David Jaša ; "spice-devel@lists.freedesktop.org" ; Christophe Fergeau Sent: Thursday, January 5, 2012 4:43 PM Subject: Re: [Spice-devel] keyboard and Mouse Fails Arnon

Re: [Spice-devel] keyboard and Mouse Fails....

2012-01-11 Thread Arnon Gilboa
ot working. Try again. We are all there. 6667 is the port. Thanks, Mohan. From: Arnon Gilboa To: Naga Mohan Pothula Cc: Alon Levy ; David Jaša ; "spice-devel@lists.freedesktop.org" ; Christophe Fergeau Sent: Monday, January 9, 2012 9:30 AM Su

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Thanks for the update. Few questions: 1. Looking at windows device manager, is there any error reported for the virtio-serial driver? 2. Is the error reproduced only on startup, or also when you start the vdservice ("RHEV Spice Agent") manually when the machine is up? 3. Is it reproduced for ot

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Vadim, I think you have reproduced the same (VirtioVDIPort::init::CreateFile() failed: 2). Do you have any idea? it is not repro on linux guests. Thanks, Arnon Gianluca Cecchi wrote: After today updates on my F16 host it seems I'm not able to start vdagent inside my 32bit windows 7. One releva

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Vadim, I think you have reproduced the same (VirtioVDIPort::init::CreateFile() failed: 2). Do you have any idea? it is not repro on linux guests. Thanks, Arnon Gianluca Cecchi wrote: After today updates on my F16 host it seems I'm not able to start vdagent inside my 32bit windows 7. One releva

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Hi Gianluca, Can you please try to reproduce on win xp guest? CC'ing Vadim (virtio-serial windows driver) to the thread. On Wed, Jan 18, 2012 at 2:21 PM, Arnon Gilboa wrote: Thanks for the update. Few questions: 1. Looking at windows device manager, is there any error reported fo

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
This seems like a different bug, which was already encountered by others in the list. I will continue trying to repro/fix both bugs, and update you accordingly. Vadim - please update regarding the driver. Gianluca Cecchi wrote: On Wed, Jan 18, 2012 at 3:41 PM, Arnon Gilboa wrote: Hi

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-19 Thread Arnon Gilboa
Gianluca Cecchi wrote: Just to inform that as the host is a laptop, this morning I booted it again and now the w7 vm works, even if not so stably (sometimes in minutes I have to restart agent because it is seen as running by windows but copy/paste doesn't work any more). Please send the qemu

[Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-01-23 Thread Arnon Gilboa
On any change of the display settings, driven by client message or guest user, normalize all display positions to non-negative coordinates, and update total width and height of the virtual desktop. The bug was due to wrong handling of (non-primary) displays positioned on negative coordinates. ---

Re: [Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-02-01 Thread Arnon Gilboa
op_layout->get_total_height(); Is it clear now? Alon Levy wrote: On Mon, Jan 23, 2012 at 12:59:22PM +0200, Arnon Gilboa wrote: On any change of the display settings, driven by client message or guest user, normalize all display positions to non-negative coordinates, and update total width and h

Re: [Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-02-01 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Feb 01, 2012 at 10:48:29AM +0200, Arnon Gilboa wrote: Thanks Alon, adding these lines to the comment: In VDAgent::handle_mouse_event(), mouse event is generated by scaling the received (x,y, display_id) to normalized absolute coordinates (0..0x) on the entire

Re: [Spice-devel] spice inside spice mouse problem

2012-02-07 Thread Arnon Gilboa
Hi Anil, Is vdservice (&vdagent) running on both xp guests? Are the vms launched with usbtablet? Regards, Arnon Anil Vettathu wrote: Hi I have a windowsXP VM installed using virt-manager (KVM) on Fedora 16 with spice as the display. Everything is working smooth. The problem is that if I open an

Re: [Spice-devel] keyboard and Mouse Fails....

2012-02-08 Thread Arnon Gilboa
producible. why this happens and how to make sure Spice client is launched from linux machine after VDAgent starts? Appreciated your help. Thanks\Naga. ____ From: Arnon Gilboa To: Naga Mohan Pothula Cc: Alon Levy ; David Jaša ; "spice-devel@lists.

Re: [Spice-devel] [PATCH] Fix = use instead of ==

2012-02-23 Thread Arnon Gilboa
Ack & thanks. The flow seems much better now;) will be tested for regression anyway. Christophe Fergeau wrote: When checking for ConnectNamedPipe status, the error check uses if ( err = ERROR_IO_PENDING) instead of using == which causes this error check to always trigger. This commit fixes this

[Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

2012-03-01 Thread Arnon Gilboa
MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no other windows in the clipboard viewer chain", which explains the 3rd party clipboard manager workaround d

[Spice-devel] [PATCH v2 spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

2012-03-01 Thread Arnon Gilboa
MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no other windows in the clipboard viewer chain", which explains the 3rd party clipboard manager workaround d

Re: [Spice-devel] [PATCH 00/20] vdagent mingw compilation

2012-03-01 Thread Arnon Gilboa
ACK series, with Alon's min/max fix. Needs some more testing of both VC++ & mingw builds. Christophe Fergeau wrote: Hi, This patch series fixes most of the issues I had when trying to compile vdagent-win with mingw. It also adds an autotools-based build system since as a more convenient way of

Re: [Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

2012-03-01 Thread Arnon Gilboa
Alon Levy wrote: On Thu, Mar 01, 2012 at 01:10:51PM +0200, Arnon Gilboa wrote: MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no o

Re: [Spice-devel] Problem about qxl and vmc

2012-03-06 Thread Arnon Gilboa
wangfeng wangfeng wrote: Hi, I have created a Win7 VM by libvirt. Then I installed only qxl driver but no virtio-serial driver, and vdservice is also not running. But the mouse can move smoothly without SHIFT+F12. Isn't this vdagent's function? After that I installed virtio-serial driver,

Re: [Spice-devel] Can USB redirection be enabled on windows client?

2012-03-18 Thread Arnon Gilboa
spice-gtk windows client support for USB redir is still under development. Patches will be posted very soon. The old spicec client for windows supports USB redir using Incentives Pro's product. Arnon Andrew Osborne wrote: Works with Fedora 16 and WinXp as client Andrew On 17 Mar 2012, at 18:

Re: [Spice-devel] Spice is breaking in 32 bits hosts

2012-03-18 Thread Arnon Gilboa
AFAIK, Spice server works only "on x86_64, because it is dependent on 64-bit atomic operations. There is no known plan to port it to other architecture." See http://www.spice-space.org/page/FAQ. Fabiano Fidêncio wrote: Guys, I've been trouble using spice-protocol/spice/qemu from git, in a 32

Re: [Spice-devel] [PATCH qemu+spice] expose server mouse status

2012-03-26 Thread Arnon Gilboa
ACK series Acked-by: Arnon Gilboa Alon Levy wrote: Below are the combined summaries. This lets the current mouse mode the server is using be shown to qemu users: (qemu) info spice Server: address: 0.0.0.0:10005 auth: none compiled: 0.10.2 mouse-mode: server qemu: Alon

Re: [Spice-devel] An overview of Network redirection in Spice

2010-03-02 Thread Arnon Gilboa
Great overview! I finally understood what my neighbor was working on... Please wikify it & add link@ http://cleo/qumrawiki/Spice Arnon Yonit Halperin wrote: Hi, I’ve previously worked on the network redirection feature, which part of it is already in the upstream. Here, I present an overview of

Re: [Spice-devel] An overview of Network redirection in Spice

2010-03-02 Thread Arnon Gilboa
Of course, I meant a link from the site... Arnon Gilboa wrote: Great overview! I finally understood what my neighbor was working on... Please wikify it & add link@ http://cleo/qumrawiki/Spice Arnon Yonit Halperin wrote: Hi, I’ve previously worked on the network redirection feature, which

Re: [Spice-devel] SPICE

2010-04-21 Thread Arnon Gilboa
Hello Vijender, As you have already noticed, Spice is a really cool, high-performance & intensively developing open project. We will be more than happy if you guys will join us in making Spice even better. I forward your message to our devel list, so you can discuss your participation with the

Re: [Spice-devel] Spice install problem

2010-05-23 Thread Arnon Gilboa
Seems like a good question for the kvm list: k...@vger.kernel.org Brian Milliron wrote: I apologize if this is not the right place for this question, but I'm running into some problems installing Spice .4 on my CentOS 5.5. I was following the instructions here: http://www.spice-space.org/docs/s

Re: [Spice-devel] does spice require qemu ?

2010-05-31 Thread Arnon Gilboa
Currently Spice defiantly requires qemu, and it is noted all over the website & documents. However, Spice has a generic open architecture and we plan to open it for other environments as well. Luc van Stappershoef wrote: Dear all, I have tried to find on the website the answer to the question

Re: [Spice-devel] [PATCH] spice-vmc: split vmc_write to max sized virtio_serial_write calls

2010-07-21 Thread Arnon Gilboa
Alon Levy wrote: This is required for working agent in windows guests with up coming release. Prevents pretty blue screens. Please Ack. workaround for current windows driver limitation (RHBZ 617000) --- hw/spice-vmc.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions

Re: [Spice-devel] [PATCH] server: add vdi_port write retry timer. RHBZ 616772

2010-07-22 Thread Arnon Gilboa
Alon Levy wrote: Retry vdi_port_write whenever a write to the sif (i.e. virtio-serial) fails because the ivq (vq from host to guest) is full. There is no existing timer based or callback based mechanism. RHBZ 616772 is a request for virtio-serial to support such a callback. Please Ack. --- ser

[Spice-devel] vdagent patches to sync with rhel6

2010-08-09 Thread Arnon Gilboa
including virtio & clipboard support ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] vdagent: use vdagent.h

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa --- common/vdcommon.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/vdcommon.h b/common/vdcommon.h index 2e4ed5d..ba9d0ec 100644 --- a/common/vdcommon.h +++ b/common/vdcommon.h @@ -21,7 +21,7 @@ #pragma warning(disable:4200) #include

[Spice-devel] [PATCH] spice: vdagent: support x64 arch

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa --- common/stdint.h|4 + vdagent.sln| 10 +++ vdagent/vdagent.vcproj | 160 vdservice/vdservice.vcproj | 159 +++ 4 files changed, 333 insertions(+), 0

[Spice-devel] [PATCH] spice: vdagent: upgrade solution & projects to vs2008

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa --- vdagent.sln|4 +- vdagent/vdagent.vcproj | 75 +--- vdservice/vdservice.vcproj | 73 -- 3 files changed, 73 insertions(+), 79 deletions(-) diff --git a/vdagent.sln

[Spice-devel] [PATCH] spice: vdagent: return error code -1 on service install/uninstall failure #576625

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa --- vdservice/vdservice.cpp | 43 +++ 1 files changed, 27 insertions(+), 16 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index e8a773c..8139af4 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice

[Spice-devel] [PATCH] spice: vdagent: drop mouse event when SendInput fails due to DesktopSwitch event delay #598968

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa --- vdagent/vdagent.cpp |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 332438b..a578dfd 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -262,7 +262,7 @@ DWORD VDAgent

[Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in VDAgent::read_completion() handle multi-chunk msgs -fix chunk size bug in VDService::handle_pipe_data() -add size to VDPipeMessage --- common/vdcommon.h |3 +- vdagent/vdagent.cpp | 236

[Spice-devel] [PATCH] spice: vdagent: virtio serial adaptations

2010-08-09 Thread Arnon Gilboa
From: Arnon Gilboa -mostly based on Alon's patches with cleanup -adapt vdi_port class to virtio serial -replace vdi_port callbacks with events -add get_device_path() - using setupapi.lib -add struct VDIPortBuffer for read/write buffers -add VD_EVENT_XXX enum for clarity -add DEBUG_VDSERVIC

Re: [Spice-devel] [PATCH] client: Fix for clipboard sending; It wasn't thread safe.

2010-08-15 Thread Arnon Gilboa
Yonit Halperin wrote: --- client/red_client.cpp | 23 +++ client/red_client.h |9 - 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/client/red_client.cpp b/client/red_client.cpp index 9a8078e..b6a412e 100644 --- a/client/red_client.cpp +++ b/cl

Re: [Spice-devel] [PATCH] vdagent: use vdagent.h

2010-08-18 Thread Arnon Gilboa
Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa --- common/vdcommon.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/vdcommon.h b/common/vdcommon.h index 2e4ed5d..ba9d0ec 100644 --- a/common/vdcommon.h

Re: [Spice-devel] RFC: spice vdagent protocol documentation

2010-09-13 Thread Arnon Gilboa
Hi Hans, When you wikify it (fixed with Alon's comments), I will add the new clipboard messages and flow. 10x, Arnon Hans de Goede wrote: Hi All, This is a first draft version / a first attempt to document the spice vdagent protocol. This is meant to eventually go to the wiki. Question where

Re: [Spice-devel] linux vdagent progress report

2010-09-20 Thread Arnon Gilboa
Hans de Goede wrote: Hi All, I've been making good progress with the linux vdagent this weekend (I've been hacking on it during FUDcon). :) It now fully supports client mouse mode without the need to specify the resolution the guest xorg is running at whent starting it, and it will automatica

[Spice-devel] [PATCH] vd_agent: add protocol messages for clipboard/selection-owner model

2010-09-21 Thread Arnon Gilboa
pasting clipboard data is now "only-by-demand" from both sides (client and agent), whose behavior is symmetric. -VD_AGENT_CLIPBOARD_GRAB(type) - tell the other side that an application in our side ("we") got ownership of the clipboard. -VD_AGENT_CLIPBOARD_REQUEST(type) - after we know the other

  1   2   3   4   >