Re: [Spice-devel] [PATCH spice-gtk] Ensure that file transfers get cancelled

likely that it will happen during other operations > (e.g. file_xfer_flush_async(), etc). In order to handle these > scenarios > (and make sure that the file gets canceled properly), send the > FILE_XFER_STATUS message in spice_file_transfer_task_completed(). Acked-by: Pavel Grunt

Re: [Spice-devel] [PATCH 06/14] FIXME/HACK: RedPipeItem/VDIPortBuf refcounting hack

Hi, On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > related to 7d375e0 > workaround a runtime check in red_pipe_item_ref() Should the refcount be initialized by red_pipe_item_init? Pavel > --- >  server/reds.c | 3 ++- >  1 file

Re: [Spice-devel] [vdagent-linux v2] remove trailing spaces

Hi, git grep "[[:space:]]$" shows one more in the ChangeLog Pavel On Mon, 2016-04-11 at 11:33 +0200, Victor Toso wrote: > --- >  src/console-kit.c| 10 +- >  src/dummy-session-info.c |  6 +++--- >  src/session-info.h   |  6 +++--- >  src/systemd-login.c  | 

Re: [Spice-devel] [vdagent-linux v3] remove trailing spaces

On Mon, 2016-04-11 at 11:54 +0200, Victor Toso wrote: Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  ChangeLog|  2 +- >  src/console-kit.c| 10 +- >  src/dummy-session-info.c |  6 +++--- >  src/session-info.h   |  6

[Spice-devel] [PATCH spice-gtk v2 3/6] Use GMutex instead of GStaticMutex

Since GLib 2.32 GMutex can be statically allocated, so GStaticMutex has been deprecated. Acked-by: Christophe Fergeau --- src/desktop-integration.c | 6 +++--- src/spice-gtk-session.c | 6 +++--- src/spice-session.c | 12 ++-- src/usbutil.c |

[Spice-devel] [PATCH spice-gtk v2 4/6] Use g_object_unref instead of gdk_cursor_unref

GdkCursor is GObject and gdk_cursor_unref has been deprecated since 3.0 Acked-by: Eduardo Lima (Etrunko) --- v2: fix commit message g_object_unref -> gdk_cursor_unref --- src/spice-widget.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Spice-devel] [PATCH spice-gtk v2 6/6] Use g_clear_pointer if possible

--- v2: removed extra curly braces fix wrong calls diff to v1 - http://paste.fedoraproject.org/350384/14599492/ --- src/bio-gio.c | 3 +-- src/channel-display-mjpeg.c | 3 +-- src/channel-display.c | 10 +++--- src/channel-main.c | 6 ++

[Spice-devel] [PATCH spice-gtk v2 0/6] Cleanups for new gtk and glib

deprecated warnings are enabled), fixes the commit message in the PATCH 4, fixes wrong usage of g_clear_pointer in the PATCH 6 Pavel Grunt (6): Use GLIB_VERSION_MAX_ALLOWED Use GDK_VERSION_MAX_ALLOWED Use GMutex instead of GStaticMutex Use g_object_unref instead of gdk_cursor_unref Use

[Spice-devel] [PATCH spice-gtk v2 5/6] Use g_clear_object if possible

Acked-by: Eduardo Lima (Etrunko) --- kept separated per Christophe's suggestion --- src/spice-channel.c| 11 ++- src/spice-widget.c | 22 -- src/wocky-http-proxy.c | 3 +-- 3 files changed, 7 insertions(+), 29 deletions(-) diff --git

[Spice-devel] [PATCH spice-gtk v2 1/6] Use GLIB_VERSION_MAX_ALLOWED

In order to avoid using a too new GLib API. Taken from virt-viewer 96d120903f0b95d49642e58d4f796b4f62aa8b20 --- v2: new patch --- configure.ac | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4227fd8..817aaab 100644 --- a/configure.ac

Re: [Spice-devel] [PATCH 04/10] Rename SmartCardDeviceState to RedCharDeviceSmartcard

On Fri, 2016-04-01 at 15:51 -0500, Jonathon Jongsma wrote: > More consistent with naming conventions, and prepares for converting > this type to a GObject which inherits from RedCharDevice. Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  server

[Spice-devel] [PATCH spice-gtk] Do not use deprecated GtkStock

Use labels or named icons Deprecated since Gtk 3.10 --- src/spicy.c | 23 +++ src/usb-device-widget.c | 12 ++-- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/src/spicy.c b/src/spicy.c index ca9db84..0475530 100644 --- a/src/spicy.c +++

Re: [Spice-devel] [PATCH 1/2] define SPICE_CONSTRUCTOR_FUNC and SPICE_DESTRUCTOR_FUNC macros

On Wed, 2016-03-16 at 11:52 -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > On Mon, Feb 29, 2016 at 10:36:53AM +, Frediano Ziglio wrote: > > > > > > Allow to define functions executed at program/shared object > > > initialization > > > or close. > > > > > > Signed-off-by: Frediano

[Spice-devel] [PATCH spice-gtk 5/5] Adjust to Gtk+ 3.10

Dependency since f9a1aad85fcc76dd76c454b51fbce5e07c9b145f Remove unneeded GTK_CHECK_VERSION guards --- src/gtk-compat.h| 2 -- src/spicy.c | 16 src/usb-device-widget.c | 9 - 3 files changed, 27 deletions(-) diff --git a/src/gtk-compat.h

[Spice-devel] [PATCH spice-gtk 3/3] spicy: s/Automagic/Automatic/

--- It's A Kind of Magic --- src/spicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spicy.c b/src/spicy.c index 12ae653..a3f357a 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -738,7 +738,7 @@ static const GtkToggleActionEntry tentries[] = { .callback=

[Spice-devel] [PATCH spice-gtk 4/5] Adjust to GLib 2.36

Dependency since 8693e7d3f7de1ff102082212fa6e35fb1a252ef7 Remove glib-compat files and most of GLIB_CHECK_VERSION guards --- doc/reference/Makefile.am | 1 - po/POTFILES.skip | 1 - src/Makefile.am| 5 -- src/channel-cursor.c

Re: [Spice-devel] [PATCH spice-gtk 3/3] spicy: s/Automagic/Automatic/

On Wed, 2016-03-16 at 17:16 -0300, Eduardo Lima (Etrunko) wrote: > On 03/16/2016 10:46 AM, Pavel Grunt wrote: > > > > --- > > It's A Kind of Magic > > --- > >  src/spicy.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

[Spice-devel] [PATCH spice-gtk 3/5] Move strtok_r from glib-compat to spice-uri

It is not glib specific and it is only used in spice-uri --- src/glib-compat.c | 31 --- src/glib-compat.h | 4 src/spice-uri.c | 29 + 3 files changed, 29 insertions(+), 35 deletions(-) diff --git a/src/glib-compat.c

[Spice-devel] [PATCH spice-gtk 2/5] spice-util: Fix alignment

--- src/spice-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-util.c b/src/spice-util.c index fd97ee7..d2bcfbf 100644 --- a/src/spice-util.c +++ b/src/spice-util.c @@ -47,7 +47,7 @@ static void spice_util_enable_debug_messages(void) if (!doms) {

[Spice-devel] [PATCH spice-gtk 2/3] spice-display: Remove auto-clipboard notify

It was used to notify the (deprecated) auto-clipboard property of the SpiceDisplay everytime the SpiceGtkSession emits its auto-clipboard notify. The commit 70a00b8fcc2ca85d3601f6ac4895f906f9032e77 removed the property from SpiceDisplay causing a runtime warning: GLib-GObject-WARNING **:

Re: [Spice-devel] [spice-gtk] channel-usbredir: Fix crash due to a Task returning earlier than expected

n g_main_context_dispatch (context=0x647390) > at gmain.c:3154 >  #40 0x721b8e3a in g_main_context_dispatch (context=context@e > ntry=0x647390) at gmain.c:3769 >  #41 0x721b91d0 in g_main_context_iterate (context=0x647390, > block=block@entry=1, dispatch=dispatch@entry=1, self=) &g

Re: [Spice-devel] [phodav PATCH 5/7 v3] spice-webdavd-windows: Automount shared folder

Hi Lukas, On Thu, 2016-03-17 at 14:47 +0100, Lukas Venhoda wrote: > Try to connect to shared folder automatically on Windows. > > On each loop of run_service(), run a GTask, that waits for 0.5s. > If sharing is disabled, read_thread will immediately return and cause > the main_loop to stop. >

Re: [Spice-devel] [PATCH] usbredir_handle_msg: rename data to err_data

On Mon, 2016-03-21 at 12:07 +0100, Victor Toso wrote: > On Sun, Mar 20, 2016 at 03:03:41PM +0200, Snir Sheriber wrote: > > > > To better reflect what this variable is used for and change the > > declare > > location such that it will be declared only if it should > Acked-by: Victor Toso

Re: [Spice-devel] [PATCH] char-device: Add helpers for SpiceCharDeviceCallbacks vfuncs

erver/char-device.c | 78 +- > -- >  1 file changed, 62 insertions(+), 16 deletions(-) > > Changes: > - removed excessive checks (proposed by Pavel Grunt). > > I would ack it. Not clear if I can ack after I did the change (even > if > suggested by Pavel). I would ack it as

Re: [Spice-devel] [PATCH spice-gtk 1/7] widget: remove superflous WIN32 check

On Mon, 2016-03-21 at 19:14 +0100, Marc-André Lureau wrote: > The egl call is already inside a X11 conditional block. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  src/spice-widget.c | 2 -- >

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

 0x7242c182 in g_main_loop_run () at /lib64/libglib- > 2.0.so.0 >  #10 0x00405df6 in main (argc=, > argv=) at spicy.c:1897 > > It was pointed out during the review and, somehow, missed :-\ > > Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> > Signed-off-by: Pavel

Re: [Spice-devel] [spice-server] doc: Add virgl documentation

On Wed, 2016-03-23 at 17:45 +0100, Christophe Fergeau wrote: > On Wed, Mar 23, 2016 at 05:36:04PM +0100, Pavel Grunt wrote: > > > > Hi Christophe, > > > > On Wed, 2016-03-23 at 17:18 +0100, Christophe Fergeau wrote: > > > > > > On Mon, Mar 21,

Re: [Spice-devel] [PATCH spice-gtk v2 8/8] widget: modify update-area to not require primary surface

Hi, as we discussed, I prefer this patch to go in after 9/8 to avoid some incorrect resizes On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > If egl display is enabled, use GL scanout geometry to check > intersection > with the monitor area. This solves displaying GL display without

Re: [Spice-devel] [PATCH spice-gtk v2 1/8] widget: remove superflous WIN32 check

Acked-by: Pavel Grunt <pgr...@redhat.com> On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > The egl call is already inside a X11 conditional block. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > --- >  src/spice-widget.c | 2 -- >

Re: [Spice-devel] [PATCH spice-gtk v2 5/8] widget: make gl-scanout and update-monitor-area privately exported

Acked-by: Pavel Grunt <pgr...@redhat.com> On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > The following changes will call these functions from spice-widget- > egl.c > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> > --- >  src/spice

Re: [Spice-devel] [PATCH spice-gtk v2 9/8] main: don't update display timer for unchanged config

Hi, So the timer is the main problem ? It also solves/avoids problems with a guest running on wayland when the "resize-guest" property is TRUE. See bug https://bugzilla.redhat.com/show_bug.cgi?id=1266484  It avoids destroying the primary surface when the display configuration has not changed I

Re: [Spice-devel] [PATCH spice-gtk v2 4/8] display: return NULL in spice_display_get_gl_scanout()

Hi Marc-André, On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > If there is no valid scanout, return NULL. When / how it can happen ? Looking at gl_scanout() there is g_return if scanout == NULL, if NULL is a valid/expected return value then that g_return should be changed. Pavel >

Re: [Spice-devel] [PATCH spice-gtk v2 3/8] widget: enable egl before updating scanout

Acked-by: Pavel Grunt <pgr...@redhat.com> On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > The GLArea is realized lazily, when it is made visible in > set_egl_enabled(). The egl context is initialized once the GLArea is > realized. Enable egl before updating the scano

Re: [Spice-devel] [PATCH spice-gtk v2 2/8] egl: check context is ready

Acked-by: Pavel Grunt <pgr...@redhat.com> On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > Add a new GL status field to check if the GL context is ready. This > helps debugging races where GL is called before the context is ready. > > Signed-off-by: Marc-André Lur

Re: [Spice-devel] [PATCH spice-gtk v2 7/8] widget: update d->ready based on scanout image available

Acked-by: Pavel Grunt <pgr...@redhat.com> On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > d->ready is updated based on monitor area & canvas. In case of GL > rendering, update it based on monitor area & scanout and add check > before drawing update. >

Re: [Spice-devel] [PATCH spice-gtk v2 6/8] egl: check and update scanout after egl init

Hi, On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote: > Once the egl/GL context are initialized, check if there is a scanout > to > associate to display widget. This solves races when scanout update is > happening before the egl/GL context is ready. > Is it common that the display

Re: [Spice-devel] [spice-gtk 0/2] Introduce gtask-helper.[ch]

Hi Fabiano, On Wed, 2016-03-23 at 10:48 +0100, Fabiano Fidêncio wrote: > The first patch is only about reverting a patch that, even if it > fixed > the problem, it wasn't done in the proper way. > The second patch introduces and uses new helpers for GTask, providing > them functions that will

Re: [Spice-devel] [PATCH spice-gtk v2 4/8] display: return NULL in spice_display_get_gl_scanout()

On Thu, 2016-03-24 at 11:59 +0100, Marc-André Lureau wrote: > On Thu, Mar 24, 2016 at 12:39 AM, Marc-André Lureau om> wrote: > > > > > > > > When / how it can happen ? Looking at gl_scanout() there is > > > g_return if > > > scanout == NULL, if NULL is a valid/expected return

Re: [Spice-devel] [PATCH 3/5] removed unused tree debugging function

Removed in *39e1cbe3211b06bca6e5d906ffb4d0582440c5cc* I would ack it but Fabiano had some comments about it https://lists.freedesktop.org/archives/spice-devel/2015-November/024060.html On Thu, Mar 24, 2016 at 12:45 PM, Victor Toso wrote: > Hi, > > On Thu, Mar 24,

[Spice-devel] [spice v11 05/27] replay: Add an option to change video codec

--- server/tests/replay.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/server/tests/replay.c b/server/tests/replay.c index 7e4659b..025b20c 100644 --- a/server/tests/replay.c +++ b/server/tests/replay.c @@ -290,7 +290,7 @@ int main(int argc, char **argv) {

[Spice-devel] [PATCH spice-gtk] usb-device-manager: Remove invalid return annotation

--- src/usb-device-manager.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 417c5b2..85231a1 100644 --- a/src/usb-device-manager.c +++ b/src/usb-device-manager.c @@ -1568,8 +1568,6 @@ gboolean

Re: [Spice-devel] [spice-server] doc: Add virgl documentation

Thanks! Acked-by: Pavel Grunt <pgr...@redhat.com> On Fri, 2016-03-18 at 17:12 +0100, Christophe Fergeau wrote: > Document how to use virgl with QEMU/libvirt > > virt-manager documentation still needs to be added. > --- >  docs/m

[Spice-devel] [PATCH spice-gtk] Remove extra checks before g_cancellable_disconnect()

If cancellable is NULL or handler_id is 0 the function does nothing. --- src/spice-pulse.c | 4 +--- src/vmcstream.c | 15 +++ 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/src/spice-pulse.c b/src/spice-pulse.c index 8d45dbe..6bc3014 100644 --- a/src/spice-pulse.c

Re: [Spice-devel] [spice-gtk] Avoid to access array with negative numbers

Hi, according to GdkEventButton documentation [0] the 'button' is guint so the button_gdk_to_spice() should take guint instead of int. Pavel [0] https://developer.gnome.org/gdk3/stable/gdk3-Event-Structures.html# GdkEventButton On Wed, 2016-03-23 at 15:28 +, Frediano Ziglio wrote: > --- >  

Re: [Spice-devel] [PATCH 2/2] use macro to define constructor function

On Mon, 2016-02-29 at 10:36 +, Frediano Ziglio wrote: > Avoid having to call function at runtime to inialize static. > Old functions are defined as deprecated for compatibility. > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> Acked-by: Pavel Grunt <pgr...@redhat

Re: [Spice-devel] [spice-gtk v2] Avoid to access array with negative numbers

On Wed, 2016-03-23 at 15:40 +, Frediano Ziglio wrote: Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  src/spice-widget.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > Changes from v1: > - make parameter guint as GdkEventButton::button is guint. >

Re: [Spice-devel] [PATCH] use constructor/destructor macros

> > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  server/red-qxl.c | 7 --- >  server/reds.c| 7 +-- >  spice-common | 2 +- >  3 files changed, 2 insertions(+), 14 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v2 spice-gtk 2/2] widget: use allocation instead of window size

-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> Thanks, Pavel > --- >  src/Makefile.am  |  1 - >  src/gtk-compat.h | 31 --- >  src/spice-gtk-session.c  |  1 - >  src/spice-widget-cairo.c | 

Re: [Spice-devel] [spice-server] doc: Add virgl documentation

Hi Christophe, On Wed, 2016-03-23 at 17:18 +0100, Christophe Fergeau wrote: > On Mon, Mar 21, 2016 at 03:28:41PM +0100, Christophe Fergeau wrote: > > > > On Mon, Mar 21, 2016 at 02:57:18PM +0100, Pavel Grunt wrote: > > > > > > Thanks! > > > >

Re: [Spice-devel] [PATCH v3 6/9] egl: check and update scanout after egl init

Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  src/spice-widget-egl.c | 6 ++ >  1 file changed, 6 insertions(+) > > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c > index 151970c..b9bec68 100644 > --

Re: [Spice-devel] [PATCH spice-gtk v2 8/8] widget: modify update-area to not require primary surface

On Wed, 2016-03-23 at 19:32 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > > > Hi, > > > > as we discussed, I prefer this patch to go in after 9/8 to avoid > > some > > incorrect resizes > Ok > > > > > > > On Tue, 2016-03-22 at 13:57 +0100, Marc-André Lureau wrote:

Re: [Spice-devel] [spice-html5] Fix 2 typos in comments

Acked-by: Pavel Grunt <pgr...@redhat.com> On Tue, 2016-03-08 at 11:39 +0100, Christophe Fergeau wrote: > --- >  utils.js | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utils.js b/utils.js > index 9eb42ff..f1a5748 100644 > --- a/utils.js &

[Spice-devel] [spice v10 07/27] replay: Add an option to change video codec

Signed-off-by: Francois Gouget --- server/tests/replay.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/server/tests/replay.c b/server/tests/replay.c index f3b670f..5bbca5e 100644 --- a/server/tests/replay.c +++ b/server/tests/replay.c @@

[Spice-devel] [PATCH spice-gtk] widget-egl: Define label only if can be used

The label can be used only with GDK_WINDOWING_WAYLAND Silence -Wunused-label --- src/spice-widget-egl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c index 51bb5c5..c54d9f6 100644 --- a/src/spice-widget-egl.c +++ b/src/spice-widget-egl.c

Re: [Spice-devel] "undefined reference" errors while running make

Hi, On Mon, 2016-04-04 at 09:59 +0200, Christophe Fergeau wrote: > On Sat, Apr 02, 2016 at 02:14:11PM +, Mahmood Naderan wrote: > > > > Hi Eduardo,I have to say that the latest git revision doesn't > > include your patch.  So, I applied your patch manually into the > > latest revision. > >

Re: [Spice-devel] [spice-common 1/3] log: Clamp SPICE_DEBUG_LEVEL if it's too high

Hi, ack for the series. Pavel On Tue, 2016-04-05 at 12:56 +0200, Christophe Fergeau wrote: > This matches how SPICE_DEBUG_LEVEL behaved before switching to glib > logging. > --- >  common/log.c | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/common/log.c b/common/log.c > index

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

Hi, I agree that there should be the only one typedef. But I don't understand why not to include the needed header directly. We should try to "untagle" these header dependencies. Pavel On Wed, 2016-03-30 at 11:46 +0200, Christophe Fergeau wrote: > This is causing compile errors with older gcc

Re: [Spice-devel] [spice-server 2/3] Update NEWS for 0.13.1

The series looks good, ack Pavel On Wed, 2016-03-30 at 11:46 +0200, Christophe Fergeau wrote: > --- >  NEWS | 14 +- >  1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index e906e88..ecedcd8 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,4 +1,4 @@ > -Major

Re: [Spice-devel] [spice-gtk] build-sys: Update symbol files

On Wed, 2016-03-30 at 10:59 +0200, Christophe Fergeau wrote: > The OSX-specific symbol files were not updated after the recent API > additions/removals, and some removed symbols were still listed in > map-file. Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  src/ma

Re: [Spice-devel] [PATCH spice-gtk 0/6] Fixes for autogenerated documentation

On Wed, 2016-03-30 at 10:49 +0200, Christophe Fergeau wrote: > Acked-by: Christophe Fergeau <cferg...@redhat.com> > Thank you, pushed > On Wed, Mar 30, 2016 at 09:00:15AM +0200, Pavel Grunt wrote: > > > > Hi, > > > > Following patches adjust

Re: [Spice-devel] [spice-server] doc: Add virgl documentation

On Thu, 2016-03-24 at 13:58 +0100, Christophe Fergeau wrote: > On Wed, Mar 23, 2016 at 05:59:03PM +0100, Pavel Grunt wrote: > > > > On Wed, 2016-03-23 at 17:45 +0100, Christophe Fergeau wrote: > > > > > > But it seems these are good enough, when I te

[Spice-devel] [PATCH spice-gtk] widget: Use parentheses around ternary conditional

"&&" has higher precedency than "?:" Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94738 --- src/spice-widget.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 21b1c14..67a9cc1 100644 --- a/src/spice-widget.c +++

Re: [Spice-devel] [PATCH 01/11] Rename some missing names related to RedCharDevice

Acked-by: Pavel Grunt <pgr...@redhat.com> On Fri, 2016-04-01 at 13:37 +0100, Frediano Ziglio wrote: > --- >  server/char-device.c | 6 +++--- >  server/char-device.h | 2 +- >  server/reds.c| 2 +- >  3 files changed, 5 insertions(+), 5 deletions(-) > > diff --g

[Spice-devel] [PATCH spice-gtk v2] widget: Avoid combining ternary with another operators

Logical operators like "&&" has higher precedency than "?:". Readiness of SpiceDisplay was wrongly determined due to missing parentheses around the ternary operator. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=94738 --- src/spice-widget.c | 11 ++- 1 file changed, 6

Re: [Spice-devel] [PATCH spice-gtk] widget: Use parentheses around ternary conditional

On Tue, 2016-03-29 at 15:39 +0200, Victor Toso wrote: > Hey, > > Works fine! Thanks! > > On Tue, Mar 29, 2016 at 03:03:03PM +0200, Pavel Grunt wrote: > > > > "&&" has higher precedency than "?:" > Maybe a small summary of the iss

[Spice-devel] [PATCH spice-gtk 2/6] doc: Remove private structs

--- doc/reference/spice-gtk-sections.txt | 7 --- 1 file changed, 7 deletions(-) diff --git a/doc/reference/spice-gtk-sections.txt b/doc/reference/spice-gtk-sections.txt index 0c05168..a6fcfbf 100644 --- a/doc/reference/spice-gtk-sections.txt +++ b/doc/reference/spice-gtk-sections.txt @@

[Spice-devel] [PATCH spice-gtk 4/6] spice-file-transfer-task: Fix docstring

--- src/spice-file-transfer-task.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-file-transfer-task.h b/src/spice-file-transfer-task.h index b97d107..18dc509 100644 --- a/src/spice-file-transfer-task.h +++ b/src/spice-file-transfer-task.h @@ -37,7 +37,7 @@ typedef

[Spice-devel] [PATCH spice-gtk 5/6] doc: Ignore spicy-connect

--- doc/reference/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/reference/Makefile.am b/doc/reference/Makefile.am index cb01f97..5aa8557 100644 --- a/doc/reference/Makefile.am +++ b/doc/reference/Makefile.am @@ -46,6 +46,7 @@ IGNORE_HFILES=

[Spice-devel] [PATCH spice-gtk 1/6] usb-device-manager: Fix docstring

Add description, "Since" and change the parameter name in the docstring to match parameter name in the function definition. --- doc/reference/spice-gtk-sections.txt | 1 + src/usb-device-manager.c | 14 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git

[Spice-devel] [PATCH spice-gtk 6/6] doc: Add description for spice_display_get_gl_scanout()

--- src/channel-display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/channel-display.c b/src/channel-display.c index 90d155e..431c2e7 100644 --- a/src/channel-display.c +++ b/src/channel-display.c @@ -532,6 +532,8 @@ void spice_display_change_preferred_compression(SpiceChannel

[Spice-devel] [PATCH spice-gtk 3/6] doc: channel stability should be Stable

--- src/channel-smartcard.c | 2 +- src/channel-usbredir.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/channel-smartcard.c b/src/channel-smartcard.c index 7f3306e..21df98a 100644 --- a/src/channel-smartcard.c +++ b/src/channel-smartcard.c @@ -35,7 +35,7 @@ *

[Spice-devel] [PATCH spice-gtk 0/6] Fixes for autogenerated documentation

Hi, Following patches adjust autogenerated docs (can be found at [0]) to recent changes (some classes are final now, there are new functions). They also silence some warnings when the docs are generated. Pavel [0] http://www.spice-space.org/spice-gtk.html Pavel Grunt (6): usb-device-manager

Re: [Spice-devel] [PATCH spice-gtk 1/2] widget: offset draw updates by widget allocation if necessary

floor ((d->mouse_guest_y - d->mouse_hotspot.y - > d->area.y) * s) + y, > +ceil (gdk_pixbuf_get_width(d->mouse_pixbuf) * > s), > +ceil (gdk_pixbuf_get_height(d->mouse_pixbuf) * > s)); >  } >   >  static void cursor_move(SpiceCursorChannel *channel, gint x, gint y, > gpointer data) Acked-by: Pavel Grunt <pgr...@redhat.com> and thanks for fixing it! Pavel ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 2/2] widget: use allocation instead of window size

Hi, This fixes the "top border" in spicy. considering how the allocation is used I would prefer some helper function to get the width and height.  Thanks, Pavel On Tue, 2016-03-22 at 19:27 +0100, Marc-André Lureau wrote: > Since spice-gtk 57df040cc, the SpiceDisplay no longer forces its own >

Re: [Spice-devel] [spice-common] tests: Fix glib version check

Ack, Pavel On Thu, 2016-03-31 at 13:35 +0200, Christophe Fergeau wrote: > The glib version checks were using #ifdef GLIB_CHECK_VERSION() rather > than  #if GLIB_CHECK_VERSION() > --- >  tests/test-logging.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH 01/14] Store display in Drawable struct

Hi Jonathon, On Thu, 2016-04-21 at 16:43 -0500, Jonathon Jongsma wrote: > If the Drawable keeps a pointer to the Display channel that it is > associated with, we can unref it directly and not need to pass the > 'display' parameter separately to the unref function So drawable needs 'display' just

Re: [Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

On Fri, 2016-04-22 at 09:57 +0200, Javier Celaya wrote: > Hi > > El 22/04/16 a las 09:19, Pavel Grunt escribió: > > Hi Javier, > > > > sorry, I must have missed the patch. Can you please explain the problem? How > > to > > reproduce it? Is it about

Re: [Spice-devel] [spice-gtk] Spice-widget: Allow smaller widget with scaling enabled

Hi Javier, sorry, I must have missed the patch. Can you please explain the problem? How to reproduce it? Is it about spicy? About the patch - you should declare the update_size_request() function instead of moving scaling_updated() down - it would be more clear what has changed. Thanks, Pavel 

Re: [Spice-devel] How to look information of the debugging of spice-server?

Hello, On Fri, 2016-04-22 at 15:43 +0800, #嚣张的狼# wrote: >        Thank you for taking time out of your busy schedule to see this > letter.I am student who has been studying Spice and have some questions about > using Spice-server. > >         Recently, I am studying some pathes released in

Re: [Spice-devel] [spice-gtk v2] Spice-widget: Allow smaller widget with scaling enabled

Hi Javier, Acked-by: Pavel Grunt <pgr...@redhat.com> On Fri, 2016-04-22 at 10:08 +0200, Javier Celaya wrote: > When resize-guest-to-match-window-size is disabled, the size request > (minimum size) of the spice widget is set to the current guest > resolution. The client window

[Spice-devel] [PATCH spice 4/4] manual: Remove spicec screenshot

--- docs/manual/images/spicec01.png | Bin 10244 -> 0 bytes docs/manual/manual.txt | 4 2 files changed, 4 deletions(-) delete mode 100644 docs/manual/images/spicec01.png diff --git a/docs/manual/images/spicec01.png b/docs/manual/images/spicec01.png deleted file mode 100644

[Spice-devel] [PATCH spice 3/4] manual: No need to use sudo to run qemu

--- docs/manual/manual.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index 348e5e0..f172ab4 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt @@ -240,7 +240,7 @@ population. I assume that you have a locally

[Spice-devel] [PATCH spice 2/4] manual: Recommend UsbDk instead of USB Clerk

--- docs/manual/manual.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index 3f869bf..348e5e0 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt @@ -1026,8 +1026,8 @@ The recommended way of getting all the

[Spice-devel] [PATCH spice-gtk 2/2] channel: Abort migration in delayed unref

When channel is unref'ed during migration migrate_channel_event_cb is called causing a crash by coroutine yielding to nonexistent channel. As comment in spice_channel_coroutine says: Co-routine exits now - the SpiceChannel object may no longer exist, so don't do anything else now unless you

[Spice-devel] [PATCH spice-gtk 1/2] channel-main: Use CHANNEL_DEBUG for migration events

To show which channel got an error or an unhandled event --- src/channel-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-main.c b/src/channel-main.c index 604f333..3966e49 100644 --- a/src/channel-main.c +++ b/src/channel-main.c @@ -2286,7 +2286,7 @@ static

Re: [Spice-devel] [PATCH spice 1/4] manual: Recommend enabling monitors using remote-viewer's menu

On Fri, 2016-04-22 at 16:01 +0200, Christophe Fergeau wrote: > ACK series. Pushed, thanks > > Christophe > > On Fri, Apr 22, 2016 at 03:09:03PM +0200, Pavel Grunt wrote: > > --- > >  docs/manual/manual.txt | 5 ++--- > >  1 file changed, 2 insertions(+), 3 deleti

Re: [Spice-devel] How to modify spice version?

Hi, On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: > Thank you for taking time out of your busy schedule to see this letter. > I am trying to compile spice downloaded from github, but the versions of these > are 'UNKNOWN'. when I compiled QEMU with these spice, there have some errors > in the

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: Abort migration in delayed unref

Hi, On Tue, 2016-04-26 at 12:05 +0200, Victor Toso wrote: > Hi, > > On Fri, Apr 22, 2016 at 04:47:48PM +0200, Pavel Grunt wrote: > > When channel is unref'ed during migration migrate_channel_event_cb > > is called causing a crash by coroutine yielding to nonexistent channel

Re: [Spice-devel] [PATCH] Fix make dist

On Mon, 2016-04-25 at 17:21 -0300, Eduardo Lima (Etrunko) wrote: > spicec screenshot has been removed since commit > b0186fe1267dfa2b8534c7c083dc301791279f08 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Acked-by: Pavel Grunt <pgr...@redhat.com> Tha

Re: [Spice-devel] [PATCH spice-gtk v3 6/7] spice-uri: Check if port is in allowed range

On Fri, 2016-05-20 at 14:50 +0200, Christophe Fergeau wrote: > On Thu, May 19, 2016 at 06:38:08PM +0200, Pavel Grunt wrote: > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c| 8 ++-- > >  tests/test-spice-uri.c | 2 ++ > >  2 files chan

Re: [Spice-devel] [spice v14 00/29] Add GStreamer support for video streaming

Hi Francois, I pushed the spice-gtk part upstream. Thanks! Pavel On Wed, 2016-05-04 at 11:40 +0200, Francois Gouget wrote: > This patch series adds support for using GStreamer to encode and  > decode the video streams, adding support for VP8 and h264 codecs. > > As before the patches can also

Re: [Spice-devel] [PATCH 1/2] Remove unnecessary cursor_pipe_item_ref()

Hi, Am I right that your next step is to remove hold_item() ? On Thu, 2016-05-19 at 14:05 -0500, Jonathon Jongsma wrote: > Use the base red_pipe_item_ref() instead of adding an additional static > wrapper function. Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  server/cur

Re: [Spice-devel] [PATCH 2/2] Simplify DisplayChannel hold_item()

On Thu, 2016-05-19 at 14:05 -0500, Jonathon Jongsma wrote: > Since all pipe items implement refcounting now, just call > red_pipe_item_ref() and eliminate the switch statement. Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  server/display-channel.c | 11 +-- &g

Re: [Spice-devel] [PATCH spice-gtk v3 5/7] spice-uri: Do not allow empty port string

On Fri, 2016-05-20 at 10:32 +0200, Victor Toso wrote: > Hi, > > On Thu, May 19, 2016 at 06:38:07PM +0200, Pavel Grunt wrote: > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c| 3 +++ > >  tests/test-spice-uri.c | 1 + > >  2 files changed, 4

Re: [Spice-devel] [PATCH spice-gtk v3 3/7] spice-uri: Add missing include

On Fri, 2016-05-20 at 10:14 +0200, Victor Toso wrote: > Hi, > > On Thu, May 19, 2016 at 06:38:05PM +0200, Pavel Grunt wrote: > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/src/sp

Re: [Spice-devel] [PATCH spice-gtk v3 7/7] spice-uri: Add ipv6 support

On Fri, 2016-05-20 at 10:54 +0200, Victor Toso wrote: > Hi, > > On Thu, May 19, 2016 at 06:38:09PM +0200, Pavel Grunt wrote: > > Just basic support -  http://user:password@[host]:port > > > > Resolves: rhbz#1335239 > > --- > >  src/spice-uri.c|

Re: [Spice-devel] [PATCH spice-gtk v3 6/7] spice-uri: Check if port is in allowed range

On Fri, 2016-05-20 at 10:36 +0200, Victor Toso wrote: > Hi, > > On Thu, May 19, 2016 at 06:38:08PM +0200, Pavel Grunt wrote: > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c| 8 ++-- > >  tests/test-spice-uri.c | 2 ++ > >  2 file

Re: [Spice-devel] [PATCHv2 1/3] egl: don't destroy wayland egl context

On Mon, 2016-05-23 at 13:01 +0200, Marc-André Lureau wrote: > The egl context is from Gtk on Wayland. Destroy it only on X11. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@gmail.com> Acked-by: Pavel Grunt <pgr...@redhat.com> > --- >  

Re: [Spice-devel] [PATCH spice-gtk v2 3/5] spice-uri: Set user & password to NULL when not specified

On Thu, 2016-05-19 at 06:24 -0400, Frediano Ziglio wrote: > > > > > > Avoid using old values after parsing a new uri. > > > > Related: rhbz#1335239 > > --- > >  src/spice-uri.c| 3 +++ > >  tests/test-spice-uri.c | 2 +- > >  2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff

[Spice-devel] [PATCH spice-gtk v3 0/7] Allow ipv6 proxy url

by Frediano and Victor: - more tests (missing port, missing ending bracket) - tests are defined in array, so it is easier to add new test cases - follow ipv6 address format http://user:password@[ipv6]:port Thanks,* Pavel Grunt (7): tests: Add test for SpiceUri spice-uri: Mark parameter

<    2   3   4   5   6   7   8   9   10   11   >