Re: [Spice-devel] virt-viewer on win10 32bit abort when pulling out the USB

2018-01-14 Thread Sameeh Jubran
h other usb devices? > Can you help me for this ? Thanks . > > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel > > -- Respectfully, *Sameeh

Re: [Spice-devel] virt-viewer on win10 32bit abort when pulling outthe USB

2018-01-15 Thread Sameeh Jubran
can further investigate the issue =) > > > -- Original -- > *From: * "Sameeh Jubran"; > *Date: * Mon, Jan 15, 2018 00:22 AM > *To: * "王杰东"; > *Cc: * "spice-devel"; > *Subject: * Re: [Spice-devel] virt-viewer on win10 32bit abor

Re: [Spice-devel] virt-viewer on win10 32bit abort when pullingoutthe USB

2018-01-28 Thread Sameeh Jubran
/Tracing.txt> [5] - https://cgit.freedesktop.org/spice/usbredir/tree/usbredirhost/usbredirhost.h#n96 > > Frediano > > > ------ > > *From: *"王杰东" > *To: *"Sameeh Jubran" > *Cc: *"Yan Vugenfirer" , "spice-devel" freed

Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-15 Thread Sameeh Jubran
On Fri, Apr 13, 2018 at 7:16 PM, Frediano Ziglio wrote: > > > > Limited the installation of the driver to Windows 8 and up > > in order to prevent false driver installation on unsupported OSes > > which lead to BSODs. > > > > Signed-off-by: Basil Salm

Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-22 Thread Sameeh Jubran
ping. On Sun, Apr 15, 2018 at 10:44 AM, Sameeh Jubran wrote: > > > On Fri, Apr 13, 2018 at 7:16 PM, Frediano Ziglio > wrote: > >> > >> > Limited the installation of the driver to Windows 8 and up >> > in order to prevent false driver installation on

Re: [Spice-devel] how to debug spice-gtk on windows

2018-04-26 Thread Sameeh Jubran
e or email immediately and delete it! > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel > > -- Respectfully, *Sameeh Jubran

Re: [Spice-devel] [RFC PATCH vdagent 14/16] Adding ioctl operation to update Vdagent state

2016-07-20 Thread Sameeh Jubran
This style was used in order to match the current style of VDAgent. On Mon, Jul 18, 2016 at 10:54 AM, Frediano Ziglio wrote: > > > > From: Sameeh Jubran > > > > This patch adds new ioctl operation to Vdagent in order to update > > the driver on Vdagent state.

[Spice-devel] [PATCH vdagent] Fixing buffer overflow when reloading wallpaper

2016-08-01 Thread Sameeh Jubran
_ELEMENTS. Based on patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/display_setting.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vdagent/display_setting.cpp b/vdagent/display_setting.cpp index 1ec7397..c261b67

[Spice-devel] [PATCH win-vdagent] Provide support for Windows CCD API

2016-08-02 Thread Sameeh Jubran
resolution on Windows 10. Tested with both Windows 10 and Windows 7. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- Makefile.am |2 + vdagent/desktop_layout.cpp| 150 ++ vdagent/desktop_layout.h

Re: [Spice-devel] [PATCH win-vdagent] Provide support for Windows CCD API

2016-08-03 Thread Sameeh Jubran
rg/archives/spice-devel/2016-July/030796.html ). Moreover they are now present in the cpp files. > Christophe > -- Respectfully, *Sameeh Jubran* *Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>* *Junior Software Engineer @ Daynix <http://www.daynix.com>.* ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH win-vdagent v2 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-03 Thread Sameeh Jubran
thing else that we didn't find here was written from scratch. * Dropped friend modifier for WDDMInterface in the CCD class. * Dropped DRIVER_TYPE member entirely and replaced with throwing an exception from ctor. * Cosmetic changes Sameeh Jubran (2): Introducing Windows CCD API Implementin

[Spice-devel] [PATCH win-vdagent v2 1/2] Introducing Windows CCD API

2016-08-03 Thread Sameeh Jubran
resolution on Windows 10. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- Makefile.am | 2 + vdagent/display_configuration.cpp | 509 ++ vdagent/display_configuration.h | 94 +++ 3

[Spice-devel] [PATCH win-vdagent v2 2/2] Implementing multiple monitors and arbitrary resolution

2016-08-03 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++ vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent] Adding a new ioctl to vdagent

2016-08-03 Thread Sameeh Jubran
Sameeh Jubran (1): Adding ioctl operation to update Vdagent state vdagent/desktop_layout.cpp| 21 + vdagent/desktop_layout.h | 1 + vdagent/display_configuration.cpp | 16 vdagent/display_configuration.h | 3 ++- 4 files changed, 40

[Spice-devel] [PATCH win-vdagent] Adding ioctl operation to update Vdagent state

2016-08-03 Thread Sameeh Jubran
client mouse mode should be enabled when it is on. The mouse mode is updated by the driver and thus this patch is needed. Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 21 + vdagent/desktop_layout.h | 1 + vdagent/display_configuration.cpp

Re: [Spice-devel] [PATCH win-vdagent v2 1/2] Introducing Windows CCD API

2016-08-04 Thread Sameeh Jubran
troduces partial functionality from the CCD API > > needed by vdagent. It is needed by vdagent in order to support > > multiple monitors and arbitrary resolution on Windows 10. > > > > Based on a patch by Sandy Stutsman > > > > Signed-off-by:

[Spice-devel] [PATCH spice-protocol] Adding a new ioctl for windows header

2016-08-04 Thread Sameeh Jubran
This patch adds the necessary stuctures and definitions to spice-protocol in order to define a new ioctl fow Windows. It should be applied along with this patch: https://lists.freedesktop.org/archives/spice-devel/2016-August/031056.html Sameeh Jubran (1): Adding new ioctl for updating Vdagent

[Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

2016-08-04 Thread Sameeh Jubran
New ioctl for updating the driver with vdagent running state. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index bc2ceff..6e557f7 100644 --- a/spice/qxl_windows.h +++ b

[Spice-devel] [PATCH win-vdagent v3 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-04 Thread Sameeh Jubran
Diffrences from previous patch: * Replaced LoadLibrary/FreeLibrary with GetModuleHandle. * Replaced malloc/free with new(std::nothrow)/delete Sameeh Jubran (2): Introducing Windows CCD API Implementing multiple monitors and arbitrary resolution Makefile.am |2

[Spice-devel] [PATCH win-vdagent v3 1/2] Introducing Windows CCD API

2016-08-04 Thread Sameeh Jubran
resolution on Windows 10. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- Makefile.am | 2 + vdagent/display_configuration.cpp | 504 ++ vdagent/display_configuration.h | 94 +++ 3

[Spice-devel] [PATCH win-vdagent v3 2/2] Implementing multiple monitors and arbitrary resolution

2016-08-04 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++ vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent v4 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-07 Thread Sameeh Jubran
t_device_name_config". * Cosmetic changes. Sameeh Jubran (2): Introducing Windows CCD API Implementing multiple monitors and arbitrary resolution Makefile.am |2 + vdagent/desktop_layout.cpp| 148 ++ vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent v4 2/2] Implementing multiple monitors and arbitrary resolution

2016-08-07 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++ vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent v4 1/2] Introducing Windows CCD API

2016-08-07 Thread Sameeh Jubran
resolution on Windows 10. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- Makefile.am | 2 + vdagent/display_configuration.cpp | 505 ++ vdagent/display_configuration.h | 92 +++ 3

Re: [Spice-devel] [PATCH win-vdagent] Adding ioctl operation to update Vdagent state

2016-08-08 Thread Sameeh Jubran
t; >> I mean, is there any tool/command line switch that we can use to > check this case? > > > > > > Yes! spicy has a `toggle mouse mode` in the options (shift + F7) > > > > Cool, I did not know this. > > Is there pre-compiled spicy binary that we can

Re: [Spice-devel] [PATCH win-vdagent] Adding ioctl operation to update Vdagent state

2016-08-08 Thread Sameeh Jubran
; > >>> > > > > > > >>> Check: > > > > > > >>> https://cgit.freedesktop.org/spice/spice-gtk/commit/?id= > 5f89a4df037f6a1f2 > > > > > > >> > > > > > > >> I mean, is there any tool/comma

Re: [Spice-devel] [PATCH win-vdagent] Adding ioctl operation to update Vdagent state

2016-08-08 Thread Sameeh Jubran
>>>>> https://cgit.freedesktop.org/spice/spice-gtk/commit/?id= > 5f89a4df037f6a1f2 > > >> > > >>>>>> > > >> > > >>>>>> I mean, is there any tool/command line switch that we can use to > check > > >>>>>&g

Re: [Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

2016-08-08 Thread Sameeh Jubran
Hi, This patch fixes the issue with pointer not showing up in server mode, when vdagent is off. On Thu, Aug 4, 2016 at 3:17 PM, Christophe Fergeau wrote: > On Thu, Aug 04, 2016 at 02:02:08PM +0300, Sameeh Jubran wrote: > > New ioctl for updating the driver with vdagent runn

[Spice-devel] [PATCH spice-protocol v2] Adding new ioctl for updating Vdagent state

2016-08-08 Thread Sameeh Jubran
mouse mode pointer should be enabled when vdagent is off and the client mouse mode should be enabled when it is on. The mouse mode is updated by the driver and thus this patch is needed. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[Spice-devel] [PATCH spice-protocol v2] Adding a new ioctl for windows header

2016-08-08 Thread Sameeh Jubran
. Sameeh Jubran (1): Adding new ioctl for updating Vdagent state spice/qxl_windows.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.7.4 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org

Re: [Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

2016-08-08 Thread Sameeh Jubran
at 06:19:41PM +0300, Sameeh Jubran wrote: > > > > > This patch enables the driver to send move commands to the QXL device > when > > vdagent is off. > > This maybe the reason you are not getting any move commands. > > But don't we have exactly the same i

Re: [Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

2016-08-08 Thread Sameeh Jubran
g...@redhat.com > > > > wrote: > > > > On Mon, Aug 08, 2016 at 06:19:41PM +0300, Sameeh Jubran wrote: > > > > > > > > > > > > > This patch enables the driver to send move commands to the QXL device > > > > when > > >

Re: [Spice-devel] [PATCH] Adding new ioctl for updating Vdagent state

2016-08-08 Thread Sameeh Jubran
gt; seems wrong from your rationale. > > Also "adds new ioctl operation to Vdagent" the ioctl is implemented > in the driver so I would say "adds new ioctl operation to the driver in > order to allow Vdagent to communicate its state to the driver". > > Frediano &

[Spice-devel] [PATCH win-vdagent v5 3/3] Adding ioctl operation to update Vdagent state

2016-08-09 Thread Sameeh Jubran
client mouse mode should be enabled when it is on. The mouse mode is updated by the driver and thus this patch is needed. Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 21 + vdagent/desktop_layout.h | 1 + vdagent/display_configuration.cpp

[Spice-devel] [PATCH win-vdagent v5 2/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-09 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 355

[Spice-devel] [PATCH win-vdagent v5 0/3] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-09 Thread Sameeh Jubran
Diffrences from previous patches: * splitted the patches into three. Sameeh Jubran (3): Encapsulating XPDM implementation Implementing WDDM interface to support multiple monitors and arbitrary resolution Adding ioctl operation to update Vdagent state vdagent/desktop_layout.cpp

[Spice-devel] [PATCH win-vdagent v5 1/3] Encapsulating XPDM implementation

2016-08-09 Thread Sameeh Jubran
class. This patch makes it easier to introduce WDDM interface to Vdagent in future patches. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++- vdagent/desktop_layout.h

Re: [Spice-devel] [PATCH win-vdagent v5 0/3] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-09 Thread Sameeh Jubran
Please ignore those patches, I haven't sent them correctly! Sending V6... On Tue, Aug 9, 2016 at 10:29 AM, Sameeh Jubran wrote: > Diffrences from previous patches: > * splitted the patches into three. > > Sameeh Jubran (3): > Encapsulating XPDM implementation > Impl

[Spice-devel] [PATCH win-vdagent v6 1/3] Introducing Windows CCD API

2016-08-09 Thread Sameeh Jubran
resolution on Windows 10. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- Makefile.am | 2 + vdagent/display_configuration.cpp | 505 ++ vdagent/display_configuration.h | 92 +++ 3

[Spice-devel] [PATCH win-vdagent v6 0/3] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-09 Thread Sameeh Jubran
Diffrences from previous patches (v4, v5 should be ignored): * splitted the patches into three. Sameeh Jubran (3): Introducing Windows CCD API Encapsulating XPDM implementation Implementing WDDM interface to support multiple monitors and arbitrary resolution Makefile.am

[Spice-devel] [PATCH win-vdagent v6 2/3] Encapsulating XPDM implementation

2016-08-09 Thread Sameeh Jubran
class. This patch makes it easier to introduce WDDM interface to Vdagent in future patches. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++- vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent v6 3/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-09 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 355

[Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

2016-08-09 Thread Sameeh Jubran
<#ifdef USE_FRAMEBUFFER> with runtime logic Fixing framebuffer usage logic Support future Qxl revisions Set SupportNonVGA in QueryAdapterInfo callback Sameeh Jubran (9): Upgrade to Windows 10 WDK Add delete operator Code Analysis clean up Replacing tabs with spaces Fix source

[Spice-devel] [PATCH qxl-wddm-dod 03/26] Add printer class to dump debug print statements to kernel debugger output

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman Allows the usage of Kd_IHVVIDEO_Mask to control print level while debugging Signed-off-by: Sameeh Jubran --- qxldod/driver.cpp | 24 +++- qxldod/driver.h | 20 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a

[Spice-devel] [PATCH qxl-wddm-dod 05/26] Fix Code Integrity error generated by the Drive Verifier

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman Add MdlMappingNoExecute to MmGetSystemAddressForMDLSafe call in ExecutePresentDisplayOnly. --- qxldod/QxlDod.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 77f4f86..1225f04 100755 --- a/qxldod/QxlDod.cp

[Spice-devel] [PATCH qxl-wddm-dod 02/26] Add delete operator

2016-08-09 Thread Sameeh Jubran
Based on a patch by Sandy Stutsman Signed-off-by: Sameeh Jubran --- qxldod/BaseObject.cpp | 11 +++ qxldod/BaseObject.h | 1 + 2 files changed, 12 insertions(+) diff --git a/qxldod/BaseObject.cpp b/qxldod/BaseObject.cpp index ac270fd..a93c040 100755 --- a/qxldod/BaseObject.cpp

[Spice-devel] [PATCH qxl-wddm-dod 01/26] Upgrade to Windows 10 WDK

2016-08-09 Thread Sameeh Jubran
* Added Windows 10 Configurations and removed older ones. * Migration to Visual Studio 2015. * Set Allow Date, Time and Timestamp property for all builds/platforms. * Fixed up project configuration names to be consistent. * unified build output directories * Simple build script added Signed-o

[Spice-devel] [PATCH qxl-wddm-dod 07/26] Do not use virtual functions for code that must not be paged

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman There is no way to guarantee that the static vtable will be in non-pageable memory. This patch converts 3 virtual non-pageble functions to functions private to each device class, the parent class will make an explicit call (based on a new device type initialized at object cr

[Spice-devel] [PATCH qxl-wddm-dod 04/26] Set DriverStarted flag at the begining of the StartDriver function

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman With the Driver Verifier on, a DPC generated during the call will assert if the flag is not set. Changed error handling so that if something fails, the code will break out of a do loop and reset the flag to false before returning the error status. --- qxldod/QxlDod.cpp | 11

[Spice-devel] [PATCH qxl-wddm-dod 06/26] Add functions called from non-pageable functions to non-paged segments

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman Found by Driver Verifier --- qxldod/QxlDod.cpp | 55 --- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 1225f04..1b3bdf1 100755 --- a/qxldod/QxlDod.cpp +++ b/qxld

[Spice-devel] [PATCH qxl-wddm-dod 09/26] Use SrcPitch when calculating size of memory to map PresentDisplayOnly

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman Otherwise, can result in a BSOD. --- qxldod/QxlDod.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 9d13934..7b60e0c 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -3606,7 +3606,7 @@ QxlDevice::Exe

[Spice-devel] [PATCH qxl-wddm-dod 11/26] Add arbitrary resolution and monitors_config Escape

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman Implement the escapes for the qxl driver and add some debug output for multiple monitor support --- qxldod/QxlDod.cpp| 162 ++- qxldod/QxlDod.h | 11 ++- qxldod/include/qxl_windows.h | 1 + 3 files changed,

[Spice-devel] [PATCH qxl-wddm-dod 13/26] Use the second bar (VRAM) for qxl command buffer.

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman --- qxldod/QxlDod.cpp | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index a328d2d..e6c4ada 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -3429,7 +34

[Spice-devel] [PATCH qxl-wddm-dod 10/26] Remove unused notify present display only interrupt and fix interrupt mask

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman This interrupt is used for asynchronous present calls. Fixed the interrupt mask to reflect currently used interrupts. --- qxldod/QxlDod.cpp | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp inde

[Spice-devel] [PATCH qxl-wddm-dod 08/26] On power wake call the init functions before setting the vidpn to black. Otherwise, BSOD.

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman --- qxldod/QxlDod.cpp | 66 --- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index ec960e5..9d13934 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -284,12

[Spice-devel] [PATCH qxl-wddm-dod 15/26] Enable HW cursor support and fix handling of monochrome cursors.

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman * Turn on enable pointer * Allow for 1bpp bitmap followed by 1bpp XOR map. --- qxldod/QxlDod.cpp | 19 +++ qxldod/QxlDod.h | 2 +- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index ff987c4..3139092

[Spice-devel] [PATCH qxl-wddm-dod 14/26] Comment out frame buffer mapping.

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman WDDM DOD driver doesn't touch the frame buffer (bar0), so no reason to map in into memory. Especially as there were rare BSOD failures when the mapping failed. Leaving the code in place so it clear where the frame buffer should be mapped if we need to do it in the future.

[Spice-devel] [PATCH qxl-wddm-dod 19/26] Fixing framebuffer usage logic

2016-08-09 Thread Sameeh Jubran
only. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 101 ++ 1 file changed, 49 insertions(+), 52 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 557d796..6d07b5d 100755 --- a/qxldod/QxlDo

[Spice-devel] [PATCH qxl-wddm-dod 23/26] Fixing Move rectangles implementation

2016-08-09 Thread Sameeh Jubran
the issue. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 17 - qxldod/QxlDod.h | 3 ++- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 0492581..8ab5031 100755 --- a/qxldod/QxlDod.cp

[Spice-devel] [PATCH qxl-wddm-dod 20/26] Support future Qxl revisions

2016-08-09 Thread Sameeh Jubran
-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 6d07b5d..6ab45fe 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -107,7 +107,7 @@ NTSTATUS QxlDod

[Spice-devel] [PATCH qxl-wddm-dod 26/26] Removing unnecessary call to BlackOutScreen

2016-08-09 Thread Sameeh Jubran
This call to BlackOutScreen is not needed since the actual display surface is destroyed and created (redrawn) again. Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index

[Spice-devel] [PATCH qxl-wddm-dod 16/26] Remove minimum size restrict for custom resolution.

2016-08-09 Thread Sameeh Jubran
From: Sandy Stutsman --- qxldod/QxlDod.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 3139092..74cd259 100755 --- a/qxldod/QxlDod.cpp +++ b/qxldod/QxlDod.cpp @@ -4488,11 +4488,10 @@ NTSTATUS QxlDevice::SetCustomDisplay(QX

[Spice-devel] [PATCH qxl-wddm-dod 21/26] Set SupportNonVGA in QueryAdapterInfo callback

2016-08-09 Thread Sameeh Jubran
From: Dmitry Fleytman This capability flag should be set in order to indicate to the OS that callback DxgkDdiStopDeviceAndReleasePostDisplayOwnership is supported. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 3 +++ 1 file changed, 3 insertions(+) diff

[Spice-devel] [PATCH qxl-wddm-dod 18/26] Replacing <#ifdef USE_FRAMEBUFFER> with runtime logic

2016-08-09 Thread Sameeh Jubran
From: Dmitry Fleytman Framebuffer should only be used in VGA mode, however the mode is only known at runtime therefore framebuffer logic should be active when the driver is operating in vga mode only. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 21

[Spice-devel] [PATCH qxl-wddm-dod 25/26] Fixing monitor flicker on resolution change

2016-08-09 Thread Sameeh Jubran
Passing the flag QXL_SURF_FLAG_KEEP_DATA to the new created surface causes weird flickering, thus this should be set to 0. Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp

[Spice-devel] [PATCH qxl-wddm-dod 22/26] Fix source buffer mapping in PresentDisplayOnly

2016-08-09 Thread Sameeh Jubran
Part of source image mapped by PresentDisplayOnly should be big enough to cover all rectangles being transferred. Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.cpp | 28 +++- qxldod/QxlDod.h | 2 ++ 2 files changed, 25 insertions(+), 5

[Spice-devel] [PATCH qxl-wddm-dod 24/26] Reserved must be set to 0

2016-08-09 Thread Sameeh Jubran
According to msdn, "The display miniport driver must set this value to 0" Signed-off-by: Sameeh Jubran --- qxldod/QxlDod.cpp | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp index 8ab5031..986d679 100755 --

[Spice-devel] [PATCH qxl-wddm-dod 17/26] Replacing tabs with spaces

2016-08-09 Thread Sameeh Jubran
Signed-off-by: Sameeh Jubran Signed-off-by: Dmitry Fleytman --- qxldod/QxlDod.h | 2 +- qxldod/driver.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qxldod/QxlDod.h b/qxldod/QxlDod.h index 9bc0bdb..19d172f 100755 --- a/qxldod/QxlDod.h +++ b/qxldod/QxlDod.h

Re: [Spice-devel] [PATCH win-vdagent v6 0/3] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-10 Thread Sameeh Jubran
Hi, Can anyone review the patches? On Tue, Aug 9, 2016 at 3:08 PM, Sameeh Jubran wrote: > Diffrences from previous patches (v4, v5 should be ignored): > * splitted the patches into three. > > Sameeh Jubran (3): > Introducing Windows CCD API > Encapsulating X

Re: [Spice-devel] [PATCH win-vdagent v6 2/3] Encapsulating XPDM implementation

2016-08-11 Thread Sameeh Jubran
patch encapsulates the current XPDM interface implementation into > > XPDMInterface class which inherits DisplayConfig class. This patch > > makes it easier to introduce WDDM interface to Vdagent in future > > patches. > > > > Based on a patch by Sandy Stutsman > &

Re: [Spice-devel] [PATCH win-vdagent v6 3/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-14 Thread Sameeh Jubran
Hi, Can anyone review this patch so I can resend the patches after the rework? On 9 Aug 2016 3:08 p.m., "Sameeh Jubran" wrote: > The Direct3D 9 API operates on either the Windows XP display driver > model (XPDM) or the Windows Vista display driver model (WDDM), depending &g

Re: [Spice-devel] [PATCH qxl-wddm-dod 00/26] Win10 support patches

2016-08-14 Thread Sameeh Jubran
Ping On 9 Aug 2016 6:29 p.m., "Sameeh Jubran" wrote: > This series contains the latest patches to support Windows 10. > > Visual Studio 2015 with Win10 WDK is required to compile this code, > Current patches may be compiled and will work for Windows 10. > > Sm

Re: [Spice-devel] [PATCH win-vdagent v6 2/3] Encapsulating XPDM implementation

2016-08-15 Thread Sameeh Jubran
DDM interface to Vdagent in future >> > patches. >> > >> > Based on a patch by Sandy Stutsman >> > >> > Signed-off-by: Dmitry Fleytman >> > Signed-off-by: Sameeh Jubran >> > --- >> > vdagent/desktop

[Spice-devel] [PATCH] Update monitor state when it is detached

2016-08-15 Thread Sameeh Jubran
The monitor detached state is being set but not updated, in order to update it we should call ChangeDisplaySettingsEx after setting the appropriate flags along with width and height that are set to 0. Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp | 5 - 1 file changed, 4

Re: [Spice-devel] [PATCH win-vdagent v6 3/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-15 Thread Sameeh Jubran
sed on a patch by Sandy Stutsman > > > > Signed-off-by: Dmitry Fleytman > > Signed-off-by: Sameeh Jubran > > --- > > vdagent/display_configuration.cpp | 355 > > +- > > vdagent/display_configuration.h | 47 + &

Re: [Spice-devel] [PATCH win-vdagent v6 3/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-15 Thread Sameeh Jubran
0 while preserving backward compatiblity with >> > previous >> > versions of Windows. >> > >> > Based on a patch by Sandy Stutsman >> > >> > Signed-off-by: Dmitry Fleytman >> > Signed-off-by: Sameeh Jubran >> > --- >> >

[Spice-devel] [PATCH win-vdagent v7 2/3] Encapsulating XPDM implementation

2016-08-16 Thread Sameeh Jubran
class. This patch makes it easier to introduce WDDM interface to Vdagent in future patches. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++- vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent v7 1/3] Introducing Windows CCD API

2016-08-16 Thread Sameeh Jubran
resolution on Windows 10. Acked-by: Frediano Ziglio Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- Makefile.am | 2 + vdagent/display_configuration.cpp | 509 ++ vdagent

[Spice-devel] [PATCH win-vdagent v7 0/3] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-16 Thread Sameeh Jubran
Diffrences from previous patches: * Fixed a bug when driver is disabled and enabled. * Moved ioctls structures to qxl_windows.h * Changes pointed out by Frediano. * Cosmetic changes. Sameeh Jubran (3): Introducing Windows CCD API Encapsulating XPDM implementation Implementing WDDM

[Spice-devel] [PATCH win-vdagent v7 3/3] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-16 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 355

[Spice-devel] [PATCH spice-protocol] Adding ioctl structures for win-vdagent/qxl-wddm-dod

2016-08-16 Thread Sameeh Jubran
This patch introduces structures that are used to communicate between win-vdagent and qxl-wddm-dod. This patch should be applied before applying this patch: https://lists.freedesktop.org/archives/spice-devel/2016-August/031386.html Sameeh Jubran (1): Add ioctls structures to qxl_windows.h

[Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

2016-08-16 Thread Sameeh Jubran
This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index

Re: [Spice-devel] [PATCH spice-protocol] Adding ioctl structures for win-vdagent/qxl-wddm-dod

2016-08-16 Thread Sameeh Jubran
vel/2016- > August/031386.html > > > > Why? Code compile even without this patch > > > Sameeh Jubran (1): > > Add ioctls structures to qxl_windows.h > > > > spice/qxl_windows.h | 18 ++ > > 1 file changed, 14 insertions(+

Re: [Spice-devel] [PATCH spice-protocol] Add ioctls structures to qxl_windows.h

2016-08-16 Thread Sameeh Jubran
On Tue, Aug 16, 2016 at 1:27 PM, Frediano Ziglio wrote: > > > > This patch defines the structures of ioctls that are used between > > win-vdagent and the qxl-wddm-dod driver. > > > > Signed-off-by: Sameeh Jubran > > --- > > spice/qxl_windows.h | 1

Re: [Spice-devel] [PATCH win-vdagent v7 2/3] Encapsulating XPDM implementation

2016-08-16 Thread Sameeh Jubran
y Stutsman > > > > Signed-off-by: Dmitry Fleytman > > Signed-off-by: Sameeh Jubran > > Acked-by: Frediano Ziglio > > Merged. > > Frediano > > ... > -- Respectfully, *Sameeh Jubran* *Linkedin &l

[Spice-devel] [PATCH spice-protocol v2] Add ioctls structures to qxl_windows.h

2016-08-16 Thread Sameeh Jubran
This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index

[Spice-devel] [PATCH spice-protocol v3] Add ioctls structures to qxl_windows.h

2016-08-16 Thread Sameeh Jubran
This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index bc2ceff

[Spice-devel] [PATCH win-vdagent v8 1/2] Encapsulating XPDM implementation

2016-08-16 Thread Sameeh Jubran
class. This patch makes it easier to introduce WDDM interface to Vdagent in future patches. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/desktop_layout.cpp| 148 +++- vdagent/desktop_layout.h

[Spice-devel] [PATCH win-vdagent v8 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-16 Thread Sameeh Jubran
I'll send the driver patches soon. Those patches require the following patch to be applied first to spice-protocol: https://lists.freedesktop.org/archives/spice-devel/2016-August/031409.html Sameeh Jubran (2): Encapsulating XPDM implementation Implementing WDDMinterface to support multip

[Spice-devel] [PATCH win-vdagent v8 2/2] Implementing WDDMinterface to support multiple monitors and arbitrary resolution

2016-08-16 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 351

[Spice-devel] [PATCH v9 2/2] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-16 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 351 +- vdagent/display_configuration.h | 47 + 2 files changed, 397

[Spice-devel] [PATCH v9 0/2] Adding multiple monitors and arbitrary resolution for Windows 10

2016-08-16 Thread Sameeh Jubran
col: https://lists.freedesktop.org/archives/spice-devel/2016-August/031409.html Sameeh Jubran (2): Modifying ioctl structures Implementing WDDM interface to support multiple monitors and arbitrary resolution vdagent/display_configuration.cpp | 379 -- vdagent/display_confi

[Spice-devel] [PATCH v9 1/2] Modifying ioctl structures

2016-08-16 Thread Sameeh Jubran
This patch modifies the Qxl ioctl structures in order to make them unified. Ioctls now should inherit QXL_ESCAPE structure. Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a

Re: [Spice-devel] [PATCH v9 1/2] Modifying ioctl structures

2016-08-16 Thread Sameeh Jubran
On Tue, Aug 16, 2016 at 7:10 PM, Frediano Ziglio wrote: > > > > This patch modifies the Qxl ioctl structures in order > > to make them unified. Ioctls now should inherit QXL_ESCAPE > > structure. > > > > Signed-off-by: Sameeh Jubran > > Yes,

Re: [Spice-devel] [PATCH spice-protocol v3] Add ioctls structures to qxl_windows.h

2016-08-17 Thread Sameeh Jubran
7, 2016 at 10:59 AM, Frediano Ziglio wrote: > > > > This patch defines the structures of ioctls that are used between > > win-vdagent and the qxl-wddm-dod driver. > > > > Signed-off-by: Sameeh Jubran > > --- > > spice/qxl_windows.h | 10 +++

[Spice-devel] [PATCH v4] Add ioctls structures to qxl_windows.h

2016-08-17 Thread Sameeh Jubran
This patch defines the structures of ioctls that are used between win-vdagent and the qxl-wddm-dod driver. Signed-off-by: Sameeh Jubran --- spice/qxl_windows.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h index bc2ceff

[Spice-devel] [PATCH v10] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-17 Thread Sameeh Jubran
support and arbitrary resolution for Windows 10 while preserving backward compatiblity with previous versions of Windows. Based on a patch by Sandy Stutsman Signed-off-by: Dmitry Fleytman Signed-off-by: Sameeh Jubran --- vdagent/display_configuration.cpp | 346

Re: [Spice-devel] [PATCH qxl-wddm-dod 02/26] Add delete operator

2016-08-17 Thread Sameeh Jubran
Yes it is a typo, the issue is with the declaration, it should be ::delete. Thanks for pointing that :) On Tue, Aug 16, 2016 at 6:42 PM, Frediano Ziglio wrote: > > > > Based on a patch by Sandy Stutsman > > > > Signed-off-by: Sameeh Jubran > > --- &

Re: [Spice-devel] [PATCH qxl-wddm-dod 06/26] Add functions called from non-pageable functions to non-paged segments

2016-08-17 Thread Sameeh Jubran
LEVEL_VERBOSE, ("---> %s\n", __FUNCTION__)); > > +m_RamHdr->int_mask = ~0; > > +WRITE_PORT_UCHAR(m_IoBase + QXL_IO_MEMSLOT_ADD, 0); > > +DbgPrint(TRACE_LEVEL_VERBOSE, ("<--- %s\n", __FUNCTION__)); > > +} > > +#pragma code_seg(pop

Re: [Spice-devel] [PATCH v10] Implementing WDDM interface to support multiple monitors and arbitrary resolution

2016-08-23 Thread Sameeh Jubran
lity with > > previous versions of Windows. > > > > Based on a patch by Sandy Stutsman > > > > Signed-off-by: Dmitry Fleytman > > Signed-off-by: Sameeh Jubran > ... > > Hi Sameeh, >I managed to compile Windows 10 driver and try this patches. > &g

  1   2   3   >