Re: [Spice-devel] irc

Hi, On 8/1/22 16:13, Victor Toso wrote: > Hi, > > CC'ing the list and Hans. > > On Sat, Jul 30, 2022 at 02:55:53PM +0100, James Miller wrote: >> Hi Victor, thanks for getting back to me. >> Currently I have to echo 0 to the path under sys, and then >> manually select the device to redirect in

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

Hi, On 07-02-19 09:59, Thomas Zimmermann wrote: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET constant. OTOH, the mmap range's size is not configurable by drivers. This patch set replaces

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

Hi, On 11-03-19 17:51, Christian König wrote: Am 11.03.19 um 17:39 schrieb Hans de Goede: Hi, On 07-02-19 09:59, Thomas Zimmermann wrote: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET

Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

file_page_offset parameter from ttm_bo_device_init() drm/ttm: Quick-test mmap offset in ttm_bo_mmap() drm: Use the same mmap-range offset and size for GEM and TTM The first patch looks good to me: Reviewed-by: Hans de Goede The vboxvideo bits in the other patches look good to me to: Acked

Re: [Spice-devel] [qxl] Xspice: Replace malloc/strdup use with xnfalloc/xnfstrdup

on failure). Signed-off-by: Christophe Fergeau <cferg...@redhat.com> LGTM: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- src/spiceqxl_audio.c| 2 +- src/spiceqxl_main_loop.c| 4 ++-- src/spiceqxl_spice_server.c | 12 ++-- 3 files changed,

Re: [Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

to that new API, which removes the need for RegisterBlockAndWakeupHandlers(). Thank you for doing this, one small comment inline, otherwise looks good: Reviewed-by: Hans de Goede <hdego...@redhat.com> (with the comment fixed). --- I've lightly (xeyes/rxvt) tested this on f25, and

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Hi, On 18-11-16 14:04, Timo Aaltonen wrote: On 04.10.2016 14:41, Hans de Goede wrote: Hi, On 03-10-16 12:04, Christophe Fergeau wrote: On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/spiceqxl_main_loop

Re: [Spice-devel] spice-gtk updates for Fedora 25 need to be added to bodhi

Hi, On 10/10/2016 02:38 PM, Marc-André Lureau wrote: Hi - Original Message - Hi, On 10/10/2016 11:49 AM, Marc-André Lureau wrote: Hi - Original Message - Hi All, I noticed that there have been a few spice-gtk builds fixing the bugs I was hitting, thank you for that. I

Re: [Spice-devel] spice-gtk updates for Fedora 25 need to be added to bodhi

Hi, On 10/10/2016 11:49 AM, Marc-André Lureau wrote: Hi - Original Message - Hi All, I noticed that there have been a few spice-gtk builds fixing the bugs I was hitting, thank you for that. I had to install them manually from koji, since they are not yet listed in bodhi. Can you

[Spice-devel] spice-gtk updates for Fedora 25 need to be added to bodhi

Hi All, I noticed that there have been a few spice-gtk builds fixing the bugs I was hitting, thank you for that. I had to install them manually from koji, since they are not yet listed in bodhi. Can you please create bodhi updates for these ? :

[Spice-devel] [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

irtual(). This commit fixes this. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1381045 Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/qxl.h| 1 + src/qxl_driver.c | 6 +++--- src/qxl_kms.c| 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Hi, On 03-10-16 12:04, Christophe Fergeau wrote: On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c

[Spice-devel] Issues with xf86-video-xql with xorg-1.19

Hi All, See: https://bugzilla.redhat.com/show_bug.cgi?id=1381045 Also why is Alon still the maintainer of xorg-x11-drv-qxl in Fedora ? It would IMHO be better if the spice-team would maintain it. Regards, Hans ___ Spice-devel mailing list

[Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c index db89b6d..0ac1f3e 100644 --- a/src/spiceqxl_main_loop.c +++ b/src/spiceqxl_main_loop.c @@ -330,7 +

[Spice-devel] spice-gtk is broken in Fedora 25

Hi, I needed a vm to test something and I noticed that spice-gtk appears to be broken in F25. As long as scaling between the guest resolution and the window size is needed everything works fine, but as soon as the agent adjusts the guest resolution to exactly match the window size, the display

[Spice-devel] Fwd: where do usbredir patches go nowadays?

Forwarded Message Subject: where do usbredir patches go nowadays? Date: Mon, 18 Jul 2016 17:23:44 +0300 From: Alon Levy <a...@pobox.com> To: Hans de Goede <hdego...@redhat.com> Well, ok, so I'm taking this time to say hi - you seem to be having good GPU fu

Re: [Spice-devel] [spice-gtk v3 4/4] usb-device-manager: Avoid USB event thread leak

Hi, On 30-06-16 18:02, Christophe Fergeau wrote: On Thu, Jun 30, 2016 at 04:54:53PM +0200, Hans de Goede wrote: Hi, The entire series looks good to me now, one remark wrt this patch, with that fixed this series is: Reviewed-by: Hans de Goede <hdego...@redhat.com> On 30-06-16

Re: [Spice-devel] [spice-gtk v3 4/4] usb-device-manager: Avoid USB event thread leak

Hi, The entire series looks good to me now, one remark wrt this patch, with that fixed this series is: Reviewed-by: Hans de Goede <hdego...@redhat.com> On 30-06-16 15:40, Christophe Fergeau wrote: This is a follow-up of the previous commit ('usb-channel: Really stop listening for USB

Re: [Spice-devel] [spice-gtk 3/3] usb-device-manager: Fix USB event thread leak

Hi, On 30-06-16 13:08, Hans de Goede wrote: Hi, On 30-06-16 09:08, Christophe Fergeau wrote: On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote: Erm no, it is the caller's responsibility to make sure that all spice_usbredir_channel's are properly torn down before

Re: [Spice-devel] [spice-gtk 3/3] usb-device-manager: Fix USB event thread leak

Hi, On 30-06-16 09:08, Christophe Fergeau wrote: On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote: Erm no, it is the caller's responsibility to make sure that all spice_usbredir_channel's are properly torn down before the usbdevicemanager gets torn down. Otherwise you're not just

Re: [Spice-devel] [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

Hi, On 30-06-16 09:13, Christophe Fergeau wrote: On Wed, Jun 29, 2016 at 07:20:16PM +0200, Hans de Goede wrote: Hi, On 29-06-16 17:42, Christophe Fergeau wrote: This variable is accessed from 2 different threads (main thread and USB event thread), so some care must be taken to read/write

Re: [Spice-devel] [spice-gtk 3/3] usb-device-manager: Fix USB event thread leak

Hi, On 29-06-16 17:42, Christophe Fergeau wrote: When using USB redirection, it's fairly easy to leak the thread handling USB events, which will eventually cause problems in long lived apps. In particular, in virt-manager, one can: - start a VM - connect to it with SPICE - open the USB

Re: [Spice-devel] [spice-gtk 2/3] usbredir: Use atomic for UsbDeviceManager::event_thread_run

Hi, On 29-06-16 17:42, Christophe Fergeau wrote: This variable is accessed from 2 different threads (main thread and USB event thread), so some care must be taken to read/write it. The event-thread only reads it, so I believe there is no need for this. Regards, Hans ---

Re: [Spice-devel] [usbredir][PATCH] usbredirhost: Fix -Wformat warning

Hi, On 03-11-15 01:52, Fabiano Fidêncio wrote: On Tue, Nov 3, 2015 at 1:51 AM, Fabiano Fidêncio wrote: Cast uint64_t to long unsigned on printfs in order to avoid warnings like: usbredirhost.c: In function 'usbredirhost_can_write_iso_package': usbredirhost.c:1023:19:

Re: [Spice-devel] [spice-gtk PATCH v6 2/2] channel-usbredir: drop isoc packets on low bandwidth

Hi, On 10/23/2015 10:59 AM, Fabiano Fidêncio wrote: On Fri, Oct 23, 2015 at 9:53 AM, Victor Toso wrote: When channel wants to send much more data then the wire can handle, the queue grows fast. This patch does not limit the queue growth but introduces an internal API to

Re: [Spice-devel] [PATCH 1/1] Allow missing capabilities from source host

abilities we ask for to machine types). I don't think this was picked up? Hans, are you planning to pick this up, IIRC I gave my reviewed-by for this already, in case I did not here it is: Reviewed-by: Hans de Goede <hdego...@redhat.com> Anyone in the spice group should be able to push to the usb

Re: [Spice-devel] [usbredir PATCH v6 1/2] usbredirhost: new callback to drop isoc packets

application's buffer size (in bytes) that are handling the isochronous data. applications *pending writes* buffer size (in bytes). (so add the pending writes, drop the "that are ... isoc data", since the application is not aware which data is isoc data and which is not. Other

Re: [Spice-devel] [usbredir PATCH v5 1/2] usbredirhost: new callback for iso streams

Hi, On 22-10-15 17:41, Victor Toso wrote: Hi, On Thu, Oct 22, 2015 at 05:28:44PM +0200, Hans de Goede wrote: Hi, On 22-10-15 16:07, Victor Toso wrote: For streaming devices it might be necessary from application to drop data for different reasons. This patch provides a new callback

Re: [Spice-devel] [usbredir PATCH v5 1/2] usbredirhost: new callback for iso streams

Hi, On 22-10-15 16:07, Victor Toso wrote: For streaming devices it might be necessary from application to drop data for different reasons. This patch provides a new callback that it is called before queueing the most recent iso packages. Related:

Re: [Spice-devel] [usbredir PATCH v4 1/2] usbredirhost: new callback for iso streams

Hi, On 21-10-15 12:38, Victor Toso wrote: For streaming devices it might be necessary from application to drop data for different reasons. This patch provides a new callback that it is called before queueing the most recent iso packages. Related:

Re: [Spice-devel] [usbredir PATCH v4 1/2] usbredirhost: new callback for iso streams

Hi, On 21-10-15 13:54, Victor Toso wrote: Hi, On Wed, Oct 21, 2015 at 01:40:01PM +0200, Hans de Goede wrote: Hi, On 21-10-15 12:38, Victor Toso wrote: For streaming devices it might be necessary from application to drop data for different reasons. This patch provides a new callback

Re: [Spice-devel] [usbredir PATCH v3] usbredir memory leak

p.s. One more thing, when I reproduced this myself I noticed a couple of other worrisome things: 1) When I stop the webcam-app inside the guest, the camera does not stop streaming on the client side. As if the control request being send from the client to stop the stream never reaches the

Re: [Spice-devel] [usbredir PATCH v3] usbredir memory leak

Hi, On 19-10-15 14:25, Fabiano Fidêncio wrote: Adding Hans ... Thanks, I missed the original patch, Victor, can you please Cc me when sending this patches, and perhaps resend v3 with me in the Cc ? On Mon, Oct 19, 2015 at 12:07 PM, Victor Toso wrote: This is already

Re: [Spice-devel] [PATCH spice-vdagent] service: simplification and accessability - reversion

Hi, On 19-10-15 16:55, poma wrote: While testing, I came to the same conclusion as Marc-André - commit 1587063. Hans, why the complexity of the "rules & target", isn't "ConditionPath*" sufficient? Besides, the lack of "WantedBy=multi-user.target" - back and forth with 'graphical.target' -

Re: [Spice-devel] [PATCH v4] usbredir: fix redirection of user-accesible device nodes.

Hi, On 20-07-15 11:51, Christophe Fergeau wrote: Hey, Looks good te me now. Hans, would you mind taking a quick look at that patch in case you have objections on the change (if spice_usb_acl_helper_open_acl_finish() fails, try to directly open the device node anyway as it may be

Re: [Spice-devel] [usbredir PATCH v2] usbredirfilter_check: force check a device if all its interfaces are skipped

Hi, On 14-07-15 17:30, Uri Lublin wrote: See usbredirfilter.h for when interfaces are skipped. Force filter check on such a device by calling recursively with a flag that forbids skipping (usbredirfilter_fl_dont_skip_non_boot_hid) Related rhbz#1179210 Looks good to me: Reviewed-by: Hans de

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

Hi, On 09-07-15 16:51, Uri Lublin wrote: On Thu, 2015-07-09 at 10:13 +0200, Hans de Goede wrote: Hi, On 09-07-15 09:19, Christophe Fergeau wrote: On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote: Can you ask the reporter to provide lsusb -v output for the usb interface

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

Hi, On 09-07-15 09:19, Christophe Fergeau wrote: On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote: Can you ask the reporter to provide lsusb -v output for the usb interface of the kvm in question, then we can better analyse what exactly is going wrong here. Perhaps my analyses

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

Hi, On 08-07-15 15:26, Uri Lublin wrote: See usbredirfilter.h for when interfaces are skipped. Fixes rhbz#1179210 Sigh, the kvm in question is really messed up as it uses non bootclass hid interfaces, that means it won't work in many BIOS' etc. What a mess ... ---

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

Hi, On 08-07-15 18:22, Uri Lublin wrote: Hi Hans, Thanks for the quick review. See answers below On Wed, 2015-07-08 at 15:45 +0200, Hans de Goede wrote: Hi, On 08-07-15 15:26, Uri Lublin wrote: See usbredirfilter.h for when interfaces are skipped. Fixes rhbz#1179210 Sigh, the kvm

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

Hi, Thinking more about this I think I've a good solution. If we end up skipping all interfaces, then do not return -ENOENT, but rerun the filter with the usbredirfilter_fl_dont_skip_non_boot_hid flag or-ed into the flags argument. That shhold fix the use case on hand while not overriding the

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

Hi, On 07-07-15 18:47, Jeremy White wrote: Well, the checkpatch.pl reports were all style (and mostly whitespace); roughly 3000 of them against 3000 lines of code :-/. I did review the code, looking for areas where I thought it would badly cram into the kernel, and I adjusted the few I

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

Hi, On 02-07-15 10:45, Oliver Neukum wrote: On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: I don't really think it is sensible to be defining implementing new network services which can't support strong encryption and authentication. Rather than passing the file descriptor to

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

Hi, On 01-07-15 20:31, Jeremy White wrote: Assuming that's correct, then this seems to imply that the socket has raw plain text data being sent/received, and thus precludes the possibility of running any security protocol like TLS unless the kernel wants to have an impl of the TLS protocol.

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

Hi, On 01-07-15 18:13, Greg KH wrote: On Wed, Jul 01, 2015 at 10:55:49AM -0500, Jeremy White wrote: On 07/01/2015 12:44 AM, Greg KH wrote: On Tue, Jun 30, 2015 at 10:34:25PM -0500, Jeremy White wrote: 1. Is the basic premise reasonable? Is Hans correct in asserting that an alternate USB

Re: [Spice-devel] Changes to usbredir to support a kernel module

Hi Jeremy, On 17-06-15 21:06, Jeremy White wrote: I have started work on a usbredir kernel module to enable USB redirection for XSpice. I'd like to reuse the usbredirparser.c code, but it needs changes to compile as part of a kernel module. These are those changes. The changes look fine to

Re: [Spice-devel] Questions on usbredir + XSpice redux, libusb anyone?

Hi, On 13-04-15 21:40, Jeremy White wrote: Hi folks, I've done some work on a usbredir kernel module to bring support for USB to XSpice. In doing so, and talking with some colleagues, their reaction was: why don't you modify libusb instead? That is, the current change is to modify XSpice

Re: [Spice-devel] Questions on usbredir + XSpice redux, libusb anyone?

Hi, On 04/14/2015 09:10 PM, Jeremy White wrote: Hey Hans, most Linux applications ... are going to use libusb to access the USB devices. That is not true, applications using libusb rather then a kernel driver are the exception not the rule. Basically the only major applications using libusb

Re: [Spice-devel] Dead lock in usbredir

Hi, On 12/16/2014 04:55 PM, Christophe Fergeau wrote: Hey, Thanks to the detailed description. Adding Hans to cc: since he knows USB redirection the best. This is only a problem with libusb on windows, there is a patch-set at the upstream libusb mailinglist to stop libusb from taking the

Re: [Spice-devel] libusbredir fixes

Hi, On 11/20/2014 06:08 PM, Christophe Fergeau wrote: Hey, Here are 3 libusbredir patches. I'm not sure where they should go (here? bugzilla? someplace else?), just let me know if they should go elsewhere. spice-devel (with me in the CC please as I'm no longer on spice-devel) is fine. All

Re: [Spice-devel] [PATCH] [spice-gtk v2] usb-device: Expose libusb device

Hi, On 11/19/2014 04:37 AM, Fabiano Fidêncio wrote: ping? Looks good to me. Regards, Hans On Thu, 2014-11-13 at 02:32 +0100, Fabiano Fidêncio wrote: As we only can filter USB devices by their Classes and sometimes it is not enough (eg: I do not want to have Keyboard and Mouse, but I

[Spice-devel] Fwd: a question about Xspice

Hi, Forwarding this to you guys from the xorg-devel list. Regards, Hans Forwarded Message Subject: a question about Xspice Date: Tue, 21 Oct 2014 17:30:54 +0800 (CST) From: cynthia cynthia_...@163.com To: xorg-de...@lists.x.org, x...@lists.x.org HI All, I am trying to

[Spice-devel] hansg unsubscribing from spice-devel list

Hi all, Since I'm not all that active on the spice front anymore I'm unsubscribing from the spice-devel list. If you want my input on anything spice related, please put me in the Cc, or send me a direct mail. Regards, Hans ___ Spice-devel mailing

Re: [Spice-devel] Questions on usbredir + XSpice

Hi, On 08/06/2014 01:29 PM, Alon Levy wrote: On 08/06/2014 02:02 PM, Hans de Goede wrote: Hi, On 08/06/2014 08:02 AM, Alon Levy wrote: On 08/05/2014 10:52 PM, Jeremy White wrote: While I'm researching, I thought I'd look into the next challenge for XSpice - usb device redirection

Re: [Spice-devel] Questions on usbredir + XSpice

Hi, On 08/06/2014 05:17 PM, Jeremy White wrote: I would advice against going for a protocol translater, your time would better spend on doing this properly right away. You don't think the kernel guys will push back, saying there is already an existing ip-to-usb device, and we should just

Re: [Spice-devel] Questions on usbredir + XSpice

Hi, On 08/06/2014 08:02 AM, Alon Levy wrote: On 08/05/2014 10:52 PM, Jeremy White wrote: While I'm researching, I thought I'd look into the next challenge for XSpice - usb device redirection. It faces similar challenges to the CAC card stuff. That is, my sense is that the usbredir library

[Spice-devel] xorg-x11-drv-qxl in Fedora should be updated to 0.1.2

Hi, $subject says it all, I've looked into doing this myself, but there are quite a few patches, which likely can be all dropped, but I believe it is better for the update to be done by someone who knows the code better, and thus is a better judge of which patches can be dropped. Regards, Hans

Re: [Spice-devel] Help on USB Sharing using Spice

Hi, On 07/27/2014 07:49 AM, A.J.Pra$anth wrote: Hi all, Is it possible to use spice usbredir in non vm environment to share USB devices ? In the usb redirection protocol document i has been mentioned like The most significant use case for this is taking a usb device attached to

Re: [Spice-devel] [PATCH] Fix leaks

Hi, On 07/16/2014 01:24 AM, Fabiano Fidêncio wrote: --- usbredirhost/usbredirhost.c | 1 + usbredirtestclient/usbredirtestclient.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/usbredirhost/usbredirhost.c b/usbredirhost/usbredirhost.c index bbaafa4..6ab6e1b 100644

Re: [Spice-devel] [xorg-x11-drv-qxl] add fix for invisible cursor after resize (#1116870)

Hi, On 07/07/2014 06:34 PM, Marc-André Lureau wrote: commit 4a7b1661823eb94a7458941885e5edd4cb07ec32 Author: Marc-André Lureau marcandre.lur...@gmail.com Date: Mon Jul 7 18:28:27 2014 +0200 add fix for invisible cursor after resize (#1116870)

Re: [Spice-devel] [PATCH] qxl_kms: read virtual monitor size from xorg.conf

Hi, On 06/09/2014 01:40 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com A better commit messages explaining the why, what and how of this patch would be nice. Regards, Hans --- src/qxl_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Spice-devel] Announcing usbredir-0.7

Hi, On 05/23/2014 08:57 AM, Gerd Hoffmann wrote: usbredir-0.7 19 May 2014 Any plans for package updates (for this and libusbx) in rawhide and maybe fedora 20? rawhide is already done :) I guess it is best to wait with doing this for F-20 until libusb-1.0.19 goes final (rawhide has

[Spice-devel] [PATCH xf86-video-qxl 1/3] Add support for XSERVER_PLATFORM_BUS

This is a preparation patch for adding support for server managed fds. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/qxl.h| 6 ++ src/qxl_driver.c | 48 ++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/src

[Spice-devel] [PATCH xf86-video-qxl 3/3] Add support for server managed fds

Signed-off-by: Hans de Goede hdego...@redhat.com --- src/qxl_driver.c | 4 src/qxl_kms.c| 32 +++- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index c81b243..b9aa0e9 100644 --- a/src/qxl_driver.c +++ b

[Spice-devel] [PATCH xf86-video-qxl 2/3] Fix qxl_driver_func to adhere to the API

The driverFunc callback MUST check the passed in operand and only return TRUE it if understands it and has handled it. It must NOT blindly assume the op is GET_REQUIRED_HW_INTERFACES. While at also always define driverFunc, and welcome qxl to the 21st century. Signed-off-by: Hans de Goede hdego

Re: [Spice-devel] Releasing ownership of Spice components in Fedora

Hi all, On 03/17/2014 10:08 AM, Hans de Goede wrote: Hi All, It seems I was still the owner of various Spice components in Fedora. I've just released the following components: https://admin.fedoraproject.org/pkgdb/acls/name/spice https://admin.fedoraproject.org/pkgdb/acls/name/spice

[Spice-devel] Releasing ownership of Spice components in Fedora

Hi All, It seems I was still the owner of various Spice components in Fedora. I've just released the following components: https://admin.fedoraproject.org/pkgdb/acls/name/spice https://admin.fedoraproject.org/pkgdb/acls/name/spice-vdagent Someone from the team should go to the above urls and

Re: [Spice-devel] does spicec support usbredir?

Hi, On 11/13/2013 01:49 AM, Li Guang wrote: Hi, Hans I did strictly as you said at http://hansdegoede.livejournal.com/11084.html, but, seems there's no effect in guest after selecting redirected USBdevice, can you help to take a look if there are something wrong for my configuration? The

Re: [Spice-devel] does spicec support usbredir?

Hi, On 11/13/2013 08:31 AM, Tomáš Chaloupka wrote: I guess that its because in spice-gtk-0.21 USB redir is not working? Fixed by this patch: http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=fb469ef815d7e8396aee49ad4ca4e5d4f882ee26 Ah, yes that is likely the culprit, good one. Regards,

Re: [Spice-devel] does spicec support usbredir?

Hi, On 11/11/2013 04:55 AM, Li Guang wrote: Hi, All does spicec support usbredir? can't figure out that by browsing source code of spice, if it does, how to support usbredir? No it does not, please use remote-viewer / virt-viewer for usbredir use. Regards, Hans

Re: [Spice-devel] [PATCH spice-gtk] main: send max-clipboard to agent

Hi, On 11/07/2013 01:03 AM, Marc-André Lureau wrote: Send configured max-clipboard size to the agent, after receiving agent capabilities. See also spice-protocol patch description: http://lists.freedesktop.org/archives/spice-devel/2013-November/015254.html ACK, for both this patch as well as

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

Hi, On 11/02/2013 05:50 PM, Fedor Lyakhov wrote: Bastein, Hans, We need an agreement on this topic so I can implement something - and have it accepted in both Spice and Gnome eventually. There are 2 possible approaches conflicting here: (i) (spice-proposed) DEs to export API for toggling

Re: [Spice-devel] [PATCH] qxl_image: fix build break once MIN/MAX switched to spice-protocol

ACK. On 10/20/2013 02:37 PM, Alon Levy wrote: In commit 5e122e4ab1ac35186cc610cd0d518cfd5e78d902 --- src/qxl_image.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qxl_image.c b/src/qxl_image.c index 2349fca..0a0ca30 100644 --- a/src/qxl_image.c +++ b/src/qxl_image.c @@ -31,6

Re: [Spice-devel] RFC: Spice in a 3D word presentation sheets

Hi, Thanks for the feedback. On 10/15/2013 09:45 PM, Fedor Lyakhov wrote: Hans, My 50 cents: Slide 4: s/Areo/Aero s/Webbrowsers/Web browsers Thanks, fixed. Slide 8: I agree with Marc-André here Well this is what all the experts say (ie Dave Airlie, Keith Packard), and if you think a

[Spice-devel] RFC: Spice in a 3D word presentation sheets

Hi All, I've created sheets for my Spice in a 3D word presentation at kvm-forum. Feedback much appreciated: http://people.fedoraproject.org/~jwrdegoede/spice-3d.odp Regards, Hans ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH 1/2] vdagent-virtio-port: no need to log opening the port as a socket

Hi, Looks good, ack series. Regards, Hans On 10/14/2013 02:47 PM, Alon Levy wrote: --- src/vdagent-virtio-port.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index a5da35f..b04d55b 100644 --- a/src/vdagent-virtio-port.c +++

Re: [Spice-devel] RFC: Integrating Virgil and Spice

Hi, On 10/10/2013 01:25 PM, Gerd Hoffmann wrote: Hi, Nice summary. 3) Virgil will render using the host gpu, using EGL to talk to a drm render node. For non local displays the rendered contents will be read back from the gpu and then passed as a pixmap to the ui to transport over the

Re: [Spice-devel] RFC: Integrating Virgil and Spice

Hi, On 10/09/2013 10:44 AM, Gerd Hoffmann wrote: snip What is virtio-vga btw? The virgil virtual vga device Yes, see: http://airlied.livejournal.com/78104.html Regards, Hans ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] RFC: Integrating Virgil and Spice

Hi All, I realize that it may be a bit early to start this discussion, given the somewhat preliminary state of Virgil, still I would like to start a discussion about this now for 2 reasons: 1) I believe it would be good to start thinking about this earlier rather then later. 2) I would like to

Re: [Spice-devel] RFC: Integrating Virgil and Spice

Hi, On 10/08/2013 03:18 PM, Gerd Hoffmann wrote: Hi, The basic idea is to use qemu's console layer (include/ui/console.h) as an abstraction between the new virtio-vga device Dave has in mind (which will include optional 3D rendering capability through VIRGIL), and various display options,

[Spice-devel] Current qemu-master hangs when used with qxl + linux guest

Hi All, I'm having this weird problem with qemu master + spice/qxl using guests. As soon as the guest starts Xorg, I get the following message from qemu: main-loop: WARNING: I/O thread spun for 1000 iterations And from then on the guest hangs and qemu consumes 100% cpu. The qemu console still

Re: [Spice-devel] Current qemu-master hangs when used with qxl + linux guest

Hi, On 10/08/2013 04:30 PM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 04:27:38PM +0200, Hans de Goede wrote: Hi All, I'm having this weird problem with qemu master + spice/qxl using guests. As soon as the guest starts Xorg, I get the following message from qemu: main-loop: WARNING: I

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: Fix usbredir being broken since commit 159c6ebf

Message - The usbredir channel uses spice_msg_in_raw to get its data, which uses in-dpos to determine the msg size and that was no longer being set for non sub-messages. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-channel.c | 1 + 1 file changed, 1 insertion(+) diff

[Spice-devel] [PATCH spice-gtk] spice-channel: Fix usbredir being broken since commit 159c6ebf

The usbredir channel uses spice_msg_in_raw to get its data, which uses in-dpos to determine the msg size and that was no longer being set for non sub-messages. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/spice-channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk/spice

Re: [Spice-devel] [PATCH] mono cursor: increase contrast, better looking putty cursor (rhbz 998529)

Seems to make sense to me, ACK. On 09/23/2013 03:10 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- The previous fix is almost impossible to notice on putty, I'm assuming the original values for the on/off pixels were taken from a different use case, but so far since we do

Re: [Spice-devel] Bug62033 Add support for --spice-disable-effects client option to spice-vdagent on Linux guests with Gnome3

Hi, On 09/15/2013 09:33 PM, Fedor Lyakhov wrote: Hello Hans, Finally I've found time to continue with this topic. Have sought for better solution and only come to improved previous one. *Requirements* Let's start with clarifying requirements. req-1. As a user I want to have my desktop

Re: [Spice-devel] [PATCH common 1/3] quic: compile with constant bpp, to help compiler

Looks good, ACK series (with the change you mentioned yourself already) On 09/08/2013 09:07 PM, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@gmail.com --- common/quic_family_tmpl.c | 4 ++-- common/quic_rgb_tmpl.c| 6 +++--- common/quic_tmpl.c| 16

Re: [Spice-devel] [PATCH v3 vdagent-linux] vdagentd: support fake uinput

ACK. On 09/02/2013 11:09 PM, Alon Levy wrote: This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy al...@redhat.com ---

Re: [Spice-devel] [PATCH vdagent-linux] vdagent-virtio-port: close socket on error

ACK. On 09/03/2013 12:07 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/vdagent-virtio-port.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index bdd22d9..bacfa42 100644 --- a/src/vdagent-virtio-port.c +++

Re: [Spice-devel] [PATCH vdagent-linux 1/4] vdagent: add option to change vdagentd socket

ACK. On 09/02/2013 05:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/vdagent.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vdagent.c b/src/vdagent.c index 10ebf6e..f270615 100644 --- a/src/vdagent.c +++ b/src/vdagent.c @@ -43,6

Re: [Spice-devel] [PATCH vdagent-linux 2/4] vdagentd: support configurable socket to vdagent

ACK. On 09/02/2013 05:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/vdagentd.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index f4cea44..2288671 100644 ---

Re: [Spice-devel] [PATCH vdagent-linux 3/4] vdagentd: support virtio as uds for Xspice usage

ACK. On 09/02/2013 05:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com --- src/vdagent-virtio-port.c | 53 +-- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c

Re: [Spice-devel] [PATCH vdagent-linux 4/4] vdagentd: support fake uinput

Comments inline. On 09/02/2013 05:02 PM, Alon Levy wrote: This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy

Re: [Spice-devel] [PATCH v2 vdagent-linux] vdagentd: support fake uinput

Hi, On 09/02/2013 05:12 PM, Alon Levy wrote: This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy al...@redhat.com ---

Re: [Spice-devel] [PATCH] channel-main: Fix minor documentation issue

ACK. On 08/27/2013 09:56 PM, Jonathon Jongsma wrote: Documentation for spice_main_clipboard_selection_request() refers to deprecated signal 'main-clipboard' instead of 'main-clipboard-selection' --- gtk/channel-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: remove dead code

Looks good, ACK. On 08/23/2013 10:25 PM, Marc-André Lureau wrote: --- gtk/spice-gtk-session.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 47c7d36..68777eb 100644 --- a/gtk/spice-gtk-session.c +++ b/gtk/spice-gtk-session.c @@

Re: [Spice-devel] [PATCH spice-gtk 2/4] Revert channel-main: Convert text line-endings if necessary (rhbz#752350)

Looks good, ACK. On 08/23/2013 10:25 PM, Marc-André Lureau wrote: This implementation assumes that the toolkit doesn't do any conversion on its own. This is actually not the case, gtk+ converts line endings already on windows. It would be pretty ugly to do conversions back and forth at

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

Hi, On 08/23/2013 10:25 PM, Marc-André Lureau wrote: Convert line endings from/to LF/CRLF, in utf8. --- gtk/spice-util-priv.h | 2 + gtk/spice-util.c | 122 ++ 2 files changed, 124 insertions(+) diff --git a/gtk/spice-util-priv.h

Re: [Spice-devel] [PATCH spice-gtk] tests: add some dos2unix tests

Looks good, ack. On 08/24/2013 02:59 AM, Marc-André Lureau wrote: This is probably not exhaustive enough, but better than nothing. --- Makefile.am | 2 +- configure.ac | 1 + gtk/spice-util.c | 1 + tests/Makefile.am | 18 +++ tests/util.c | 89

Re: [Spice-devel] [PATCH spice-gtk 4/4] gtk: handle clipboard CRLF conversion

Hi, On 08/23/2013 10:25 PM, Marc-André Lureau wrote: gtk+ internal text/utf8 is using LF conversion, on all platforms. Even though the toolkit may only handle a single line ending type, we may want to avoid the conversion for Spice use cases, gtk+ could learn a new native utf8 target type, see

  1   2   3   4   5   6   7   8   9   10   >