Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 15:53, Christophe Fergeau wrote: > > On Thu, Jul 27, 2017 at 03:00:27PM +0200, Christophe de Dinechin wrote: >> No, that’s not correct (at least for me). The review itself can happen over >> mail, >> what I find inefficient is: >> >> a) to get the list of things to review,

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 03:00:27PM +0200, Christophe de Dinechin wrote: > No, that’s not correct (at least for me). The review itself can happen over > mail, > what I find inefficient is: > > a) to get the list of things to review, and > b) to get a working version of the code after patching >

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 15:27, Frediano Ziglio wrote: > > On 27 Jul 2017, at 15:07, Frediano Ziglio wrote: > > On 27 Jul 2017, at 12:39, Christophe Fergeau wrote: > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote:

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On 27 Jul 2017, at 15:07, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > On 27 Jul 2017, at 12:39, Christophe Fergeau < cferg...@redhat.com > > > > > wrote: > > > > > > > > > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > > > > > > > > > > On Mon, Jul 24,

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 15:07, Frediano Ziglio wrote: > > On 27 Jul 2017, at 12:39, Christophe Fergeau > wrote: > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > Not really familiar wit

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On 27 Jul 2017, at 12:39, Christophe Fergeau < cferg...@redhat.com > wrote: > > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > > > > > Not really familiar with GitLab merge requests but on GitH

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 12:53, Daniel P. Berrange wrote: > > On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: >> On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: >>> On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: Not really familiar with GitLab

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 27 Jul 2017, at 12:39, Christophe Fergeau wrote: > > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: >> On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: >>> Not really familiar with GitLab merge requests but on GitHub they >>> remain open till closed so this wou

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

Hi, On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > Not really familiar with GitLab merge requests but on GitHub they > > > remain open till

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 12:39:32PM +0200, Christophe Fergeau wrote: > On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > Not really familiar with GitLab merge requests but on GitHub they > > > remain open till clos

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 27, 2017 at 11:54:08AM +0200, Victor Toso wrote: > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > Not really familiar with GitLab merge requests but on GitHub they > > remain open till closed so this would help with old ones. > > The big change on moving to full PR

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

Hey, On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, Jul 21, 2017 at 06:41:01AM -0400, Frediano Ziglio wrote: > > > > > > > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > > > > Beside that I wonder why I had to wait 8 months for

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > > > Not really familiar with GitLab merge requests but on GitHub they > > remain open till closed so this would help with old ones. > > This would help until there are enough old ones piled up that we no > longer know if th

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Mon, Jul 24, 2017 at 10:47:34AM -0400, Frediano Ziglio wrote: > > Not really familiar with GitLab merge requests but on GitHub they > remain open till closed so this would help with old ones. This would help until there are enough old ones piled up that we no longer know if they are still rele

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > Hi, > > On Fri, Jul 21, 2017 at 06:41:01AM -0400, Frediano Ziglio wrote: > > > > > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > > > Beside that I wonder why I had to wait 8 months for these reviews, > > > > not counting the time to decide to rewrite this part of code

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

Hi, On Fri, Jul 21, 2017 at 06:41:01AM -0400, Frediano Ziglio wrote: > > > > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > > Beside that I wonder why I had to wait 8 months for these reviews, > > > not counting the time to decide to rewrite this part of code > > > (with all

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > > Beside that I wonder why I had to wait 8 months for these reviews, > > not counting the time to decide to rewrite this part of code > > (with all the wasted time trying to not do it) and the time we > > waited to fix a known

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Fri, Jul 21, 2017 at 06:18:49AM -0400, Frediano Ziglio wrote: > Beside that I wonder why I had to wait 8 months for these reviews, > not counting the time to decide to rewrite this part of code > (with all the wasted time trying to not do it) and the time we > waited to fix a known bug which is

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > > On 20 Jul 2017, at 11:23, Christophe Fergeau wrote: > > > > On Thu, Jul 20, 2017 at 09:42:26AM +0200, Christophe de Dinechin wrote: > >>> I moved to "unsigned int" 2 versions ago. > >> > >> It was courteous of you. > > > > Yup, thanks, did not take a look at the newer iterations yet. > >

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Fri, Jul 21, 2017 at 11:12:13AM +0200, Christophe de Dinechin wrote: > > > On 20 Jul 2017, at 11:23, Christophe Fergeau wrote: > > > > On Thu, Jul 20, 2017 at 09:42:26AM +0200, Christophe de Dinechin wrote: > >>> I moved to "unsigned int" 2 versions ago. > >> > >> It was courteous of you. >

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 20 Jul 2017, at 11:23, Christophe Fergeau wrote: > > On Thu, Jul 20, 2017 at 09:42:26AM +0200, Christophe de Dinechin wrote: >>> I moved to "unsigned int" 2 versions ago. >> >> It was courteous of you. > > Yup, thanks, did not take a look at the newer iterations yet. > >> >>> >>> But s

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Thu, Jul 20, 2017 at 09:42:26AM +0200, Christophe de Dinechin wrote: > > I moved to "unsigned int" 2 versions ago. > > It was courteous of you. Yup, thanks, did not take a look at the newer iterations yet. > > > > > But still think that is a useful discussion. But honestly I think > > in th

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 19 Jul 2017, at 19:21, Frediano Ziglio wrote: > >> >> On Wed, Jul 19, 2017 at 08:03:49AM -0400, Frediano Ziglio wrote: On Wed, Jul 19, 2017 at 12:09:23PM +0200, Christophe de Dinechin wrote: > >> On 19 Jul 2017, at 11:21, Christophe Fergeau >> wrote: >> >>

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On Wed, Jul 19, 2017 at 08:03:49AM -0400, Frediano Ziglio wrote: > > > > > > On Wed, Jul 19, 2017 at 12:09:23PM +0200, Christophe de Dinechin wrote: > > > > > > > > > On 19 Jul 2017, at 11:21, Christophe Fergeau > > > > > wrote: > > > > > > > > > > On Wed, Jul 19, 2017 at 10:23:30AM +0200,

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Wed, Jul 19, 2017 at 08:03:49AM -0400, Frediano Ziglio wrote: > > > > On Wed, Jul 19, 2017 at 12:09:23PM +0200, Christophe de Dinechin wrote: > > > > > > > On 19 Jul 2017, at 11:21, Christophe Fergeau > > > > wrote: > > > > > > > > On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Din

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On Wed, Jul 19, 2017 at 12:09:23PM +0200, Christophe de Dinechin wrote: > > > > > On 19 Jul 2017, at 11:21, Christophe Fergeau wrote: > > > > > > On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Dinechin wrote: > > >> > > >>> On 18 Jul 2017, at 17:28, Christophe Fergeau > > >>> wro

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Wed, Jul 19, 2017 at 12:09:23PM +0200, Christophe de Dinechin wrote: > > > On 19 Jul 2017, at 11:21, Christophe Fergeau wrote: > > > > On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Dinechin wrote: > >> > >>> On 18 Jul 2017, at 17:28, Christophe Fergeau wrote: > >>> > >>> On Mon,

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 19 Jul 2017, at 11:21, Christophe Fergeau wrote: > > On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Dinechin wrote: >> >>> On 18 Jul 2017, at 17:28, Christophe Fergeau wrote: >>> >>> On Mon, Jul 17, 2017 at 11:01:22AM +0100, Frediano Ziglio wrote: Remove CxImage linking. >>

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> > On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Dinechin wrote: > > > > > On 18 Jul 2017, at 17:28, Christophe Fergeau wrote: > > > > > > On Mon, Jul 17, 2017 at 11:01:22AM +0100, Frediano Ziglio wrote: > > >> Remove CxImage linking. > > >> Support Windows BMP format. > > > > > > T

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Wed, Jul 19, 2017 at 10:23:30AM +0200, Christophe de Dinechin wrote: > > > On 18 Jul 2017, at 17:28, Christophe Fergeau wrote: > > > > On Mon, Jul 17, 2017 at 11:01:22AM +0100, Frediano Ziglio wrote: > >> Remove CxImage linking. > >> Support Windows BMP format. > > > > Too bad there is no sm

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

> On 18 Jul 2017, at 17:28, Christophe Fergeau wrote: > > On Mon, Jul 17, 2017 at 11:01:22AM +0100, Frediano Ziglio wrote: >> Remove CxImage linking. >> Support Windows BMP format. > > Too bad there is no small/maintained library which would do that for us > :-/ From a quick glance, looks ok. >

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

On Mon, Jul 17, 2017 at 11:01:22AM +0100, Frediano Ziglio wrote: > Remove CxImage linking. > Support Windows BMP format. Too bad there is no small/maintained library which would do that for us :-/ From a quick glance, looks ok. > > +static inline size_t compute_dib_stride(unsigned width, unsign

[Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

Remove CxImage linking. Support Windows BMP format. Signed-off-by: Frediano Ziglio --- Makefile.am | 4 +- configure.ac| 4 +- mingw-spice-vdagent.spec.in | 10 +-- vdagent/image.cpp | 170 ++-- vdagent/image.