Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Arnon Gilboa
Yep, I will send a patch exactly for that update the zip - today. Sorry about the delay, Arnon Emre Erenoglu wrote: Dear Developers, I'm trying to install the vdagent vdservice to an up to date Windows 2003 Server. The OS version is 5.2.3790. The current vdagent vdservice distributed from

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Emre Erenoglu
Many thanks Arnon! I'll be checking the git and the mail list :) On Thu, Apr 28, 2011 at 11:10 AM, Arnon Gilboa agil...@redhat.com wrote: Yep, I will send a patch exactly for that update the zip - today. Sorry about the delay, Arnon Emre Erenoglu wrote: Dear Developers, I'm trying to

[Spice-devel] [PATCH 1/3] vdservice: don't close pipe if overlapped I/O event is not in signaled state (rhbz#667777)

2011-04-28 Thread Arnon Gilboa
which is beacuse ReadFile completed successfully without pending and the data was already consumed --- vdservice/vdservice.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 175587c..85fa182 100644 ---

[Spice-devel] [PATCH 3/3] vdagent: remove dependency on qxl driver (rhbz#683166)

2011-04-28 Thread Arnon Gilboa
-don't fail to start when no qxl driver installed -if qxls found use them, otherwise just use enumerated non-mirror devices -currently qxl/non-qxl multimon mix is not supported --- vdagent/desktop_layout.cpp | 104 ++- vdagent/desktop_layout.h |1 +

Re: [Spice-devel] Spice on OS/X

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:36:45PM +0200, Kai Mosebach wrote: If I run configure --with-coroutine=gthread I donĀ¹t need those patches below. Are there any disadvantages out of the gthreads? No idea, I'm trying to stay as close as possible to upstream defaults :) Christophe pgpxSxdBRmQ0r.pgp

Re: [Spice-devel] [PATCH 1/3] vdservice: don't close pipe if overlapped I/O event is not in signaled state (rhbz#667777)

2011-04-28 Thread Alon Levy
On Thu, Apr 28, 2011 at 11:58:40AM +0300, Arnon Gilboa wrote: which is beacuse ReadFile completed successfully without pending and the data was already consumed --- vdservice/vdservice.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ACK series. A better comment for the

Re: [Spice-devel] [PATCH 1/3] vdservice: don't close pipe if overlapped I/O event is not in signaled state (rhbz#667777)

2011-04-28 Thread Arnon Gilboa
Alon Levy wrote: ACK series. A better comment for the third patch would be to specify what inconsistent means - that there are some devices with a QXL driver and some without. 10x, you are absolutely right. ___ Spice-devel mailing list

[Spice-devel] [PATCH 3/3] spice: drop obsolete iothread locking

2011-04-28 Thread Gerd Hoffmann
We don't use qemu internals from spice server context any more. Thus we don't also need to grab the iothread mutex from spice server context. And we don't have to temporarely release the lock to avoid deadlocks. Drop all the calls. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c

[Spice-devel] [PATCH 2/3] spice: don't call displaystate callbacks from spice server context.

2011-04-28 Thread Gerd Hoffmann
This patch moves the displaystate callback calls for setting the cursor and the mouse pointer from spice server to qemu (iothread) context. This allows us to simplify locking. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl-render.c| 25 - hw/qxl.c

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Gianluca Cecchi
On Thu, Apr 28, 2011 at 11:54 AM, Arnon Gilboa agil...@redhat.com wrote: Hi Emre, Please try the updated binaries at: http://www.spice-space.org/download/binaries/vdagent-win32_28042011.zip Link added also at the download page: http://www.spice-space.org/download.html Enjoy, Arnon I'm

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Gianluca Cecchi
On Thu, Apr 28, 2011 at 12:34 PM, Gianluca Cecchi gianluca.cec...@gmail.com wrote: On Thu, Apr 28, 2011 at 11:54 AM, Arnon Gilboa agil...@redhat.com wrote: Hi Emre, Please try the updated binaries at: http://www.spice-space.org/download/binaries/vdagent-win32_28042011.zip Link added also at

Re: [Spice-devel] [PATCH 2/3] spice: don't call displaystate callbacks from spice server context.

2011-04-28 Thread Alon Levy
On Thu, Apr 28, 2011 at 12:13:09PM +0200, Gerd Hoffmann wrote: This patch moves the displaystate callback calls for setting the cursor and the mouse pointer from spice server to qemu (iothread) context. This allows us to simplify locking. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Spice-devel] [PATCH 0/3] RfC: fix locking

2011-04-28 Thread Gerd Hoffmann
On 04/28/11 13:14, Alon Levy wrote: On Thu, Apr 28, 2011 at 12:13:07PM +0200, Gerd Hoffmann wrote: Hi folks, Here is a alternative approach to fix the qemu locking issue. It simply handles the updates in the display refresh timer instead of switching back and forth between the threads

Re: [Spice-devel] [PATCH 0/3] RfC: fix locking

2011-04-28 Thread Alon Levy
On Thu, Apr 28, 2011 at 01:26:38PM +0200, Gerd Hoffmann wrote: On 04/28/11 13:14, Alon Levy wrote: On Thu, Apr 28, 2011 at 12:13:07PM +0200, Gerd Hoffmann wrote: Hi folks, Here is a alternative approach to fix the qemu locking issue. It simply handles the updates in the display refresh

Re: [Spice-devel] Spice on OS/X

2011-04-28 Thread Kai Mosebach
# find / -name libglib* /Applications/Adium.app/Contents/Frameworks/libglib.framework /Applications/Adium.app/Contents/Frameworks/libglib.framework/libglib /Applications/Adium.app/Contents/Frameworks/libglib.framework/Versions/2.0. 0/libglib /opt/local/lib/libglib-2.0.0.dylib

[Spice-devel] qemu spice 0.8.1

2011-04-28 Thread Emre Erenoglu
Hi, Do we need to re-compile qemu when we update spice from 0.8.0 to 0.8.1, since qemu depends on spice? I assume if there's no ABI/API change, no need to re-compile, right? -- Emre ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Arnon Gilboa
Gianluca Cecchi wrote: On Thu, Apr 28, 2011 at 12:34 PM, Gianluca Cecchi gianluca.cec...@gmail.com wrote: On Thu, Apr 28, 2011 at 11:54 AM, Arnon Gilboa agil...@redhat.com wrote: Hi Emre, Please try the updated binaries at:

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Gianluca Cecchi
On Thu, Apr 28, 2011 at 3:04 PM, Arnon Gilboa agil...@redhat.com wrote: Please try the updated binaries at: http://www.spice-space.org/download/binaries/vdagent-win32_28042011.zip I'm going to test too on my w2k3 guest. Is it correct this workflow? - I have to install virtio-serial before

Re: [Spice-devel] Spice on OS/X

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote: Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/ Another note, on building the OSX client the symbol _g_get_monotonic_clock is missing. I think this comes from gtk/spice-session.c but does not seem to

Re: [Spice-devel] [PATCH] QEMU: spice: add SASL support

2011-04-28 Thread Gerd Hoffmann
Hi, +if (qemu_opt_get_bool(opts, sasl, 0)) { +spice_server_set_sasl_appname(spice_server, qemu); +spice_server_set_sasl(spice_server, 1); +} This fails will fail to build with older spice-server versions. It should be ifdef'ed using SPICE_SERVER_VERSION for the

Re: [Spice-devel] [RFC 06/33] partially replace outb with ioport_write

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 06:55:55PM +0300, Alon Levy wrote: replace everywhere it is needed for xspice - places left out are ifdefed out later based on the same define mentioned in qxl.h, XSPICE. note: leave spaces between function name and open paren? note2: ioport_write is added at the

Re: [Spice-devel] [RFC 09/33] qxl_driver: fix initialization from wrong pointer warning

2011-04-28 Thread Christophe Fergeau
Ack too On Wed, Apr 27, 2011 at 06:55:58PM +0300, Alon Levy wrote: --- src/qxl_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3514360..dced9fb 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -60,7

Re: [Spice-devel] [RFC 11/33] qxl_driver: fix three incompatible pointer passed warnings

2011-04-28 Thread Christophe Fergeau
Seems ok, ack On Wed, Apr 27, 2011 at 06:56:00PM +0300, Alon Levy wrote: --- src/qxl_driver.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ff6fe97..18050fb 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@

Re: [Spice-devel] [RFC 13/33] qxl_driver: whitespace fixes

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 06:56:02PM +0300, Alon Levy wrote: removing whitespace in lines consisting only of it. most of those areas are touched later, but not all. --- src/qxl_driver.c | 50 +- 1 files changed, 25 insertions(+), 25

Re: [Spice-devel] [RFC 18/33] xspice: use SPICE_CFLAGS

2011-04-28 Thread Christophe Fergeau
Should be merged in patch #15 On Wed, Apr 27, 2011 at 06:56:07PM +0300, Alon Levy wrote: --- src/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8f048c8..6f2cb56 100644 --- a/src/Makefile.am +++

Re: [Spice-devel] [RFC 19/33] cleanup (add eol between system and non system includes)

2011-04-28 Thread Christophe Fergeau
Ack On Wed, Apr 27, 2011 at 06:56:08PM +0300, Alon Levy wrote: --- src/qxl.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index e45066c..3fddef3 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -28,6 +28,7 @@ #include stdint.h #include

Re: [Spice-devel] [RFC 15/33] configure.ac/Makefile.am: add SUPPORT_XSPICE

2011-04-28 Thread Christophe Fergeau
On Wed, Apr 27, 2011 at 06:56:04PM +0300, Alon Levy wrote: --- configure.ac|2 ++ src/Makefile.am | 23 +++ 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 99bc517..6a183df 100644 --- a/configure.ac +++

Re: [Spice-devel] [RFC 06/33] partially replace outb with ioport_write

2011-04-28 Thread Alon Levy
On Thu, Apr 28, 2011 at 04:14:38PM +0200, Christophe Fergeau wrote: On Wed, Apr 27, 2011 at 06:55:55PM +0300, Alon Levy wrote: replace everywhere it is needed for xspice - places left out are ifdefed out later based on the same define mentioned in qxl.h, XSPICE. note: leave spaces

Re: [Spice-devel] [RFC 15/33] configure.ac/Makefile.am: add SUPPORT_XSPICE

2011-04-28 Thread Alon Levy
On Thu, Apr 28, 2011 at 04:27:50PM +0200, Christophe Fergeau wrote: On Wed, Apr 27, 2011 at 06:56:04PM +0300, Alon Levy wrote: --- configure.ac|2 ++ src/Makefile.am | 23 +++ 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure.ac