Re: [Spice-devel] [client 01/10] build-sys: Enable deprecation warnings instead of ignoring them entirely

Hi, this should be the last patch to avoid any compilation issues On Tue, 2016-10-18 at 19:46 +0200, Francois Gouget wrote: > For Spice-gtk most deprecation issues come from changes outside > Spice > (GLib) and thus should not be treated as errors to not break > compilation for users who have

Re: [Spice-devel] [client] gtk: Remove an obsolete comment

On Tue, 2016-10-18 at 05:30 -0400, Frediano Ziglio wrote: > > > > The GTK+ compatibility code has been gathered in a single file > > long ago. > > > similar thing is in vncdisplaykeymap.c > And I also think we removed support for Gtk2 too > > Frediano > > > Signed-off-by: Francois Gouget

Re: [Spice-devel] [PATCH spice-server 01/10] Define a compatibility include for GLib

Hi, On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/Makefile.am   |  1 + >  server/glib-compat.h | 47 > +++ >  2 files changed, 48 insertions(+) >  create mode 100644

Re: [Spice-devel] [PATCH spice-server 02/12] Be consistent with opaque type

On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote: > vdi_port_read_buf_release is registered passing data as > RedVDIReadBuf*, not RedPipeItem*. Cast opaque to proper > pointer type to avoid the assumption that first field of > RedVDIReadBuf is a RedPipeItem. > > Signed-off-by: Frediano

[Spice-devel] Remove Virgl status

Hi, has been a while since I posted a patchset on this. One reason is that the feature set of the series is not changed. Basically all pieces from DRM prime handling to VAAPI (hardware encoding acceleration), forcing streaming and fallback to software encoding are there. The main concern about

[Spice-devel] [PATCH spice-server v4 0/4] Small updates to refactory patches

Added 2 fixup: - revert some changes that can cause regressions; - make compile if debug is enabled. Frediano Ziglio (2): fixup! Improve MainChannel encapsulation fixup! Convert RedChannel hierarchy to GObject Jonathon Jongsma (2): Improve MainChannel encapsulation Convert RedChannel

[Spice-devel] [PATCH spice-server v4 2/4] fixup! Improve MainChannel encapsulation

Revert back spice_assert changes. Pass success to main_channel_on_migrate_connected to avoid changing check behaviour. Signed-off-by: Frediano Ziglio --- server/main-channel-client.c | 2 +- server/main-channel.c| 9 + server/main-channel.h| 3 ++- 3

[Spice-devel] [PATCH spice-server v4 1/4] Improve MainChannel encapsulation

From: Jonathon Jongsma Encapsulate MainChannel a bit better in preparation for proting to GObject. --- server/main-channel-client.c | 24 +++- server/main-channel.c| 15 +++ server/main-channel.h| 2 ++ 3 files changed, 28

[Spice-devel] [PATCH spice-server v4 4/4] fixup! Convert RedChannel hierarchy to GObject

g_object_get require the object to be no-const. Avoid compiler error if statistics are enabled Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +- server/display-channel.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice-server 03/10] Avoid to typedef twice CursorChannel

On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio \ Acked-by: Pavel Grunt > --- >  server/cursor-channel-client.h | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server 02/10] Include GLib compatibility header where needed

My preference would be to squash with the first patch On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  server/char-device.c| 1 + >  server/red-channel-client.c | 1 + >  2

[Spice-devel] [PATCH spice-server] Remove unused InputsChannelPrivate typedef

Signed-off-by: Frediano Ziglio --- server/inputs-channel.h | 1 - 1 file changed, 1 deletion(-) diff --git a/server/inputs-channel.h b/server/inputs-channel.h index 4bae61f..26569fa 100644 --- a/server/inputs-channel.h +++ b/server/inputs-channel.h @@ -41,7 +41,6 @@

[Spice-devel] [PATCH spice-server 03/12] Remove warnings from reds_stat utility

Signed-off-by: Frediano Ziglio --- tools/reds_stat.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/reds_stat.c b/tools/reds_stat.c index 9aca1ad..3e966d4 100644 --- a/tools/reds_stat.c +++ b/tools/reds_stat.c @@ -24,6 +24,7 @@ #include

[Spice-devel] [PATCH spice-server 04/12] Add reds_stat to compiled software

Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- Makefile.am | 2 +- configure.ac | 1 + tools/Makefile.am | 19 +++ 3 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 tools/Makefile.am diff

[Spice-devel] [PATCH spice-server 11/12] Move monitors_config_ref inside red_monitors_config_item_new

Make move symmetric red_monitors_config_item_new and red_monitors_config_item_free. Signed-off-by: Frediano Ziglio --- server/dcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 9bd1c0a..82a9f49 100644 ---

[Spice-devel] [PATCH spice-server 01/12] Remove red_pipe_add_verb family function

These functions were implementing the same stuff as empty messages functions provided by RedChannel so reuse them. The implementation seems a bit different but the result is the same. Specifically: - RedEmptyMsgPipeItem::msg is int while RedVerbItem::verb was uint16_t however this data goes

[Spice-devel] [PATCH spice-server 00/12] Miscellaneous patches

Frediano Ziglio (12): Remove red_pipe_add_verb family function Be consistent with opaque type Remove warnings from reds_stat utility Add reds_stat to compiled software Make QXLMessage handling safe Reuse SPICE_N_ELEMENTS macro Make compression image declarations more similar Do not

[Spice-devel] [PATCH spice-server 10/12] dcc: Use spice_new instead of spice_malloc

spice_new return directly the correct type. Signed-off-by: Frediano Ziglio --- server/dcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 45ba81b..9bd1c0a 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -176,7

[Spice-devel] [PATCH spice-server 06/12] Reuse SPICE_N_ELEMENTS macro

Signed-off-by: Frediano Ziglio --- server/red-worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-worker.c b/server/red-worker.c index 3784261..f3b8c4b 100644 --- a/server/red-worker.c +++ b/server/red-worker.c @@ -407,11 +407,11 @@

[Spice-devel] [PATCH spice-server 12/12] Declare same enumerator in a single header

Avoid having duplication and desynchronisation. Signed-off-by: Frediano Ziglio --- server/cursor-channel-client.c | 6 -- server/cursor-channel-client.h | 6 ++ server/cursor-channel.c| 6 -- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git

[Spice-devel] [PATCH spice-server 02/12] Be consistent with opaque type

vdi_port_read_buf_release is registered passing data as RedVDIReadBuf*, not RedPipeItem*. Cast opaque to proper pointer type to avoid the assumption that first field of RedVDIReadBuf is a RedPipeItem. Signed-off-by: Frediano Ziglio --- server/reds.c | 3 ++- 1 file changed,

[Spice-devel] [PATCH spice-server 09/12] Fix typo in comment

Signed-off-by: Frediano Ziglio --- server/red-channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-channel.h b/server/red-channel.h index 8818a04..5299646 100644 --- a/server/red-channel.h +++ b/server/red-channel.h @@ -358,7 +358,7 @@

[Spice-devel] [PATCH spice-server 08/12] Do not declare image_encoders_compress_lz4 if LZ4 is not available

Signed-off-by: Frediano Ziglio --- server/image-encoders.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/image-encoders.h b/server/image-encoders.h index 6b4999e..a755bf3 100644 --- a/server/image-encoders.h +++ b/server/image-encoders.h @@ -202,8 +202,10 @@

[Spice-devel] [PATCH spice-server 07/12] Make compression image declarations more similar

Signed-off-by: Frediano Ziglio --- server/image-encoders.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/server/image-encoders.h b/server/image-encoders.h index 6542edd..6b4999e 100644 --- a/server/image-encoders.h +++ b/server/image-encoders.h

[Spice-devel] [PATCH spice-server 1/2] Refactory Glz RedDrawable retention code

The code was quite complicated. - a GlzEncDictImageContext was bound to a GlzDrawableInstanceItem (1-1 relation); - multiple GlzDrawableInstanceItem were attached to RedGlzDrawable; - multiple RedGlzDrawable (one for RedClient) were attached to Drawable using GlzImageRetention; - OOM code

[Spice-devel] [PATCH spice-server 2/2] Add some debugging for GlzDictItem structure

Signed-off-by: Frediano Ziglio --- server/image-encoders.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/server/image-encoders.c b/server/image-encoders.c index 951fe96..70eb24a 100644 --- a/server/image-encoders.c +++

[Spice-devel] [client] gtk: Remove an obsolete comment

The GTK+ compatibility code has been gathered in a single file long ago. Signed-off-by: Francois Gouget --- See commit c2356a71. src/spice-widget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 06e332f..3ac0a7d 100644

Re: [Spice-devel] [client] gtk: Remove an obsolete comment

> > The GTK+ compatibility code has been gathered in a single file long ago. > And I also think we removed support for Gtk2 too Frediano > Signed-off-by: Francois Gouget > --- > > See commit c2356a71. > > src/spice-widget.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [Spice-devel] [PATCH spice-common 2/2] Add protocol documentation for "channel" and "protocol"

Hi, On Tue, Oct 18, 2016 at 10:20:44AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso both patches > --- > docs/spice_protocol.txt | 46 +- > 1 file changed, 45

Re: [Spice-devel] Remove Virgl status

Hi, On Tue, Oct 18, 2016 at 06:07:50AM -0400, Frediano Ziglio wrote: > Hi, > has been a while since I posted a patchset on this. > One reason is that the feature set of the series is not changed. > > Basically all pieces from DRM prime handling to VAAPI (hardware > encoding acceleration),

[Spice-devel] [spice-protocol v1] enums: Move auto generated SpiceDataCompressionType

From: Victor Toso This header is auto generated from spice_codegen.py tool in spice-common repository and thus, it changes what was included manually. Move SpiceDataCompressionType struct to comply with spice_codegen.py. This header was generated with: ./spice_codegen.py

[Spice-devel] [PATCH v4] !fixup Improve MainChannel encapsulation

--- Changes since v3: - change _peek_migration_target() to _get_migration_target() - add separate 'success' argument to _on_migrate_connected() - revert to using asserts server/main-channel-client.c | 6 +++--- server/main-channel.c| 12 +++- server/main-channel.h|

Re: [Spice-devel] [PATCH spice-server v4 0/4] Small updates to refactory patches

Ugh, I was catching up on email today and started responding to the v3 series before I noticed that you had sent a new version of this series already today. So the patches/emails I just sent may be out-of-date. Will start looking at these. Sorry. On Tue, 2016-10-18 at 12:13 +0100, Frediano

Re: [Spice-devel] [PATCH spice-server 01/10] Define a compatibility include for GLib

On Tue, 18 Oct 2016, Pavel Grunt wrote: [...] > > +#if !GLIB_CHECK_VERSION(2,30,0) > > +static inline gboolean > > +g_queue_remove_boolean(GQueue *queue, gconstpointer data) > > +{ > > + GList *link = g_queue_find(queue, data); > > + if (!link) { > > + return FALSE; > > + } > > +

Re: [Spice-devel] [PATCH spice-server 01/10] Define a compatibility include for GLib

On Tue, 2016-10-18 at 10:38 +0200, Francois Gouget wrote: > On Tue, 18 Oct 2016, Pavel Grunt wrote: > [...] > > > +#if !GLIB_CHECK_VERSION(2,30,0) > > > +static inline gboolean > > > +g_queue_remove_boolean(GQueue *queue, gconstpointer data) > > > +{ > > > + GList *link = g_queue_find(queue,

Re: [Spice-devel] [PATCH spice-server 01/10] Define a compatibility include for GLib

> > On Tue, 2016-10-18 at 10:38 +0200, Francois Gouget wrote: > > On Tue, 18 Oct 2016, Pavel Grunt wrote: > > [...] > > > > +#if !GLIB_CHECK_VERSION(2,30,0) > > > > +static inline gboolean > > > > +g_queue_remove_boolean(GQueue *queue, gconstpointer data) > > > > +{ > > > > + GList *link =

[Spice-devel] [PATCH spice-common 2/2] Add protocol documentation for "channel" and "protocol"

Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index 892872d..e982d26 100644 ---

[Spice-devel] [PATCH spice-common 1/2] Fix BNF notation in documentation

Definition names have no angular brackets. Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index 1d45b34..892872d 100644 ---

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

On Mon, 2016-10-17 at 06:55 -0400, Frediano Ziglio wrote: > >  > > I just realized that beside spice_assert replacement this test is > different. > Not seamless is the old "seamless && success" condition so this is > equivalent Oh, good catch. > to  > > g_warn_if_fail(!(seamless && success) ||

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

> > On Mon, 2016-10-17 at 06:55 -0400, Frediano Ziglio wrote: > > >  > > > > I just realized that beside spice_assert replacement this test is > > different. > > Not seamless is the old "seamless && success" condition so this is > > equivalent > > Oh, good catch. > > > to > > > >

[Spice-devel] [spice-gtk] support for multiple shared directories

From: Visarion Alexandru This patch offers the alternative of supplying a list of shared directories instead of a single shared directory. This new API does not break the old one, meant for a single shared folder. Visarion Alexandru (1): session: add

Re: [Spice-devel] [PATCH spice-server v4 4/4] fixup! Convert RedChannel hierarchy to GObject

Hmm, that's kind of annoying, but OK.  Acked-by: Jonathon Jongsma On Tue, 2016-10-18 at 12:13 +0100, Frediano Ziglio wrote: > g_object_get require the object to be no-const. > Avoid compiler error if statistics are enabled > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-server v4 2/4] fixup! Improve MainChannel encapsulation

This looks basically the same as the fixup patch that I just sent, but mine also includes the change from _peek_ to _get_. Feel free to choose this one or mine. Jonathon On Tue, 2016-10-18 at 12:13 +0100, Frediano Ziglio wrote: > Revert back spice_assert changes. > Pass success to

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

On Fri, 2016-10-14 at 10:49 -0400, Frediano Ziglio wrote: > > > > From: Jonathon Jongsma > > > > Encapsulate MainChannel a bit better in preparation for proting to > > GObject. > > Small typo > proting -> porting > right > > > >  > > diff --git a/server/main-channel.h

[Spice-devel] [spice-gtk] session: add multiple-shared-dirs property

From: Visarion Alexandru Allow to specify a list of directories at runtime via properties, which are symlinked in a per-session temporary, shared directory. https://bugs.freedesktop.org/show_bug.cgi?id=95255 --- src/spice-session-priv.h | 2 ++ src/spice-session.c

Re: [Spice-devel] [spice-gtk] session: add multiple-shared-dirs property

Hi - Original Message - > From: Visarion Alexandru > > Allow to specify a list of directories at runtime via > properties, which are symlinked in a per-session temporary, > shared directory. > > https://bugs.freedesktop.org/show_bug.cgi?id=95255 > --- I

[Spice-devel] [client 00/10] Deprecation warning cleanup

This is another take on trying to clean up the deprecation warning situation in Spice-Gtk. Let me know if it goes in the right direction. With this patchset deprecation warnings are enabled again and there are no remaining warnings, except those in src/controller since they happen in

[Spice-devel] [client 07/10] build-sys: Use spice-protocol's deprecation macros

Signed-off-by: Francois Gouget --- src/spice-channel.h | 5 +++-- src/spice-util.h | 2 -- src/usb-device-manager.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/spice-channel.h b/src/spice-channel.h index 3b0bffb..aa0d9cb 100644

[Spice-devel] [client 04/10] gtk: Avoid gtk_hbutton_box_new(); it is deprecated

Spice-Gtk requires GTK+ > 3.12 which has gtk_button_box_new(). Signed-off-by: Francois Gouget --- src/spicy-connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spicy-connect.c b/src/spicy-connect.c index a1d895a..915eb06 100644 ---

[Spice-devel] [client 09/10] RFC: gtk: Temporarily ignore the keyboard/mouse grabbing deprecation warnings

Signed-off-by: Francois Gouget --- src/spice-widget.c | 24 1 file changed, 24 insertions(+) diff --git a/src/spice-widget.c b/src/spice-widget.c index 82adacf..f0681d6 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -812,6 +812,9 @@

[Spice-devel] [client 08/10] session: Disable the spice_audio_new() deprecation warning

Third parties are not supposed to use spice_audio_new() anymore, but internally it is used to implement its replacement, spice_audio_get(). Signed-off-by: Francois Gouget --- src/spice-session.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/spice-session.c

[Spice-devel] [client 01/10] build-sys: Enable deprecation warnings instead of ignoring them entirely

For Spice-gtk most deprecation issues come from changes outside Spice (GLib) and thus should not be treated as errors to not break compilation for users who have newer third-party libraries. However they must be visible otherwise Spice developers will not be aware of them and thus will not fix

[Spice-devel] [client 02/10] gtk: Ignore GLib's too-new warnings where we explicitly check its version

Signed-off-by: Francois Gouget --- src/spice-gtk-session.c | 5 + src/spice-widget-egl.c | 3 +++ src/spice-widget.c | 6 ++ 3 files changed, 14 insertions(+) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index 3e0ec74..7ec2a57 100644 ---

[Spice-devel] [client 03/10] gtk: Avoid gtk_vbox_new(); it is deprecated

Spice-Gtk requires GTK+ > 3.12 which has gtk_box_new(). Signed-off-by: Francois Gouget --- src/spicy-connect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spicy-connect.c b/src/spicy-connect.c index c471df5..a1d895a 100644 ---

[Spice-devel] [client 05/10] gtk: GtkTable is deprecated so use GtkGrid instead

Signed-off-by: Francois Gouget --- src/spicy-connect.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/spicy-connect.c b/src/spicy-connect.c index 915eb06..39555a6 100644 --- a/src/spicy-connect.c +++ b/src/spicy-connect.c @@

Re: [Spice-devel] [client 03/10] gtk: Avoid gtk_vbox_new(); it is deprecated

please use "spicy:" for code touching spicy, thanks - Original Message - > Spice-Gtk requires GTK+ > 3.12 which has gtk_box_new(). > > Signed-off-by: Francois Gouget > --- > src/spicy-connect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Spice-devel] [PATCH spice-server v4 2/4] fixup! Improve MainChannel encapsulation

> > This looks basically the same as the fixup patch that I just sent, but > mine also includes the change from _peek_ to _get_. Feel free to choose > this one or mine. > > Jonathon > Got a mix (just space changes of your, there was a long line). Frediano > > On Tue, 2016-10-18 at 12:13

[Spice-devel] [client 06/10] build-sys: Remove SPICE_NO_DEPRECATED

Deprecation warnings no longer cause compilation errors. Also they should either be fixed or ignored with G_GNUC_{BEGIN,END}_IGNORE_DEPRECATIONS. Signed-off-by: Francois Gouget --- src/Makefile.am | 1 - src/spice-util.h | 12 +++- 2 files changed, 3

[Spice-devel] [client 10/10] RFC: spicy: Temporarily ignore deprecation warnings

GtkAction and lots of GtkUI APIs are deprecated. Signed-off-by: Francois Gouget --- src/spicy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index c502428..c4a6c7d 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -38,6 +38,9 @@

Re: [Spice-devel] [PATCH spice-server 06/10] Include directly used header in dcc.h

Acked-by: Jonathon Jongsma On Mon, 2016-10-17 at 14:26 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc.h | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/server/dcc.h b/server/dcc.h > index 2456f09..7a07981

Re: [Spice-devel] [client] gtk: Remove an obsolete comment

On Tue, 18 Oct 2016, Pavel Grunt wrote: > On Tue, 2016-10-18 at 05:30 -0400, Frediano Ziglio wrote: > > > > > > The GTK+ compatibility code has been gathered in a single file > > > long ago. > > > > > > similar thing is in vncdisplaykeymap.c It's a bit different. Those comments still have the

[Spice-devel] [PATCH spice-server v5] Updated refactory patches

Just removed acked and pushed patches and merged acknowledged fixup (1). Jonathon Jongsma (1): Convert RedChannel hierarchy to GObject server/Makefile.am | 2 + server/common-graphics-channel.c| 111 -- server/common-graphics-channel.h| 42 ++-

[Spice-devel] [spice-gtk v1 4/4] channel-display-gst: early return if gst_init failed

From: Victor Toso If gst_init() fails, gstvideo_init() will warn once about the issue and never attempt to try again, which is probably fine. All the other APIs that might be called such as create_gstreamer_decoder() should not fail silently. Signed-off-by: Victor Toso

[Spice-devel] [spice-gtk v1 1/4] channel-display-gst: style changes in create_pipeline

From: Victor Toso Move declaration of variable to top and break big g_strdup_printf line. Signed-off-by: Victor Toso --- src/channel-display-gst.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

From: Victor Toso Instead of creating the whole pipeline and check for errors (which would create and destroy the SpiceGstDecoder), let's use gst_element_factory_find() function. Signed-off-by: Victor Toso --- src/channel-display-gst.c | 25

[Spice-devel] [spice-gtk v1 2/4] channel-display-gst: use a static array for gst options

From: Victor Toso Signed-off-by: Victor Toso --- src/channel-display-gst.c | 78 +-- 1 file changed, 42 insertions(+), 36 deletions(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c

Re: [Spice-devel] [PATCH spice-server 01/12] Remove red_pipe_add_verb family function

It seems that  On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote: > These functions were implementing the same stuff as empty > messages functions provided by RedChannel so reuse them. > > The implementation seems a bit different but the result > is the same. Specifically: > -

Re: [Spice-devel] [PATCH spice-server 03/12] Remove warnings from reds_stat utility

Acked-by: Jonathon Jongsma On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  tools/reds_stat.c | 11 ++- >  1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/tools/reds_stat.c