Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Frediano Ziglio
> > > On 1 Mar 2018, at 13:13, Frediano Ziglio wrote: > > > >> > >> From: Christophe de Dinechin > >> > >> Throwing 'runtime_error' directly should be reserved for the support > >> library. Add an 'Error' class as a base class for all errors thrown > >> by the streaming agent, as well as sub

Re: [Spice-devel] [PATCH 18/22] Convert existing std::runtime_error to the new Error classes

2018-03-02 Thread Lukáš Hrázký
On Thu, 2018-03-01 at 17:52 +0100, Christophe de Dinechin wrote: > > On 1 Mar 2018, at 16:47, Lukáš Hrázký wrote: > > > > On Thu, 2018-03-01 at 16:23 +0100, Christophe de Dinechin wrote: > > > > On 1 Mar 2018, at 15:42, Lukáš Hrázký wrote: > > > > > > > > On Wed, 2018-02-28 at 16:43 +0100, Chri

Re: [Spice-devel] [PATCH 10/22] Remove client_codecs global variable, moved inside the 'Stream' class

2018-03-02 Thread Christophe Fergeau
On Thu, Mar 01, 2018 at 08:28:12PM +0100, Christophe de Dinechin wrote: > > > > On 1 Mar 2018, at 11:51, Lukáš Hrázký wrote: > > > > On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: > >> From: Christophe de Dinechin > >> > >> It makes sense to place the codecs inside the Strea

Re: [Spice-devel] [spice-gtk v1] Don't exceed one statement per line

2018-03-02 Thread Marc-André Lureau
ack On Thu, Mar 1, 2018 at 10:23 AM, Victor Toso wrote: > From: Victor Toso > > Cosmetic change. One break was dropped on _default:_ label of switch > > Signed-off-by: Victor Toso > --- > src/channel-usbredir.c | 8 +--- > src/spice-channel.c| 7 +-- > 2 files changed, 10 insertion

Re: [Spice-devel] [spice-streaming-agent 3/6] build: Remove -fvisibility detection from configure.ac

2018-03-02 Thread Christophe Fergeau
On Fri, Mar 02, 2018 at 02:27:57AM -0500, Frediano Ziglio wrote: > > > > In my testing (x86_64/gcc), this had no impact on the resulting binary, > > building with/without it gives the same stripped binary save for its > > buildid. > > > > Signed-off-by: Christophe Fergeau > > Have you compiled

Re: [Spice-devel] [PATCH spice-gtk v2 3/4] uri: generate spice://host:port or spice+tls://host:port

2018-03-02 Thread Marc-André Lureau
Hi On Wed, Feb 21, 2018 at 5:53 PM, Marc-André Lureau wrote: > On Wed, Feb 21, 2018 at 10:17 AM, Frediano Ziglio wrote: >>> From: Marc-André Lureau >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> src/spice-session.c | 31 +++ >>> tests/session.c | 20 +

Re: [Spice-devel] [PATCH 14/22] Create classes encapsulating the X11 display cursor capture

2018-03-02 Thread Lukáš Hrázký
On Thu, 2018-03-01 at 20:01 +0100, Christophe de Dinechin wrote: > > On 1 Mar 2018, at 14:56, Lukáš Hrázký wrote: > > > > On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > There are two classes: > > > - The X11CursorUpdater class sen

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Lukáš Hrázký
On Fri, 2018-03-02 at 03:03 -0500, Frediano Ziglio wrote: > > > > > On 1 Mar 2018, at 13:13, Frediano Ziglio wrote: > > > > > > > > > > > From: Christophe de Dinechin > > > > > > > > Throwing 'runtime_error' directly should be reserved for the support > > > > library. Add an 'Error' class as

[Spice-devel] [spice-gtk v1 1/3] channel-display: remove id parameter from helper function

2018-03-02 Thread Victor Toso
From: Victor Toso Instead of passing the id parameter for destroy_display_stream() which is only used for debug, let's store the id when creating the stream at display_stream_create(). Another benefit is that we can drop a helper function to get the id while holding display_stream structure. Th

[Spice-devel] [spice-gtk v1 2/3] channel-display: remove unneeded function

2018-03-02 Thread Victor Toso
From: Victor Toso The get_stream_id_by_stream() was introduced in 141c2d82 to debug GStreamer's pipeline. But with previous patch, we are moving the ID to the display_stream structure and can be accessible directly. Signed-off-by: Victor Toso --- src/channel-display-gst.c | 5 ++--- src/chan

[Spice-devel] [spice-gtk v1 3/3] channel-display: Use GHashTable to keep stream's structure

2018-03-02 Thread Victor Toso
From: Victor Toso The major issue with the current approach is that it relies on the ID from SpiceMsgDisplayStreamCreate to create the smallest 2^n sized array that could fit the stream's id as index. This is potentially dangerous as the ID value is not documented and could have any uint32_t val

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 09:03, Frediano Ziglio wrote: > >>> >>> On 1 Mar 2018, at 13:13, Frediano Ziglio wrote: >>> From: Christophe de Dinechin Throwing 'runtime_error' directly should be reserved for the support library. Add an 'Error' class as a base class for all

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 11:53, Lukáš Hrázký wrote: > > On Fri, 2018-03-02 at 03:03 -0500, Frediano Ziglio wrote: >>> On 1 Mar 2018, at 13:13, Frediano Ziglio wrote: > > From: Christophe de Dinechin > > Throwing 'runtime_error' directly should be reserved for the supp

Re: [Spice-devel] [PATCH 19/22] Put Stream and Message classes in separate files

2018-03-02 Thread Lukáš Hrázký
On Thu, 2018-03-01 at 17:57 +0100, Christophe de Dinechin wrote: > > On 1 Mar 2018, at 16:11, Lukáš Hrázký wrote: > > > > On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Doing this change will make it possible to move the capture l

Re: [Spice-devel] [PATCH 14/22] Create classes encapsulating the X11 display cursor capture

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 11:37, Lukáš Hrázký wrote: > > On Thu, 2018-03-01 at 20:01 +0100, Christophe de Dinechin wrote: >>> On 1 Mar 2018, at 14:56, Lukáš Hrázký wrote: >>> >>> On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: From: Christophe de Dinechin There are

Re: [Spice-devel] [PATCH 21/22] Moving FrameLog into a separate file

2018-03-02 Thread Lukáš Hrázký
On Thu, 2018-03-01 at 16:47 +0100, Christophe de Dinechin wrote: > > On 1 Mar 2018, at 16:14, Lukáš Hrázký wrote: > > > > On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Isolating classes in separate files makes parallel builds fas

Re: [Spice-devel] [PATCH 19/22] Put Stream and Message classes in separate files

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 14:07, Lukáš Hrázký wrote: > > On Thu, 2018-03-01 at 17:57 +0100, Christophe de Dinechin wrote: >>> On 1 Mar 2018, at 16:11, Lukáš Hrázký wrote: >>> >>> On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: From: Christophe de Dinechin Doing thi

Re: [Spice-devel] [PATCH 21/22] Moving FrameLog into a separate file

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 14:34, Lukáš Hrázký wrote: > > On Thu, 2018-03-01 at 16:47 +0100, Christophe de Dinechin wrote: >>> On 1 Mar 2018, at 16:14, Lukáš Hrázký wrote: >>> >>> On Wed, 2018-02-28 at 16:43 +0100, Christophe de Dinechin wrote: From: Christophe de Dinechin Isolating

Re: [Spice-devel] [PATCH 14/22] Create classes encapsulating the X11 display cursor capture

2018-03-02 Thread Lukáš Hrázký
On Fri, 2018-03-02 at 14:28 +0100, Christophe de Dinechin wrote: > > On 2 Mar 2018, at 11:37, Lukáš Hrázký wrote: > > > > On Thu, 2018-03-01 at 20:01 +0100, Christophe de Dinechin wrote: > > > > On 1 Mar 2018, at 14:56, Lukáš Hrázký wrote: > > > > > > > > On Wed, 2018-02-28 at 16:43 +0100, Chri

[Spice-devel] [PATCH spice-common] build: Remove FIXME_SERVER_SMARTCARD hack

2018-03-02 Thread Eduardo Lima (Etrunko)
When we remove the hacks in configure.ac and common/Makefile.am, two errors pop out: generated_server_demarshallers.c: In function ‘parse_msgc_smartcard_reader_add’: generated_server_demarshallers.c:1985:30: error: ‘mem_size’ undeclared (first use in this function); did you mean ‘nw_size’? d

Re: [Spice-devel] [PATCH 19/22] Put Stream and Message classes in separate files

2018-03-02 Thread Lukáš Hrázký
On Fri, 2018-03-02 at 14:35 +0100, Christophe de Dinechin wrote: > > On 2 Mar 2018, at 14:07, Lukáš Hrázký wrote: > > > > On Thu, 2018-03-01 at 17:57 +0100, Christophe de Dinechin wrote: > > > > On 1 Mar 2018, at 16:11, Lukáš Hrázký wrote: > > > > > > > > On Wed, 2018-02-28 at 16:43 +0100, Chri

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Jonathon Jongsma
On Fri, 2018-03-02 at 11:53 +0100, Lukáš Hrázký wrote: > On Fri, 2018-03-02 at 03:03 -0500, Frediano Ziglio wrote: > > > > > > > On 1 Mar 2018, at 13:13, Frediano Ziglio > > > > wrote: > > > > > > > > > > > > > > From: Christophe de Dinechin > > > > > > > > > > Throwing 'runtime_error' direct

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 17:16, Jonathon Jongsma wrote: > > On Fri, 2018-03-02 at 11:53 +0100, Lukáš Hrázký wrote: >> On Fri, 2018-03-02 at 03:03 -0500, Frediano Ziglio wrote: > On 1 Mar 2018, at 13:13, Frediano Ziglio > wrote: > >> >> From: Christophe de Dinechin >

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-02 Thread Christophe Fergeau
On Fri, Mar 02, 2018 at 02:00:23PM +0100, Christophe de Dinechin wrote: > > > > On 2 Mar 2018, at 09:03, Frediano Ziglio wrote: > > > >>> > >>> On 1 Mar 2018, at 13:13, Frediano Ziglio wrote: > >>> > > From: Christophe de Dinechin > > Throwing 'runtime_error' directly

Re: [Spice-devel] [PATCH spice-gtk v2 3/4] uri: generate spice://host:port or spice+tls://host:port

2018-03-02 Thread Frediano Ziglio
> > Hi > > On Wed, Feb 21, 2018 at 5:53 PM, Marc-André Lureau > wrote: > > On Wed, Feb 21, 2018 at 10:17 AM, Frediano Ziglio > > wrote: > >>> From: Marc-André Lureau > >>> > >>> Signed-off-by: Marc-André Lureau > >>> --- > >>> src/spice-session.c | 31 +++ > >>> t

Re: [Spice-devel] [PATCH 19/22] Put Stream and Message classes in separate files

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 16:46, Lukáš Hrázký wrote: > > On Fri, 2018-03-02 at 14:35 +0100, Christophe de Dinechin wrote: >>> On 2 Mar 2018, at 14:07, Lukáš Hrázký wrote: >>> >>> On Thu, 2018-03-01 at 17:57 +0100, Christophe de Dinechin wrote: > On 1 Mar 2018, at 16:11, Lukáš Hrázký wrote: >>>

Re: [Spice-devel] [PATCH 14/22] Create classes encapsulating the X11 display cursor capture

2018-03-02 Thread Christophe de Dinechin
> On 2 Mar 2018, at 14:45, Lukáš Hrázký wrote: > > On Fri, 2018-03-02 at 14:28 +0100, Christophe de Dinechin wrote: >>> On 2 Mar 2018, at 11:37, Lukáš Hrázký wrote: >>> >>> On Thu, 2018-03-01 at 20:01 +0100, Christophe de Dinechin wrote: > On 1 Mar 2018, at 14:56, Lukáš Hrázký wrote: >>>

Re: [Spice-devel] [PATCH spice-streaming-agent v5 2/2] Implement handling of error messages from the server

2018-03-02 Thread Christophe de Dinechin
> On 28 Feb 2018, at 13:53, Lukáš Hrázký wrote: > > Log error messages from the server to syslog (not aborting the agent). > Limits the messages to 1023 bytes, error messages from the server are > not expected to be longer. In the unlikely case the message is longer, > log the first 1023 bytes