Re: [sqlite] SQLITE_OMIT_BUILTIN_TEST renders fix for ticket [da784137] useless

2016-12-07 Thread Richard Hipp
On 12/7/16, Ralf Junker wrote: > > I assumed that > binaries on sqlite.org would omit test code for best performance. We go by the principle of "Fly what you test, and test what you fly". > >> The SQLITE_OMIT_BUILTIN_TEST option is untested and unsupported. > > This was not clear to me from the

Re: [sqlite] SQLITE_OMIT_BUILTIN_TEST renders fix for ticket [da784137] useless

2016-12-07 Thread Ralf Junker
On 07.12.2016 14:21, Richard Hipp wrote: Side note: I notice that the SQLite binaries (Windows, at least) are not compiled with SQLITE_OMIT_BUILTIN_TEST and not affected by the problem. Is there a reason to omit SQLITE_OMIT_BUILTIN_TEST from the builds, as it adds at least some overhead? > The

Re: [sqlite] SQLITE_OMIT_BUILTIN_TEST renders fix for ticket [da784137] useless

2016-12-07 Thread Richard Hipp
On 12/7/16, Ralf Junker wrote: > > Side note: I notice that the SQLite binaries (Windows, at least) are not > compiled with SQLITE_OMIT_BUILTIN_TEST and not affected by the problem. > Is there a reason to omit SQLITE_OMIT_BUILTIN_TEST from the builds, as > it adds at least some overhead? The reas

[sqlite] SQLITE_OMIT_BUILTIN_TEST renders fix for ticket [da784137] useless

2016-12-07 Thread Ralf Junker
Alarming side effect of SQLITE_OMIT_BUILTIN_TEST: It renders the fix [005d5b87] for ticket [da784137] useless. Ticket: http://www.sqlite.org/src/info/da7841375186386c Fix, trunk: http://www.sqlite.org/src/info/005d5b870625d175 Fix, 3.15.2: http://www.sqlite.org/src/info/27438fb43db4eae9 R