Re: [squid-dev] [PATCH] Incorrect processing of long URIs

2016-08-23 17:50 GMT+03:00 Alex Rousskov : > s/request-line/request-line: URI/ for consistency and clarity sake. > I wonder whether we should make this variable static to avoid repeated > function calls on a performance-sensitive code path. Same for the old >

Re: [squid-dev] [PATCH] Older response must not update

On 08/24/2016 09:20 AM, Amos Jeffries wrote: > in src/HttpReply.h: > * please use doxygen syntax "\returns" instead of "returns" in the > comment text. No objection, but please note that the "returns..." phrase in isolation does not fully describe what the method returns in this case. Only the

[squid-dev] [PATCH] SSL CN wildcard must only match a single domain component [fragment]

When comparing the requested domain name with a certificate Common Name, Squid expanded wildcard to cover more than one domain name label (a.k.a component), violating RFC 2818 requirement[1]. For example, Squid thought that wrong.host.example.com matched a *.example.com CN. [1] "the

Re: [squid-dev] [PATCH] Older response must not update

On 25/08/2016 12:46 a.m., Eduard Bagdasaryan wrote: > Hello, > > This patch teaches Squid to ignore a [revalidation] response with an older > Date header. > > Before this patch, Squid violated the RFC 7234 section 4 MUST > requirement: "When more than one suitable response is stored, a cache >

Re: [squid-dev] [PATCH] Incorrect processing of long URIs

On 08/24/2016 08:30 AM, Amos Jeffries wrote: > On 25/08/2016 12:36 a.m., Eduard Bagdasaryan wrote: >> 2016-08-23 18:01 GMT+03:00 Alex Rousskov: >> >>> invalid request-line: missing delimiter before "HTTP/1" >> >> In order to generate "where" with such detalization (i.e. the specific >> protocol

Re: [squid-dev] [PATCH] Incorrect processing of long URIs

On 25/08/2016 12:36 a.m., Eduard Bagdasaryan wrote: > 2016-08-23 18:01 GMT+03:00 Alex Rousskov: > >> invalid request-line: missing delimiter before "HTTP/1" > > In order to generate "where" with such detalization (i.e. the specific > protocol version or method) we would need to pass

Re: [squid-dev] [PATCH] Incorrect processing of long URIs

On 08/24/2016 06:36 AM, Eduard Bagdasaryan wrote: > 2016-08-23 18:01 GMT+03:00 Alex Rousskov > : > >> invalid request-line: missing delimiter before "HTTP/1" > > In order to generate "where" with such detalization (i.e. the specific > protocol version or method)

Re: [squid-dev] [PATCH] Incorrect processing of long URIs

2016-08-23 18:01 GMT+03:00 Alex Rousskov : > invalid request-line: missing delimiter before "HTTP/1" In order to generate "where" with such detalization (i.e. the specific protocol version or method) we would need to pass skipDelimiter() the parsed