Re: [squid-dev] [PATCH] Fixed Write.cc:41 "!ccb->active()" assertion

On 15/11/2016 7:03 a.m., Christos Tsantilas wrote: > The following sequence of events triggers this assertion: > - The server sends an 1xx control message. > - http.cc schedules ConnStateData::sendControlMsg call. > - Before sendControlMsg is fired, http.cc detects an error (e.g., I/O >

Re: [squid-dev] [PATCH] ICAP trailer support

On 13/11/2016 7:01 a.m., Eduard Bagdasaryan wrote: > 2016-11-11 8:27 GMT+03:00 Amos Jeffries : > >> In Adaptation::Icap::ModXact::expectIcapTrailers() please use >> getByIdIfPresent(Http::TRAILER, ...) since Trailer is a registered >> header. > > Fixed. > >> In answer to

[squid-dev] Build failed in Jenkins: 5-matrix » gcc,d-debian-unstable #8

http://build.squid-cache.org/job/5-matrix/compiler=gcc,label=d-debian-unstable/8/-- [...truncated 32111 lines...] libtool: compile: ccache gcc -DHAVE_CONFIG_H -I../../.. -I../../../include -I../../../lib -I../../../src -I../include -I/usr/include/libxml2

[squid-dev] [PATCH] Fixed Write.cc:41 "!ccb->active()" assertion

The following sequence of events triggers this assertion: - The server sends an 1xx control message. - http.cc schedules ConnStateData::sendControlMsg call. - Before sendControlMsg is fired, http.cc detects an error (e.g., I/O error or timeout) and starts writing the reply to the user. -

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

> For the record, I do not plan on reviewing this patch further. I did > what I could, but there is just too much information missing for me to > reconstruct the exact intent and evaluate the results. IMHO, I should > not be parsing large raw dumps to figure out what the patch does or does > not

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

On 11/13/2016 11:02 PM, Amos Jeffries wrote: > On 14/11/2016 6:36 p.m., Alex Rousskov wrote: >> On 11/13/2016 10:15 PM, Amos Jeffries wrote: >> >>> I think we should accumulate into two SBufList instead, one for -i and >>> one for +i instead of switching back and forth with potentially lots of >>>

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

Hi, the attached patch fixes the issue with missing ACL entries (verified) and streamlines the code a bit. Performance-wise it improves a bit, parsing the same 1M-entry ACL in 19.4 seconds (17.8 seconds in userland). On Mon, Nov 14, 2016 at 11:04 AM, Kinkie wrote: > On

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

>> The code managing case-insensitivity flags is IMO quite complicated >> and not really intuitive: it switches between case-insensitive and >> case-sensitive each time it meets a -i flag. > > It does?! Wow! The documentation says that +i switches back to > case-sensitive rather than repeating -i

Re: [squid-dev] [PATCH] Fix for the bug 3533

On 13/11/2016 9:40 a.m., Garri Djavadyan wrote: > Dear developers, > > The attached patch fixes the bug 3533 [1], still existing in trunk > (revno: 14938). The problem relates to the fact that the code 303 > (scSeeOther) is not considered by Squid as a one permitted to remove > public store

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

On Mon, Nov 14, 2016 at 5:59 AM, Amos Jeffries wrote: > On 14/11/2016 6:30 p.m., Alex Rousskov wrote: >> On 11/13/2016 05:11 PM, Kinkie wrote: >> >>> the attached patch moves away from hand-rolling a c-string onto >>> joining a SBufList for optimizing regexes in

Re: [squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

On 28/10/2016 9:39 p.m., Christos Tsantilas wrote: > Patch applied to trunk as r14898. > > I am attaching the squid-3.5 version of the patch. > Applied to 3.5 as r14110. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

On Mon, Nov 14, 2016 at 5:36 AM, Alex Rousskov wrote: > On 11/13/2016 10:15 PM, Amos Jeffries wrote: > >> I think we should accumulate into two SBufList instead, one for -i and >> one for +i instead of switching back and forth with potentially lots of >> little

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

On Mon, Nov 14, 2016 at 5:30 AM, Alex Rousskov wrote: > On 11/13/2016 05:11 PM, Kinkie wrote: > >> the attached patch moves away from hand-rolling a c-string onto >> joining a SBufList for optimizing regexes in RegexData.cc. > >> You can find attached as a test