Re: [squid-dev] [PATCH] Fix broken build for ufsdump

2017-03-16 Thread Alex Rousskov
On 03/16/2017 01:43 AM, Amos Jeffries wrote: > On 6/03/2017 3:54 p.m., Alex Rousskov wrote: >> On 03/05/2017 12:28 PM, Eduard Bagdasaryan wrote: >>> ufsdump build is broken now [...] >>> This patch fixes this, however I am not sure that >>> does it in a best possible way. For example, someone may

Re: [squid-dev] [PATCH] Fix broken build for ufsdump

2017-03-16 Thread Amos Jeffries
On 6/03/2017 3:54 p.m., Alex Rousskov wrote: > On 03/05/2017 12:28 PM, Eduard Bagdasaryan wrote: > >> ufsdump build is broken now [...] >> This patch fixes this, however I am not sure that >> does it in a best possible way. For example, someone may argue that >> inlining storeKeyText() is wrong.

Re: [squid-dev] [PATCH] Fix broken build for ufsdump

2017-03-05 Thread Alex Rousskov
On 03/05/2017 12:28 PM, Eduard Bagdasaryan wrote: > ufsdump build is broken now [...] > This patch fixes this, however I am not sure that > does it in a best possible way. For example, someone may argue that > inlining storeKeyText() is wrong. Yeah, I would argue that such inlining is "wrong".

[squid-dev] [PATCH] Fix broken build for ufsdump

2017-03-05 Thread Eduard Bagdasaryan
Hello, ufsdump build is broken now and seems that it became broken quite a long time ago (though I have not tested when exactly), probably because is not built by default. This patch fixes this, however I am not sure that does it in a best possible way. For example, someone may argue that