Re: [squid-dev] [PATCH] Older response must not update

2016-10-05 20:17 GMT+03:00 Amos Jeffries : > Well, Alex and I are really disagreeeing on long-term things. As patch > author on the spot for this that final choice is yours in regards to > what goes in right now. > > If you could pick something and submit a final patch in

Re: [squid-dev] [PATCH] Older response must not update

On 16/09/2016 2:13 a.m., Eduard Bagdasaryan wrote: > 2016-09-10 17:20 GMT+03:00 Amos Jeffries: > >> Well, I'm still in slight disagreement with Alex on how to group things >> -though that is mostly because we have not discussed it properly. >> >> If a sub-struct name cannot be agreed then bool

Re: [squid-dev] [PATCH] Older response must not update

2016-09-10 17:20 GMT+03:00 Amos Jeffries : > Well, I'm still in slight disagreement with Alex on how to group things > -though that is mostly because we have not discussed it properly. > > If a sub-struct name cannot be agreed then bool members in the LogTags > object is

Re: [squid-dev] [PATCH] Older response must not update

On 10/09/2016 2:24 a.m., Eduard Bagdasaryan wrote: > 2016-08-28 1:51 GMT+03:00 Alex Rousskov wrote: >> In summary, if you are going to commit the patch, it is your call >> whether to rename Flags. If you want me to commit, please let me know >> what name to use for that class. And the new TODO

Re: [squid-dev] [PATCH] Older response must not update

On 08/27/2016 08:23 AM, Amos Jeffries wrote: > On 26/08/2016 5:05 a.m., Alex Rousskov wrote: >> I recommend renaming and re-documenting that subclass: >> >> /// Things that may happen to a transaction while it is being >> /// processed according to its LOG_* category. Logged as _SUFFIX(es). >> ///

Re: [squid-dev] [PATCH] Older response must not update

On 26/08/2016 5:05 a.m., Alex Rousskov wrote: > On 08/25/2016 08:18 AM, Eduard Bagdasaryan wrote: >> 2016-08-24 18:20 GMT+03:00 Amos Jeffries : >> >>> in src/LogTags.cc: >>> * instead of adding new enum entry please extend LogTags with a new bool >>> flag and the c_str() to

Re: [squid-dev] [PATCH] Older response must not update

2016-08-25 20:05 GMT+03:00 Alex Rousskov : > The "_IGNORED" flag Amos is talking about should go into LogTags::Errors. > I recommend renaming and re-documenting that subclass Updated the patch with your suggestions. Eduard. Squid should ignore a

Re: [squid-dev] [PATCH] Older response must not update

On 08/25/2016 08:18 AM, Eduard Bagdasaryan wrote: > 2016-08-24 18:20 GMT+03:00 Amos Jeffries : > >> in src/LogTags.cc: >> * instead of adding new enum entry please extend LogTags with a new bool >> flag and the c_str() to append the "IGNORED" when that flag is true. > Added

Re: [squid-dev] [PATCH] Older response must not update

2016-08-24 18:20 GMT+03:00 Amos Jeffries : > in src/LogTags.cc: > * instead of adding new enum entry please extend LogTags with a new bool > flag and the c_str() to append the "IGNORED" when that flag is true. > - TCP_REFRESH should be set when refresh was started. > -

Re: [squid-dev] [PATCH] Older response must not update

On 08/24/2016 09:20 AM, Amos Jeffries wrote: > in src/HttpReply.h: > * please use doxygen syntax "\returns" instead of "returns" in the > comment text. No objection, but please note that the "returns..." phrase in isolation does not fully describe what the method returns in this case. Only the

Re: [squid-dev] [PATCH] Older response must not update

On 25/08/2016 12:46 a.m., Eduard Bagdasaryan wrote: > Hello, > > This patch teaches Squid to ignore a [revalidation] response with an older > Date header. > > Before this patch, Squid violated the RFC 7234 section 4 MUST > requirement: "When more than one suitable response is stored, a cache >