Re: cvs commit: squid3/src/ICAP ICAPConfig.cc ICAPConfig.h ....

2007-05-18 Thread Tsantilas Christos
Hi Amos Amos Jeffries wrote: Does ICAP really not build without a const version of the operator[]? Strangly it does for me. Oh well, adding anyway. May be because of different versions of g++. I am using g++ 4.1.2 here . This change is more of a problem. To me it looks like the latter

Re: cvs commit: squid3/src/ICAP ICAPConfig.cc ICAPConfig.h ....

2007-05-18 Thread Amos Jeffries
Alex Rousskov wrote: On Sat, 2007-05-19 at 02:38 +1200, Amos Jeffries wrote: Oh dear I was sure y test build had --enable-icap. Seems not though, very sorry. Blame evil #ifdefs! I was going to, then I looked at the code more. I can't see _any_ in that file file. I'm using the same g++

Re: cvs commit: squid3/src/ICAP ICAPConfig.cc ICAPConfig.h ....

2007-05-18 Thread Alex Rousskov
On Sat, 2007-05-19 at 02:38 +1200, Amos Jeffries wrote: Oh dear I was sure y test build had --enable-icap. Seems not though, very sorry. Blame evil #ifdefs! Index: ICAP/ICAPXaction.cc === RCS file:

Re: cvs commit: squid3/src/ICAP ICAPConfig.cc ICAPConfig.h ....

2007-05-18 Thread Alex Rousskov
On Sat, 2007-05-19 at 03:33 +1200, Amos Jeffries wrote: Alex Rousskov wrote: On Sat, 2007-05-19 at 02:38 +1200, Amos Jeffries wrote: Oh dear I was sure y test build had --enable-icap. Seems not though, very sorry. Blame evil #ifdefs! I was going to, then I looked at the code

Re: squid3_logdaemon work (round 1) complete, again!

2007-05-18 Thread Adrian Chadd
On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the current codebase

Re: squid3_logdaemon work (round 1) complete, again!

2007-05-18 Thread Amos Jeffries
Adrian Chadd wrote: On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the