Re: Regression introduced in trunk r13201 (large rock merge)

2014-02-06 Thread Nikolai Gorchilov
I did bzr pool before diff. No changed files were found. Web interface also shows no modified files - http://bazaar.launchpad.net/~squid/squid/trunk/revision/13257 On Thu, Feb 6, 2014 at 8:24 AM, Kinkie gkin...@gmail.com wrote: It' the tip, a bzr pull should get it for you On Feb 6, 2014 2:45

Re: Regression introduced in trunk r13201 (large rock merge)

2014-02-06 Thread Kinkie
Hi, Maybe there's some issue with launchpad mirroring? Can you try the branch at http://bzr.squid-cache.org/bzr/squid3/trunk ? On Thu, Feb 6, 2014 at 9:23 AM, Nikolai Gorchilov n...@x3me.net wrote: I did bzr pool before diff. No changed files were found. Web interface also shows no

Re: Regression introduced in trunk r13201 (large rock merge)

2014-02-06 Thread Nikolai Gorchilov
On Thu, Feb 6, 2014 at 10:54 AM, Kinkie gkin...@gmail.com wrote: Hi, Maybe there's some issue with launchpad mirroring? Can you try the branch at http://bzr.squid-cache.org/bzr/squid3/trunk ? Just tried with http://bzr.squid-cache.org/bzr/squid3/trunk - same empty diff as with launchpad

Re: Regression introduced in trunk r13201 (large rock merge)

2014-02-06 Thread Kinkie
Doh! you are right. For some reason I botched the commit in r13257. I've now committed the change as r13258. Please try it. On Thu, Feb 6, 2014 at 10:25 AM, Nikolai Gorchilov n...@x3me.net wrote: On Thu, Feb 6, 2014 at 10:54 AM, Kinkie gkin...@gmail.com wrote: Hi, Maybe there's some issue

Re: Regression introduced in trunk r13201 (large rock merge)

2014-02-06 Thread Amos Jeffries
On 6/02/2014 9:54 p.m., Kinkie wrote: Hi, Maybe there's some issue with launchpad mirroring? Can you try the branch at http://bzr.squid-cache.org/bzr/squid3/trunk ? I dont think so. The master server shows the same things on the checkout used to generate changesets and do maintenance.

Re: Regression introduced in trunk r13201 (large rock merge)

2014-02-06 Thread Kinkie
Hi, Apparently my checked-out tree had some problems. I've performed a follow-up commit with the actual changes. On Thu, Feb 6, 2014 at 11:53 AM, Amos Jeffries squ...@treenet.co.nz wrote: On 6/02/2014 9:54 p.m., Kinkie wrote: Hi, Maybe there's some issue with launchpad mirroring? Can you

Re: [PATCH] refactor Vector

2014-02-06 Thread Amos Jeffries
On 5/02/2014 8:57 a.m., Kinkie wrote: On Sun, Feb 2, 2014 at 10:42 PM, Amos Jeffries squ...@treenet.co.nz wrote: On 2014-02-03 08:06, Kinkie wrote: Hi, the attached patch (merge from lp:~squid/squid/vector-refactor) is an attempt to refactor Vector and its clients so that: - clients of

Re: Vector vs std::vector

2014-02-06 Thread Alex Rousskov
On 01/30/2014 01:37 PM, Alex Rousskov wrote: On 01/30/2014 12:14 PM, Kinkie wrote: Ok, here's some numbers (same testing methodology as before) Trunk: mean RPS (CPU time) 10029.11 (996.661872) 9786.60 (1021.695007) 10116.93 (988.395665) 9958.71 (1004.039956) stdvector: mean RPS (CPUtime)

Re: [PATCH] refactor Vector

2014-02-06 Thread Alex Rousskov
On 02/04/2014 12:57 PM, Kinkie wrote: On Sun, Feb 2, 2014 at 10:42 PM, Amos Jeffries squ...@treenet.co.nz wrote: On 2014-02-03 08:06, Kinkie wrote: Hi, the attached patch (merge from lp:~squid/squid/vector-refactor) is an attempt to refactor Vector and its clients so that: - clients of

Re: Vector vs std::vector

2014-02-06 Thread Kinkie
Thank you for running this test. I guess that with these results, it can make sense to go forward with the project of replacing Vector with std::vector, does everyone agree? Thanks! On Fri, Feb 7, 2014 at 6:18 AM, Alex Rousskov rouss...@measurement-factory.com wrote: On 01/30/2014 01:37 PM,