[Success!] [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Bundle Buggy
This change has been merged. Previous status: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809030444.m834iIKI048580%40harfy.jeamland.net%3E Project: Squid

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Adrian Chadd
bb:approve *sigh!* 2008/9/3 Bundle Buggy <[EMAIL PROTECTED]>: > Bundle Buggy has detected this merge request. > > For details, see: > http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809030444.m834iIKI048580%40harfy.jeamland.net%3E > Project: Squid > >

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Amos Jeffries
> bb:approve > > (third time lucky?) > nope. votes need to be in direct reply to the initial [MERGE] request message. BB does not follow threads. Amos > 2008/9/4 Adrian Chadd <[EMAIL PROTECTED]>: >> bb:approve >> >> (Sorry, I wasn't setup to vote until now!) >> >> 2008/9/4 Adrian Chadd <[EMAIL

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Adrian Chadd
bb:approve 2008/9/3 Bundle Buggy <[EMAIL PROTECTED]>: > Bundle Buggy has detected this merge request. > > For details, see: > http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809030444.m834iIKI048580%40harfy.jeamland.net%3E > Project: Squid > >

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Adrian Chadd
bb:approve (third time lucky?) 2008/9/4 Adrian Chadd <[EMAIL PROTECTED]>: > bb:approve > > (Sorry, I wasn't setup to vote until now!) > > 2008/9/4 Adrian Chadd <[EMAIL PROTECTED]>: >> I still need to eyeball the relative URL stuff, but.. >> >> >> bb:approve >> >> 2008/9/3 Bundle Buggy <[EMAIL PRO

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Adrian Chadd
bb:approve (Sorry, I wasn't setup to vote until now!) 2008/9/4 Adrian Chadd <[EMAIL PROTECTED]>: > I still need to eyeball the relative URL stuff, but.. > > > bb:approve > > 2008/9/3 Bundle Buggy <[EMAIL PROTECTED]>: >> Bundle Buggy has detected this merge request. >> >> For details, see: >> http

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Adrian Chadd
I still need to eyeball the relative URL stuff, but.. bb:approve 2008/9/3 Bundle Buggy <[EMAIL PROTECTED]>: > Bundle Buggy has detected this merge request. > > For details, see: > http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809030444.m834iIKI048580%40harfy.jeamland.net%3E > P

Re: [MERGE] Address Alex and Amos' comments.

2008-09-03 Thread Amos Jeffries
Benno Rice wrote: Address Alex and Amos' comments. /* + * Test if a URL is relative. + * + * RFC 2396, Section 5 (Page 17) implies that in a relative URL, a '/' will + * appear before a ':'. + */ +bool +urlIsRelative(const char *url) +{ +const char *p; + +if (url == NULL) { +

Re: [MERGE] Address Alex and Amos' comments.

2008-09-02 Thread Alex Rousskov
On Wed, 2008-09-03 at 14:44 +1000, Benno Rice wrote: > Address Alex and Amos' comments. > > - Use bool instead of int for urlIsRelative. > - Document what leads to a NULL return in urlMakeAbsolute and mention the > responsibility of the caller to free the result in the non-NULL case. > - Declare

Re: [MERGE] Address Alex and Amos' comments.

2008-09-02 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809030444.m834iIKI048580%40harfy.jeamland.net%3E Project: Squid

[MERGE] Address Alex and Amos' comments.

2008-09-02 Thread Benno Rice
Address Alex and Amos' comments. - Use bool instead of int for urlIsRelative. - Document what leads to a NULL return in urlMakeAbsolute and mention the responsibility of the caller to free the result in the non-NULL case. - Declare variables closer to where they're used. - Fix indentation. # Baz