Re: ayjwork squid3/src HttpRequestMethod...

2008-02-08 Thread Amos Jeffries
Henrik Nordström wrote: sön 2008-02-03 klockan 19:37 +1300 skrev Amos Jeffries: Changing the MD5 affects both private and public (GET, HEAD, etc I assume?) store MD5 functions. You don't need to worry about the private keys. The primary input to private keys is the runtime unique object id (m

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-08 Thread Henrik Nordström
sön 2008-02-03 klockan 19:37 +1300 skrev Amos Jeffries: > Changing the MD5 affects both private and public (GET, HEAD, etc I > assume?) store MD5 functions. You don't need to worry about the private keys. The primary input to private keys is the runtime unique object id (mem_obj->id). Having the

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-08 Thread Henrik Nordström
sön 2008-02-03 klockan 19:05 +1300 skrev Amos Jeffries: > The problem with MD5 is what the side-effect of altering the MD5 in > store will do. Would it make older caches after upgrade 'loose' all > their content as never-matching-again objects? > I don't know enough at this point to answer that

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-03 Thread Amos Jeffries
> On Sun, 2008-02-03 at 19:37 +1300, Amos Jeffries wrote: >> >> The biggest possible hit I've seen so far with the enum change is the >> >> store MD5's, they currently use the int value of the enum. I'm not >> sure >> >> if it would matter making them always use the image() string instead. >> >> Th

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-03 Thread Alex Rousskov
On Sun, 2008-02-03 at 19:37 +1300, Amos Jeffries wrote: > >> The biggest possible hit I've seen so far with the enum change is the > >> store MD5's, they currently use the int value of the enum. I'm not sure > >> if it would matter making them always use the image() string instead. > >> They are

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-02-03 at 16:41 +1300, Amos Jeffries wrote: Alex Rousskov wrote: Please give an example or two, where the performance would noticeably suffer for standard methods. There were several switch(e->method) in what I think is the request processing pathways. I was t

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Adrian Chadd wrote: On Sun, Feb 03, 2008, Amos Jeffries wrote: Please give an example or two, where the performance would noticeably suffer for standard methods. There were several switch(e->method) in what I think is the request processing pathways. I was thinking making that switch into a se

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Alex Rousskov
On Sun, 2008-02-03 at 16:41 +1300, Amos Jeffries wrote: > Alex Rousskov wrote: > > > > Please give an example or two, where the performance would noticeably > > suffer for standard methods. > > There were several switch(e->method) in what I think is the request > processing pathways. I was thin

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Adrian Chadd
On Sun, Feb 03, 2008, Amos Jeffries wrote: > > > >Please give an example or two, where the performance would noticeably > >suffer for standard methods. > > There were several switch(e->method) in what I think is the request > processing pathways. I was thinking making that switch into a series o

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-02-03 at 12:11 +1300, Amos Jeffries wrote: Alex, I'm droppign the conversion and not seeing many uses of METHOD_* as an int. the ones present however look to be important a keepers. You mentioned earlier when this class went it it might be an idea to look at r

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-02-03 at 11:31 +1300, Amos Jeffries wrote: ... making access to the int value an explicit call to value() instead of silent conversion. How about id() instead of value()? Much the sameness. But yes thats more logical. My head isn't working too well this mo

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Alex Rousskov
On Sun, 2008-02-03 at 13:09 +1300, Amos Jeffries wrote: > The exact errors is when compiling testHeaders_HttpRequestMethod.cc. > The test where there is no code run, just the dependency and inline build. > > ./HttpRequestMethod.h: In function ‘std::ostream& > operator<<(std::ostream&, const Htt

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Alex Rousskov
On Sun, 2008-02-03 at 11:31 +1300, Amos Jeffries wrote: > ... making access to the int value an explicit call to value() instead > of silent conversion. How about id() instead of value()? > But as usual I'm not expecting anyone but me will go near the code > until its already in HEAD. :-( Hey,

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Alex Rousskov
On Sun, 2008-02-03 at 12:11 +1300, Amos Jeffries wrote: > Alex, I'm droppign the conversion and not seeing many uses of METHOD_* > as an int. the ones present however look to be important a keepers. > You mentioned earlier when this class went it it might be an idea to > look at removing the _me

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Amos Jeffries wrote: Alex Rousskov wrote: On Sat, 2008-02-02 at 13:12 +, Amos Jeffries wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src Modified Files: Tag: ayjwork HttpRequestMethod.cc HttpRequestMethod.h SquidString.h String.cci Log Message: Compile er

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Alex Rousskov wrote: I do not know what error you are getting, but it is possible that auto-conversion from HttpRequestMethod to method_t is at fault. If so, we should probably try to remove that conversion. Again, let me know if you need a hand. Thank you, Alex, I'm droppign the conversion

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Amos Jeffries
Alex Rousskov wrote: On Sat, 2008-02-02 at 13:12 +, Amos Jeffries wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src Modified Files: Tag: ayjwork HttpRequestMethod.cc HttpRequestMethod.h SquidString.h String.cci Log Message: Compile errors. From HttpRequestMetho

Re: ayjwork squid3/src HttpRequestMethod...

2008-02-02 Thread Alex Rousskov
On Sat, 2008-02-02 at 13:12 +, Amos Jeffries wrote: > Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src > > Modified Files: > Tag: ayjwork > HttpRequestMethod.cc HttpRequestMethod.h SquidString.h > String.cci > Log Message: > Compile errors. From HttpRequestMeth