Re: compat/unsafe.h

2010-08-21 Thread Amos Jeffries
Henrik Nordström wrote: lör 2010-08-21 klockan 20:07 +1200 skrev Amos Jeffries: IMO some of them such as the malloc/calloc/free which only force a xfoo() version internal to Squid to be hard-coded should be done with a real symbol swap-in in the relevant header files. That way the code can go

Re: compat/unsafe.h

2010-08-21 Thread Henrik Nordström
lör 2010-08-21 klockan 20:07 +1200 skrev Amos Jeffries: > IMO some of them such as the malloc/calloc/free which only force a > xfoo() version internal to Squid to be hard-coded should be done with a > real symbol swap-in in the relevant header files. That way the code can > go to using malloc/c

Re: compat/unsafe.h

2010-08-21 Thread Amos Jeffries
Henrik Nordström wrote: Stumbled over compat/unsafe.h again when trying to compile trunk after the purge merge. Imho these rules in compat/unsafe.h should be dropped, replaced by coding standards for the different sections and auditing. - The rules originally come from lazyness in Squid-2

Re: [MERGE] Kill compat/unsafe.h, not really needed and causes more grief than gain

2010-08-19 Thread Kinkie
+1 --     /kinkie

[MERGE] Kill compat/unsafe.h, not really needed and causes more grief than gain

2010-08-19 Thread Henrik Nordström
Exclude CPPUnit tests from the allocator restrictions. */ -/* BSD implementation uses these still */ -#if defined(SQUID_UNIT_TEST) -#define SQUID_NO_STRING_BUFFER_PROTECT 1 -#endif - /* Bug 2500: Solaris 10/11 require s6_addr* defines. */ //#define s6_addr8 _S6_un._S6_u8 //#define s6_addr

compat/unsafe.h

2010-08-19 Thread Henrik Nordström
Stumbled over compat/unsafe.h again when trying to compile trunk after the purge merge. Imho these rules in compat/unsafe.h should be dropped, replaced by coding standards for the different sections and auditing. - The rules originally come from lazyness in Squid-2 where we did not want to check