Re: Revised approach to fixing configuration syntax

2013-09-27 Thread Amos Jeffries
On 27/09/2013 6:14 a.m., Alex Rousskov wrote: On 08/30/2013 11:39 AM, Alex Rousskov wrote: One of the key ideas behind strict syntax is that the token type can be and is determined by the parser (simple token, quoted string, regular expression, number, etc.) and not the caller. This is not the

Re: Squid 3.4.0.1 configurator problems

2013-09-27 Thread Amos Jeffries
On 27/09/2013 5:23 p.m., Alex Rousskov wrote: On 09/26/2013 12:13 PM, Amos Jeffries wrote: On 09/26/2013, Alex Rousskov wrote: The only real problem with /re/ syntax as the default is that it does not work well with URLs, which are very common in Squid patterns. That is why I think a

Re: stringng-cherrypick r12764

2013-09-27 Thread Kinkie
On Fri, Sep 27, 2013 at 12:11 AM, Alex Rousskov rouss...@measurement-factory.com wrote: On 09/26/2013 01:43 PM, Kinkie wrote: On Mon, Aug 26, 2013 at 4:22 AM, Alex Rousskov wrote: + * SBuf.cc (C) 2008 Francesco Chemolli kin...@squid-cache.org If you do not mind, please drop the copyright

Re: stringng-cherrypick r12764

2013-09-27 Thread Kinkie
It can probably be avoided by using those extra warning arguments I mentioned above. I'm running a test now to see how it fares. Short summary: there's plenty of implicit type and sign conversions around. -- /kinkie

Re: stringng-cherrypick r12764

2013-09-27 Thread Amos Jeffries
On 27/09/2013 8:18 p.m., Kinkie wrote: It can probably be avoided by using those extra warning arguments I mentioned above. I'm running a test now to see how it fares. Short summary: there's plenty of implicit type and sign conversions around. If you recall that side project I was doing ever

Re: stringng-cherrypick r12764

2013-09-27 Thread Kinkie
If you recall that side project I was doing ever now and again to improve the compiler warnings situation. -Wshadow got done but -Wcasting and -Wconversion and a few others are still very much TODO. The situation as it stands for conversion is that *certain* very specific dangerous

Re: stringng-cherrypick r12764

2013-09-27 Thread Amos Jeffries
On 27/09/2013 9:47 p.m., Kinkie wrote: If you recall that side project I was doing ever now and again to improve the compiler warnings situation. -Wshadow got done but -Wcasting and -Wconversion and a few others are still very much TODO. The situation as it stands for conversion is that

Re: stringng-cherrypick r12764

2013-09-27 Thread Kinkie
How about proceeding like this: merge as-is and trust the callers to know what they're doing, so that I can spend some time on implementing these flags? It'll be tedious work, but it shouldn't require too much brainpower. The alternative (blocking StringNG until the conversions work is done)

Re: stringng-cherrypick r12764

2013-09-27 Thread Amos Jeffries
On 27/09/2013 10:06 p.m., Kinkie wrote: How about proceeding like this: merge as-is and trust the callers to know what they're doing, so that I can spend some time on implementing these flags? It'll be tedious work, but it shouldn't require too much brainpower. The alternative (blocking StringNG

Re: Revised approach to fixing configuration syntax

2013-09-27 Thread Tsantilas Christos
On 09/26/2013 09:14 PM, Alex Rousskov wrote: On 08/30/2013 11:39 AM, Alex Rousskov wrote: One of the key ideas behind strict syntax is that the token type can be and is determined by the parser (simple token, quoted string, regular expression, number, etc.) and not the caller. This is not

Re: Squid 3.4.0.1 configurator problems

2013-09-27 Thread Tsantilas Christos
On 09/27/2013 08:23 AM, Alex Rousskov wrote: Using approach (2) with flexible RE delimiter, we could write acl foo url_regex /ends[) (]/ or acl foo url_regex {ends[) (]} or acl foo url_regex @ends[) (]@ and it will all work without double escaping. Alex, in the Revised

Re: [PATCH] Fix leaks and check for newer libraries in Kerberos related helpers

2013-09-27 Thread Amos Jeffries
This has now been applied to trunk. I just noticed that the helper versions have not been bumped. Shall we update these to 1.3.1sq and 3.0.5sq ? Amos

Re: Squid 3.4.0.1 configurator problems

2013-09-27 Thread Amos Jeffries
On 28/09/2013 3:18 a.m., Tsantilas Christos wrote: On 09/27/2013 08:23 AM, Alex Rousskov wrote: Using approach (2) with flexible RE delimiter, we could write acl foo url_regex /ends[) (]/ or acl foo url_regex {ends[) (]} or acl foo url_regex @ends[) (]@ and it will all work

Build failed in Jenkins: 3.HEAD-amd64-CentOS-5.3 #2541

2013-09-27 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/2541/changes Changes: [Amos Jeffries] negotiate_kerberos_auth: upgrade to present group= keys Use the new kv-pair protocol extensions for emitting group details directly at the time of authentication. group=X key-value pair is used to

Re: Revised approach to fixing configuration syntax

2013-09-27 Thread Alex Rousskov
On 09/27/2013 12:20 AM, Amos Jeffries wrote: On 27/09/2013 6:14 a.m., Alex Rousskov wrote: NextChars(const char *); // the exact sequence of characters given NextToken(String t); // next name or token as defined in the grammar NextValue(String v, kind); // next value as defined in

Re: Squid 3.4.0.1 configurator problems

2013-09-27 Thread Alex Rousskov
On 09/27/2013 01:05 AM, Amos Jeffries wrote: :-) if I understand it correctly is precisely my point. Even you with your skills reading syntax have to go slowly and you still fell for the trap. Sorry I misunderstood you. I had no idea what you are getting at with that example, so I had to take

Re: stringng-cherrypick r12764

2013-09-27 Thread Alex Rousskov
On 09/27/2013 03:52 AM, Amos Jeffries wrote: As for this code specifically I see the unit tests in StringNG as having three authors with various parts by each of us three. Please keep in mind that a code author is not always a code copyright holder. If you decide to go down this path, please

Build failed in Jenkins: 3.HEAD-amd64-CentOS-5.3 #2543

2013-09-27 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-CentOS-5.3/2543/ -- [...truncated 3997 lines...] libtool: link: g++

Re: Squid 3.4.0.1 configurator problems

2013-09-27 Thread Alex Rousskov
On 09/27/2013 09:39 AM, Amos Jeffries wrote: On 28/09/2013 3:18 a.m., Tsantilas Christos wrote: On 09/27/2013 08:23 AM, Alex Rousskov wrote: Using approach (2) with flexible RE delimiter, we could write acl foo url_regex /ends[) (]/ or acl foo url_regex {ends[) (]} or acl

Re: [PATCH] Fix leaks and check for newer libraries in Kerberos related helpers

2013-09-27 Thread Markus Moeller
Sounds like a good idea. Thanks for spotting it Markus Amos Jeffries wrote in message news:5245a336.1070...@treenet.co.nz... This has now been applied to trunk. I just noticed that the helper versions have not been bumped. Shall we update these to 1.3.1sq and 3.0.5sq ? Amos

Re: Revised approach to fixing configuration syntax

2013-09-27 Thread Alex Rousskov
On 09/27/2013 08:13 AM, Tsantilas Christos wrote: My sense is that it is not possible to have backward compatibility. We had discuss in [PATCH] Unknown cfg function mail thread many cases where the quoted tokens can not be backward compatible. Yes, we cannot have 100% backward compatibility,

Re: Revised approach to fixing configuration syntax

2013-09-27 Thread Alex Rousskov
On 09/27/2013 10:20 AM, Alex Rousskov wrote: Your call regarding v3.4, but I suggest the following for that branch: - Undo recent parsing changes. - Add simple, disabled-by-default support for whitespaces in ACLs: https://code.launchpad.net/~measurement-factory/squid/conf-quoted-str

Looking for more eyes on external_acl helper sketch.

2013-09-27 Thread Eliezer Croitoru
I have written in the past couple very tiny helpers and now I added a new one for external_acl as a base to a specific ip_DB helper. The code is at: http://www1.ngtech.co.il/paste/1033/ or http://pastebin.centos.org/4631/ I have mentioned a nice unified DB API called moneta for ruby. The moneta