Re: IPv6 developments for HEAD

2007-04-07 Thread Guido Serassio
Hi Amos, At 07.24 07/04/2007, Amos Jeffries wrote: Attached are two patches which constitute part of the core developments for protocol-independent handling of IP addresses in squid3. There is a problem in your patch. You are including many include files without checking for the existence

Re: IPv6 developments for HEAD

2007-04-07 Thread Amos Jeffries
Guido Serassio wrote: Hi Amos, At 07.24 07/04/2007, Amos Jeffries wrote: Attached are two patches which constitute part of the core developments for protocol-independent handling of IP addresses in squid3. There is a problem in your patch. You are including many include files without

Re: IPv6 developments for HEAD

2007-04-07 Thread Guido Serassio
Hi Amos, At 13.21 07/04/2007, Amos Jeffries wrote: Thank Guido. I wondered what the reason was behind those. Fixed. New patches attached. Still some details on the include side: In IPAddress.cc you should first include squid.h like other sources, in this way you should no more need the

Re: IPv6 developments for HEAD

2007-04-07 Thread Amos Jeffries
Guido Serassio wrote: Hi Amos, At 13.21 07/04/2007, Amos Jeffries wrote: Thank Guido. I wondered what the reason was behind those. Fixed. New patches attached. Still some details on the include side: In IPAddress.cc you should first include squid.h like other sources, in this way you

Re: IPv6 developments for HEAD

2007-04-07 Thread Guido Serassio
Hi Amos, At 13.52 07/04/2007, Amos Jeffries wrote: Guido Serassio wrote: Hi Amos, At 13.21 07/04/2007, Amos Jeffries wrote: Thank Guido. I wondered what the reason was behind those. Fixed. New patches attached. Still some details on the include side: In IPAddress.cc you should first include

Re: IPv6 developments for HEAD

2007-04-07 Thread Amos Jeffries
Guido Serassio wrote: Hi Amos, At 13.52 07/04/2007, Amos Jeffries wrote: Guido Serassio wrote: Hi Amos, At 13.21 07/04/2007, Amos Jeffries wrote: Thank Guido. I wondered what the reason was behind those. Fixed. New patches attached. Still some details on the include side: In IPAddress.cc

Re: IPv6 developments for HEAD

2007-04-07 Thread Guido Serassio
Hi Amos, At 14.22 07/04/2007, Amos Jeffries wrote: Okay. While I'm re-arranging I suppose I should also include the GNU disclaimers license stuff too. Sure :-) Anything else before I make new patches? You can try to run astyle on your sources,

Re: IPv6 developments for HEAD

2007-04-07 Thread Amos Jeffries
Sigh. For some weird reason my test machine built squid with the previous patches despite a missing #include. Here is an updated patch set, tested on two machines. Patch file generated Sun Apr 8 01:12:39 NZST 2007 from CVS branch squid3-ipv6 CVS base branch HEAD CVS repository: [EMAIL

Re: squid3.0.PRE6 and bugzilla

2007-04-07 Thread Guido Serassio
Hi Alex, At 20.54 03/04/2007, Alex Rousskov wrote: On Tue, 2007-04-03 at 21:32 +0300, Tsantilas Christos wrote: Which is the goal for squid3.0.PRE6? Which bugs waiting a fix before released? Release recent improvements in a form convenient for testing and experimental deployment. I hate

Re: squid3.0.PRE6 and bugzilla

2007-04-07 Thread Tsantilas Christos
Guido Serassio wrote: There are some bugs probably ready to be commited/closed: Excellent! #1889: If the latest Henrik's comment is true... He does not look like a person who says lies, I am sure that he has correct it ;-) Regards, Christos

Re: squid3.0.PRE6 and bugzilla

2007-04-07 Thread Guido Serassio
Hi, At 20.49 07/04/2007, Tsantilas Christos wrote: #1889: If the latest Henrik's comment is true... He does not look like a person who says lies, I am sure that he has correct it ;-) I know personally Henrik :-) The question is if the patch really fixes the problem. Probably,