Re: Generic helper I/O format

2012-07-06 Thread Henrik Nordström
tor 2012-07-05 klockan 16:00 +1200 skrev Amos Jeffries: The blob only exists in this discussion for two reasons; the old helpers backward compatibility requires it, and you wanted to discuss a body field for the responses. Even not understanding properly the specifics of why you wanted to

Re: Generic helper I/O format

2012-07-06 Thread Amos Jeffries
On 5/07/2012 4:16 p.m., Robert Collins wrote: On Thu, Jul 5, 2012 at 4:00 PM, Amos Jeffries wrote: Why do we need backwards compat in the new protocol? As an alternative, consider setting a protocol= option on the helpers, making the default our latest-and-greatest,a nd folk running

Re: Generic helper I/O format

2012-07-04 Thread Amos Jeffries
On 4/07/2012 4:54 p.m., Alex Rousskov wrote: On 07/03/2012 08:10 PM, Amos Jeffries wrote: [channel-ID] (OK/ERR/BH) [key-pairs] blob terminator How will the generic code be able to tell where key-pairs end and blob begins? The generic code will have a format for key-pair of ( 1#token =

Re: Generic helper I/O format

2012-07-04 Thread Alex Rousskov
On 07/04/2012 12:02 AM, Amos Jeffries wrote: On 4/07/2012 4:54 p.m., Alex Rousskov wrote: On 07/03/2012 08:10 PM, Amos Jeffries wrote: [channel-ID] (OK/ERR/BH) [key-pairs] blob terminator How will the generic code be able to tell where key-pairs end and blob begins? The generic code will

Re: Generic helper I/O format

2012-07-04 Thread Henrik Nordström
ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: No, it is not. BS is required if the body is present and BS is not a valid key name. Thus, BS cannot be confused with a start of a key-value pair _and_ if a body starts with BS as well, there is no problem because we already know to

Re: Generic helper I/O format

2012-07-04 Thread Alex Rousskov
On 07/04/2012 02:34 PM, Henrik Nordström wrote: ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: Why not simply use key=value pairs across the board? We need blobs because some values in use today are not expressed as tokens or quoted strings (the two value formats Amos is

Re: Generic helper I/O format

2012-07-04 Thread Amos Jeffries
On 05.07.2012 08:34, Henrik Nordström wrote: ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: No, it is not. BS is required if the body is present and BS is not a valid key name. Thus, BS cannot be confused with a start of a key-value pair _and_ if a body starts with BS as well, there

Re: Generic helper I/O format

2012-07-04 Thread Amos Jeffries
On 05.07.2012 10:15, Alex Rousskov wrote: On 07/04/2012 02:34 PM, Henrik Nordström wrote: ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: Why not simply use key=value pairs across the board? We need blobs because some values in use today are not expressed as tokens or quoted

Re: Generic helper I/O format

2012-07-04 Thread Alex Rousskov
On 07/04/2012 04:52 PM, Amos Jeffries wrote: On 05.07.2012 08:34, Henrik Nordström wrote: ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: Alex, before starting I went through each of the helper response styles we have and documented exactly what comes and goes

Re: Generic helper I/O format

2012-07-04 Thread Alex Rousskov
On 07/04/2012 05:07 PM, Amos Jeffries wrote: http://wiki.squid-cache.org/Features/AddonHelpers#Negotiate_and_NTLM_Scheme If you note, the reason field is usually something other than OK/ERR, so we can parse the old syntax differently to the new OK/ERR responses. Where there is an overlap

Re: Generic helper I/O format

2012-07-04 Thread Amos Jeffries
On 5/07/2012 11:10 a.m., Alex Rousskov wrote: On 07/04/2012 04:52 PM, Amos Jeffries wrote: On 05.07.2012 08:34, Henrik Nordström wrote: ons 2012-07-04 klockan 13:02 -0600 skrev Alex Rousskov: Alex, before starting I went through each of the helper response styles we have and documented

Re: Generic helper I/O format

2012-07-04 Thread Robert Collins
On Thu, Jul 5, 2012 at 4:00 PM, Amos Jeffries squ...@treenet.co.nz wrote: Why do we need backwards compat in the new protocol? As an alternative, consider setting a protocol= option on the helpers, making the default our latest-and-greatest,a nd folk running third-party helpers can set

Re: Generic helper I/O format

2012-07-04 Thread Alex Rousskov
On 07/04/2012 10:00 PM, Amos Jeffries wrote: The blob only exists in this discussion for two reasons; the old helpers backward compatibility requires it, and you wanted to discuss a body field for the responses. Even not understanding properly the specifics of why you wanted to discuss it I

Generic helper I/O format

2012-07-03 Thread Alex Rousskov
On 07/03/2012 08:10 PM, Amos Jeffries wrote: [channel-ID] (OK/ERR/BH) [key-pairs] blob terminator How will the generic code be able to tell where key-pairs end and blob begins? The generic code will have a format for key-pair of ( 1#token = 1#(token / quoted-string) ) [to be finalized