Re: Squid3 BodyReader changes

2007-02-28 Thread Tsantilas Christos
Hi Alex, Alex Rousskov wrote: I have committed your change, simplified virgin body buffer maintenance (in hope to minimize the number of similar bugs), and probably fixed a bug with handling of post-preview 204 replies. Yes I know. I am watching the branch for changes and additions... The

Re: Squid3 BodyReader changes

2007-02-27 Thread Alex Rousskov
On Tue, 2007-02-20 at 12:22 +0200, Tsantilas Christos wrote: > So yes I believe it is the same bug, but I thing the problem begins > because the state.writing is not updated correctly ... Right, but the state is not updated correctly because of the bug you have fixed. I have committed your chan

Re: Squid3 BodyReader changes

2007-02-20 Thread Tsantilas Christos
Alex Rousskov wrote: On Sat, 2007-02-17 at 19:00 +0200, Tsantilas Christos wrote: Still exist problems in preview transaction between icap server and squid. There are cases in which the squid-icap does not send the "0; ieof" sequence if all the http response body fits in the preview data bu

Re: Squid3 BodyReader changes

2007-02-19 Thread Alex Rousskov
On Sat, 2007-02-17 at 19:00 +0200, Tsantilas Christos wrote: > Still exist problems in preview transaction between icap server and > squid. There are cases in which the squid-icap does not send the "0; > ieof" sequence if all the http response body fits in the preview data > but sends the 0\r\n\r

Re: Squid3 BodyReader changes

2007-02-17 Thread Tsantilas Christos
Hi Alex, Still exist problems in preview transaction between icap server and squid. There are cases in which the squid-icap does not send the "0; ieof" sequence if all the http response body fits in the preview data but sends the 0\r\n\r\n. After that gets the "100 continue" icap response but i

Re: Squid3 BodyReader changes

2007-02-14 Thread Tsantilas Christos
Hi Alex, I try some test's. It is not so bad, but I saw that there are problems. After surfing the web for a while the icap-client of squid failed and the squid returned an error page to the web browser (ICAP protocoll error ICAP server is not reachable ..) The icap client sends an res

Re: Squid3 BodyReader changes

2007-02-14 Thread Alex Rousskov
On Wed, 2007-02-14 at 13:19 -0700, Alex Rousskov wrote: > On Wed, 2007-02-14 at 21:17 +0200, Tsantilas Christos wrote: > > Hi Alex, > > I try some test's. It is not so bad, but I saw that there are problems. > > After surfing the web for a while the icap-client of squid failed and > > the squid

Re: Squid3 BodyReader changes

2007-02-14 Thread Alex Rousskov
On Wed, 2007-02-14 at 21:17 +0200, Tsantilas Christos wrote: > Hi Alex, > I try some test's. It is not so bad, but I saw that there are problems. > After surfing the web for a while the icap-client of squid failed and > the squid returned an error page to the web browser (ICAP protocoll > error

Re: Squid3 BodyReader changes

2007-02-14 Thread Adrian Chadd
On Wed, Feb 14, 2007, Alex Rousskov wrote: > Hi there, > > I have committed the BodyPipe changes described below (with a few > modifications) to the squid3-icap branch. Using the new BodyPipe class, > I was able to eliminate many ICAP-related classes and code complexities, > not to mention

Re: Squid3 BodyReader changes

2007-02-13 Thread Alex Rousskov
Hi there, I have committed the BodyPipe changes described below (with a few modifications) to the squid3-icap branch. Using the new BodyPipe class, I was able to eliminate many ICAP-related classes and code complexities, not to mention a few memory leaks and bugs. I will be working on a

Re: Squid3 BodyReader changes

2007-01-31 Thread Adrian Chadd
On Tue, Jan 30, 2007, Alex Rousskov wrote: > Folks, > > Executive summary: I am trying to fix several bugs and complaints > related to your favorite class, the BodyReader. The changes I would like > to make are significant, so I decided to post them here first. Please > see the attached Body

Squid3 BodyReader changes

2007-01-30 Thread Alex Rousskov
Folks, Executive summary: I am trying to fix several bugs and complaints related to your favorite class, the BodyReader. The changes I would like to make are significant, so I decided to post them here first. Please see the attached BodyPipe.h sketch. I will proceed with these changes unle