Re: r13497: Converts the PortCfgPointer to reference counted

2014-07-16 Thread Amos Jeffries
On 16/07/2014 9:31 a.m., Alex Rousskov wrote: On 07/14/2014 11:59 PM, Amos Jeffries wrote: On 15/07/2014 5:02 a.m., Alex Rousskov wrote: On 07/14/2014 03:48 AM, Amos Jeffries wrote: -if (!s.valid()) { +if (!s) { // it is possible the call or accept() was still queued when

Build failed in Jenkins: 3.HEAD-amd64-centos-6 #400

2014-07-16 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-6/400/changes Changes: [Amos Jeffries] Fix http_port after rev.13497 Also, remove dead code if-statement in httpAccept(). Replace with a note that the call may have been queued when a reconfgure happened to the port

Comm::TcpAcceptor::doAccept fd limit handling is broken

2014-07-16 Thread Rainer Weikusat
NB: This occurred in the real world on some 'customer machine' using 3.3.12. Since the code is unchanged in 3.HEAD, I assume it is affected, too. The method mentioned in the subject is void Comm::TcpAcceptor::doAccept(int fd, void *data) { try { debugs(5, 2, HERE New connection on

TOS values

2014-07-16 Thread Tsantilas Christos
Hi all, Squid currently does not make a check for the TOS values used in squid configuration file. Squid will accept 8bit numbers as TOS values, however: 1) TOS values with 1st ad 2nd bit set can not be used. These bits used by the ECN. For Linux if someone try to set the 0x23 value as TOS

Re: Comm::TcpAcceptor::doAccept fd limit handling is broken

2014-07-16 Thread Alex Rousskov
On 07/16/2014 11:11 AM, Rainer Weikusat wrote: void Comm::TcpAcceptor::doAccept(int fd, void *data) { try { debugs(5, 2, HERE New connection on FD fd); Must(isOpen(fd)); TcpAcceptor *afd = static_castTcpAcceptor*(data); if (!okToAccept()) {

Re: TOS values

2014-07-16 Thread Alex Rousskov
On 07/16/2014 11:39 AM, Tsantilas Christos wrote: Hi all, Squid currently does not make a check for the TOS values used in squid configuration file. Squid will accept 8bit numbers as TOS values, however: 1) TOS values with 1st ad 2nd bit set can not be used. These bits used by the ECN. For

Re: Comm::TcpAcceptor::doAccept fd limit handling is broken

2014-07-16 Thread Rainer Weikusat
Alex Rousskov rouss...@measurement-factory.com writes: On 07/16/2014 11:11 AM, Rainer Weikusat wrote: void Comm::TcpAcceptor::doAccept(int fd, void *data) { try { debugs(5, 2, HERE New connection on FD fd); Must(isOpen(fd)); TcpAcceptor *afd =

Re: [PATCH] Comm::TcpAcceptor::doAccept fd limit handling is broken

2014-07-16 Thread Alex Rousskov
On 07/16/2014 02:38 PM, Rainer Weikusat wrote: Alex Rousskov rouss...@measurement-factory.com writes: On 07/16/2014 11:11 AM, Rainer Weikusat wrote: This is broken because it re-enables readable notifications even if no connection was accepted. In other words, it re-enables a check for new

Re: TOS values

2014-07-16 Thread Amos Jeffries
On 17/07/2014 8:01 a.m., Alex Rousskov wrote: On 07/16/2014 11:39 AM, Tsantilas Christos wrote: Hi all, Squid currently does not make a check for the TOS values used in squid configuration file. Squid will accept 8bit numbers as TOS values, however: 1) TOS values with 1st ad 2nd bit set can

Re: [PATCH] Comm::TcpAcceptor::doAccept fd limit handling is broken

2014-07-16 Thread Amos Jeffries
On 17/07/2014 11:10 a.m., Alex Rousskov wrote: On 07/16/2014 02:38 PM, Rainer Weikusat wrote: Alex Rousskov rouss...@measurement-factory.com writes: On 07/16/2014 11:11 AM, Rainer Weikusat wrote: This is broken because it re-enables readable notifications even if no connection was accepted.

Build failed in Jenkins: 3.HEAD-amd64-centos-6 #401

2014-07-16 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-6/401/changes Changes: [Amos Jeffries] Bug 4085: cache_miss_revalidate / ignore_ims_on_miss docs confusing -- [...truncated 7066 lines...] make[5]: Nothing to be done for `all'. make[5]: Leaving